Re: [E-devel] Add Null checking routine

2012-10-15 Thread The Rasterman
[SPRC] -Original Message- From: Sungho Kwak [mailto:sungho@gmail.com] Sent: 5 października 2012 09:41 To: Enlightenment developer list Subject: Re: [E-devel] Add Null checking routine I found that I should follow other way for checking NULL. Please ignore this patch. Proper

Re: [E-devel] Add Null checking routine

2012-10-05 Thread Vincent Torri
provide the patch for et in efl/ too, please Vincent On Fri, Oct 5, 2012 at 6:46 AM, 곽성호 sungho1.k...@samsung.com wrote: Hi, I add NULL chekcing routine in eet_identity_signature, eet_identity_x509, eet_identity_sha1 to avoid crash. I just use if - return, cause I couldn't find any

Re: [E-devel] Add Null checking routine

2012-10-05 Thread Sungho Kwak
I just added patch for trunk/efl/src/lib/eet/eet_lib.c 2012/10/5 Vincent Torri vincent.to...@gmail.com provide the patch for et in efl/ too, please Vincent On Fri, Oct 5, 2012 at 6:46 AM, 곽성호 sungho1.k...@samsung.com wrote: Hi, I add NULL chekcing routine in eet_identity_signature,

Re: [E-devel] Add Null checking routine

2012-10-05 Thread Sungho Kwak
I found that I should follow other way for checking NULL. Please ignore this patch. Proper patches will be provided by SPRC. 2012/10/5 Sungho Kwak sungho@gmail.com I just added patch for trunk/efl/src/lib/eet/eet_lib.c 2012/10/5 Vincent Torri vincent.to...@gmail.com provide the patch

[E-devel] Add Null checking routine

2012-10-04 Thread 곽성호
Hi, I add NULL chekcing routine in eet_identity_signature, eet_identity_x509, eet_identity_sha1 to avoid crash. I just use if - return, cause I couldn't find any EINA_SAFETY inline function in eet_lib.c Please show me that do I have to use EINA_SAFETY. Sincerely, Sungho Kwak

[E-devel] Add Null checking routine

2012-09-05 Thread Sungho Kwak
Hi, I always come with NULL Checking routine these days. :( I found that *eet_data_image_encode_cipher*, *eet_data_image_encode* can be crashed by passing null value to *eet_data_image_lossless_compressed_convert* in each function. Thanks. Sincerely, Sungho Kwak eet_image.diff Description:

Re: [E-devel] Add Null-checking routine e_dbus_message_send

2012-09-04 Thread Sungho Kwak
I'll double check about this problem, Thx. 2012/9/4 Carsten Haitzler ras...@rasterman.com On Tue, 4 Sep 2012 09:41:54 +0900 Sungho Kwak sungho@gmail.com said: actually i think this patch is wrong... do you have any valgrind debug output for this? the code explicitly tries to handle the

[E-devel] Add Null-checking routine e_dbus_message_send

2012-09-03 Thread Sungho Kwak
Hi, I found that if Callback function was missed, e_dbus_message_send crashed. It need some routine for that. @@ -64,7 +64,9 @@ e_dbus_message_send(E_DBus_Connection *conn, DBusM { DBusPendingCall *pending; + EINA_SAFETY_ON_NULL_RETURN_VAL(cb_return, NULL);

Re: [E-devel] Add Null-checking routine e_dbus_message_send

2012-09-03 Thread The Rasterman
On Tue, 4 Sep 2012 09:41:54 +0900 Sungho Kwak sungho@gmail.com said: actually i think this patch is wrong... do you have any valgrind debug output for this? the code explicitly tries to handle the case of no cb_return (it being NULL - ie u dont care about the return value). i don't understand