Re: [E-devel] Deprecating eina_tmpstr_strlen

2015-02-06 Thread The Rasterman
On Fri, 06 Feb 2015 10:05:06 + Tom Hacohen said: > On 05/02/15 23:22, Carsten Haitzler (The Rasterman) wrote: > > On Thu, 05 Feb 2015 11:59:38 + Tom Hacohen > > said: > > > >> On 04/02/15 23:48, Carsten Haitzler (The Rasterman) wrote: > >>> On Wed, 04 Feb 2015 12:11:28 + Tom Hacohen

Re: [E-devel] Deprecating eina_tmpstr_strlen

2015-02-06 Thread Tom Hacohen
On 05/02/15 23:22, Carsten Haitzler (The Rasterman) wrote: > On Thu, 05 Feb 2015 11:59:38 + Tom Hacohen said: > >> On 04/02/15 23:48, Carsten Haitzler (The Rasterman) wrote: >>> On Wed, 04 Feb 2015 12:11:28 + Tom Hacohen >>> said: >>> Hey, If there are no objections, I'd li

Re: [E-devel] Deprecating eina_tmpstr_strlen

2015-02-05 Thread The Rasterman
On Thu, 05 Feb 2015 11:59:38 + Tom Hacohen said: > On 04/02/15 23:48, Carsten Haitzler (The Rasterman) wrote: > > On Wed, 04 Feb 2015 12:11:28 + Tom Hacohen > > said: > > > >> Hey, > >> > >> If there are no objections, I'd like to deprecate eina_tmpstr_strlen() > >> and create eina_tmpst

Re: [E-devel] Deprecating eina_tmpstr_strlen

2015-02-05 Thread Tom Hacohen
On 04/02/15 23:48, Carsten Haitzler (The Rasterman) wrote: > On Wed, 04 Feb 2015 12:11:28 + Tom Hacohen said: > >> Hey, >> >> If there are no objections, I'd like to deprecate eina_tmpstr_strlen() >> and create eina_tmpstr_len() that is unlike the former, not crazily >> confusing and error pro

Re: [E-devel] Deprecating eina_tmpstr_strlen

2015-02-04 Thread The Rasterman
On Wed, 04 Feb 2015 12:11:28 + Tom Hacohen said: > Hey, > > If there are no objections, I'd like to deprecate eina_tmpstr_strlen() > and create eina_tmpstr_len() that is unlike the former, not crazily > confusing and error prone. > > With a name like *_strlen() you'd expect a function wou

Re: [E-devel] Deprecating eina_tmpstr_strlen

2015-02-04 Thread Tom Hacohen
Yes, it accepts the len as strlen (real strlen) and then they add it inside, but for the user, add_length gets a different len than you get back from tmpstr_strlen(). :( On Wed, Feb 4, 2015 at 12:33 PM, Daniel Hirt wrote: > Nah, it does "length += 1" beforehand (there's a comment in code), > an

Re: [E-devel] Deprecating eina_tmpstr_strlen

2015-02-04 Thread Daniel Hirt
Nah, it does "length += 1" beforehand (there's a comment in code), and just after that does "s->length = length"; Agreeing with your suggestion, but let's keep this for 1.14+ and not a few days before release :) On 02/04/2015 02:28 PM, Tom Hacohen wrote: > On 04/02/15 12:11, Tom Hacohen wrote: >>

Re: [E-devel] Deprecating eina_tmpstr_strlen

2015-02-04 Thread Tom Hacohen
On 04/02/15 12:11, Tom Hacohen wrote: > Hey, > > If there are no objections, I'd like to deprecate eina_tmpstr_strlen() > and create eina_tmpstr_len() that is unlike the former, not crazily > confusing and error prone. > > With a name like *_strlen() you'd expect a function would behave like > strl

[E-devel] Deprecating eina_tmpstr_strlen

2015-02-04 Thread Tom Hacohen
Hey, If there are no objections, I'd like to deprecate eina_tmpstr_strlen() and create eina_tmpstr_len() that is unlike the former, not crazily confusing and error prone. With a name like *_strlen() you'd expect a function would behave like strlen(), alas, it behaves like "strlen() + 1". This