Re: [E-devel] implementation of ntohl and al.

2019-01-02 Thread Vincent Torri
On Thu, Jan 3, 2019 at 2:32 AM Cedric Bail wrote: > > On Wednesday, January 2, 2019 1:24 PM, Vincent Torri > wrote: > > just for some ideas, here is a patch for this code : > > https://pastebin.com/bHdMVjLZ > > It would be really nice to start pushing this through phab for > review as this would

Re: [E-devel] implementation of ntohl and al.

2019-01-02 Thread Cedric Bail
On Wednesday, January 2, 2019 1:24 PM, Vincent Torri wrote: > just for some ideas, here is a patch for this code : > https://pastebin.com/bHdMVjLZ It would be really nice to start pushing this through phab for review as this would allow for a better tracking of it for sure. I really recommend sw

Re: [E-devel] implementation of ntohl and al.

2019-01-02 Thread Vincent Torri
Hello just for some ideas, here is a patch for this code : https://pastebin.com/bHdMVjLZ I have to add a macro (EINA_BIGENDIAN) with configure as the code is inlined ideas, remarks ? thank you and happy new year Vincent On Wed, Dec 19, 2018 at 10:35 AM Vincent Torri wrote: > > hey > > On Tue

Re: [E-devel] implementation of ntohl and al.

2018-12-19 Thread Vincent Torri
hey On Tue, Dec 18, 2018 at 9:00 PM Cedric Bail wrote: > > Hi, > > I also agree completely with Xavi. Especially on naming it ntoh() for > discoverability as it is the well known expected name for it. > > As for the implementation, maybe move it into an inline .x file, but no > strong opinion t

Re: [E-devel] implementation of ntohl and al.

2018-12-18 Thread Cedric Bail
Hi, I also agree completely with Xavi. Especially on naming it ntoh() for discoverability as it is the well known expected name for it. As for the implementation, maybe move it into an inline .x file, but no strong opinion there. Cedric ‐‐‐ Original Message ‐‐‐ On Tuesday, December 18

Re: [E-devel] implementation of ntohl and al.

2018-12-18 Thread Vincent Torri
On Tue, Dec 18, 2018 at 4:08 PM Xavi Artigas wrote: > > If this is finally accepted, I suggest you submit it through Phab and > undergo the regular review process :P that was my intention. This mail is mainly to know if there are a lot of people against such addition and about the name of the fun

Re: [E-devel] implementation of ntohl and al.

2018-12-18 Thread Xavi Artigas
Hi, Certainly, including winsock2.h just to define ntoh() is an extreme overkill! Your proposal sounds very sensible to me. Regarding the names, I also prefer the shorter version, since ntoh() is well known enough, but this is very arguable so I won't argue about it. If this is finally accepted,

[E-devel] implementation of ntohl and al.

2018-12-18 Thread Vincent Torri
Hello i would like to introduce in eina (more precisely in eina_cpu) implementations of ntohl and al. The reason is: on Windows, it requires to link against winsock2 and include winsock2.h, with introduce compilation errors with libjpeg in Emile (they both redefine the same types, with different