Re: [E-devel] @onefang

2011-11-13 Thread Mike Blumenkrantz
On Mon, 14 Nov 2011 14:54:39 +1000 David Seikel wrote: > On Sun, 13 Nov 2011 23:51:45 -0500 Mike Blumenkrantz > wrote: > > > On Mon, 14 Nov 2011 14:48:34 +1000 > > David Seikel wrote: > > > > > On Sun, 13 Nov 2011 23:46:05 -0500 Mike Blumenkrantz > > > wrote: > > > > > > > On Mon, 14 Nov 20

Re: [E-devel] @onefang

2011-11-13 Thread David Seikel
On Sun, 13 Nov 2011 23:51:45 -0500 Mike Blumenkrantz wrote: > On Mon, 14 Nov 2011 14:48:34 +1000 > David Seikel wrote: > > > On Sun, 13 Nov 2011 23:46:05 -0500 Mike Blumenkrantz > > wrote: > > > > > On Mon, 14 Nov 2011 14:41:29 +1000 > > > David Seikel wrote: > > > > > > > On Sun, 13 Nov 20

Re: [E-devel] @onefang

2011-11-13 Thread Mike Blumenkrantz
On Mon, 14 Nov 2011 14:48:34 +1000 David Seikel wrote: > On Sun, 13 Nov 2011 23:46:05 -0500 Mike Blumenkrantz > wrote: > > > On Mon, 14 Nov 2011 14:41:29 +1000 > > David Seikel wrote: > > > > > On Sun, 13 Nov 2011 23:38:35 -0500 Mike Blumenkrantz > > > wrote: > > > > > > > On Mon, 14 Nov 20

Re: [E-devel] @onefang

2011-11-13 Thread David Seikel
On Sun, 13 Nov 2011 23:46:05 -0500 Mike Blumenkrantz wrote: > On Mon, 14 Nov 2011 14:41:29 +1000 > David Seikel wrote: > > > On Sun, 13 Nov 2011 23:38:35 -0500 Mike Blumenkrantz > > wrote: > > > > > On Mon, 14 Nov 2011 14:33:16 +1000 > > > David Seikel wrote: > > > > > > > On Sun, 13 Nov 20

Re: [E-devel] @onefang

2011-11-13 Thread Mike Blumenkrantz
On Mon, 14 Nov 2011 14:41:29 +1000 David Seikel wrote: > On Sun, 13 Nov 2011 23:38:35 -0500 Mike Blumenkrantz > wrote: > > > On Mon, 14 Nov 2011 14:33:16 +1000 > > David Seikel wrote: > > > > > On Sun, 13 Nov 2011 23:17:08 -0500 Mike Blumenkrantz > > > wrote: > > > > > > > edje_lua2.c: In f

Re: [E-devel] @onefang

2011-11-13 Thread David Seikel
On Sun, 13 Nov 2011 23:38:35 -0500 Mike Blumenkrantz wrote: > On Mon, 14 Nov 2011 14:33:16 +1000 > David Seikel wrote: > > > On Sun, 13 Nov 2011 23:17:08 -0500 Mike Blumenkrantz > > wrote: > > > > > edje_lua2.c: In function '_elua_map_lighting': > > > edje_lua2.c:2177: warning: suggest parent

Re: [E-devel] @onefang

2011-11-13 Thread Mike Blumenkrantz
On Mon, 14 Nov 2011 14:33:16 +1000 David Seikel wrote: > On Sun, 13 Nov 2011 23:17:08 -0500 Mike Blumenkrantz > wrote: > > > edje_lua2.c: In function '_elua_map_lighting': > > edje_lua2.c:2177: warning: suggest parentheses around assignment used > > as truth value edje_lua2.c: In function '_elu

Re: [E-devel] @onefang

2011-11-13 Thread David Seikel
On Sun, 13 Nov 2011 23:17:08 -0500 Mike Blumenkrantz wrote: > edje_lua2.c: In function '_elua_map_lighting': > edje_lua2.c:2177: warning: suggest parentheses around assignment used > as truth value edje_lua2.c: In function '_elua_map_populate': > edje_lua2.c:2241: warning: suggest parentheses aro

Re: [E-devel] @onefang

2011-11-13 Thread Mike Blumenkrantz
On Mon, 14 Nov 2011 14:28:59 +1000 David Seikel wrote: > On Sun, 13 Nov 2011 23:17:08 -0500 Mike Blumenkrantz > wrote: > > > edje_lua2.c: In function '_elua_map_lighting': > > edje_lua2.c:2177: warning: suggest parentheses around assignment used > > as truth value edje_lua2.c: In function '_elu

Re: [E-devel] @onefang

2011-11-13 Thread David Seikel
On Sun, 13 Nov 2011 23:17:08 -0500 Mike Blumenkrantz wrote: > edje_lua2.c: In function '_elua_map_lighting': > edje_lua2.c:2177: warning: suggest parentheses around assignment used > as truth value edje_lua2.c: In function '_elua_map_populate': > edje_lua2.c:2241: warning: suggest parentheses aro

Re: [E-devel] @onefang

2011-11-06 Thread Tom Hacohen
On 07/11/11 09:18, David Seikel wrote: > Spanked on one cheek for suppressing them, on the other for not. > > I wont forget, I left a fixme, and all those non generic functions > proliferating is really annoying me. I'll scratch that itch. I just hope that itch won't get infected over time. :) -

Re: [E-devel] @onefang

2011-11-06 Thread David Seikel
On Mon, 07 Nov 2011 09:14:08 +0200 Tom Hacohen wrote: > On 07/11/11 09:07, David Seikel wrote: > > I plan on pulling out one of those functions (plus others) and > > replacing them with something more generic later anyway. But not > > now. I'll think it through properly when I do that. It's ju

Re: [E-devel] @onefang

2011-11-06 Thread Tom Hacohen
On 07/11/11 09:07, David Seikel wrote: > I plan on pulling out one of those functions (plus others) and replacing > them with something more generic later anyway. But not now. I'll > think it through properly when I do that. It's just internal support > stuff, but at the time I was in my "don't

Re: [E-devel] @onefang

2011-11-06 Thread David Seikel
On Mon, 07 Nov 2011 09:01:49 +0200 Tom Hacohen wrote: > On 07/11/11 08:53, David Seikel wrote: > > In this case, the warnings are either saying that one of the > > functions is defined wrong, or that I should just cast to const for > > one to shut it up. > > > > Personally I think that making a f

Re: [E-devel] @onefang

2011-11-06 Thread Tom Hacohen
On 07/11/11 08:53, David Seikel wrote: > In this case, the warnings are either saying that one of the functions > is defined wrong, or that I should just cast to const for one to shut > it up. > > Personally I think that making a function parameter const when the whole > point of passing that param

Re: [E-devel] @onefang

2011-11-06 Thread David Seikel
On Mon, 07 Nov 2011 08:41:33 +0200 Tom Hacohen wrote: > On 07/11/11 07:32, David Seikel wrote: > > Not sure what to de about those. Caught between one API that needs > > const, and one that doesn't. In the end, the variable itself is > > being changed, so it's not const. I'll just cast to shut

Re: [E-devel] @onefang

2011-11-06 Thread Tom Hacohen
On 07/11/11 07:32, David Seikel wrote: > Damn, my compiler needs to take bitching lessons from my girl, she's > an expert. I'm not getting those warnings, or errors, and that should > be an error. -Wall -Wextra -Wshadow ? > Not sure what to de about those. Caught between one API that needs > co

Re: [E-devel] @onefang

2011-11-06 Thread David Seikel
On Mon, 7 Nov 2011 00:04:19 -0500 Mike Blumenkrantz wrote: > SPANK SPANK SPANK > > edje_lua2.c: In function '_elua_obj_new': > edje_lua2.c:538: warning: no return statement in function returning > non-void edje_lua2.c: In function '_elua_map_new': > edje_lua2.c:544: warning: no return statement