[ewg] Re: problems with ofed-1.2.c chelsio low level driver

2007-08-08 Thread Michael S. Tsirkin
> Quoting Steve Wise <[EMAIL PROTECTED]>: > Subject: problems with ofed-1.2.c chelsio low level driver > > Michael, > > I've discovered that I was really testing the ofed-1.2 cxgb3.ko module > in my testing 1.2.c regression test. Upon getting a complete 1.2.c > installed, I'm seeing crashes wi

[ewg] Re: RFCv2: SRC API

2007-08-08 Thread Michael S. Tsirkin
> Quoting Tang, Changqing <[EMAIL PROTECTED]>: > Subject: RE: RFCv2: SRC API > > > > > > > Is there any performance worry to let j2(the first job on a > > node) to > > > do all the "work" ? > > > > How do you mean? > > I mean that j2 has all the QP connections with all other remote jobs, so

[ewg] RE: RFCv2: SRC API

2007-08-08 Thread Tang, Changqing
> > > Is there any performance worry to let j2(the first job on a > node) to > > do all the "work" ? > > How do you mean? I mean that j2 has all the QP connections with all other remote jobs, so j2 does not save anything compared with non-SRC case, can this affect j2's performance ? I have a

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: 08 Aug 2007 14:38:10 +0200 > Jeff Garzik <[EMAIL PROTECTED]> writes: > > > + val, reg_index, addr, addr+4); */ > > > + writel(cpu_to_le32(reg_index), addr); > > > + writel(cpu_to_le32(val),(u8 *)addr + 4); > > > > wrong -- endian conversi

Re: [ewg] [PATCH 11/14] nes: OpenFabrics kernel verbs

2007-08-08 Thread Roland Dreier
> +static struct ib_mw *nes_alloc_mw(struct ib_pd *ibpd) { > +get_random_bytes(&next_stag_index, sizeof(next_stag_index)); Could this use up a lot of entropy? Is random32() sufficient? > +stag_key = (u8)next_stag_index; I don't think this cast is needed. > +if (ret) { > +

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Jeff Garzik
Michael Buesch wrote: On Wednesday 08 August 2007 18:59:08 Jeff Garzik wrote: Michael Buesch wrote: writel doesn't guarantee flushing either. readl does. Not quite -- there are multiple kinds of flushing. You're thinking about flushing across PCI bridges, which is correct, but you also have

[ewg] [GIT PULL] ~sashak/management.git

2007-08-08 Thread Sasha Khapyorsky
Hi Vlad, Please pull recent ofed_1_2 branch of ~sashak/management.git. In addition to already pulled: commit 067fc2c8d91b405546d1d5629540880681c45df1 Author: Sasha Khapyorsky <[EMAIL PROTECTED]> opensm: descrease default HoQLife value for leaf ports. commit 2705d36f473ea80f571a91cde47e44d9

[ewg] Re: problems with ofed-1.2.c chelsio low level driver

2007-08-08 Thread Michael S. Tsirkin
> Quoting Steve Wise <[EMAIL PROTECTED]>: > Subject: problems with ofed-1.2.c chelsio low level driver > > Michael, > > I've discovered that I was really testing the ofed-1.2 cxgb3.ko module > in my testing 1.2.c regression test. Upon getting a complete 1.2.c > installed, I'm seeing crashes wi

[ewg] problems with ofed-1.2.c chelsio low level driver

2007-08-08 Thread Steve Wise
Michael, I've discovered that I was really testing the ofed-1.2 cxgb3.ko module in my testing 1.2.c regression test. Upon getting a complete 1.2.c installed, I'm seeing crashes with the chelsio driver. I think there are some patches that went into the ofed-1.2 branch, that did not get merge

[ewg] Re: [ofa-general] RE: OFA website edits

2007-08-08 Thread Jeff Becker
Hi. I created most of the requested directory/owner pairs in /var/www/openfabrics.org/downloads. I left out the various MPI directories, figuring the appropriate web pages will be linked from somewhere (possibly the downloads web page). I gave Stan Smith an account. Stan, please contact me to get t

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Michael Buesch
On Wednesday 08 August 2007 18:59:08 Jeff Garzik wrote: > Michael Buesch wrote: > > writel doesn't guarantee flushing either. > > readl does. > > > Not quite -- there are multiple kinds of flushing. You're thinking > about flushing across PCI bridges, which is correct, but you also have > CPU

Re: [ewg] [PATCH 0/14] nes: NetEffect 10Gb RNIC Driver

2007-08-08 Thread Roland Dreier
> git.openfabrics.org/~glenn/libnes.git > git.openfabrics.org/~glenn/ofed_1_2.git > git.openfabrics.org/~glenn/ofascripts.git > git.openfabrics.org/~glenn/ofed_1_2_scripts.git these aren't actually git URLs. prepending git:// seems to work though. _

Re: [ewg] [PATCH 4/5] libnes: OpenFabrics userspace verbs

2007-08-08 Thread Roland Dreier
> +nesupd->udoorbell = mmap(NULL, page_size, PROT_WRITE | PROT_READ, > MAP_SHARED, > +context->cmd_fd, nesupd->db_index * page_size); > + > +if (((void *)-1) == nesupd->udoorbell) { probably cleaner to test against MAP_FAILED here. > +asm __v

Re: [ewg] [PATCH 1/5] libnes: library init entry points

2007-08-08 Thread Roland Dreier
> +ibv_driver_init; This is unnecessary -- I realize you copied it from libmthca or libmlx4 probably, but there it is a relic of older code. I'll delete it from the libmthca and libmlx4 linker script to avoid confusing anyone else. ___ ewg

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Jeff Garzik
Michael Buesch wrote: writel doesn't guarantee flushing either. readl does. Not quite -- there are multiple kinds of flushing. You're thinking about flushing across PCI bridges, which is correct, but you also have CPU write posting and CPU write ordering and such. Without taking all that

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread akepner
On Wed, Aug 08, 2007 at 09:46:16AM -0700, Roland Dreier wrote: > > Not mmiowb() -- that is for ordering between CPUs, eg on systems like > Altix where PCI transactions might get reordered in the system fabric > before reaching the PCI bus. > Yes, that's right. This is a continual source of

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Roland Dreier
> The barrier/ordering issue however might be a critical thing, > when using __raw_XXX. So one must always mmiowb() after such a write. Not mmiowb() -- that is for ordering between CPUs, eg on systems like Altix where PCI transactions might get reordered in the system fabric before reaching the

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Michael Buesch
On Wednesday 08 August 2007 18:33:24 Jeff Garzik wrote: > Michael Buesch wrote: > > On Wednesday 08 August 2007 18:18:31 Roland Dreier wrote: > >> > But there are indeed a few cases that look wrong. > >> > >> yes... > >> > >> > arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val), > >

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Roland Dreier
> Most likely the __raw_writel variant is portable, but I am not > sure. Anybody sure? Yes, it should be fine. I use that construct in a few IB drivers. - R. ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Jeff Garzik
Michael Buesch wrote: On Wednesday 08 August 2007 18:18:31 Roland Dreier wrote: > But there are indeed a few cases that look wrong. yes... > arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val), target); eg this almost certainly wants to be writel(swab32(val), target);

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Michael Buesch
On Wednesday 08 August 2007 18:18:31 Roland Dreier wrote: > > But there are indeed a few cases that look wrong. > > yes... > > > arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val), target); > > eg this almost certainly wants to be > > writel(swab32(val), target); > > or so

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Jeff Garzik
Roland Dreier wrote: > But there are indeed a few cases that look wrong. yes... > arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val), target); eg this almost certainly wants to be writel(swab32(val), target); or something equivalent like __raw_writel(cpu_to_be

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Jeff Garzik
Andi Kleen wrote: Jeff Garzik <[EMAIL PROTECTED]> writes: + val, reg_index, addr, addr+4); */ + writel(cpu_to_le32(reg_index), addr); + writel(cpu_to_le32(val),(u8 *)addr + 4); wrong -- endian conversion macros not needed with writel() Are you sure? Yes. r

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Roland Dreier
> But there are indeed a few cases that look wrong. yes... > arch/x86_64/kernel/pci-calgary.c: writel(cpu_to_be32(val), target); eg this almost certainly wants to be writel(swab32(val), target); or something equivalent like __raw_writel(cpu_to_be32(val), target);

[ewg] RE: [PATCH 3/14] nes: connection manager routines

2007-08-08 Thread Glenn Grundstrom
This code is far from a TCP stack. It's main purpose is to exchange RDMA MPA request/response messages that are required by the iWarp specs and therefore needed by our hardware. All RNIC hardware vendors need this MPA message exchange, including those already accepted into kernel.org. Do you hav

Re: [ewg] OFED 1.2.c-11 is available

2007-08-08 Thread Tziporet Koren
Erez Zilber wrote: Tziporet, Can you add the following as a known issue: "open-iscsi over TCP does not support usage of data digest on RedHat EL/AS 4 up3, up4 & up5." Note that this comment should be added to OFED release notes, not to iSER release notes. This is not an iSER bug (it's a bug

Re: [ewg] OFED 1.2.c status & plans

2007-08-08 Thread Steve Wise
Tziporet, Can we make the change to 1.2.5? This should probably include: - change builds/connectx to builds/ofed-1.2.5 (or just add a link) - change build names from 1.2.c to 1.2.5 Scott Weitzenkamp (sweitzen) wrote: Cisco has been testing 1.2.c-10 IPoIB/SDP/MPI successfully on a 32-node

[ewg] RE: [PATCH 6/14] nes: hardware init

2007-08-08 Thread Glenn Grundstrom
Jeff, Thanks for the input. I'll take your suggestions into account for the patch v2 posting. Glenn. -Original Message- From: Jeff Garzik [mailto:[EMAIL PROTECTED] Sent: Tuesday, August 07, 2007 8:58 PM To: Glenn Grundstrom Cc: [EMAIL PROTECTED]; ewg@lists.openfabrics.org; [EMAIL PROTE

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Michael Buesch
On Wednesday 08 August 2007 15:48:25 Michael Buesch wrote: > > However if that's true then there are quite some drivers wrong: > > > > % grep -r write[bwl]\(cpu_to * | wc -l > > 57 > > Yeah, seems so. Most of them seem to be __raw_writew(cpu_toXX(... which I think might be valid. But there a

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Michael Buesch
On Wednesday 08 August 2007 15:38:50 Andi Kleen wrote: > On Wed, Aug 08, 2007 at 03:28:33PM +0200, Michael Buesch wrote: > > On Wednesday 08 August 2007 15:08:28 Andi Kleen wrote: > > > On Wed, Aug 08, 2007 at 03:02:35PM +0200, Michael Buesch wrote: > > > > On Wednesday 08 August 2007 14:55:11 Andi

Re: [ewg] OFED 1.2.c-11 is available

2007-08-08 Thread Erez Zilber
Tziporet, Can you add the following as a known issue: "open-iscsi over TCP does not support usage of data digest on RedHat EL/AS 4 up3, up4 & up5." Note that this comment should be added to OFED release notes, not to iSER release notes. This is not an iSER bug (it's a bug in the backport for

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Andi Kleen
On Wed, Aug 08, 2007 at 03:28:33PM +0200, Michael Buesch wrote: > On Wednesday 08 August 2007 15:08:28 Andi Kleen wrote: > > On Wed, Aug 08, 2007 at 03:02:35PM +0200, Michael Buesch wrote: > > > On Wednesday 08 August 2007 14:55:11 Andi Kleen wrote: > > > > On Wed, Aug 08, 2007 at 01:50:35PM +0200,

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Michael Buesch
On Wednesday 08 August 2007 15:08:28 Andi Kleen wrote: > On Wed, Aug 08, 2007 at 03:02:35PM +0200, Michael Buesch wrote: > > On Wednesday 08 August 2007 14:55:11 Andi Kleen wrote: > > > On Wed, Aug 08, 2007 at 01:50:35PM +0200, Michael Buesch wrote: > > > > On Wednesday 08 August 2007 14:38:10 Andi

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Andi Kleen
On Wed, Aug 08, 2007 at 03:02:35PM +0200, Michael Buesch wrote: > On Wednesday 08 August 2007 14:55:11 Andi Kleen wrote: > > On Wed, Aug 08, 2007 at 01:50:35PM +0200, Michael Buesch wrote: > > > On Wednesday 08 August 2007 14:38:10 Andi Kleen wrote: > > > > Jeff Garzik <[EMAIL PROTECTED]> writes: >

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Michael Buesch
On Wednesday 08 August 2007 14:55:11 Andi Kleen wrote: > On Wed, Aug 08, 2007 at 01:50:35PM +0200, Michael Buesch wrote: > > On Wednesday 08 August 2007 14:38:10 Andi Kleen wrote: > > > Jeff Garzik <[EMAIL PROTECTED]> writes: > > > > > + val, reg_index, addr, addr+4); */ > > > >

[ewg] OFED 1.2.c-11 is available

2007-08-08 Thread Tziporet Koren
Hi All, OFED 1.2.c-11 is available now on the OFA server under: http://www.openfabrics.org/builds/connectx/release/ Note: This release supports FW 2.1.000 that is available on Mellanox web site for download and FW 2.2.0 that will be released soon Supported Platforms and Operating Systems =

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Andi Kleen
On Wed, Aug 08, 2007 at 01:50:35PM +0200, Michael Buesch wrote: > On Wednesday 08 August 2007 14:38:10 Andi Kleen wrote: > > Jeff Garzik <[EMAIL PROTECTED]> writes: > > > > + val, reg_index, addr, addr+4); */ > > > > + writel(cpu_to_le32(reg_index), addr); > > > > +

[ewg] [PATCH] IB/core: Ignore membership bit in ib_find_pkey()

2007-08-08 Thread Moni Shoua
Vlad, This patch is already merged in upstream kernel. Please add it also to kernel patches of OFED-1.2.5 thanks MoniS -- ib_find_pkey() is used as a replacement for ib_find_cached_pkey(), and the original function ignored the membership bit when searching for a P_Key, so ib_find_pkey() sh

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Michael Buesch
On Wednesday 08 August 2007 14:38:10 Andi Kleen wrote: > Jeff Garzik <[EMAIL PROTECTED]> writes: > > > + val, reg_index, addr, addr+4); */ > > > + writel(cpu_to_le32(reg_index), addr); > > > + writel(cpu_to_le32(val),(u8 *)addr + 4); > > > > wrong -- endian conversion macros not ne

[ewg] Re: [PATCH 3/14] nes: connection manager routines

2007-08-08 Thread Andi Kleen
[EMAIL PROTECTED] writes: > NetEffect connection manager routines. This seems more like a new TCP stack. I don't think such code is appropiate, since Linux already has one. -Andi ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.o

[ewg] Re: [PATCH 2/14] nes: device structures and defines

2007-08-08 Thread Andi Kleen
Jeff Garzik <[EMAIL PROTECTED]> writes: > > + val, reg_index, addr, addr+4); */ > > + writel(cpu_to_le32(reg_index), addr); > > + writel(cpu_to_le32(val),(u8 *)addr + 4); > > wrong -- endian conversion macros not needed with writel() Are you sure? I don't think that's true.

Re: [ewg] OFED 1.2.c status & plans

2007-08-08 Thread Tziporet Koren
Scott Weitzenkamp (sweitzen) wrote: Cisco has been testing 1.2.c-10 IPoIB/SDP/MPI successfully on a 32-node cluster. We are still working on tvflash, though. We can add tvflash at beginning of next week Tziporet ___ ewg mailing list ewg@lists.ope

[ewg] ignore membership bit when looking for a P_key

2007-08-08 Thread Michael S. Tsirkin
Is this patch relevant for 1.2.5? If yes pls feel free to send it to Vlad. -- MST ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg