Re: [ewg] [PATCHv8 08/11] mlx4: Allow interfaces to correspond to each other

2010-05-13 Thread Eli Cohen
On Wed, May 12, 2010 at 01:30:22PM -0700, Roland Dreier wrote: > > +void *mlx4_get_prot_dev(struct mlx4_dev *dev, enum mlx4_prot proto, int > port) > > +{ > > + return mlx4_find_get_prot_dev(dev, proto, port); > > +} > > +EXPORT_SYMBOL(mlx4_get_prot_dev); > > Not sure I understand why you h

Re: [ewg] [PATCHv8 08/11] mlx4: Allow interfaces to correspond to each other

2010-05-12 Thread Roland Dreier
> +void *mlx4_get_prot_dev(struct mlx4_dev *dev, enum mlx4_prot proto, int > port) > +{ > +return mlx4_find_get_prot_dev(dev, proto, port); > +} > +EXPORT_SYMBOL(mlx4_get_prot_dev); Not sure I understand why you have a wrapper to call another function with exactly the same parameters?

[ewg] [PATCHv8 08/11] mlx4: Allow interfaces to correspond to each other

2010-02-18 Thread Eli Cohen
Add a mechanism for mlx4 core interfaces to get a pointer to other interfaces' device object. For this, an exported function, mlx4_get_prot_dev() is added, which allows an interfaces to get some other interface's device based on the protocol that interface implements. Two new protocols are added, M