Re: [ewg] IB/ipoib: Fix neigh destructor oops for kernels older than 2.6.21

2008-05-19 Thread Eli Cohen
On Mon, 2008-05-19 at 11:28 +0300, Or Gerlitz wrote: > I see, next time, could you drop a mail saying that you decided to move > on with something, etc? > Sure. ___ ewg mailing list ewg@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman

Re: [ewg] IB/ipoib: Fix neigh destructor oops for kernels older than 2.6.21

2008-05-19 Thread Or Gerlitz
Eli Cohen wrote: Unfortunately not. But I did not want to leave this problem pending anymore since I want to get some mileage on it. Still, if we have a better solution it would be easy to adopt since this patch is independent of all others. I see, next time, could you drop a mail saying that

Re: [ewg] IB/ipoib: Fix neigh destructor oops for kernels older than 2.6.21

2008-05-19 Thread Eli Cohen
On Mon, 2008-05-19 at 10:01 +0300, Or Gerlitz wrote: > I see that you have merged the patch, so sorry, but I am not going to > look on it. Have someone else reviewed it before the merge? Unfortunately not. But I did not want to leave this problem pending anymore since I want to get some mileage o

Re: [ewg] IB/ipoib: Fix neigh destructor oops for kernels older than 2.6.21

2008-05-19 Thread Or Gerlitz
Eli Cohen wrote: 1 day is not enough time to review the patch, as of the importance, I suggest you ask Roland and Alexey to review it and say what their opinion on the solution, now once we all understand the problem. I think I did ask, not explicitly but I guess it is understood that the patch

Re: [ewg] IB/ipoib: Fix neigh destructor oops for kernels older than 2.6.21

2008-05-15 Thread Eli Cohen
On Thu, 2008-05-15 at 18:10 +0300, Or Gerlitz wrote: > 1 day is not enough time to review the patch, as of the importance, I > suggest you ask Roland and Alexey to review it and say what their > opinion on the solution, now once we all understand the problem. > I think I did ask, not explicitly

Re: [ewg] IB/ipoib: Fix neigh destructor oops for kernels older than 2.6.21

2008-05-15 Thread Or Gerlitz
Eli Cohen wrote: Good, so now we have some experience that it works and I don't see any comments on the patch itself. Unless there are objections I will push this to OFED as a backport for kernels <= 2.6.20. Eli, 1 day is not enough time to review the patch, as of the importance, I suggest yo

Re: [ewg] IB/ipoib: Fix neigh destructor oops for kernels older than 2.6.21

2008-05-15 Thread Eli Cohen
On Thu, 2008-05-15 at 16:50 +0300, Ron Livne wrote: > Hi, > I tested it on red hat 5 and it's working. > Good, so now we have some experience that it works and I don't see any comments on the patch itself. Unless there are objections I will push this to OFED as a backport for kernels <= 2.6.20.

Re: [ewg] IB/ipoib: Fix neigh destructor oops for kernels older than 2.6.21

2008-05-15 Thread Ron Livne
Hi, I tested it on red hat 5 and it's working. Ron On Wed, May 14, 2008 at 2:37 PM, Eli Cohen <[EMAIL PROTECTED]> wrote: > IB/ipoib: Fix neigh destructor oops > > For kernels 2.6.20 and older, it may happen that the pointer to > ipoib_neigh_cleanup() is called after IPoIB has been unloades, > c

[ewg] IB/ipoib: Fix neigh destructor oops for kernels older than 2.6.21

2008-05-14 Thread Eli Cohen
IB/ipoib: Fix neigh destructor oops For kernels 2.6.20 and older, it may happen that the pointer to ipoib_neigh_cleanup() is called after IPoIB has been unloades, causing a kernel oops. This problem has been fixed for 2.6.21 with the following commit: ecbb416939da77c0d107409976499724baddce7b The