Git revert done.
Stéphane
> Le 18 avr. 2020 à 12:16, Bart Brouns a écrit :
>
> Hi Oleg,
>
>
> Before I wrote this code I tested yours and got silence.
> That test was somehow flawed; I tried again just now and it works as expected.
> Sorry for the noise.
>
> After the silent test, I looke
Hi Oleg,
Before I wrote this code I tested yours and got silence.
That test was somehow flawed; I tried again just now and it works
as expected.
Sorry for the noise.
After the silent test, I looked into the commit history, saw that
the init got removed and found out it did make noise with th
Hi Bart,
it seems that you are not convinced, let me try again.
On 04/16, Oleg Nesterov wrote:
>
> On 04/16, Bart Brouns wrote:
> >
> > Somehow the initial value of `u` got lost in the last commit to this
> > function:
> > https://github.com/grame-cncm/faustlibraries/commit/ba34ca657a8c98efc8040
Hi Bart,
I am not sure I understand you, but I'll try to answer anyway ;)
Please correct me.
On 04/16, Bart Brouns wrote:
>
> Somehow the initial value of `u` got lost in the last commit to this
> function:
> https://github.com/grame-cncm/faustlibraries/commit/ba34ca657a8c98efc804061c5b2e1d4f7e6
Hi Oleg,
Thanks for your watchful eye!
Somehow the initial value of `u` got lost in the last commit to
this function:
https://github.com/grame-cncm/faustlibraries/commit/ba34ca657a8c98efc804061c5b2e1d4f7e6bc6ff.
The oscillator doesn't seem to work without it.
The other changes where to bri
Bart,
could you explain the commit 4fb8849b833629 ("Fixup quadosc") ?
It looks absolutely wrong.
- It removes the 1st output (cosine), why ??
- It makes the 2nd output less precise
- It makes the generated C++ code worse.
Oleg.
___
