Re: [Fedora-livecd-list] [PATCH] -fs.py-kickstart.py-chages-for-mulit-partitions

2008-05-29 Thread Mark McLoughlin
On Wed, 2008-05-28 at 14:36 -0400, Jeremy Katz wrote: The ability for a tool to create these partitioned disk images via the command like, livecd-creator, is very helpful in reproducing known state appliances, epically with the rising use of visualization. Going through a actual install

Re: [Fedora-livecd-list] livecd-creator on RHEL5/FC6

2008-01-23 Thread Mark McLoughlin
On Wed, 2008-01-23 at 00:47 +0530, Rahul Sundaram wrote: File //usr/lib/python2.4/site-packages/imgcreate/fs.py, line 178, in expand fd = os.open(self.lofile, flags) OSError: [Errno 20] Not a directory: '/var/tmp/imgcreate-oWHPY1/iso-GPC7L3/LiveOS/osmin' This is a

Re: [Fedora-livecd-list] livecd-creator on RHEL5/FC6

2008-01-23 Thread Mark McLoughlin
On Wed, 2008-01-23 at 10:37 +, Mark McLoughlin wrote: On Wed, 2008-01-23 at 00:47 +0530, Rahul Sundaram wrote: File //usr/lib/python2.4/site-packages/imgcreate/fs.py, line 178, in expand fd = os.open(self.lofile, flags) OSError: [Errno 20] Not a directory: '/var/tmp

Re: [Fedora-livecd-list] [PATCH] Add initramfs image creator

2008-01-18 Thread Mark McLoughlin
Hi Alan, There's nothing wrong with the code, it's in good shape. Some thoughts: - Using pax instead of cpio is okay, I guess. The cpio code is probably a little hairy just for the sake of avoiding the pax dep. - Symlinking /init to /sbin/init seems a little odd, but I guess

Re: [Fedora-livecd-list] [PATCH] installroot mountpoint OSError

2008-01-14 Thread Mark McLoughlin
Hi, On Fri, 2008-01-11 at 19:13 +0100, Jeroen van Meeuwen wrote: When the installation root or mount point is attempted to be created, and already exists, livecd-tools will show a traceback and fail to continue. I'm thinking that creating the directory on which to loopmount something

Re: [Fedora-livecd-list] rfc/suggestion: livecd kickstart format should include url install method

2008-01-14 Thread Mark McLoughlin
On Sun, 2008-01-13 at 22:32 -0600, Douglas McClendon wrote: I'm thinking that livecd-tools might be better off requiring the install method syntax anyway, and basically setting down the idea that the kickstarts that it accepts, should be usable as generic kickstarts for installation in the

Re: [Fedora-livecd-list] livecd-creator on RHEL5/FC6

2008-01-14 Thread Mark McLoughlin
On Thu, 2008-01-10 at 13:34 +0530, Rahul Sundaram wrote: 395, in apply if ksselinux.selinux: AttributeError: 'int' object has no attribute 'selinux' I've updated: http://markmc.fedorapeople.org/rhel5-livecd-creator/imgcreate-old-pykickstart.patch with the simple

Re: [Fedora-livecd-list] livecd-creator on RHEL5/FC6

2008-01-08 Thread Mark McLoughlin
Hi Rahul, On Tue, 2008-01-08 at 03:48 +0530, Rahul Sundaram wrote: I had to patch two files for the try finally construct. The patches are http://sundaram.fedorapeople.org/livecd-creator-try-finally.patch http://sundaram.fedorapeople.org/image-creator-try-finally.patch (These patches are

[Fedora-livecd-list] [PATCH] Run e2fsck before resize2fs

2007-12-20 Thread Mark McLoughlin
resize2fs barfs if you haven't run e2fsck on the filesystem beforehand, so do this in the case of resizing an existing image. We already do this when minimising an image. Signed-off-by: Mark McLoughlin [EMAIL PROTECTED] --- imgcreate/fs.py |2 ++ 1 files changed, 2 insertions(+), 0 deletions

Re: [Fedora-livecd-list] livecd-creator on RHEL5/FC6

2007-12-17 Thread Mark McLoughlin
On Sun, 2007-12-16 at 19:49 +0530, Rahul Sundaram wrote: Mark McLoughlin wrote: Hey, I have some patches to make livecd-creator work with python 2.4 and older pykickstart; posting them here in case anyone needs them or is interested in e.g. getting livecd-tools into EPEL

Re: [Fedora-livecd-list] [PATCH] Use string methods instead of the string module

2007-12-17 Thread Mark McLoughlin
On Sun, 2007-12-16 at 23:58 +0800, Tan Swee Heng wrote: -(string.join(args, ), ret)) +( .join(args), ret)) Agree with Jeremy - I'm not a fan of this construct; it's just a wee bit too clever and obtuse for my liking. -

[Fedora-livecd-list] livecd-creator on RHEL5/FC6

2007-12-12 Thread Mark McLoughlin
Hey, I have some patches to make livecd-creator work with python 2.4 and older pykickstart; posting them here in case anyone needs them or is interested in e.g. getting livecd-tools into EPEL: http://markmc.fedorapeople.org/rhel5-livecd-creator/ Cheers, Mark. -- Fedora-livecd-list

Debug options [was Re: [Fedora-livecd-list] Revised: [PATCH] turboLiveInst - improves livecd/usb installer speed by 15-20+%]

2007-09-07 Thread Mark McLoughlin
Hi Jeremy, On Wed, 2007-09-05 at 17:49 -0400, Jeremy Katz wrote: As has probably been noticed, there are a lot fewer options now, and a good chunk are marked as for debugging/development use only with comments. One option that I'm missing at the moment is the --repo option.

Re: [Fedora-livecd-list] Revised: [PATCH] turboLiveInst - improves livecd/usb installer speed by 15-20+%

2007-09-06 Thread Mark McLoughlin
On Wed, 2007-09-05 at 09:58 -0400, Jeremy Katz wrote: I think that some of the above will go a long way towards making things look nicer which is going to make me more amenable to it. I still don't necessarily _like_ it because I still think that it makes anaconda depend a bit too much on a

Re: [Fedora-livecd-list] A couple of cleanup patches

2007-09-04 Thread Mark McLoughlin
On Mon, 2007-09-03 at 22:09 -0500, Douglas McClendon wrote: Mark McLoughlin wrote: Second patch refactors the resize2fs stuff so that it is substantially easier to understand - e.g. trying to grok the binary search in resize2fsToMinimal() is a lot easier than the original version

Re: [Fedora-livecd-list] SRPMS for installed RPMs?

2007-09-04 Thread Mark McLoughlin
Hi Matt, On Mon, 2007-08-13 at 22:11 -0500, Matt Domsch wrote: I want to be sure, for license compliance, that all the binary bits on the final LiveCD have corresponding source code available. One of the features I'd like to see something in the stack of livecd-tools produce is a

Managing patches [was Re: [Fedora-livecd-list] [PATCH] overlay/persistence second pass - for developer reference only]

2007-09-04 Thread Mark McLoughlin
Hey, On Tue, 2007-08-21 at 16:18 -0400, Jeremy Katz wrote: * It's good to get into the habit of doing git commits for each separate change. Then you can get a patch per change. And that would avoid having the addidir/addsdir stuff being in the same changes FWIW, I don't think this

Re: [Fedora-livecd-list] Revised: [PATCH] turboLiveInst - improves livecd/usb installer speed by 15-20+%

2007-09-04 Thread Mark McLoughlin
On Mon, 2007-09-03 at 15:33 -0500, Douglas McClendon wrote: Mark McLoughlin wrote: The main suggestion I'd have is that if the osmin.size was dropped[1], Actually in my first iteration of the patch, I was using dumpe2fs, but my parsing of it with awk and grep looked pretty ugly

Re: Managing patches [was Re: [Fedora-livecd-list] [PATCH] overlay/persistence second pass - for developer reference only]

2007-09-04 Thread Mark McLoughlin
On Tue, 2007-09-04 at 06:19 -0500, Matt Domsch wrote: On Tue, Sep 04, 2007 at 09:17:59AM +0100, Mark McLoughlin wrote: Hey, On Tue, 2007-08-21 at 16:18 -0400, Jeremy Katz wrote: * It's good to get into the habit of doing git commits for each separate change. Then you can get

Re: [Fedora-livecd-list] Revised: [PATCH] turboLiveInst - improves livecd/usb installer speed by 15-20+%

2007-09-03 Thread Mark McLoughlin
Hi, This doesn't actually seem so bad to me ... The main suggestion I'd have is that if the osmin.size was dropped[1], and if we could reduce the size of the COW area of the snapshot to its minimal (i.e. look at how much is used and truncate it at that point), then we can just

Re: [Fedora-livecd-list] [PATCH] livecd-creator : implement kickstart network command

2007-04-13 Thread Mark McLoughlin
On Wed, 2007-04-11 at 18:29 +0100, Mark McLoughlin wrote: On Wed, 2007-04-11 at 13:15 -0400, Jeremy Katz wrote: On Wed, 2007-04-11 at 14:41 +0100, Mark McLoughlin wrote: Here's a patch which takes a stab at implementing kickstart's network command in livecd-creator. This ends up