Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h264_slice: More complete cleanup in h264_slice_header_init()

2014-08-22 Thread Michael Niedermayer
On Thu, Aug 21, 2014 at 10:58:34PM +, Carl Eugen Hoyos wrote: > Michael Niedermayer gmx.at> writes: > > > Fixes null pointer dereference > > Fixes Ticket3873 > > Thank you! both patches applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix o

[FFmpeg-devel] [PATCH] lavc/tiff: add support for LZMA compression

2014-08-22 Thread James Almer
Derived from deflate code. Requires liblzma. Signed-off-by: James Almer --- Changelog | 1 + configure | 5 +++- libavcodec/tiff.c | 85 +-- 3 files changed, 88 insertions(+), 3 deletions(-) diff --git a/Changelog b/Changelog

Re: [FFmpeg-devel] [PATCH] Adds support for setting aq_mode in libvpx encoder

2014-08-22 Thread James Almer
On 22/08/14 3:25 PM, Deb Mukherjee wrote: > @@ -803,6 +807,11 @@ static const AVOption vp9_options[] = { > { "tile-columns","Number of tile columns to use, log2", > OFFSET(tile_columns),AV_OPT_TYPE_INT, {.i64 = -1}, -1, 6, VE}, > { "tile-rows", "Number of tile rows

Re: [FFmpeg-devel] [PATCH] h264: do not return on sidedata allocation failure

2014-08-22 Thread Michael Niedermayer
On Fri, Aug 22, 2014 at 04:57:35PM +0200, Christophe Gisquet wrote: > Hi, > > following "[PATCH] h264: Move AFD to side data to match MPEG-2", it > was mentioned making sidedata allocation failures non-fatal. > > This patch is a proposal for this. > > -- > Christophe > h264.c | 16 +++--

Re: [FFmpeg-devel] [PATCH] avfilter/showcqt: add fontcolor option

2014-08-22 Thread Muhammad Faiz
On Thu, Aug 21, 2014 at 7:33 AM, Muhammad Faiz wrote: > On Thu, Aug 21, 2014 at 3:49 AM, Clément Bœsch wrote: > >> On Wed, Aug 20, 2014 at 07:10:56AM +0700, Muhammad Faiz wrote: >> [...] >> > +static double r_func(void *p, double x) >> > +{ >> > +x = av_clipd(x, 0.0, 1.0); >> > +return (

Re: [FFmpeg-devel] [PATCH] Adds decode support for formats other than 420

2014-08-22 Thread James Almer
On 22/08/14 5:31 PM, Deb Mukherjee wrote: > Handles new VP9 profiles 1-3 with different color sampling and > bit-depths. > --- > libavcodec/libvpxdec.c | 69 > +++--- > 1 file changed, 60 insertions(+), 9 deletions(-) > > diff --git a/libavcodec/libvpx

Re: [FFmpeg-devel] [PATCH] Adds decode support for formats other than 420

2014-08-22 Thread Reimar Döffinger
On 22.08.2014, at 22:31, Deb Mukherjee wrote: > +// returns 0 on success, 1 on unsupported Please choose one of the standard ways, either 1 for success and 0 failure, or negative failure, 0 or positive success. This variant, at least in the context of FFmpeg, is just confusing/misleading Though

Re: [FFmpeg-devel] [RFC] [PATCH] hevc_ps: reorder SPS reading to allow some errors

2014-08-22 Thread Michael Niedermayer
On Thu, Aug 21, 2014 at 10:07:23PM -0700, Timothy Gu wrote: > On Aug 21, 2014 10:14 AM, "Christophe Gisquet" > wrote: > > > > Hi, > > > > 2014-08-21 3:06 GMT+02:00 Michael Niedermayer : > > > heres a narrower solution for this file > > > not sure its better > > > i can apply whichever you prefer,

Re: [FFmpeg-devel] [PATCH] Adds decode support for formats other than 420

2014-08-22 Thread compn
On Fri, 22 Aug 2014 13:31:06 -0700 Deb Mukherjee wrote: > Handles new VP9 profiles 1-3 with different color sampling and > bit-depths. > --- > -static int vp8_decode(AVCodecContext *avctx, > +static int vpx_decode(AVCodecContext *avctx, > -static av_cold int vp8_free(AVCodecContext *avctx) > +s

Re: [FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-22 Thread Timothy Gu
On Aug 22, 2014 1:29 PM, "Debargha Mukherjee" wrote: > > Unless the codec is VP9, VPX_Q will not be set. So the behavior does not > change for VP8. If it's not set, then the code won't compile with older libvpx. Timothy ___ ffmpeg-devel mailing list ff

[FFmpeg-devel] [PATCH] avformat/mxfenc: dont warn about d10_channelcount being ignored if its not set

2014-08-22 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/mxfenc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index bba0115..6a6b7c2 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -1023,7 +1023,7 @@ static void mxf

[FFmpeg-devel] [PATCH] Adds decode support for formats other than 420

2014-08-22 Thread Deb Mukherjee
Handles new VP9 profiles 1-3 with different color sampling and bit-depths. --- libavcodec/libvpxdec.c | 69 +++--- 1 file changed, 60 insertions(+), 9 deletions(-) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index 94e1e4d..7c397fb 10064

Re: [FFmpeg-devel] [PATCH 2/2] vidstabutils: improve documentation

2014-08-22 Thread Michael Niedermayer
On Thu, Aug 21, 2014 at 07:12:10PM -0700, Timothy Gu wrote: > Signed-off-by: Timothy Gu > --- > libavfilter/vidstabutils.h | 17 ++--- > 1 file changed, 14 insertions(+), 3 deletions(-) both patches applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040

Re: [FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-22 Thread James Zern
On Fri, Aug 22, 2014 at 10:53 AM, Deb Mukherjee wrote: > [...] > @@ -311,7 +316,7 @@ static av_cold int vpx_init(AVCodecContext *avctx, > } else { > if (enccfg.rc_end_usage == VPX_CQ) { > enccfg.rc_target_bitrate = 100; > -} else { > +} else if (enccf

[FFmpeg-devel] [PATCH] Adds support for setting aq_mode in libvpx encoder

2014-08-22 Thread Deb Mukherjee
Sets aq_mode in the [0, 3] range for the libvpx encode wrapper. 0: none 1: variance aq 2: complexity aq 3: cyclic refresh aq --- doc/encoders.texi | 5 - libavcodec/libvpxenc.c | 9 + 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/doc/encoders.texi b/doc/encoders.t

[FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-22 Thread Deb Mukherjee
Changes in the parameter mapping for libvpx to support the constant quality mode in VP9. The assumption in the patch is that if crf is provided but bitrate is 0, then the 'constant quality' mode of VP9 is used. However if both are present, the 'constrained quality' mode is used as before. --- liba

[FFmpeg-devel] [PATCH] h264: do not return on sidedata allocation failure

2014-08-22 Thread Christophe Gisquet
Hi, following "[PATCH] h264: Move AFD to side data to match MPEG-2", it was mentioned making sidedata allocation failures non-fatal. This patch is a proposal for this. -- Christophe From 7092da22cf0efbdb0988810bd30c279d18388fdc Mon Sep 17 00:00:00 2001 From: Christophe Gisquet Date: Fri, 22 Au

Re: [FFmpeg-devel] [PATCH] h264: Move AFD to side data to match MPEG-2

2014-08-22 Thread Christophe Gisquet
Hi, 2014-08-22 1:21 GMT+02:00 Christophe Gisquet : > Maybe all that side data stuff should be moved to the end of the > function first (but before the last thread-related line), and fixed, > then you also add this hunk there? Not a good thing to do either, after discussing with Michael. I'll send

Re: [FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

2014-08-22 Thread Michael Niedermayer
On Fri, Aug 22, 2014 at 02:04:36PM +0200, Mickaël Raulet wrote: > for the whole patchset. all applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and endeavor to excel them, by a

Re: [FFmpeg-devel] [PATCH 4/4] x86: hevcdsp: use compilation-time-fixed constant

2014-08-22 Thread Michael Niedermayer
On Mon, Jul 28, 2014 at 05:17:28PM +, Christophe Gisquet wrote: > The stride for some buffers is known. > --- > libavcodec/x86/hevc_mc.asm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0F

Re: [FFmpeg-devel] [PATCH 3/4] hevcdsp: remove more instances of compile-time-fixed parameters

2014-08-22 Thread Michael Niedermayer
On Mon, Aug 04, 2014 at 06:46:17PM +0200, Christophe Gisquet wrote: > 2014-07-28 19:17 GMT+02:00 Christophe Gisquet : > > --- > > libavcodec/hevc.c | 8 +++ > > libavcodec/hevcdsp.h | 8 +++ > > libavcodec/hevcdsp_template.c | 56 > > +---

Re: [FFmpeg-devel] [PATCH 2/4] hevcdsp: remove compilation-time-fixed parameter

2014-08-22 Thread Michael Niedermayer
On Mon, Jul 28, 2014 at 05:17:26PM +, Christophe Gisquet wrote: > The dststride parameter is always MAX_PB_SIZE. > --- > libavcodec/hevc.c | 4 ++-- > libavcodec/hevcdsp.h | 4 ++-- > libavcodec/hevcdsp_template.c | 27 +-- > libavcodec/x86/hevc_m

Re: [FFmpeg-devel] [PATCH 1/4] hevc: move MAX_PB_SIZE declaration

2014-08-22 Thread Michael Niedermayer
On Mon, Jul 28, 2014 at 05:17:25PM +, Christophe Gisquet wrote: > --- > libavcodec/hevc.h| 1 - > libavcodec/hevcdsp.h | 2 ++ > 2 files changed, 2 insertions(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting co

Re: [FFmpeg-devel] [PATCH 4/4] wavpackenc: reset trailer info on block encoding

2014-08-22 Thread Paul B Mahol
On 8/22/14, Christophe Gisquet wrote: > In some cases, in particular if several blocks are needed because of > the channel layout (e.g. 2.1), the information used to write the > trailing bits terminating the sample data was not reset. > > This would cause potential desync on the decoder, although

Re: [FFmpeg-devel] [PATCH 3/4] wavpack: check number of channels

2014-08-22 Thread Paul B Mahol
On 8/22/14, Christophe Gisquet wrote: > This means container and codec disagree. The codec is supposed to > know better so this could be an error instead. > --- > libavcodec/wavpack.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/wavpack.c b/libavcodec/wa

Re: [FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

2014-08-22 Thread Mickaël Raulet
for the whole patchset. Mickaël Le 22 août 2014 à 13:25, Michael Niedermayer a écrit : > On Fri, Aug 22, 2014 at 11:40:17AM +0200, Mickaël Raulet wrote: >> Patch okay. > > patch applied > > just to make sure i dont misunderstand, that "okay" was just for this > patch or the whole patchset ? >

Re: [FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

2014-08-22 Thread Michael Niedermayer
On Fri, Aug 22, 2014 at 11:40:17AM +0200, Mickaël Raulet wrote: > Patch okay. patch applied just to make sure i dont misunderstand, that "okay" was just for this patch or the whole patchset ? thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In fact, the

Re: [FFmpeg-devel] [PATCH 2/4] wavpackenc: make assert more thorough

2014-08-22 Thread Michael Niedermayer
On Fri, Aug 22, 2014 at 09:31:43AM +, Christophe Gisquet wrote: > It was only validating that normal data wasn't filling the buffer. > However, extra data may be written afterwards. > --- > libavcodec/wavpackenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...]

Re: [FFmpeg-devel] [PATCH 1/4] wavpackenc: fix number of samples per block

2014-08-22 Thread Michael Niedermayer
On Fri, Aug 22, 2014 at 09:31:42AM +, Christophe Gisquet wrote: > Currently, the encoder will try to reduce it down to 15, but the > decoder will complain starting at 131072 (WV_MAX_SAMPLES). Therefore, > change the loop limit. > > Fixes ticket #3881. > --- > libavcodec/wavpackenc.c | 2 +

Re: [FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

2014-08-22 Thread Mickaël Raulet
Patch okay. Mickaël Le 4 août 2014 à 10:31, Christophe Gisquet a écrit : > Hi, > > 2014-08-02 14:48 GMT+02:00 Michael Niedermayer : >> seems to fail with >> libavcodec/x86/hevc_mc.asm:1258: error: (add:2) cannot reference symbol >> `MAX_PB_SIZE' in preprocessor > > I forgot the initial patch

[FFmpeg-devel] [PATCH 4/4] wavpackenc: reset trailer info on block encoding

2014-08-22 Thread Christophe Gisquet
In some cases, in particular if several blocks are needed because of the channel layout (e.g. 2.1), the information used to write the trailing bits terminating the sample data was not reset. This would cause potential desync on the decoder, although decoded samples were actually mostly fine. Fixe

[FFmpeg-devel] [PATCH 3/4] wavpack: check number of channels

2014-08-22 Thread Christophe Gisquet
This means container and codec disagree. The codec is supposed to know better so this could be an error instead. --- libavcodec/wavpack.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c index 9f72ebe..1ad3901 100644 --- a/libavcod

[FFmpeg-devel] [PATCH 2/4] wavpackenc: make assert more thorough

2014-08-22 Thread Christophe Gisquet
It was only validating that normal data wasn't filling the buffer. However, extra data may be written afterwards. --- libavcodec/wavpackenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wavpackenc.c b/libavcodec/wavpackenc.c index 169836a..299a035 100644 --- a/li

[FFmpeg-devel] [PATCH 1/4] wavpackenc: fix number of samples per block

2014-08-22 Thread Christophe Gisquet
Currently, the encoder will try to reduce it down to 15, but the decoder will complain starting at 131072 (WV_MAX_SAMPLES). Therefore, change the loop limit. Fixes ticket #3881. --- libavcodec/wavpackenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wavpacke

[FFmpeg-devel] [PATCH 0/4] Fix various issues in wavpack

2014-08-22 Thread Christophe Gisquet
Another batch of different issues. Christophe Gisquet (4): wavpackenc: fix number of samples per block wavpackenc: make assert more thorough wavpack: check number of channels wavpackenc: reset trailer info on block encoding libavcodec/wavpack.c| 5 - libavcodec/wavpackenc.c | 7 +