Re: [FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-17 Thread Hendrik Leppkes
On Sun, Jan 18, 2015 at 1:02 AM, Nicolas George wrote: > L'octidi 28 nivôse, an CCXXIII, Kieran Kunhya a écrit : > > Oops I misunderstood, you mean the software must comply with the users > wishes. > > Yes. > > > Anyway my argument is that BT601 should be the default for the these > > resolutions

Re: [FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-17 Thread Nicolas George
L'octidi 28 nivôse, an CCXXIII, Kieran Kunhya a écrit : > Oops I misunderstood, you mean the software must comply with the users wishes. Yes. > Anyway my argument is that BT601 should be the default for the these > resolutions. If you want, but that must happen immediately when the contents ente

Re: [FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-17 Thread Nicolas George
L'octidi 28 nivôse, an CCXXIII, Kieran Kunhya a écrit : > > There is a very simple way of flagging content that is supposed to comply > > with BT601: the SAR is 512/351. If SAR is 64/45, that means someone before > > nvenc decided that the video is not expected to conform with BT601, and > > nvenc

Re: [FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-17 Thread Kieran Kunhya
On 17 January 2015 at 23:46, Kieran Kunhya wrote: > On 17 January 2015 at 23:38, Nicolas George wrote: >> L'octidi 28 nivôse, an CCXXIII, Kieran Kunhya a écrit : >>> The behaviour of the Nvidia code I believe is correct. >>> As far as I understand it corrects SAR for 720-width content to comply >

Re: [FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-17 Thread Kieran Kunhya
On 17 January 2015 at 23:38, Nicolas George wrote: > L'octidi 28 nivôse, an CCXXIII, Kieran Kunhya a écrit : >> The behaviour of the Nvidia code I believe is correct. >> As far as I understand it corrects SAR for 720-width content to comply >> with BT601. > > That is just not true. > > Basic princ

Re: [FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-17 Thread Nicolas George
L'octidi 28 nivôse, an CCXXIII, Kieran Kunhya a écrit : > The behaviour of the Nvidia code I believe is correct. > As far as I understand it corrects SAR for 720-width content to comply > with BT601. That is just not true. Basic principle: THE COMPETENT USER IS RIGHT. If someone knows BT601, and

Re: [FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-17 Thread Kieran Kunhya
On 17 January 2015 at 23:00, Nicolas George wrote: > L'octidi 28 nivôse, an CCXXIII, Kieran Kunhya a écrit : >> I don't make the standards and frankly whether you dislike them is >> your problem but they exist and need to work correctly. >> Instead you wish to break things based off an artificial

Re: [FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-17 Thread Nicolas George
L'octidi 28 nivôse, an CCXXIII, Kieran Kunhya a écrit : > I don't make the standards and frankly whether you dislike them is > your problem but they exist and need to work correctly. > Instead you wish to break things based off an artificial test pattern > and your own beliefs. I do not wish to br

Re: [FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-17 Thread Kieran Kunhya
On 17 January 2015 at 20:42, Nicolas George wrote: > L'octidi 28 nivôse, an CCXXIII, Kieran Kunhya a écrit : >> BT601 makes this very clear. The active picture is 702 pixels. > > There are two fundamental flaws with your reasoning: > > First, BT601 only applies to a some kind of videos. Wikipedia

Re: [FFmpeg-devel] Post-processing filter Documentation

2015-01-17 Thread Michael Niedermayer
On Sun, Jan 18, 2015 at 02:05:55AM +0530, arwa arif wrote: > This is an attempt for explaining the use of post-processing filters. > > http://trac.ffmpeg.org/wiki/Postprocessing some random thoughts/corrections/extensions i had when reading: QP is choosen by the encoder used to create the video,

Re: [FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-17 Thread Nicolas George
L'octidi 28 nivôse, an CCXXIII, Kieran Kunhya a écrit : > BT601 makes this very clear. The active picture is 702 pixels. There are two fundamental flaws with your reasoning: First, BT601 only applies to a some kind of videos. Wikipedia tells me it applies to "encoding interlaced analog video sign

[FFmpeg-devel] Post-processing filter Documentation

2015-01-17 Thread arwa arif
This is an attempt for explaining the use of post-processing filters. http://trac.ffmpeg.org/wiki/Postprocessing ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-17 Thread Kieran Kunhya
On 17 January 2015 at 20:01, Philip Langdale wrote: > There is a long sad story behind all this, but it's somewhat ambiguous as to > whether DVD content should be treated as 720 pixels wide or 704 pixels, with > 16 pixels cut off. If you decide is should be 704 pixels wide, you need to > adjust th

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-17 Thread Kieran Kunhya
> FFmpeg is correct, there is absolutely no doubt about it: This "active" > pixels nonsense is only relevant for certain very specific media, definitely > not when encoding testsrc and decoding the result to showinfo. Demuxers or > high-level tools may know when they are dealing with that kind of c

[FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-17 Thread Philip Langdale
There is a long sad story behind all this, but it's somewhat ambiguous as to whether DVD content should be treated as 720 pixels wide or 704 pixels, with 16 pixels cut off. If you decide is should be 704 pixels wide, you need to adjust the sample aspect ratio to keep the final display aspect ratio

Re: [FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-17 Thread Nicolas George
L'octidi 28 nivôse, an CCXXIII, Philip Langdale a écrit : > There is a long sad story behind all this, but it's somewhat ambiguous as to > whether DVD content should be treated as 720 pixels wide or 704 pixels, with > 16 pixels cut off. If you decide is should be 704 pixels wide, you need to > adju

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-17 Thread Nicolas George
L'octidi 28 nivôse, an CCXXIII, Kieran Kunhya a écrit : > I haven't quite followed what's going on to decide whether Nvidia or > FFmpeg is correct. FFmpeg is correct, there is absolutely no doubt about it: This "active" pixels nonsense is only relevant for certain very specific media, definitely n

[FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

2015-01-17 Thread Philip Langdale
There is a long sad story behind all this, but it's somewhat ambiguous as to whether DVD content should be treated as 720 pixels wide or 704 pixels, with 16 pixels cut off. If you decide is should be 704 pixels wide, you need to adjust the sample aspect ratio to keep the final display aspect ratio

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-17 Thread Philip Langdale
On Sat, 17 Jan 2015 19:27:17 + Kieran Kunhya wrote: > On 17 January 2015 at 18:14, Nicolas George wrote: > > Le septidi 27 nivôse, an CCXXIII, Philip Langdale a écrit : > >> On Fri, 16 Jan 2015 22:17:56 +0100 > >> Nicolas George wrote: > >> Ok. I did this test and it produces correct result

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-17 Thread Kieran Kunhya
On 17 January 2015 at 18:14, Nicolas George wrote: > Le septidi 27 nivôse, an CCXXIII, Philip Langdale a écrit : >> On Fri, 16 Jan 2015 22:17:56 +0100 >> Nicolas George wrote: >> Ok. I did this test and it produces correct results - SAR 133:221 which >> yields the correct final aspect ratio, > >

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-17 Thread Philip Langdale
On Sat, 17 Jan 2015 19:14:04 +0100 Nicolas George wrote: > Le septidi 27 nivôse, an CCXXIII, Philip Langdale a écrit : > The 45/44 value looks like 704/720: the sign that some people long > time ago in committees in the broadcast industry could not agree > whether the aspect ratio applies to the

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-17 Thread Nicolas George
Le septidi 27 nivôse, an CCXXIII, Philip Langdale a écrit : > On Fri, 16 Jan 2015 22:17:56 +0100 > Nicolas George wrote: > Ok. I did this test and it produces correct results - SAR 133:221 which > yields the correct final aspect ratio, This is a good start. >

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-17 Thread Philip Langdale
On Sat, 17 Jan 2015 18:29:59 +0100 Timo Rothenpieler wrote: > > That's with Timo's patch and with hard-coding the darWidth and > > darHeight to 1024x576. Same result. > > Which patch did you use? The old one, that didn't take the > width/height into account, or the newer one? > The original one

Re: [FFmpeg-devel] [PATCH] Force text files to be downloaded in UNIX line ending (LF)

2015-01-17 Thread Derek Buitenhuis
On 1/16/2015 8:46 PM, Timotius Margo wrote: > However, the official documentation and the wiki still suggest that > MinGW/MSYS as the default environment to build FFmpeg on Windows. For example > MSYS web link points directly to the MinGW/MSYS web page. If MSYS2 is in fact > the recommended shel

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/nvenc: Add support for nvenc api version 5

2015-01-17 Thread Michael Niedermayer
On Fri, Jan 16, 2015 at 01:02:40AM +0100, Timo Rothenpieler wrote: > --- > libavcodec/nvenc.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things a

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-17 Thread Timo Rothenpieler
> That's with Timo's patch and with hard-coding the darWidth and darHeight > to 1024x576. Same result. Which patch did you use? The old one, that didn't take the width/height into account, or the newer one? The original one definitely was not correct. signature.asc Description: OpenPGP digital

[FFmpeg-devel] [PATCH] avfilter/showcqt: add gamma2 option

2015-01-17 Thread Muhammad Faiz
--- doc/filters.texi | 10 ++ libavfilter/avf_showcqt.c | 5 - 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 1b02be4..b8c378f 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -11205,6 +11205,10 @@ Specify gamma

[FFmpeg-devel] [PATCH] avfilter/vf_showinfo: show timebase & framerate too

2015-01-17 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavfilter/vf_showinfo.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index aa3bc83..78ba4a0 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-17 Thread wm4
On Sat, 17 Jan 2015 13:37:30 +0100 Michael Niedermayer wrote: > On Fri, Jan 16, 2015 at 08:48:59PM -0800, Philip Langdale wrote: > > On Fri, 16 Jan 2015 22:17:56 +0100 > > Nicolas George wrote: > > > > > Le septidi 27 nivôse, an CCXXIII, Philip Langdale a écrit : > > > > Right. It is display as

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-17 Thread Michael Niedermayer
On Fri, Jan 16, 2015 at 08:48:59PM -0800, Philip Langdale wrote: > On Fri, 16 Jan 2015 22:17:56 +0100 > Nicolas George wrote: > > > Le septidi 27 nivôse, an CCXXIII, Philip Langdale a écrit : > > > Right. It is display aspect ratio, not sample aspect ratio. And then > > > you have the 45/44 probl