[FFmpeg-devel] [PATCH] h264: avoid unnecessary calls to get_format

2015-03-30 Thread Rainer Hochecker
I think is useless to call get_format in this case, right? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] h264: avoid unnecessary calls to get_format

2015-03-30 Thread Rainer Hochecker
--- libavcodec/h264_slice.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index 80d27e5..9477650 100644 --- a/libavcodec/h264_slice.c +++ b/libavcodec/h264_slice.c @@ -1417,7 +1417,8 @@ int ff_h264_decode_slice_header(H264Co

Re: [FFmpeg-devel] [PATCH 1/2] lavf/segment: style nits

2015-03-30 Thread Michael Niedermayer
On Mon, Mar 30, 2015 at 08:23:19PM -0600, Rodger Combs wrote: > --- > libavformat/segment.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The greatest way to live with honor in th

[FFmpeg-devel] [PATCH 1/2] lavf/segment: style nits

2015-03-30 Thread Rodger Combs
--- libavformat/segment.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 7b8fdad..69038ca 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -226,7 +226,7 @@ static int segment_start(AVFormatContext *s,

[FFmpeg-devel] [PATCH 2/2] WIP: lavf/segment: provide a virtual AVIOContext representing all the segments

2015-03-30 Thread Rodger Combs
This needs a fair bit of testing and review before merge. --- libavformat/segment.c | 259 ++ 1 file changed, 198 insertions(+), 61 deletions(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 69038ca..4d934a2 100644 --- a/libavform

Re: [FFmpeg-devel] [PATCH] lavf: Add support for WebM Live Muxing

2015-03-30 Thread Lukasz Marek
When are we going to get a DASH demuxer? Why don't you implement it? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] vf_drawtext: add support for setting box border width

2015-03-30 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/filters.texi | 4 libavfilter/vf_drawtext.c | 5 - 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 15f8ed5..b75ce5a 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -3955,6 +3955,

[FFmpeg-devel] [PATCH] avcodec/libx265: export choosen picture types

2015-03-30 Thread Michael Niedermayer
Fixes part of ticket 4285 anyone knows where the choosen QPs are or QP average is ? Signed-off-by: Michael Niedermayer --- libavcodec/libx265.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 5a26ca9..ceadcd0 100644 --- a/libavcodec

Re: [FFmpeg-devel] [PATCH] lavf: Add support for WebM Live Muxing

2015-03-30 Thread wm4
On Mon, 30 Mar 2015 12:49:45 -0700 Vignesh Venkatasubramanian wrote: > This patch adds support for WebM Live Muxing by adding a new WebM > Chunk muxer. It writes out live WebM Chunks which can be used for > playback using Live DASH Clients. > > Please see muxers.texi for sample usage. > > Signe

Re: [FFmpeg-devel] [PATCH] lavf: Add support for WebM Live Muxing

2015-03-30 Thread Carl Eugen Hoyos
Vignesh Venkatasubramanian google.com> writes: > >> +oc->streams = NULL; > >> +oc->nb_streams = 0; > >> +avformat_free_context(oc); > > > > The first two seem unnecessary if you call > > avformat_free_context(). > > The first two lines are intentional. Sorry about the comment;-) Ca

[FFmpeg-devel] [PATCH] lavf: Add support for WebM Live Muxing

2015-03-30 Thread Vignesh Venkatasubramanian
This patch adds support for WebM Live Muxing by adding a new WebM Chunk muxer. It writes out live WebM Chunks which can be used for playback using Live DASH Clients. Please see muxers.texi for sample usage. Signed-off-by: Vignesh Venkatasubramanian --- Changelog | 1 + doc/mux

[FFmpeg-devel] Ticket 4386 : crash create by previous patch

2015-03-30 Thread Martin Vignali
Hello, After some research, the crash when reading exr Piz file (ticket 4386), appear with this patch : https://github.com/FFmpeg/FFmpeg/commit/586ba24ff29468d2a4ee843a9650feea5b2be6f6 if, i use the previous line : memset(lut + k, 0, (USHORT_RANGE - k) * 2); instead of the new one : memset(lut +

Re: [FFmpeg-devel] [PATCH 1/4] lavf: add directory listing API

2015-03-30 Thread Lukasz Marek
On 30.03.2015 03:01, Michael Niedermayer wrote: On Mon, Mar 30, 2015 at 12:36:34AM +0200, Lukasz Marek wrote: On 29.03.2015 01:14, Mariusz Szczepańczyk wrote: diff --git a/doc/APIchanges b/doc/APIchanges index 3f153e9..814f752 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -15,6 +15,15 @@

Re: [FFmpeg-devel] [PATCH] avcodec/libdcadec: remove av_assert and check bits_per_sample more completely

2015-03-30 Thread Michael Niedermayer
On Sun, Mar 29, 2015 at 01:19:11PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/libdcadec.c |4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let u

Re: [FFmpeg-devel] [PATCH] lavf: Add support for WebM Live Muxing

2015-03-30 Thread Carl Eugen Hoyos
Vignesh Venkatasubramanian google.com> writes: > +if (!wc->oformat) { return AVERROR_MUXER_NOT_FOUND; } It is your file but most people here seem to agree that the following is more (and not less) readable: if (!wc->oformat) return AVERROR_MUXER_NOT_FOUND; > +if ((ret = chu

[FFmpeg-devel] [PATCH] avfilter/vf_vignette: force per frame evaluation if per frame variables are used

2015-03-30 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavfilter/vf_vignette.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_vignette.c b/libavfilter/vf_vignette.c index 806bd72..9a05651 100644 --- a/libavfilter/vf_vignette.c +++ b/libavfilter/vf_vignette.c @@ -

[FFmpeg-devel] [PATCH] lavf: Add support for WebM Live Muxing

2015-03-30 Thread Vignesh Venkatasubramanian
This patch adds support for WebM Live Muxing by adding a new WebM Chunk muxer. It writes out live WebM Chunks which can be used for playback using Live DASH Clients. Please see muxers.texi for sample usage. Signed-off-by: Vignesh Venkatasubramanian --- Changelog | 1 + doc/mux

Re: [FFmpeg-devel] Patch for High color and High bit-depth support

2015-03-30 Thread Carl Eugen Hoyos
Debargha Mukherjee google.com> writes: > - if (avctx->profile != FF_PROFILE_UNKNOWN) > - enccfg.g_profile = avctx->profile; > +if (avctx->profile != FF_PROFILE_UNKNOWN) { > +enccfg.g_profile = avctx->profile; > +} Please make this a separate patch, do not mix functional

Re: [FFmpeg-devel] [PATCH] tiff: Return more meaningful error codes

2015-03-30 Thread Michael Niedermayer
On Mon, Mar 30, 2015 at 10:24:06PM +0530, Himangi Saraogi wrote: > --- > libavcodec/tiffenc.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but

Re: [FFmpeg-devel] [PATCH 2/8] png: Don't fail when a packet is larger than INT_MAX

2015-03-30 Thread Michael Niedermayer
On Mon, Mar 30, 2015 at 06:02:35PM +0200, wm4 wrote: > On Mon, 30 Mar 2015 17:47:03 +0200 > Michael Niedermayer wrote: > > > On Mon, Mar 30, 2015 at 05:11:05PM +0200, wm4 wrote: > > > On Mon, 30 Mar 2015 13:49:08 + > > > Donny Yang wrote: > > > > > > > On 30 March 2015 at 02:48, Michael Nie

[FFmpeg-devel] [PATCH] tiff: Return more meaningful error codes

2015-03-30 Thread Himangi Saraogi
--- libavcodec/tiffenc.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libavcodec/tiffenc.c b/libavcodec/tiffenc.c index 44cd956..2cdac0b 100644 --- a/libavcodec/tiffenc.c +++ b/libavcodec/tiffenc.c @@ -164,7 +164,8 @@ static int add_entry1(TiffEncoderContext *s

Re: [FFmpeg-devel] [PATCH] tiff: Return more meaningful error codes

2015-03-30 Thread Himangi Saraogi
On 30 March 2015 at 22:00, Carl Eugen Hoyos wrote: > Himangi Saraogi gmail.com> writes: > > > case TIFF_LZW: > > return ff_lzw_encode(s->lzws, src, n); > > default: > > -return -1; > > +return AVERROR(EINVAL); > > Please print a message in this case or > explai

Re: [FFmpeg-devel] [PATCH] tiff: Return more meaningful error codes

2015-03-30 Thread Carl Eugen Hoyos
Himangi Saraogi gmail.com> writes: > case TIFF_LZW: > return ff_lzw_encode(s->lzws, src, n); > default: > -return -1; > +return AVERROR(EINVAL); Please print a message in this case or explain why this is not a good idea. (And please don't make me write this a

Re: [FFmpeg-devel] [PATCH 2/8] png: Don't fail when a packet is larger than INT_MAX

2015-03-30 Thread wm4
On Mon, 30 Mar 2015 17:47:03 +0200 Michael Niedermayer wrote: > On Mon, Mar 30, 2015 at 05:11:05PM +0200, wm4 wrote: > > On Mon, 30 Mar 2015 13:49:08 + > > Donny Yang wrote: > > > > > On 30 March 2015 at 02:48, Michael Niedermayer wrote: > > > > > > > On Sun, Mar 29, 2015 at 11:05:41AM +0

[FFmpeg-devel] [PATCH] tiff: Return more meaningful error codes

2015-03-30 Thread Himangi Saraogi
--- libavcodec/tiffenc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavcodec/tiffenc.c b/libavcodec/tiffenc.c index 44cd956..7a872a2 100644 --- a/libavcodec/tiffenc.c +++ b/libavcodec/tiffenc.c @@ -164,7 +164,8 @@ static int add_entry1(TiffEncoderContext *s,

Re: [FFmpeg-devel] [PATCH 2/8] png: Don't fail when a packet is larger than INT_MAX

2015-03-30 Thread Michael Niedermayer
On Mon, Mar 30, 2015 at 05:11:05PM +0200, wm4 wrote: > On Mon, 30 Mar 2015 13:49:08 + > Donny Yang wrote: > > > On 30 March 2015 at 02:48, Michael Niedermayer wrote: > > > > > On Sun, Mar 29, 2015 at 11:05:41AM +, Donny Yang wrote: > > > > Signed-off-by: Donny Yang > > > > --- > > > >

Re: [FFmpeg-devel] [GSoC] Proof-of-concept HTTP Server

2015-03-30 Thread Nicolas George
Le nonidi 9 germinal, an CCXXIII, Stephan Holljes a écrit : > I hope this addresses the issues mentioned. > I added a new label in case of failure in http_open() in favor of > duplicated code (i.e. calling av_dict_free() multiple times). I copied > the style from the other functions. > > Signed-of

Re: [FFmpeg-devel] [PATCH 2/8] png: Don't fail when a packet is larger than INT_MAX

2015-03-30 Thread wm4
On Mon, 30 Mar 2015 13:49:08 + Donny Yang wrote: > On 30 March 2015 at 02:48, Michael Niedermayer wrote: > > > On Sun, Mar 29, 2015 at 11:05:41AM +, Donny Yang wrote: > > > Signed-off-by: Donny Yang > > > --- > > > libavcodec/pngenc.c | 2 -- > > > 1 file changed, 2 deletions(-) > > >

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-03-30 Thread Michael Niedermayer
On Mon, Mar 30, 2015 at 11:37:10AM +0200, Wiebe Cazemier wrote: > - Original Message - > > From: "Kieran Kunhya" > > To: "Wiebe Cazemier" > > Sent: Monday, 30 March, 2015 10:47:49 AM > > Subject: Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression > > (drc_scale) is now 0

Re: [FFmpeg-devel] [PATCH 2/8] png: Don't fail when a packet is larger than INT_MAX

2015-03-30 Thread Donny Yang
On 30 March 2015 at 02:48, Michael Niedermayer wrote: > On Sun, Mar 29, 2015 at 11:05:41AM +, Donny Yang wrote: > > Signed-off-by: Donny Yang > > --- > > libavcodec/pngenc.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c > > index 3

Re: [FFmpeg-devel] [PATCH] Add 'Presentation Y offset' metadata

2015-03-30 Thread Michael Niedermayer
On Mon, Mar 30, 2015 at 03:01:54PM +0200, tomas.har...@codemill.se wrote: > On 2015-03-30 14:21, Michael Niedermayer wrote: > >On Mon, Mar 30, 2015 at 12:31:04PM +0200, tomas.har...@codemill.se > >wrote: > >>On 2015-03-30 12:19, tim nicholson wrote: > >>>Some software mis decodes IMX material in mx

Re: [FFmpeg-devel] [PATCH] Add 'Presentation Y offset' metadata

2015-03-30 Thread tim nicholson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 30/03/15 13:21, Michael Niedermayer wrote: > On Mon, Mar 30, 2015 at 12:31:04PM +0200, tomas.har...@codemill.se wro te: >> On 2015-03-30 12:19, tim nicholson wrote: >>> Some software mis decodes IMX material in mxf if this metadata field is >>> mis

Re: [FFmpeg-devel] [PATCH] WIP: lavf/segment: provide a virtual AVIOContext representing all the segments

2015-03-30 Thread Michael Niedermayer
On Sun, Mar 29, 2015 at 10:07:21PM -0600, Rodger Combs wrote: > This needs a fair bit of testing and review before merge. > > Re: mini: If you wish to shorten my name please use mn, its fewer keys, so you safe some time > > if the header does get updated at the end this would mismatch

Re: [FFmpeg-devel] [PATCH] Add 'Presentation Y offset' metadata

2015-03-30 Thread tomas . hardin
On 2015-03-30 14:21, Michael Niedermayer wrote: On Mon, Mar 30, 2015 at 12:31:04PM +0200, tomas.har...@codemill.se wrote: On 2015-03-30 12:19, tim nicholson wrote: >Some software mis decodes IMX material in mxf if this metadata field is >missing. See the discussion on the ffmpeg ML:- > >"[FFmpeg

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-03-30 Thread Andy Furniss
Michael Niedermayer wrote: Apologies for the slightly out of place response. I've only just subscribed after reading the rest of this thread via the archive. I'm with KieranK the exception should be full range for those that can stand it. Maybe I am not best placed to comment as I mixdown to 2c

Re: [FFmpeg-devel] [PATCH] Add 'Presentation Y offset' metadata

2015-03-30 Thread Michael Niedermayer
On Mon, Mar 30, 2015 at 12:31:04PM +0200, tomas.har...@codemill.se wrote: > On 2015-03-30 12:19, tim nicholson wrote: > >Some software mis decodes IMX material in mxf if this metadata field is > >missing. See the discussion on the ffmpeg ML:- > > > >"[FFmpeg-user] How to set 3 specific metadata fla

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-03-30 Thread Michael Niedermayer
On Sun, Mar 29, 2015 at 07:01:08PM +0200, Wiebe Cazemier wrote: > Signed-off-by: Wiebe Cazemier > --- > Changelog | 1 + > doc/decoders.texi | 2 +- > libavcodec/ac3dec_fixed.c | 2 +- > libavcodec/ac3dec_float.c | 2 +- > libavutil/version.h | 2 +- > 5 files change

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-03-30 Thread Michael Niedermayer
On Mon, Mar 30, 2015 at 11:28:29AM +0100, Kieran Kunhya wrote: > On 30 March 2015 at 11:24, madshi wrote: > > 2015-03-30 12:10 GMT+02:00 Kieran Kunhya : > >> We should have DRC enabled in AAC and other codecs > >> if it's considered a normative part of the spec. > > > > So basically you do what th

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-03-30 Thread Nicolas George
Le decadi 10 germinal, an CCXXIII, madshi a écrit : > What do you think would happen if we started a vote like the following: > > 1) Should ffmpeg output reduced (range compressed) audio quality by > default, because the spec says so? > 2) Should ffmpeg output full (range) quality by default, unle

Re: [FFmpeg-devel] [PATCH] Add 'Presentation Y offset' metadata

2015-03-30 Thread tim nicholson
On 30/03/15 11:31, tomas.har...@codemill.se wrote: > On 2015-03-30 12:19, tim nicholson wrote: >> Some software mis decodes IMX material in mxf if this metadata field is >> missing. See the discussion on the ffmpeg ML:- >> >> "[FFmpeg-user] How to set 3 specific metadata flags >> (ITU601/displayoff

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-03-30 Thread madshi
2015-03-30 12:28 GMT+02:00 Kieran Kunhya : > Yes, and we let power users change things from the API - > I don't see why that's so hard. It's not hard. The only problem is that there are many many applications out there using ffmpeg, and many (most?) of them are not aware of drc_scale. So they deco

Re: [FFmpeg-devel] [PATCH] Add 'Presentation Y offset' metadata

2015-03-30 Thread tomas . hardin
On 2015-03-30 12:19, tim nicholson wrote: Some software mis decodes IMX material in mxf if this metadata field is missing. See the discussion on the ffmpeg ML:- "[FFmpeg-user] How to set 3 specific metadata flags (ITU601/displayoffset) in FFmpegs IMX50 MXF-OP1a encoding?" This patch add this fi

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-03-30 Thread Kieran Kunhya
On 30 March 2015 at 11:24, madshi wrote: > 2015-03-30 12:10 GMT+02:00 Kieran Kunhya : >> We should have DRC enabled in AAC and other codecs >> if it's considered a normative part of the spec. > > So basically you do what the spec says regardless of whether it makes sense > or not? Yes, and we let

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-03-30 Thread madshi
2015-03-30 12:10 GMT+02:00 Kieran Kunhya : > We should have DRC enabled in AAC and other codecs > if it's considered a normative part of the spec. So basically you do what the spec says regardless of whether it makes sense or not? Best regards, Mathias. ___

[FFmpeg-devel] [PATCH] Add 'Presentation Y offset' metadata

2015-03-30 Thread tim nicholson
Some software mis decodes IMX material in mxf if this metadata field is missing. See the discussion on the ffmpeg ML:- "[FFmpeg-user] How to set 3 specific metadata flags (ITU601/displayoffset) in FFmpegs IMX50 MXF-OP1a encoding?" This patch add this field to mxf wrapped material. -- Tim. Key Fi

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-03-30 Thread Kieran Kunhya
> And you didn't answer the question I asked before: Why would only AC3 have > range compression on by default? Why not any other codec? What is the sense > in that?? Are you saying that laptop speakers are not able to play full > range AC3 tracks, but that they *are* able to play full range TrueHD

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-03-30 Thread madshi
> From: "Kieran Kunhya" > To: "Wiebe Cazemier" > Sent: Monday, 30 March, 2015 3:43:42 AM > Subject: Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default > It is not an option and I quote ETSI 102 366: > "Therefore, the AC-3 decoder shall, by default,

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-03-30 Thread Wiebe Cazemier
- Original Message - > From: "Kieran Kunhya" > To: "Wiebe Cazemier" > Sent: Monday, 30 March, 2015 10:47:49 AM > Subject: Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression > (drc_scale) is now 0 by default > >> > >> It is not an option and I quote ETSI 102 366: > >> > >>

Re: [FFmpeg-devel] UDP Multicast

2015-03-30 Thread Thomas Volkert
Andre Lopes wrote: H I was trying to setup a ffmpeg client to work with an Arecont camera in multicast and realized that the camera would only return a multicast stream after an RSTP call, if the SETUP was requested with the following transport: Transport: RTP/AVP;multicast;client_port=x

Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression (drc_scale) is now 0 by default

2015-03-30 Thread Wiebe Cazemier
- Original Message - > From: "Kieran Kunhya" > To: "Wiebe Cazemier" > Sent: Monday, 30 March, 2015 3:43:42 AM > Subject: Re: [FFmpeg-devel] [PATCH] Dolby Digital dynamic range compression > (drc_scale) is now 0 by default > > > It's in the spec as an *option*, to cater to those who have