Re: [FFmpeg-devel] [PATCH] vf_lut: Add support for RGB48 and RGBA64

2015-10-25 Thread Steven Robertson
Done, thanks. On Tue, Oct 13, 2015 at 12:51 AM, Paul B Mahol wrote: > On 10/11/15, Steven Robertson wrote: > > Thanks for taking a look! > > > > Steve > > > > lgtm, do you need to update fate? > ___ >

Re: [FFmpeg-devel] [PATCH] x86/intmath: allow the source operand for icc/icl ff_ctzll to be a memory location

2015-10-25 Thread Matt Oliver
On 25 October 2015 at 22:16, Hendrik Leppkes wrote: > On Sun, Oct 25, 2015 at 11:26 AM, Matt Oliver > wrote: > > On 25 October 2015 at 12:22, Ganesh Ajjanagadde > wrote: > > > >> On Sat, Oct 24, 2015 at 7:03 PM, James Almer

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-25 Thread Michael Niedermayer
On Sun, Oct 25, 2015 at 11:19:53AM +, Derek Buitenhuis wrote: > On 10/25/2015 11:09 AM, Michael Niedermayer wrote: > > on ARM (cubox) this changes > > time ./ffmpeg -i ~/fate-suite/qt-surge-suite/surge-2-16-B-QDM2.mov > > from > > real0m0.028s > > user0m0.010s > > sys 0m0.010s > >

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-25 Thread Derek Buitenhuis
On 10/25/2015 11:56 AM, Michael Niedermayer wrote: > the problem that causes the slowdown should be due to initializing all > table sizes when only 1 or a few small ones are needed > making the init more fine grained (as it was) should solve this > that could be done with a single mutex (not of

Re: [FFmpeg-devel] [PATCH] x86/intmath: allow the source operand for icc/icl ff_ctzll to be a memory location

2015-10-25 Thread Henrik Gramner
On Sun, Oct 25, 2015 at 12:08 AM, James Almer wrote: > +__asm__ ("bsfq %1,%0" : "=r" (c) : "rm" (v)); Shouldn't we be using tzcnt instead of bsf? Or rep bsf (which is the same opcode as tzcnt) if we need to support ancient compilers. tzcnt is generally faster than bsf on

[FFmpeg-devel] [PATCH]lavc/proresdec2: Fix slice_count for very high resolutions

2015-10-25 Thread Carl Eugen Hoyos
Hi! Attached patch intends to fix an issue reported by forum user Koracas: For slice_count > 0x1 FFmpeg fails to decode a frame, QT seems to ignore the value. Please comment, Carl Eugen diff --git a/libavcodec/proresdec2.c b/libavcodec/proresdec2.c index 932f85f..7d06a0b 100644 ---

Re: [FFmpeg-devel] [DECISION] Include more developers in the voting committee [#2]

2015-10-25 Thread Nicolas George
Le quartidi 4 brumaire, an CCXXIV, Michael Niedermayer a écrit : > Heres another suggested addition to the voting committee > also off topic but i wonder if "[DECISSION]" in the subject is the best > choice for this Remember: before voting, there is campaigning. Basically: first propose something

Re: [FFmpeg-devel] [PATCH] x86/intmath: allow the source operand for icc/icl ff_ctzll to be a memory location

2015-10-25 Thread Hendrik Leppkes
On Sun, Oct 25, 2015 at 11:26 AM, Matt Oliver wrote: > On 25 October 2015 at 12:22, Ganesh Ajjanagadde wrote: > >> On Sat, Oct 24, 2015 at 7:03 PM, James Almer wrote: >> > On 10/24/2015 7:48 PM, Ganesh Ajjanagadde wrote: >> >> On Sat,

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-25 Thread Derek Buitenhuis
On 10/25/2015 11:44 AM, Michael Niedermayer wrote: >> One could argue this is not a representative sample. It's a single small >> file, >> which must always init (as opposed to a longer running process such as >> Chrome. >> Whereas if you have a longer sample, it wouldn't even be within the

Re: [FFmpeg-devel] [PATCH] Adds support parsing the QuickTime Metadata Keys.

2015-10-25 Thread wm4
On Sun, 25 Oct 2015 12:39:08 +0100 Nicolas George wrote: > Le quartidi 4 brumaire, an CCXXIV, Derek Buitenhuis a écrit : > > Perhaps wm4 or Michael or someone can chime in... I don't know of a single > > good > > way to handle this. Just failing if the locale has a radix point

Re: [FFmpeg-devel] [PATCH] avcodec/huffman: replace qsort with AV_QSORT

2015-10-25 Thread Michael Niedermayer
On Sat, Oct 24, 2015 at 09:05:21AM -0400, Ganesh Ajjanagadde wrote: > On Thu, Oct 22, 2015 at 10:25 PM, Ganesh Ajjanagadde > wrote: > > > > On Thu, Oct 22, 2015 at 9:28 PM, Timothy Gu wrote: > > > On Thu, Oct 22, 2015 at 5:01 PM Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-25 Thread Michael Niedermayer
On Fri, Oct 23, 2015 at 03:35:15PM -0700, Dale Curtis wrote: > Changes from partial initialization which happens for every > initialize call to a full initialization once per process. Changes > as discussed on list by wm4 and rbultje. > > Passes fft-test and fate suite. on ARM (cubox) this

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-25 Thread Derek Buitenhuis
On 10/25/2015 11:09 AM, Michael Niedermayer wrote: > on ARM (cubox) this changes > time ./ffmpeg -i ~/fate-suite/qt-surge-suite/surge-2-16-B-QDM2.mov > from > real0m0.028s > user0m0.010s > sys 0m0.010s > > real0m0.028s > user0m0.020s > sys 0m0.000s > > > to > > real

Re: [FFmpeg-devel] [PATCH] Don't needlessly reinitialize ff_cos_## tables.

2015-10-25 Thread wm4
On Sat, 24 Oct 2015 19:30:26 -0400 "Ronald S. Bultje" wrote: > On Sat, Oct 24, 2015 at 6:45 PM, Michael Niedermayer > wrote: > > > either way, this subject is rather uninterresting ill try to do > > something more usefull for FFmpeg than arguing

Re: [FFmpeg-devel] [PATCH] Adds support parsing the QuickTime Metadata Keys.

2015-10-25 Thread Derek Buitenhuis
On 10/25/2015 12:06 PM, wm4 wrote: > I think we don't need to block the patch on this issue anymore, because: > 1. We don't have any workarounds in place this patch could use, > 2. Lots of other code is probably affected anyway I agree, it is beyond the scope of this patch. - Derek

Re: [FFmpeg-devel] [DECISION] Include more developers in the voting committee [#2]

2015-10-25 Thread wm4
On Sun, 25 Oct 2015 01:53:07 +0200 Michael Niedermayer wrote: > Hi all > > Heres another suggested addition to the voting committee > also off topic but i wonder if "[DECISSION]" in the subject is the best > choice for this > > I Suggest to add all people who pushed or

Re: [FFmpeg-devel] [PATCH] Don't needlessly reinitialize ff_cos_## tables.

2015-10-25 Thread Ronald S. Bultje
Hi, On Sun, Oct 25, 2015 at 8:11 AM, wm4 wrote: > On Sat, 24 Oct 2015 19:30:26 -0400 > "Ronald S. Bultje" wrote: > > > On Sat, Oct 24, 2015 at 6:45 PM, Michael Niedermayer > > > wrote: > > > > > either way, this subject is

Re: [FFmpeg-devel] [RFC] mem: facilitate imports into GPU memory space.

2015-10-25 Thread Nicolas George
Le quartidi 4 brumaire, an CCXXIV, Gwenole Beauchesne a écrit : > Allow for av_malloc() to allocate memory that could be mapped into > the GPU address space. This requires allocations on page boundaries. > On the video memory buffers side, this requires minimal alignment of > strides to 64 bytes.

Re: [FFmpeg-devel] [PATCH] x86/intmath: allow the source operand for icc/icl ff_ctzll to be a memory location

2015-10-25 Thread Hendrik Leppkes
On Sun, Oct 25, 2015 at 12:30 PM, Matt Oliver wrote: > On 25 October 2015 at 22:16, Hendrik Leppkes wrote: > >> On Sun, Oct 25, 2015 at 11:26 AM, Matt Oliver >> wrote: >> > On 25 October 2015 at 12:22, Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH] Adds support parsing the QuickTime Metadata Keys.

2015-10-25 Thread Derek Buitenhuis
On 10/23/2015 7:41 PM, Tinglin Liu wrote: > ​ > http://stackoverflow.com/questions/3457968/snprintf-simple-way-to-force-as-radix > ​ > Here it mentioned using the setlocale() function, but I didn't find any > examples elsewhere though > > Derek, would you do the amend and push? Let me know if

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-25 Thread Michael Niedermayer
On Sun, Oct 25, 2015 at 11:48:12AM +, Derek Buitenhuis wrote: > On 10/25/2015 11:44 AM, Michael Niedermayer wrote: > >> One could argue this is not a representative sample. It's a single small > >> file, > >> which must always init (as opposed to a longer running process such as > >> Chrome.

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-25 Thread Ronald S. Bultje
Hi, On Sun, Oct 25, 2015 at 7:48 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 10/25/2015 11:44 AM, Michael Niedermayer wrote: > >> One could argue this is not a representative sample. It's a single > small file, > >> which must always init (as opposed to a longer running

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-25 Thread Derek Buitenhuis
On 10/25/2015 11:56 AM, Ronald S. Bultje wrote: > So this is likely because we init all tables instead of just these that we > need, right? So how about having one ff_once per table? That should be > trivial to implement. Yep. > Obviously anyone using shell scripts and calls to CLI ffmpeg

Re: [FFmpeg-devel] [PATCH] avformat/aiffdec: give message if compressed codec tag is unsupported

2015-10-25 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > +if (codec->codec_id == AV_CODEC_ID_NONE) > +avpriv_request_sample(s, "unknown or > unsupported codec tag: 0x%X", codec->codec_tag); You could use av_get_codec_tag_string() to make this more readable. Looks good either way, Carl Eugen

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-25 Thread Ronald S. Bultje
Hi, On Sun, Oct 25, 2015 at 9:39 AM, wm4 wrote: > On Sun, 25 Oct 2015 07:56:49 -0400 > "Ronald S. Bultje" wrote: > > > Hi, > > > > On Sun, Oct 25, 2015 at 7:48 AM, Derek Buitenhuis < > > derek.buitenh...@gmail.com> wrote: > > > > > On 10/25/2015 11:44

Re: [FFmpeg-devel] [PATCH] all: simplify qsort comparators, and add const-correctness

2015-10-25 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 9:38 PM, Mark Harris wrote: >>> >>> static int compare_int64(const void *a, const void *b) >>> { >>> -int64_t va = *(int64_t *)a, vb = *(int64_t *)b; >>> -return va < vb ? -1 : va > vb ? +1 : 0; >>> +return *(const int64_t *)a - *(const

Re: [FFmpeg-devel] [PATCH] all: simplify qsort comparators, and add const-correctness

2015-10-25 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 9:32 PM, Ronald S. Bultje wrote: > Hi, > > On Sat, Oct 24, 2015 at 9:02 PM, Ganesh Ajjanagadde > wrote: >> >> All the comparator API needs is > 0, < 0, or = 0 signalling: it does not >> need +1, -1, 0. This avoids some useless

Re: [FFmpeg-devel] [PATCH] x86/intmath: allow the source operand for icc/icl ff_ctzll to be a memory location

2015-10-25 Thread Matt Oliver
On 25 October 2015 at 12:22, Ganesh Ajjanagadde wrote: > On Sat, Oct 24, 2015 at 7:03 PM, James Almer wrote: > > On 10/24/2015 7:48 PM, Ganesh Ajjanagadde wrote: > >> On Sat, Oct 24, 2015 at 6:08 PM, James Almer wrote: > >>> This gives

Re: [FFmpeg-devel] [PATCH] Adds support parsing the QuickTime Metadata Keys.

2015-10-25 Thread Nicolas George
Le quartidi 4 brumaire, an CCXXIV, Derek Buitenhuis a écrit : > Perhaps wm4 or Michael or someone can chime in... I don't know of a single > good > way to handle this. Just failing if the locale has a radix point as a comma > instead > of a period seems less bad than mucking with the

[FFmpeg-devel] [PATCH] avformat/aiffdec: give message if compressed codec tag is unsupported

2015-10-25 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/aiffdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c index f26951d..7de103b 100644 --- a/libavformat/aiffdec.c +++ b/libavformat/aiffdec.c @@ -128,6 +128,8 @@ static int

Re: [FFmpeg-devel] [RFC] mem: facilitate imports into GPU memory space.

2015-10-25 Thread wm4
On Sun, 25 Oct 2015 06:46:45 +0100 Gwenole Beauchesne wrote: > Allow for av_malloc() to allocate memory that could be mapped into > the GPU address space. This requires allocations on page boundaries. > On the video memory buffers side, this requires minimal alignment of >

Re: [FFmpeg-devel] [PATCH]lavc/proresdec2: Fix slice_count for very high resolutions

2015-10-25 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: > +slice_count = FFMAX(slice_count, > +ctx->mb_width * ctx->mb_height / > mb_height_pow2[log2_slice_mb_width]); This is not correct, please ignore. Carl Eugen ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-25 Thread wm4
On Sun, 25 Oct 2015 07:56:49 -0400 "Ronald S. Bultje" wrote: > Hi, > > On Sun, Oct 25, 2015 at 7:48 AM, Derek Buitenhuis < > derek.buitenh...@gmail.com> wrote: > > > On 10/25/2015 11:44 AM, Michael Niedermayer wrote: > > >> One could argue this is not a representative

Re: [FFmpeg-devel] [PATCH] Adds support parsing the QuickTime Metadata Keys.

2015-10-25 Thread Nicolas George
Le quartidi 4 brumaire, an CCXXIV, wm4 a écrit : > Well, I'm not sure if this only affects LC_NUMERIC and maybe LC_COLLATE? I grant you that LC_PAPER or LC_TELEPHONE are probably harmless; they were added after I made my mental list. It should work by whitelist, not by blacklist. > On the other

Re: [FFmpeg-devel] [PATCH] avcodec: disallow hwaccel with frame threads

2015-10-25 Thread Hendrik Leppkes
On Fri, Oct 23, 2015 at 1:54 PM, Hendrik Leppkes wrote: > HWAccels with frame threads are fundamentally flawed in avcodecs current > design, and there are several known problems ranging from image corruption > to driver crashes. > > These problems come down to two design

Re: [FFmpeg-devel] [PATCH] lavfi: add realtime filter.

2015-10-25 Thread Mark Harris
> +static int filter_frame(AVFilterLink *inlink, AVFrame *frame) > +{ > +AVFilterContext *ctx = inlink->dst; > +RealtimeContext *s = ctx->priv; > + > +if (frame->pts != AV_NOPTS_VALUE) { > +int64_t pts = av_rescale_q(frame->pts, inlink->time_base, > AV_TIME_BASE_Q); > +

Re: [FFmpeg-devel] [PATCH] avutil/opt: print more meaningful default flags values

2015-10-25 Thread Clément Bœsch
On Sat, Oct 24, 2015 at 07:02:50PM +0200, Michael Niedermayer wrote: > On Sat, Oct 24, 2015 at 03:14:33PM +0200, Clément Bœsch wrote: > > Example: > > % ./ffmpeg -h encoder=gif > > [...] > > GIF encoder AVOptions: > > -gifflagsE..V set GIF flags (default > >

[FFmpeg-devel] [PATCH] MAINTAINERS: add key fingerprint

2015-10-25 Thread Ganesh Ajjanagadde
Patch on hold until the results of the "DECISION" call are given. This patch just signifies intent. Signed-off-by: Ganesh Ajjanagadde --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 25cff79..96dab5e 100644 ---

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add key fingerprint

2015-10-25 Thread Michael Niedermayer
On Sun, Oct 25, 2015 at 06:02:33PM -0400, Ganesh Ajjanagadde wrote: > Patch on hold until the results of the "DECISION" call are given. This > patch just signifies intent. > > Signed-off-by: Ganesh Ajjanagadde > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+)

Re: [FFmpeg-devel] [PATCH] all: simplify qsort comparators, and add const-correctness

2015-10-25 Thread Ganesh Ajjanagadde
On Sun, Oct 25, 2015 at 9:46 AM, Ganesh Ajjanagadde wrote: > On Sat, Oct 24, 2015 at 9:38 PM, Mark Harris wrote: static int compare_int64(const void *a, const void *b) { -int64_t va = *(int64_t *)a, vb = *(int64_t *)b; -

[FFmpeg-devel] [PATCH]lavf/xwma: Support wmapro

2015-10-25 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #4963 for me. Please comment, Carl Eugen diff --git a/libavformat/xwma.c b/libavformat/xwma.c index 9edad7d..6c8bb79 100644 --- a/libavformat/xwma.c +++ b/libavformat/xwma.c @@ -85,7 +85,8 @@ static int xwma_read_header(AVFormatContext *s) * extradata for

Re: [FFmpeg-devel] [PATCH 3/5] concatdec: move duration calculating code to open_file

2015-10-25 Thread Marton Balint
On Sun, 25 Oct 2015, Nicolas George wrote: Le tridi 3 brumaire, an CCXXIV, Marton Balint a écrit : Signed-off-by: Marton Balint --- libavformat/concatdec.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavformat/concatdec.c

Re: [FFmpeg-devel] [PATCH 3/3] avutil/tree: add additional const qualifier to the comparator

2015-10-25 Thread Ganesh Ajjanagadde
On Sun, Oct 25, 2015 at 12:35 PM, Michael Niedermayer wrote: > On Sat, Oct 24, 2015 at 09:03:03PM -0400, Ganesh Ajjanagadde wrote: >> On Sat, Oct 24, 2015 at 7:17 PM, Henrik Gramner wrote: >> > On Sun, Oct 25, 2015 at 12:02 AM, Ganesh Ajjanagadde >> >

Re: [FFmpeg-devel] [PATCH 3/3] avutil/tree: add additional const qualifier to the comparator

2015-10-25 Thread Michael Niedermayer
On Sun, Oct 25, 2015 at 12:46:31PM -0400, Ganesh Ajjanagadde wrote: > On Sun, Oct 25, 2015 at 12:35 PM, Michael Niedermayer > wrote: > > On Sat, Oct 24, 2015 at 09:03:03PM -0400, Ganesh Ajjanagadde wrote: > >> On Sat, Oct 24, 2015 at 7:17 PM, Henrik Gramner

[FFmpeg-devel] [PATCH] swr: do not reject channel layouts that use channel 63

2015-10-25 Thread wm4
Channel layouts are essentially uint64_t, and every value is valid. --- libswresample/options.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libswresample/options.c b/libswresample/options.c index 0bcb102..2bf8ab1 100644 --- a/libswresample/options.c +++

Re: [FFmpeg-devel] [PATCH] avfilter/avf_showcqt: rewrite showcqt and add features

2015-10-25 Thread Muhammad Faiz
On Sun, Oct 25, 2015 at 9:51 AM, Michael Niedermayer wrote: > On Sun, Oct 25, 2015 at 08:43:07AM +0700, Muhammad Faiz wrote: >> doc/filters.texi | 181 +++-- >> libavfilter/avf_showcqt.c | 1546 >> +++--- >>

Re: [FFmpeg-devel] [PATCH 1/2] lavfi/drawutils: add const to blending mask.

2015-10-25 Thread Michael Niedermayer
On Sun, Oct 25, 2015 at 04:47:07PM +0100, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/drawutils.c | 9 + > libavfilter/drawutils.h | 2 +- > 2 files changed, 6 insertions(+), 5 deletions(-) LGTM thx [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH 3/3] avutil/tree: add additional const qualifier to the comparator

2015-10-25 Thread Ganesh Ajjanagadde
On Sun, Oct 25, 2015 at 1:03 PM, Michael Niedermayer wrote: > On Sun, Oct 25, 2015 at 12:46:31PM -0400, Ganesh Ajjanagadde wrote: >> On Sun, Oct 25, 2015 at 12:35 PM, Michael Niedermayer >> wrote: >> > On Sat, Oct 24, 2015 at 09:03:03PM -0400,

Re: [FFmpeg-devel] [PATCH 04/11] libavformat/mxfdec.c: Try to increment current edit before rejecting a klv that spans onto next edit unit.

2015-10-25 Thread Tomas Härdin
On Thu, 2015-10-22 at 19:47 +0200, Alexis Ballier wrote: > On Wed, 21 Oct 2015 23:45:07 +0200 > Tomas Härdin wrote: > > > On Wed, 2015-10-21 at 18:00 +0200, Alexis Ballier wrote: > > > Some files such as those from tickets #2817 & #2776 claim to have > > > constant edit

Re: [FFmpeg-devel] [PATCH] avcodec/huffman: replace qsort with AV_QSORT

2015-10-25 Thread Ganesh Ajjanagadde
On Sun, Oct 25, 2015 at 8:12 AM, Michael Niedermayer wrote: > On Sat, Oct 24, 2015 at 09:05:21AM -0400, Ganesh Ajjanagadde wrote: >> On Thu, Oct 22, 2015 at 10:25 PM, Ganesh Ajjanagadde >> wrote: >> > >> > On Thu, Oct 22, 2015 at 9:28 PM, Timothy

[FFmpeg-devel] [PATCH 1/2] lavfi/drawutils: add const to blending mask.

2015-10-25 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/drawutils.c | 9 + libavfilter/drawutils.h | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/libavfilter/drawutils.c b/libavfilter/drawutils.c index 91fffd5..1724a82 100644 --- a/libavfilter/drawutils.c

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: add testsrc2 test source.

2015-10-25 Thread Nicolas George
Le quartidi 4 brumaire, an CCXXIV, Nicolas George a écrit : > Similar to testsrc, but using drawutils and therefore > supporting a lot of pixel formats instead of just rgb24. > This allows using it as input for other tests without > requiring a format conversion. > It is also slightly faster than

Re: [FFmpeg-devel] [PATCH]lavf/xwma: Support wmapro

2015-10-25 Thread Paul B Mahol
On 10/25/15, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #4963 for me. > > Please comment, Carl Eugen > The 24 should be 16, lgtm otherwise. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] x86/intmath: allow the source operand for icc/icl ff_ctzll to be a memory location

2015-10-25 Thread Matt Oliver
On 26 October 2015 at 00:43, Hendrik Leppkes wrote: > On Sun, Oct 25, 2015 at 12:30 PM, Matt Oliver > wrote: > > On 25 October 2015 at 22:16, Hendrik Leppkes > wrote: > > > >> On Sun, Oct 25, 2015 at 11:26 AM, Matt Oliver

Re: [FFmpeg-devel] [PATCH 4/5] concatdec: add metadata for file start time and duration

2015-10-25 Thread Nicolas George
Le tridi 3 brumaire, an CCXXIV, Marton Balint a écrit : > Signed-off-by: Marton Balint > --- > libavformat/concatdec.c| 6 ++ > tests/ref/fate/concat-demuxer-lavf-mxf | 2 +- > tests/ref/fate/concat-demuxer-lavf-mxf_d10 | 2 +- >

Re: [FFmpeg-devel] [PATCH] all: simplify qsort comparators, and add const-correctness

2015-10-25 Thread Ganesh Ajjanagadde
On Sun, Oct 25, 2015 at 9:46 AM, Ganesh Ajjanagadde wrote: > On Sat, Oct 24, 2015 at 9:38 PM, Mark Harris wrote: static int compare_int64(const void *a, const void *b) { -int64_t va = *(int64_t *)a, vb = *(int64_t *)b; -

Re: [FFmpeg-devel] [PATCH] all: simplify qsort comparators, and add const-correctness

2015-10-25 Thread Ganesh Ajjanagadde
On Sun, Oct 25, 2015 at 11:12 AM, Nicolas George wrote: > Le quartidi 4 brumaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >> Seems like the (x > y) - (x < y) trick works very well: GCC optimizes >> it to branch-less code, and it is overflow safe: >>

[FFmpeg-devel] [PATCH 2/2] lavfi: add testsrc2 test source.

2015-10-25 Thread Nicolas George
Similar to testsrc, but using drawutils and therefore supporting a lot of pixel formats instead of just rgb24. This allows using it as input for other tests without requiring a format conversion. It is also slightly faster than testsrc for some reason. Signed-off-by: Nicolas George

Re: [FFmpeg-devel] [PATCH 2/5] fate: add concat demuxer tests

2015-10-25 Thread Marton Balint
On Sun, 25 Oct 2015, Nicolas George wrote: [...] --- a/tests/fate-run.sh +++ b/tests/fate-run.sh @@ -249,6 +249,20 @@ gapless(){ do_md5sum $decfile3 } +concat(){ +template=$(target_path $1) Should it really be target_path? The template is in the source. You are right, target

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: add testsrc2 test source.

2015-10-25 Thread Paul B Mahol
On 10/25/15, Nicolas George wrote: > Le quartidi 4 brumaire, an CCXXIV, Nicolas George a ecrit : >> Similar to testsrc, but using drawutils and therefore >> supporting a lot of pixel formats instead of just rgb24. >> This allows using it as input for other tests without >>

Re: [FFmpeg-devel] [PATCH] avfilter: add vibrato filter

2015-10-25 Thread Ganesh Ajjanagadde
On Sun, Oct 25, 2015 at 12:00 PM, Paul B Mahol wrote: > On 10/24/15, Kyle Swanson wrote: >> Signed-off-by: Kyle Swanson >> --- >> Changelog| 2 +- >> doc/filters.texi | 16 >> libavfilter/Makefile | 1 + >>

Re: [FFmpeg-devel] [PATCH 3/3] avutil/tree: add additional const qualifier to the comparator

2015-10-25 Thread Michael Niedermayer
On Sat, Oct 24, 2015 at 09:03:03PM -0400, Ganesh Ajjanagadde wrote: > On Sat, Oct 24, 2015 at 7:17 PM, Henrik Gramner wrote: > > On Sun, Oct 25, 2015 at 12:02 AM, Ganesh Ajjanagadde > > wrote: > >> -static int cmp(void *key, const void *node) > >>

[FFmpeg-devel] [PATCH] lavfi: add realtime filter.

2015-10-25 Thread Nicolas George
Similar to the -re option in ffmpeg that only works for input files. Can be used at any place in the filter graph. Signed-off-by: Nicolas George --- Changelog| 1 + doc/filters.texi | 16 ++ libavfilter/Makefile | 2 +

Re: [FFmpeg-devel] [PATCH]lavc/proresdec2: Fix slice_count for very high resolutions

2015-10-25 Thread Carl Eugen Hoyos
On Sunday 25 October 2015 01:37:15 pm Carl Eugen Hoyos wrote: > Hi! > > Attached patch intends to fix an issue reported by forum user Koracas: > For slice_count > 0x1 FFmpeg fails to decode a frame, QT seems to > ignore the value. New patch attached. Please comment, Carl Eugen diff --git

Re: [FFmpeg-devel] [PATCH 2/3] avutil/tree: improve documentation for av_tree_find, av_tree_insert

2015-10-25 Thread Ganesh Ajjanagadde
On Sat, Oct 24, 2015 at 6:02 PM, Ganesh Ajjanagadde wrote: > This documents the additional constness, and provides a useful libc > reference for the API specification of the comparator. > > Signed-off-by: Ganesh Ajjanagadde > --- >

Re: [FFmpeg-devel] [PATCH 4/5] concatdec: add metadata for file start time and duration

2015-10-25 Thread Marton Balint
On Sun, 25 Oct 2015, Nicolas George wrote: Le tridi 3 brumaire, an CCXXIV, Marton Balint a écrit : Signed-off-by: Marton Balint --- libavformat/concatdec.c| 6 ++ tests/ref/fate/concat-demuxer-lavf-mxf | 2 +-

Re: [FFmpeg-devel] [PATCH]lavf/xwma: Support wmapro

2015-10-25 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > > Attached patch fixes ticket #4963 for me. > > > > Please comment, Carl Eugen > > > > The 24 should be 16, lgtm otherwise. Applied using bps from the waveformatex header. Thank you, Carl Eugen ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avutil/opt: Support max > INT64_MAX in write_number() with AV_OPT_TYPE_INT64

2015-10-25 Thread Ronald S. Bultje
Hi, On Sun, Oct 25, 2015 at 3:12 PM, wm4 wrote: > On Sun, 25 Oct 2015 19:46:42 +0100 > Michael Niedermayer wrote: > > > From: Michael Niedermayer > > > > This allows for example to set max to UINT64_MAX and set values in that >

Re: [FFmpeg-devel] [PATCH 1/2] lavfi/drawutils: add const to blending mask.

2015-10-25 Thread Nicolas George
Le quartidi 4 brumaire, an CCXXIV, Michael Niedermayer a écrit : > LGTM Thanks, pushed. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] avfilter/vf_removegrain: replace qsort with AV_QSORT

2015-10-25 Thread Ganesh Ajjanagadde
filter_slice calls qsort, so qsort is in a performance critical position. AV_QSORT is substantially faster due to the inlining of the comparison callback. Thus, the increase in performance is worth the increase in binary size. Sample benchmark (x86-64, Haswell, GNU/Linux),