Re: [FFmpeg-devel] [PATCH] lavu/libm: add copysign hack

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 6:26 AM, Ronald S. Bultje wrote: > Hi, > > On Fri, Dec 18, 2015 at 3:47 PM, Ganesh Ajjanagadde > wrote: >> >> On Fri, Dec 18, 2015 at 12:41 PM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Fri, Dec 18,

[FFmpeg-devel] [PATCH] avcodec/s302menc: set supported channel layouts by codec

2015-12-19 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/s302menc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/s302menc.c b/libavcodec/s302menc.c index fbaa845..3706eba 100644 --- a/libavcodec/s302menc.c +++ b/libavcodec/s302menc.c @@ -175,4 +175,9 @@ AVCodec

Re: [FFmpeg-devel] [PATCH] lavu/libm: add copysign hack

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 12:33 PM, Ronald S. Bultje wrote: > Hi, > > On Sat, Dec 19, 2015 at 2:25 PM, Ganesh Ajjanagadde > wrote: > >> On Sat, Dec 19, 2015 at 11:05 AM, Hendrik Leppkes >> wrote: >> > On Sat, Dec 19, 2015 at 6:54 PM,

Re: [FFmpeg-devel] [PATCH] lavu/libm: add copysign hack

2015-12-19 Thread Paul B Mahol
On 12/19/15, Ganesh Ajjanagadde wrote: > On Sat, Dec 19, 2015 at 12:33 PM, Ronald S. Bultje > wrote: >> Hi, >> >> On Sat, Dec 19, 2015 at 2:25 PM, Ganesh Ajjanagadde >> wrote: >> >>> On Sat, Dec 19, 2015 at 11:05 AM, Hendrik Leppkes

Re: [FFmpeg-devel] [PATCH] lavu/libm: add copysign hack

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 1:56 PM, Ganesh Ajjanagadde wrote: > On Sat, Dec 19, 2015 at 1:31 PM, Paul B Mahol wrote: > [...] >> C90 is more than 20 years old. > > Of course, but this was raised by Hendrik and Ronald regarding > compliance and FFmpeg's coding

Re: [FFmpeg-devel] [PATCH 01/12] lavfi/vf_idet: replace round and cast by lrint

2015-12-19 Thread Michael Niedermayer
On Sat, Dec 19, 2015 at 08:01:37AM -0800, Ganesh Ajjanagadde wrote: > On Sat, Dec 19, 2015 at 2:45 AM, Michael Niedermayer > wrote: > > On Fri, Dec 18, 2015 at 09:45:27PM -0800, Ganesh Ajjanagadde wrote: > >> lrint is faster and conveys the intent better here. It is safe

Re: [FFmpeg-devel] [PATCH 06/12] lavf/hlsenc: replace round by lrint

2015-12-19 Thread Michael Niedermayer
On Fri, Dec 18, 2015 at 09:45:32PM -0800, Ganesh Ajjanagadde wrote: > Mainly cosmetic here. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavformat/hlsenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) should be ok [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2015-12-19 Thread Matthias Hunstock
Am 18.12.2015 um 20:25 schrieb Matthias Hunstock: > Introduces new option. PS. I did not find any ressources on how to properly name new FFmpeg options, e.g. to be consistent. Using the existing "ac" option did not work. I would like to add some more features, like selection of video and/or

Re: [FFmpeg-devel] [PATCH] lavu/libm: add copysign hack

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 11:05 AM, Hendrik Leppkes wrote: > On Sat, Dec 19, 2015 at 6:54 PM, Ganesh Ajjanagadde > wrote: >> On Sat, Dec 19, 2015 at 8:06 AM, Ganesh Ajjanagadde >> wrote: >>> On Sat, Dec 19, 2015 at 6:26 AM,

Re: [FFmpeg-devel] [PATCH] lavu/libm: add copysign hack

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 1:33 PM, Hendrik Leppkes wrote: > On Sat, Dec 19, 2015 at 10:28 PM, Ganesh Ajjanagadde wrote: >> On Sat, Dec 19, 2015 at 12:33 PM, Ronald S. Bultje >> wrote: >>> Hi, >>> >>> On Sat, Dec 19, 2015 at 2:25 PM,

[FFmpeg-devel] [PATCH 3/3] rawdec: only exempt BIT0 with need_copy from buffer sanity check

2015-12-19 Thread Andreas Cadhalpun
Otherwise the too samll buffer is directly used in the frame, causing segmentation faults, when trying to use the frame. Signed-off-by: Andreas Cadhalpun --- libavcodec/rawdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 1/3] mlvdec: check that index_entries exist

2015-12-19 Thread Andreas Cadhalpun
This fixes NULL pointer dereferencing. Signed-off-by: Andreas Cadhalpun --- libavformat/mlvdec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c index 48a429e..4b3bdc1 100644 --- a/libavformat/mlvdec.c +++

Re: [FFmpeg-devel] [PATCH 2/2] swscale/arm/yuv2rgb: add ff_yuv420p_to_{argb, rgba, abgr, bgra}_neon_{16, 32}

2015-12-19 Thread Matthieu Bouron
On Sat, Dec 19, 2015 at 06:08:10PM +0100, Michael Niedermayer wrote: > On Sat, Dec 19, 2015 at 01:28:06PM +0100, Matthieu Bouron wrote: > > On Sat, Dec 19, 2015 at 11:50:21AM +0100, Michael Niedermayer wrote: > > > On Sat, Dec 19, 2015 at 10:56:26AM +0100, Matthieu Bouron wrote: > > > > On Sat,

Re: [FFmpeg-devel] [PATCH 1/2] swscale/arm/yuv2rgb: disable neon if accurate_rnd is enabled

2015-12-19 Thread Matthieu Bouron
On Fri, Dec 18, 2015 at 03:59:45PM +0100, Matthieu Bouron wrote: > From: Matthieu Bouron > > This disables the 32bit precision neon code path in favor of the > default C one and avoids breaking fate if accurate_rnd is enabled. > --- >

Re: [FFmpeg-devel] [PATCH] lavu/libm: add copysign hack

2015-12-19 Thread Hendrik Leppkes
On Sat, Dec 19, 2015 at 10:28 PM, Ganesh Ajjanagadde wrote: > On Sat, Dec 19, 2015 at 12:33 PM, Ronald S. Bultje wrote: >> Hi, >> >> On Sat, Dec 19, 2015 at 2:25 PM, Ganesh Ajjanagadde >> wrote: >> >>> On Sat, Dec 19, 2015 at 11:05 AM,

Re: [FFmpeg-devel] [PATCH] lavu/libm: add copysign hack

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 1:31 PM, Paul B Mahol wrote: [...] > C90 is more than 20 years old. Of course, but this was raised by Hendrik and Ronald regarding compliance and FFmpeg's coding guidelines. This also highlights how ludicruous it is in 2015, soon to be 2016. >

[FFmpeg-devel] [PATCH] vaapi: Add VP9 hwaccell support

2015-12-19 Thread Timo Rothenpieler
Signed-off-by: Timo Rothenpieler --- Changelog | 1 + configure | 3 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/vaapi_vp9.c | 168 + libavcodec/version.h | 2

Re: [FFmpeg-devel] [PATCH 01/12] lavfi/vf_idet: replace round and cast by lrint

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 2:45 AM, Michael Niedermayer wrote: > On Fri, Dec 18, 2015 at 09:45:27PM -0800, Ganesh Ajjanagadde wrote: >> lrint is faster and conveys the intent better here. It is safe as long int >> has >> at least 32 bits. >> >> Signed-off-by: Ganesh

Re: [FFmpeg-devel] [PATCH 01/12] lavfi/vf_idet: replace round and cast by lrint

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 8:24 AM, Michael Niedermayer wrote: > On Sat, Dec 19, 2015 at 08:01:37AM -0800, Ganesh Ajjanagadde wrote: >> On Sat, Dec 19, 2015 at 2:45 AM, Michael Niedermayer >> wrote: >> > On Fri, Dec 18, 2015 at 09:45:27PM -0800,

Re: [FFmpeg-devel] [PATCH] mpegvideo: validate block_last_index before dct_unquantize_intra

2015-12-19 Thread Michael Niedermayer
On Sat, Dec 19, 2015 at 06:13:37PM +0100, Andreas Cadhalpun wrote: > If it is negative, it triggers the assertion in > dct_unquantize_h263_intra. > > This is somehow related to the second hunk of commit 9251942: reverting > that prevents these crashes, but breaks the sample from ticket 302. > >

Re: [FFmpeg-devel] [PATCH] mpegvideo: validate block_last_index before dct_unquantize_intra

2015-12-19 Thread Andreas Cadhalpun
On 19.12.2015 21:12, Michael Niedermayer wrote: > On Sat, Dec 19, 2015 at 06:13:37PM +0100, Andreas Cadhalpun wrote: >> If it is negative, it triggers the assertion in >> dct_unquantize_h263_intra. >> >> This is somehow related to the second hunk of commit 9251942: reverting >> that prevents these

Re: [FFmpeg-devel] [PATCH] mpegvideo: validate block_last_index before dct_unquantize_intra

2015-12-19 Thread Michael Niedermayer
On Sat, Dec 19, 2015 at 09:19:27PM +0100, Andreas Cadhalpun wrote: > On 19.12.2015 21:12, Michael Niedermayer wrote: > > On Sat, Dec 19, 2015 at 06:13:37PM +0100, Andreas Cadhalpun wrote: > >> If it is negative, it triggers the assertion in > >> dct_unquantize_h263_intra. > >> > >> This is somehow

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2015-12-19 Thread Timothy Gu
Hi, On Sat, Dec 19, 2015 at 11:23 AM Matthias Hunstock < matthias.hunst...@tu-ilmenau.de> wrote: > Am 18.12.2015 um 20:25 schrieb Matthias Hunstock: > > Introduces new option. > > PS. I did not find any ressources on how to properly name new FFmpeg > options, e.g. to be consistent. Using the

[FFmpeg-devel] [PATCH] avcodec/s302menc: check if buf_size can actually be put into 16bit size

2015-12-19 Thread Paul B Mahol
This disallows creating unplayable audio. Signed-off-by: Paul B Mahol --- libavcodec/s302menc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/s302menc.c b/libavcodec/s302menc.c index 3706eba..c703e9a 100644 --- a/libavcodec/s302menc.c +++

Re: [FFmpeg-devel] [PATCH] lavu/libm: add copysign hack

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 12:33 PM, Ronald S. Bultje wrote: > Hi, > > On Sat, Dec 19, 2015 at 2:25 PM, Ganesh Ajjanagadde > wrote: > >> On Sat, Dec 19, 2015 at 11:05 AM, Hendrik Leppkes >> wrote: >> > On Sat, Dec 19, 2015 at 6:54 PM,

Re: [FFmpeg-devel] [PATCH] lavu/intmath: add faster clz support

2015-12-19 Thread Ganesh Ajjanagadde
On Thu, Dec 17, 2015 at 9:29 AM, Ganesh Ajjanagadde wrote: > On Thu, Dec 17, 2015 at 9:25 AM, Clément Bœsch wrote: >> On Thu, Dec 17, 2015 at 09:23:53AM -0800, Ganesh Ajjanagadde wrote: >>> On Thu, Dec 17, 2015 at 9:20 AM, Kieran Kunhya wrote: >>>

Re: [FFmpeg-devel] [PATCH 10/12] lavfi/vf_cropdetect: replace round by lrint

2015-12-19 Thread Michael Niedermayer
On Fri, Dec 18, 2015 at 09:45:36PM -0800, Ganesh Ajjanagadde wrote: > lrint is at least as fast, and more accurate. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavfilter/vf_cropdetect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ok [...] -- Michael

Re: [FFmpeg-devel] [PATCH] nutdec: reject negative sm_size

2015-12-19 Thread Andreas Cadhalpun
On 19.12.2015 16:25, Michael Niedermayer wrote: > On Sat, Dec 19, 2015 at 02:25:42PM +0100, Andreas Cadhalpun wrote: >> nutdec.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> d1813b6394c006a3f235e5e9a5fb8f5172933736 >> 0001-nutdec-reject-negative-value_len-in-read_sm_data.patch

Re: [FFmpeg-devel] [PATCH 2/2] swscale/arm/yuv2rgb: add ff_yuv420p_to_{argb, rgba, abgr, bgra}_neon_{16, 32}

2015-12-19 Thread Michael Niedermayer
On Sat, Dec 19, 2015 at 01:28:06PM +0100, Matthieu Bouron wrote: > On Sat, Dec 19, 2015 at 11:50:21AM +0100, Michael Niedermayer wrote: > > On Sat, Dec 19, 2015 at 10:56:26AM +0100, Matthieu Bouron wrote: > > > On Sat, Dec 19, 2015 at 03:24:17AM +0100, Michael Niedermayer wrote: > > > > On Fri,

Re: [FFmpeg-devel] [PATCH] lavu/libm: add copysign hack

2015-12-19 Thread Hendrik Leppkes
On Sat, Dec 19, 2015 at 6:54 PM, Ganesh Ajjanagadde wrote: > On Sat, Dec 19, 2015 at 8:06 AM, Ganesh Ajjanagadde > wrote: >> On Sat, Dec 19, 2015 at 6:26 AM, Ronald S. Bultje wrote: >>> Hi, >>> >>> On Fri, Dec 18, 2015 at 3:47

Re: [FFmpeg-devel] [PATCH] lavu/libm: add copysign hack

2015-12-19 Thread Ronald S. Bultje
Hi, On Sat, Dec 19, 2015 at 2:25 PM, Ganesh Ajjanagadde wrote: > On Sat, Dec 19, 2015 at 11:05 AM, Hendrik Leppkes > wrote: > > On Sat, Dec 19, 2015 at 6:54 PM, Ganesh Ajjanagadde > > wrote: > >> On Sat, Dec 19, 2015 at 8:06 AM,

[FFmpeg-devel] [PATCH] mpegvideo: validate block_last_index before dct_unquantize_intra

2015-12-19 Thread Andreas Cadhalpun
If it is negative, it triggers the assertion in dct_unquantize_h263_intra. This is somehow related to the second hunk of commit 9251942: reverting that prevents these crashes, but breaks the sample from ticket 302. Signed-off-by: Andreas Cadhalpun --- Note

Re: [FFmpeg-devel] [PATCH 2/2] lavc/aacsbr: sbr_dequant optimization

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 4:21 AM, Andreas Cadhalpun wrote: > On 18.12.2015 16:52, Ganesh Ajjanagadde wrote: >> On Tue, Dec 15, 2015 at 9:53 PM, Ganesh Ajjanagadde >> wrote: >>> This uses ff_exp2fi to get a speedup (~ 6x). >>> >>> sample

Re: [FFmpeg-devel] [PATCH 10/12] lavfi/vf_cropdetect: replace round by lrint

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 8:47 AM, Michael Niedermayer wrote: > On Fri, Dec 18, 2015 at 09:45:36PM -0800, Ganesh Ajjanagadde wrote: >> lrint is at least as fast, and more accurate. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >>

Re: [FFmpeg-devel] [PATCH 05/12] lavfi/vsrc_mandelbrot: replace round by lrint

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 2:45 AM, Michael Niedermayer wrote: > On Fri, Dec 18, 2015 at 09:45:31PM -0800, Ganesh Ajjanagadde wrote: >> lrint is at least as fast, and is more accurate. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >>

Re: [FFmpeg-devel] [PATCH 06/12] lavf/hlsenc: replace round by lrint

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 8:54 AM, Michael Niedermayer wrote: > On Fri, Dec 18, 2015 at 09:45:32PM -0800, Ganesh Ajjanagadde wrote: >> Mainly cosmetic here. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavformat/hlsenc.c | 2 +- >> 1 file

Re: [FFmpeg-devel] [PATCH] lavu/libm: add copysign hack

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 8:06 AM, Ganesh Ajjanagadde wrote: > On Sat, Dec 19, 2015 at 6:26 AM, Ronald S. Bultje wrote: >> Hi, >> >> On Fri, Dec 18, 2015 at 3:47 PM, Ganesh Ajjanagadde >> wrote: >>> >>> On Fri, Dec 18, 2015 at

Re: [FFmpeg-devel] [PATCH 1/3] mlvdec: check that index_entries exist

2015-12-19 Thread Michael Niedermayer
On Sat, Dec 19, 2015 at 11:47:54PM +0100, Andreas Cadhalpun wrote: > This fixes NULL pointer dereferencing. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/mlvdec.c | 5 + > 1 file changed, 5 insertions(+) iam not maintainer of this but probably

Re: [FFmpeg-devel] [PATCH] avcodec/s302menc: set supported channel layouts by codec

2015-12-19 Thread Michael Niedermayer
On Sat, Dec 19, 2015 at 09:35:19PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/s302menc.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavcodec/s302menc.c b/libavcodec/s302menc.c > index fbaa845..3706eba 100644 > ---

Re: [FFmpeg-devel] [PATCH] vaapi: Add VP9 hwaccell support

2015-12-19 Thread Ronald S. Bultje
Hi, On Sat, Dec 19, 2015 at 5:43 PM, Timo Rothenpieler wrote: > Signed-off-by: Timo Rothenpieler > --- > Changelog | 1 + > configure | 3 + > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 1 + >

Re: [FFmpeg-devel] [PATCH] vaapi: Add VP9 hwaccell support

2015-12-19 Thread philipl
On 20.12.2015 06:43, Timo Rothenpieler wrote: Signed-off-by: Timo Rothenpieler --- Changelog | 1 + configure | 3 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/vaapi_vp9.c | 168

Re: [FFmpeg-devel] [PATCH 2/3] mlvdec: validate bits_per_coded_sample

2015-12-19 Thread Michael Niedermayer
On Sat, Dec 19, 2015 at 11:49:02PM +0100, Andreas Cadhalpun wrote: > A negative bits_per_coded_sample doesn't make sense. > If it is too large, the size calculation for av_get_packet overflows, > resulting in allocation of a too small buffer. > > Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] [PATCH] lavu/libm: add erf hack

2015-12-19 Thread James Almer
On 12/19/2015 11:34 PM, Ganesh Ajjanagadde wrote: > +/** > + * erf function > + * Algorithm taken from the Boost project, source: > + * http://www.boost.org/doc/libs/1_46_1/boost/math/special_functions/erf.hpp > + * Use, modification and distribution are subject to the > + * Boost Software

Re: [FFmpeg-devel] [PATCH] lavu/libm: add erf hack

2015-12-19 Thread James Almer
On 12/19/2015 11:34 PM, Ganesh Ajjanagadde wrote: > +/* handle the nan case, but don't use isnan for max portability */ > +else if (z != z) > +return z; Didn't check, but this sounds like it would probably trigger warnings with -Wtautological-compare (GCC 6). That aside, libm.h

Re: [FFmpeg-devel] [PATCH] lavu/libm: add erf hack

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 9:58 PM, James Almer wrote: > On 12/19/2015 11:34 PM, Ganesh Ajjanagadde wrote: >> +/* handle the nan case, but don't use isnan for max portability */ >> +else if (z != z) >> +return z; > > Didn't check, but this sounds like it would

Re: [FFmpeg-devel] [PATCH] lavu/libm: add erf hack

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 10:40 PM, Ganesh Ajjanagadde wrote: > On Sat, Dec 19, 2015 at 9:58 PM, James Almer wrote: >> On 12/19/2015 11:34 PM, Ganesh Ajjanagadde wrote: >>> +/* handle the nan case, but don't use isnan for max portability */ >>> +else if

Re: [FFmpeg-devel] [PATCH 2/3] mlvdec: validate bits_per_coded_sample

2015-12-19 Thread Peter Ross
On Sat, Dec 19, 2015 at 11:49:02PM +0100, Andreas Cadhalpun wrote: > A negative bits_per_coded_sample doesn't make sense. > If it is too large, the size calculation for av_get_packet overflows, > resulting in allocation of a too small buffer. > > Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] Vertical bands with RT21 (Intel Real TimeVideo2.1) codec

2015-12-19 Thread Piotr Bandurski
> And ir21.dll ? http://www.moviecodec.com/download-video-codecs/indeo-2-319598me-30/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] swscale/arm/yuv2rgb: add ff_yuv420p_to_{argb, rgba, abgr, bgra}_neon_{16, 32}

2015-12-19 Thread Matthieu Bouron
On Sat, Dec 19, 2015 at 03:24:17AM +0100, Michael Niedermayer wrote: > On Fri, Dec 18, 2015 at 04:33:37PM +0100, Matthieu Bouron wrote: > > On Fri, Dec 18, 2015 at 3:59 PM, Matthieu Bouron > > wrote: > > > > > From: Matthieu Bouron > > >

Re: [FFmpeg-devel] [PATCH 05/12] lavfi/vsrc_mandelbrot: replace round by lrint

2015-12-19 Thread Michael Niedermayer
On Fri, Dec 18, 2015 at 09:45:31PM -0800, Ganesh Ajjanagadde wrote: > lrint is at least as fast, and is more accurate. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavfilter/vsrc_mandelbrot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] --

Re: [FFmpeg-devel] [PATCH 2/2] lavc/aacsbr: sbr_dequant optimization

2015-12-19 Thread Andreas Cadhalpun
On 18.12.2015 16:52, Ganesh Ajjanagadde wrote: > On Tue, Dec 15, 2015 at 9:53 PM, Ganesh Ajjanagadde > wrote: >> This uses ff_exp2fi to get a speedup (~ 6x). >> >> sample benchmark (Haswell, GNU/Linux): >> old: >> 19102 decicycles in sbr_dequant,1023 runs, 1

Re: [FFmpeg-devel] [PATCH] nutdec: reject negative sm_size

2015-12-19 Thread Michael Niedermayer
On Sat, Dec 19, 2015 at 12:19:44PM +0100, Andreas Cadhalpun wrote: > On 19.12.2015 01:51, Michael Niedermayer wrote: > > On Fri, Dec 18, 2015 at 05:22:31PM +0100, Andreas Cadhalpun wrote: > >> If it is negative, it makes size larger than the size of the packet > >> buffer, causing invalid writes

Re: [FFmpeg-devel] [PATCH] Revert "Merge commit '741b494fa8cd28a7d096349bac183893c236e3f9'"

2015-12-19 Thread Michael Niedermayer
On Thu, Dec 17, 2015 at 02:46:40PM +0100, Hendrik Leppkes wrote: > On Thu, Dec 17, 2015 at 2:06 PM, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > This fixes a regression of the sample from Ticket 2371 > > > > This reverts commit

Re: [FFmpeg-devel] [PATCH 1/2] swscale/arm/yuv2rgb: simplify process_16px_* macro call

2015-12-19 Thread Matthieu Bouron
On Tue, Dec 15, 2015 at 10:40:13PM +0100, Michael Niedermayer wrote: > On Tue, Dec 15, 2015 at 05:46:08PM +0100, Matthieu Bouron wrote: > > From: Matthieu Bouron > > > > --- > > libswscale/arm/yuv2rgb_neon.S | 8 +--- > > 1 file changed, 1 insertion(+), 7

Re: [FFmpeg-devel] [libav-devel] [PATCH] xwddec: prevent overflow of lsize * avctx->height

2015-12-19 Thread Andreas Cadhalpun
On 19.12.2015 01:32, Michael Niedermayer wrote: > On Fri, Dec 18, 2015 at 08:13:06PM +0100, Andreas Cadhalpun wrote: >> xwddec.c |6 ++ >> 1 file changed, 6 insertions(+) >> 0be27d89a669445b523bfdac99884065e3581f3c >> 0001-xwddec-prevent-overflow-of-lsize-avctx-height.patch >> From

Re: [FFmpeg-devel] [PATCH] nutdec: reject negative sm_size

2015-12-19 Thread Andreas Cadhalpun
On 19.12.2015 01:51, Michael Niedermayer wrote: > On Fri, Dec 18, 2015 at 05:22:31PM +0100, Andreas Cadhalpun wrote: >> If it is negative, it makes size larger than the size of the packet >> buffer, causing invalid writes in avio_read. >> >> Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] [libav-devel] [PATCH] nutdec: only copy the header if it exists

2015-12-19 Thread Andreas Cadhalpun
On 18.12.2015 23:11, Luca Barbato wrote: > On 18/12/15 20:12, Andreas Cadhalpun wrote: >> On 18.12.2015 20:06, Luca Barbato wrote: >>> On 18/12/15 19:05, Andreas Cadhalpun wrote: On 18.12.2015 18:53, Luca Barbato wrote: > On 18/12/15 17:24, Andreas Cadhalpun wrote: >> Fixes runtime

Re: [FFmpeg-devel] [PATCH 2/2] swscale/arm/yuv2rgb: add ff_yuv420p_to_{argb, rgba, abgr, bgra}_neon_{16, 32}

2015-12-19 Thread Michael Niedermayer
On Sat, Dec 19, 2015 at 10:56:26AM +0100, Matthieu Bouron wrote: > On Sat, Dec 19, 2015 at 03:24:17AM +0100, Michael Niedermayer wrote: > > On Fri, Dec 18, 2015 at 04:33:37PM +0100, Matthieu Bouron wrote: > > > On Fri, Dec 18, 2015 at 3:59 PM, Matthieu Bouron > > > > >

Re: [FFmpeg-devel] [PATCH 3/3] rawdec: only exempt BIT0 with need_copy from buffer sanity check

2015-12-19 Thread Michael Niedermayer
On Sat, Dec 19, 2015 at 11:49:14PM +0100, Andreas Cadhalpun wrote: > Otherwise the too samll buffer is directly used in the frame, causing > segmentation faults, when trying to use the frame. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/rawdec.c | 2

Re: [FFmpeg-devel] [PATCH 3/3] rawdec: only exempt BIT0 with need_copy from buffer sanity check

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 2:49 PM, Andreas Cadhalpun wrote: > Otherwise the too samll buffer is directly used in the frame, causing samll-> small sorry, can't review further. [...] ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] lavu/libm: add erf hack

2015-12-19 Thread Ganesh Ajjanagadde
Source code is from Boost: http://www.boost.org/doc/libs/1_46_1/boost/math/special_functions/erf.hpp with appropriate modifications for FFmpeg. Tested on interval -6 to 6 (beyond which it saturates), +/-NAN, +/-INFINITY under -fsanitize=undefined on clang to test for possible undefined behavior.

Re: [FFmpeg-devel] [PATCH] lavu/libm: add erf hack

2015-12-19 Thread Ganesh Ajjanagadde
On Sat, Dec 19, 2015 at 7:06 PM, James Almer wrote: > On 12/19/2015 11:34 PM, Ganesh Ajjanagadde wrote: >> +/** >> + * erf function >> + * Algorithm taken from the Boost project, source: >> + * http://www.boost.org/doc/libs/1_46_1/boost/math/special_functions/erf.hpp >> + *

Re: [FFmpeg-devel] [libav-devel] [PATCH] xwddec: prevent overflow of lsize * avctx->height

2015-12-19 Thread Michael Niedermayer
On Sat, Dec 19, 2015 at 12:17:42PM +0100, Andreas Cadhalpun wrote: > On 19.12.2015 01:32, Michael Niedermayer wrote: > > On Fri, Dec 18, 2015 at 08:13:06PM +0100, Andreas Cadhalpun wrote: > >> xwddec.c |6 ++ > >> 1 file changed, 6 insertions(+) > >>

Re: [FFmpeg-devel] [PATCH] nutdec: reject negative sm_size

2015-12-19 Thread Andreas Cadhalpun
On 19.12.2015 13:58, Michael Niedermayer wrote: > On Sat, Dec 19, 2015 at 12:19:44PM +0100, Andreas Cadhalpun wrote: >> On 19.12.2015 01:51, Michael Niedermayer wrote: >>> On Fri, Dec 18, 2015 at 05:22:31PM +0100, Andreas Cadhalpun wrote: If it is negative, it makes size larger than the size

Re: [FFmpeg-devel] [libav-devel] [PATCH] xwddec: prevent overflow of lsize * avctx->height

2015-12-19 Thread Andreas Cadhalpun
On 19.12.2015 14:23, Michael Niedermayer wrote: > On Sat, Dec 19, 2015 at 12:17:42PM +0100, Andreas Cadhalpun wrote: >> On 19.12.2015 01:32, Michael Niedermayer wrote: >>> On Fri, Dec 18, 2015 at 08:13:06PM +0100, Andreas Cadhalpun wrote: xwddec.c |6 ++ 1 file changed, 6

Re: [FFmpeg-devel] [PATCH] ffplay: remove existing AVPicture usage

2015-12-19 Thread Marton Balint
On Fri, 18 Dec 2015, Paul B Mahol wrote: On 12/18/15, Marton Balint wrote: It is deprecated. Signed-off-by: Marton Balint --- ffplay.c | 51 +++ 1 file changed, 27 insertions(+), 24 deletions(-) lgtm

Re: [FFmpeg-devel] [PATCH] lavu/libm: add copysign hack

2015-12-19 Thread Ronald S. Bultje
Hi, On Fri, Dec 18, 2015 at 3:47 PM, Ganesh Ajjanagadde wrote: > On Fri, Dec 18, 2015 at 12:41 PM, Ronald S. Bultje > wrote: > > Hi, > > > > On Fri, Dec 18, 2015 at 2:18 PM, Ganesh Ajjanagadde < > gajjanaga...@gmail.com> > > wrote: > >> > >> For

Re: [FFmpeg-devel] [PATCH] nutdec: reject negative sm_size

2015-12-19 Thread Michael Niedermayer
On Sat, Dec 19, 2015 at 02:25:42PM +0100, Andreas Cadhalpun wrote: > On 19.12.2015 13:58, Michael Niedermayer wrote: > > On Sat, Dec 19, 2015 at 12:19:44PM +0100, Andreas Cadhalpun wrote: > >> On 19.12.2015 01:51, Michael Niedermayer wrote: > >>> On Fri, Dec 18, 2015 at 05:22:31PM +0100, Andreas