Re: [FFmpeg-devel] [PATCH 1/2] opus_pvq: add resynth support and band encoding cost function

2017-04-14 Thread Carl Eugen Hoyos
2017-04-15 2:35 GMT+02:00 wm4 : > Legally, all these copyright headers are meaningless, as long as the > license is correct. You are joking, right? > If they weren't, FFmpeg would be in trouble for changing the copyright > headers of all files added by Libav from "Libav"

Re: [FFmpeg-devel] [PATCH]lavc/opus_pvg: Add missing copyright notices

2017-04-14 Thread Carl Eugen Hoyos
2017-04-15 2:52 GMT+02:00 Rostislav Pehlivanov : > On 14 April 2017 at 23:35, Carl Eugen Hoyos wrote: > >> Hi! >> >> As analyzed by Rostislav. >> >> Please comment, Carl Eugen > LGTM, apply and get this thread over with Done. Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH] Enhanced configure to improve compiler options associated with debugging with Visual C++ (MSVC)

2017-04-14 Thread Aaron Levinson
On 4/13/2017 5:03 PM, Aaron Levinson wrote: > From 558b957eb85a669899750b2e150eba7cdee8dcd9 Mon Sep 17 00:00:00 2001 > From: Aaron Levinson > Date: Thu, 13 Apr 2017 16:46:59 -0700 > Subject: [PATCH] Enhanced configure to improve compiler options associated > with debugging

Re: [FFmpeg-devel] [PATCH] Enhanced require_pkg_config() in configure to fallback to require() if pkg-config is missing

2017-04-14 Thread Aaron Levinson
On 4/14/2017 6:04 PM, James Almer wrote: On 4/13/2017 9:56 PM, Aaron Levinson wrote: From 48f7daba16e0fcdb83d9abd254800c7b9f4ab684 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Thu, 13 Apr 2017 17:30:47 -0700 Subject: [PATCH] Enhanced require_pkg_config() in

[FFmpeg-devel] [PATCH 5/6] avcodec/h264: add avx 8-bit h264_idct_dc_add

2017-04-14 Thread James Darnley
Haswell: - 1.02x faster (405±0.7 vs. 397±0.8 decicycles) compared with mmxext Skylake-U: - 1.06x faster (498±1.8 vs. 470±1.3 decicycles) compared with mmxext --- libavcodec/x86/h264_idct.asm | 20 libavcodec/x86/h264dsp_init.c | 2 ++ 2 files changed, 22 insertions(+)

[FFmpeg-devel] [PATCH 2/6] avcodec/h264: change some labels to be macro-local

2017-04-14 Thread James Darnley
The labels get stripped leading to (slightly) nicer disassembly from objdump. --- libavcodec/x86/h264_idct.asm | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavcodec/x86/h264_idct.asm b/libavcodec/x86/h264_idct.asm index 878ff02..dde40e9 100644

[FFmpeg-devel] [PATCH 6/6] avcodec/h264: add sse2 versions of previous idct functions

2017-04-14 Thread James Darnley
Kaby Lake Pentium: - ff_h264_idct_add_8_sse2:~1.18x faster than mmxext - ff_h264_idct_dc_add_8_sse2: ~1.07x faster than mmxext --- libavcodec/x86/h264_idct.asm | 11 +-- libavcodec/x86/h264dsp_init.c | 5 + 2 files changed, 14 insertions(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH 4/6] avcodec/h264: add avx 8-bit h264_idct_add

2017-04-14 Thread James Darnley
Haswell: - 1.11x faster (522±0.4 vs. 469±1.8 decicycles) compared with mmxext Skylake-U: - 1.21x faster (671±5.5 vs. 555±1.4 decicycles) compared with mmxext --- libavcodec/x86/h264_idct.asm | 33 - libavcodec/x86/h264dsp_init.c | 3 +++ 2 files changed, 35

[FFmpeg-devel] [PATCH 3/6] avcodec/h264: use some 3 operand forms

2017-04-14 Thread James Darnley
--- libavcodec/x86/h264_idct.asm | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/libavcodec/x86/h264_idct.asm b/libavcodec/x86/h264_idct.asm index dde40e9..bc4dce4 100644 --- a/libavcodec/x86/h264_idct.asm +++ b/libavcodec/x86/h264_idct.asm @@ -87,10

[FFmpeg-devel] [PATCH 1/6] avcodec/h264: change RETs into REP_RETs where appropriate

2017-04-14 Thread James Darnley
--- libavcodec/x86/h264_idct.asm | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/x86/h264_idct.asm b/libavcodec/x86/h264_idct.asm index c36fea5..878ff02 100644 --- a/libavcodec/x86/h264_idct.asm +++ b/libavcodec/x86/h264_idct.asm @@ -695,7 +695,7 @@

[FFmpeg-devel] [PATCH 0/6 v3] AVX functions for 8-bit H.264 IDCT

2017-04-14 Thread James Darnley
Changes: - Added sse2 functions - Fixed an incorrect xmm register count I did not make the change suggested by Gramner about TAIL_CALL and I did leave the TODOs there. If there are no further objections I will push by Monday at the latest. I want to get this out the door. James Darnley (6):

[FFmpeg-devel] Added require fallback for libmfx in the case that pkg-config cannot find libmfx

2017-04-14 Thread Aaron Levinson
From e0c73c054add0137901d0bf7a7893e42e7e566c8 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Fri, 14 Apr 2017 18:38:37 -0700 Subject: [PATCH] Added require fallback for libmfx in the case that pkg-config cannot find libmfx Purpose: Added require fallback for libmfx in

Re: [FFmpeg-devel] [PATCH] web/index: add news entry for release 3.3

2017-04-14 Thread Michael Niedermayer
On Thu, Apr 13, 2017 at 09:00:33PM +0100, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > src/index | 53 + > 1 file changed, 53 insertions(+) > > diff --git a/src/index b/src/index > index

[FFmpeg-devel] [PATCH] Enhanced configure and Makefile to copy .pdb files to bindir for MSVC builds for make install

2017-04-14 Thread Aaron Levinson
From 1059473c449c3079f03461bb42c2d3cc21d1b2c1 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Fri, 14 Apr 2017 18:14:21 -0700 Subject: [PATCH] Enhanced configure and Makefile to copy .pdb files to bindir for MSVC builds for make install Purpose: Enhanced configure and

Re: [FFmpeg-devel] [PATCH] Enhanced require_pkg_config() in configure to fallback to require() if pkg-config is missing

2017-04-14 Thread James Almer
On 4/13/2017 9:56 PM, Aaron Levinson wrote: > From 48f7daba16e0fcdb83d9abd254800c7b9f4ab684 Mon Sep 17 00:00:00 2001 > From: Aaron Levinson > Date: Thu, 13 Apr 2017 17:30:47 -0700 > Subject: [PATCH] Enhanced require_pkg_config() in configure to fallback to > require() if

Re: [FFmpeg-devel] [PATCH]lavc/opus_pvg: Add missing copyright notices

2017-04-14 Thread Rostislav Pehlivanov
On 14 April 2017 at 23:35, Carl Eugen Hoyos wrote: > Hi! > > As analyzed by Rostislav. > > Please comment, Carl Eugen > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >

Re: [FFmpeg-devel] [PATCH]lavc/opus_pvg: Add missing copyright notices

2017-04-14 Thread Rostislav Pehlivanov
On 15 April 2017 at 01:52, Rostislav Pehlivanov wrote: > > > On 14 April 2017 at 23:35, Carl Eugen Hoyos wrote: > >> Hi! >> >> As analyzed by Rostislav. >> >> Please comment, Carl Eugen >> >> ___ >> ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] opus_pvq: add resynth support and band encoding cost function

2017-04-14 Thread wm4
On Sat, 15 Apr 2017 03:14:12 +0300 Ivan Kalvachev wrote: > On 4/15/17, wm4 wrote: > > On Sat, 15 Apr 2017 00:28:19 +0200 > > Carl Eugen Hoyos wrote: > > > >> 2017-04-14 23:27 GMT+02:00 Clément Bœsch : > >> > On

Re: [FFmpeg-devel] [PATCH 1/2] opus_pvq: add resynth support and band encoding cost function

2017-04-14 Thread Ivan Kalvachev
On 4/15/17, wm4 wrote: > On Sat, 15 Apr 2017 00:28:19 +0200 > Carl Eugen Hoyos wrote: > >> 2017-04-14 23:27 GMT+02:00 Clément Bœsch : >> > On Fri, Apr 14, 2017 at 02:30:28PM +0200, Carl Eugen Hoyos wrote: >> > [...] >> >> We know that the

Re: [FFmpeg-devel] [PATCH] web/index: add news entry for release 3.3

2017-04-14 Thread Michael Niedermayer
On Fri, Apr 14, 2017 at 08:48:55PM -0300, James Almer wrote: > On 4/14/2017 8:32 PM, Michael Niedermayer wrote: > > On Fri, Apr 14, 2017 at 04:07:41PM -0400, Ronald S. Bultje wrote: > >> Hi, > >> > >> On Fri, Apr 14, 2017 at 4:24 AM, Michael Niedermayer > >> >>> wrote: >

Re: [FFmpeg-devel] [PATCH] Enhanced require_pkg_config() in configure to fallback to require() if pkg-config is missing

2017-04-14 Thread Aaron Levinson
On 4/14/2017 1:09 AM, Hendrik Leppkes wrote: On Fri, Apr 14, 2017 at 2:56 AM, Aaron Levinson wrote: From 48f7daba16e0fcdb83d9abd254800c7b9f4ab684 Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Thu, 13 Apr 2017 17:30:47 -0700 Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH 1/2] opus_pvq: add resynth support and band encoding cost function

2017-04-14 Thread wm4
On Sat, 15 Apr 2017 00:28:19 +0200 Carl Eugen Hoyos wrote: > 2017-04-14 23:27 GMT+02:00 Clément Bœsch : > > On Fri, Apr 14, 2017 at 02:30:28PM +0200, Carl Eugen Hoyos wrote: > > [...] > >> We know that the avconv developers are violating the > >> copyright of

Re: [FFmpeg-devel] [PATCH 1/2] opus_pvq: add resynth support and band encoding cost function

2017-04-14 Thread wm4
On Sat, 15 Apr 2017 00:29:44 +0200 Carl Eugen Hoyos wrote: > 2017-04-14 14:50 GMT+02:00 wm4 : > > > especially since your dictatorship over the bug tracker makes you > > This reminds me: Who is supposed to fix the regressions > that you create and

Re: [FFmpeg-devel] [PATCH] web/index: add news entry for release 3.3

2017-04-14 Thread Michael Niedermayer
On Fri, Apr 14, 2017 at 04:07:41PM -0400, Ronald S. Bultje wrote: > Hi, > > On Fri, Apr 14, 2017 at 4:24 AM, Michael Niedermayer > wrote: > > > On Thu, Apr 13, 2017 at 09:00:33PM +0100, Rostislav Pehlivanov wrote: > > > +We strongly recommend users, distributors,

Re: [FFmpeg-devel] [PATCH 1/2] opus_pvq: add resynth support and band encoding cost function

2017-04-14 Thread Carl Eugen Hoyos
2017-04-14 18:18 GMT+02:00 Rostislav Pehlivanov : > On 14 April 2017 at 13:34, Carl Eugen Hoyos wrote: > >> 2017-04-14 14:30 GMT+02:00 Carl Eugen Hoyos : >> > 2017-04-14 13:11 GMT+02:00 Rostislav Pehlivanov : >> >>

Re: [FFmpeg-devel] [PATCH 1/2] opus_pvq: add resynth support and band encoding cost function

2017-04-14 Thread Carl Eugen Hoyos
2017-04-14 23:27 GMT+02:00 Clément Bœsch : > On Fri, Apr 14, 2017 at 02:30:28PM +0200, Carl Eugen Hoyos wrote: > [...] >> We know that the avconv developers are violating the >> copyright of many people, we fix that in the FFmpeg code as >> soon as we are aware of it, there are many

[FFmpeg-devel] [PATCH]lavc/opus_pvg: Add missing copyright notices

2017-04-14 Thread Carl Eugen Hoyos
Hi! As analyzed by Rostislav. Please comment, Carl Eugen From 66e02de36c53cc373e7ee4eeb8d134fa28d0641f Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 15 Apr 2017 00:32:43 +0200 Subject: [PATCH] lavc/opus_pvq: Add missing copyright notices from libopus. The file is

Re: [FFmpeg-devel] [PATCH 1/2] opus_pvq: add resynth support and band encoding cost function

2017-04-14 Thread Carl Eugen Hoyos
2017-04-14 14:50 GMT+02:00 wm4 : > especially since your dictatorship over the bug tracker makes you This reminds me: Who is supposed to fix the regressions that you create and that users report on trac? Please try to refrain from such accusations. Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH 1/2] opus_pvq: add resynth support and band encoding cost function

2017-04-14 Thread Clément Bœsch
On Fri, Apr 14, 2017 at 02:30:28PM +0200, Carl Eugen Hoyos wrote: [...] > We know that the avconv developers are violating the > copyright of many people, we fix that in the FFmpeg code as > soon as we are aware of it, there are many examples in gitlog. This is a serious accusation, what are you

Re: [FFmpeg-devel] [PATCH] web/index: add news entry for release 3.3

2017-04-14 Thread Ronald S. Bultje
Hi, On Fri, Apr 14, 2017 at 4:24 AM, Michael Niedermayer wrote: > On Thu, Apr 13, 2017 at 09:00:33PM +0100, Rostislav Pehlivanov wrote: > > +We strongly recommend users, distributors, and system integrators to > > +upgrade unless they use current git master. > >

[FFmpeg-devel] [PATCH 1/2] opus_pvq: add resynth support and band encoding cost function

2017-04-14 Thread Compn
On Fri, 14 Apr 2017 14:30:28 +0200 Carl Eugen Hoyos wrote: i understand you want to fix the copyright header of the file, that is a good idea. >We know that the avconv developers are violating the >copyright of many people, we fix that in the FFmpeg code as >soon as we are aware of it, there

Re: [FFmpeg-devel] [PATCH 1/2] opus_pvq: add resynth support and band encoding cost function

2017-04-14 Thread Rostislav Pehlivanov
On 14 April 2017 at 13:34, Carl Eugen Hoyos wrote: > 2017-04-14 14:30 GMT+02:00 Carl Eugen Hoyos : > > 2017-04-14 13:11 GMT+02:00 Rostislav Pehlivanov : > > >> Point is, I have used only code from libavcodec/opus_pvq.c from > >> the

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: add hls encrypt options

2017-04-14 Thread Steven Liu
2017-04-06 23:02 GMT+08:00 Steven Liu : > refer to: > https://git.libav.org/?p=libav.git;a=commitdiff;h= > 0a4b9d0ccd10b3c39105f99bd320f696f69a75a2 > add hls encrypt options looks like libav's libavformat/hlsenc.c > > Signed-off-by: Steven Liu > --- >

Re: [FFmpeg-devel] [PATCH] ffserver: fix memory leaks pointed out by valgrind.

2017-04-14 Thread wm4
On Fri, 14 Apr 2017 15:00:05 +0200 Zalewa wrote: > From 29d36664c55b3a7078ebe57f8642e1d7dc389f16 Mon Sep 17 00:00:00 2001 > From: Zalewa > Date: Fri, 14 Apr 2017 09:26:18 +0200 > Subject: [PATCH] ffserver: fix memory leaks pointed out by valgrind. > >

[FFmpeg-devel] [PATCH] ffserver: fix memory leaks pointed out by valgrind.

2017-04-14 Thread Zalewa
Many memory leaks were created upon HTTP client disconnect. Many clients connecting & disconnecting rapidly could very quickly create leaks going into Gigabytes of memory. From 29d36664c55b3a7078ebe57f8642e1d7dc389f16 Mon Sep 17 00:00:00 2001 From: Zalewa Date: Fri, 14 Apr

Re: [FFmpeg-devel] [PATCH 1/2] opus_pvq: add resynth support and band encoding cost function

2017-04-14 Thread wm4
On Fri, 14 Apr 2017 14:30:28 +0200 Carl Eugen Hoyos wrote: > We know that the avconv developers are violating the > copyright of many people, we fix that in the FFmpeg code as > soon as we are aware of it, there are many examples in gitlog. > I don't see how this case would

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/h264: change RETs into REP_RETs where appropriate

2017-04-14 Thread Henrik Gramner
On Fri, Apr 14, 2017 at 1:19 PM, James Darnley wrote: > Do you want me to change this patch to add that? Either the same patch or a different one, pick whichever is most convenient for you. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/2] opus_pvq: add resynth support and band encoding cost function

2017-04-14 Thread Carl Eugen Hoyos
2017-04-14 14:30 GMT+02:00 Carl Eugen Hoyos : > 2017-04-14 13:11 GMT+02:00 Rostislav Pehlivanov : >> Point is, I have used only code from libavcodec/opus_pvq.c from >> the FFmpeg project. I don't have to do anything as all credit has >> been given where

Re: [FFmpeg-devel] [PATCH 1/2] opus_pvq: add resynth support and band encoding cost function

2017-04-14 Thread Carl Eugen Hoyos
2017-04-14 13:11 GMT+02:00 Rostislav Pehlivanov : > On 14 April 2017 at 05:50, Carl Eugen Hoyos wrote: > >> 2017-04-13 9:51 GMT+02:00 Rostislav Pehlivanov : >> > On 13 April 2017 at 07:13, Carl Eugen Hoyos wrote:

Re: [FFmpeg-devel] [PATCH] Ignore expired cookies

2017-04-14 Thread Micah Galizia
On 2017-04-08 09:05 PM, Micah Galizia wrote: Signed-off-by: Micah Galizia Hello, Has anyone had a chance to review this? I was hoping to get the rework (if needed) done this weekend. Thanks, ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/h264: add avx 8-bit h264_idct_add

2017-04-14 Thread James Darnley
On 2017-04-06 18:06, James Almer wrote: > Your numbers are really confusing. Could you post the actual numbers for > each function instead of doing comparisons? These figures are the actual numbers! Using the figures from Haswell above: > ff_h264_idct_add_8_mmx = 52 cycles >

Re: [FFmpeg-devel] [PATCH] vaapi_encode: Fix the vaapi h264 encoder VBR/CBR metadata setting error.

2017-04-14 Thread Mark Thompson
On 14/04/17 02:01, Jun Zhao wrote: > On 2017/4/13 22:05, Mark Thompson wrote: >> On 13/04/17 13:34, Jun Zhao wrote: >>> From 1fa48b45fe962d8c342d158d9c16ce24139ffd84 Mon Sep 17 00:00:00 2001 >>> From: Jun Zhao >>> Date: Thu, 13 Apr 2017 20:07:10 +0800 >>> Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/h264: change RETs into REP_RETs where appropriate

2017-04-14 Thread James Darnley
On 2017-04-05 22:26, Henrik Gramner wrote: > On Wed, Apr 5, 2017 at 3:53 AM, James Darnley wrote: >> call h264_idct_add8_mmx_plane >> -RET >> +RET ; TODO: check rep ret after a function call > > call followed by RET should be replaced by the TAIL_CALL macro

Re: [FFmpeg-devel] [PATCH 1/2] opus_pvq: add resynth support and band encoding cost function

2017-04-14 Thread Rostislav Pehlivanov
On 14 April 2017 at 05:50, Carl Eugen Hoyos wrote: > 2017-04-13 9:51 GMT+02:00 Rostislav Pehlivanov : > > On 13 April 2017 at 07:13, Carl Eugen Hoyos wrote: > > > >> 2017-04-13 4:02 GMT+02:00 Rostislav Pehlivanov

Re: [FFmpeg-devel] [PATCH] web/index: add news entry for release 3.3

2017-04-14 Thread Michael Niedermayer
On Thu, Apr 13, 2017 at 09:00:33PM +0100, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > src/index | 53 + > 1 file changed, 53 insertions(+) > > diff --git a/src/index b/src/index > index

Re: [FFmpeg-devel] [PATCH] Enhanced require_pkg_config() in configure to fallback to require() if pkg-config is missing

2017-04-14 Thread Hendrik Leppkes
On Fri, Apr 14, 2017 at 2:56 AM, Aaron Levinson wrote: > From 48f7daba16e0fcdb83d9abd254800c7b9f4ab684 Mon Sep 17 00:00:00 2001 > From: Aaron Levinson > Date: Thu, 13 Apr 2017 17:30:47 -0700 > Subject: [PATCH] Enhanced require_pkg_config() in configure

[FFmpeg-devel] [PATCH] Fixed problems with QuickSync (QSV) interlaced video encoding

2017-04-14 Thread Aaron Levinson
From da3899b24ad89b4788a3b8191d53b26f5eec328e Mon Sep 17 00:00:00 2001 From: Aaron Levinson Date: Thu, 13 Apr 2017 23:12:30 -0700 Subject: [PATCH] Fixed problems with QuickSync (QSV) interlaced video encoding Purpose: Fixed problems with QuickSync (QSV) interlaced video