Re: [FFmpeg-devel] [PATCH] libvpxenc: allow aq-mode 4 (equator360)

On Thu, Apr 20, 2017 at 1:42 PM, Ronald S. Bultje wrote: > Hi, > > On Thu, Apr 20, 2017 at 2:42 PM, James Zern > wrote: > >> On Thu, Apr 13, 2017 at 6:44 PM, James Zern wrote: >> > this was added in 1.6.0 >> > >> >

[FFmpeg-devel] [PATCH v3 1/2] avfilter/interlace: change lowpass_line function prototype

Hi, this patch set 1) changes the lowpass_line function prototype in vf_interlace and vf_tinterlace as suggested by James Almer. 2) adds a complex (-1 2 6 2 -1) vertical low-pass filter to vf_interlace and vf_tinterlace. This one slightly less reduces interlace 'twitter' but better retains detail

[FFmpeg-devel] [PATCH v3 2/2] avfilter/interlace: add complex vertical low-pass filter

Patch attached... 0002-avfilter-interlace-add-complex-vertical-low-pass-fil.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libvpxenc: allow aq-mode 4 (equator360)

Hi, On Thu, Apr 20, 2017 at 2:42 PM, James Zern wrote: > On Thu, Apr 13, 2017 at 6:44 PM, James Zern wrote: > > this was added in 1.6.0 > > > > Signed-off-by: James Zern > > --- > > doc/encoders.texi | 2 +- > >

Re: [FFmpeg-devel] fate/exr : fix pix_fmt for pxr24 half/uint32

2017-04-02 23:00 GMT+02:00 Martin Vignali : > Hello, > > In attach a patch to fix a fate test, the sample doesn't have alpha > > Martin > ping ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter/avf_avectorscope: Assert that format is valid

On 4/20/17, Michael Niedermayer wrote: > This should help coverity realize that src[] is inited > > Signed-off-by: Michael Niedermayer > --- > libavfilter/avf_avectorscope.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [FFmpeg-devel] [PATCH] libvpxenc: allow aq-mode 4 (equator360)

On Thu, Apr 13, 2017 at 6:44 PM, James Zern wrote: > this was added in 1.6.0 > > Signed-off-by: James Zern > --- > doc/encoders.texi | 2 +- > libavcodec/libvpxenc.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > I'll submit this soon if

[FFmpeg-devel] [PATCH] avfilter/avf_avectorscope: Assert that format is valid

This should help coverity realize that src[] is inited Signed-off-by: Michael Niedermayer --- libavfilter/avf_avectorscope.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/avf_avectorscope.c b/libavfilter/avf_avectorscope.c index 3063283efb..c6e278d30d

Re: [FFmpeg-devel] [PATCH] [UPDATE] HLS, add option to skip down streams,

On 18/04/2017 17:00, Amine kabab wrote: > option to skip down streams in HLS > >From 5079f9b7114589626a4c9fff0fbb8f6e0d2f4fd9 Mon Sep 17 00:00:00 2001 From: amine kabab Date: Thu, 20 Apr 2017 15:59:42 + Subject: [PATCH] HLS skip down streams --- libavformat/hls.c |

Re: [FFmpeg-devel] [PATCH 1/2] webmdashenc: Require the 'adaptation_sets' option to be ste

On 4/20/2017 4:58 PM, James Almer wrote: > EINVAL IMO, since it's an user option. AVERROR_INVALIDDATA was defined as AVERROR(EINVAL) for years, I guess I forgot it changed to something else... git blame puts it at 72af5d8a020e4dca1118b3ede67be983b33e27c5 in 2010... My memory was seriously

Re: [FFmpeg-devel] [PATCH 1/2] webmdashenc: Require the 'adaptation_sets' option to be ste

On Thu, Apr 20, 2017 at 12:58:54PM -0300, James Almer wrote: > On 4/20/2017 9:14 AM, Derek Buitenhuis wrote: > >This seems to be non-optional, and if the muxer is run without it, > >strlen() is run on NULL, causing a segfault. > > > >Signed-off-by: Derek Buitenhuis >

Re: [FFmpeg-devel] [PATCH 1/2] webmdashenc: Require the 'adaptation_sets' option to be ste

On 4/20/2017 9:14 AM, Derek Buitenhuis wrote: This seems to be non-optional, and if the muxer is run without it, strlen() is run on NULL, causing a segfault. Signed-off-by: Derek Buitenhuis --- libavformat/webmdashenc.c | 4 1 file changed, 4 insertions(+)

Re: [FFmpeg-devel] [PATCH 1/2] webmdashenc: Require the 'adaptation_sets' option to be ste

On Thu, Apr 20, 2017 at 01:14:42PM +0100, Derek Buitenhuis wrote: > This seems to be non-optional, and if the muxer is run without it, > strlen() is run on NULL, causing a segfault. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/webmdashenc.c | 4 > 1

Re: [FFmpeg-devel] [PATCH 2/2 v2] webmdashenc: Validate the 'streams' adaptation sets parameter

On Thu, Apr 20, 2017 at 04:17:44PM +0100, Derek Buitenhuis wrote: > It should not be a value larger than the number of streams we have, > or it will cause invalid reads and/or SIGSEGV. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/webmdashenc.c | 6 +- >

[FFmpeg-devel] [PATCH 2/2 v2] webmdashenc: Validate the 'streams' adaptation sets parameter

It should not be a value larger than the number of streams we have, or it will cause invalid reads and/or SIGSEGV. Signed-off-by: Derek Buitenhuis --- libavformat/webmdashenc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 2/2] webmdashenc: Validate the 'streams' adaptation sets parameter

On 4/20/2017 3:47 PM, Michael Niedermayer wrote: > breaks fate v2 sent. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest_demuxer: Fix UB in cue timestamp string code and make it actually work

On 4/20/2017 3:58 PM, Michael Niedermayer wrote: > On Thu, Apr 20, 2017 at 03:02:54PM +0100, Derek Buitenhuis wrote: >> The original author apparently never read the documentation for snprintf, >> or even tested that the output was correct. > This statement does not belong in a commit message. >

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest_demuxer: Fix UB in cue timestamp string code and make it actually work

On Thu, Apr 20, 2017 at 03:02:54PM +0100, Derek Buitenhuis wrote: > The original author apparently never read the documentation for snprintf, > or even tested that the output was correct. This statement does not belong in a commit message. Its insulting to whoever the author is and may not even

Re: [FFmpeg-devel] [PATCH 2/2] webmdashenc: Validate the 'streams' adaptation sets parameter

On Thu, Apr 20, 2017 at 01:14:43PM +0100, Derek Buitenhuis wrote: > It should not be a value larger than the number of streams we have, > or it will cause invalid reads and/or SIGSEGV. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/webmdashenc.c | 7 ++-

[FFmpeg-devel] [PATCH] webm_dash_manifest_demuxer: Fix UB in cue timestamp string code and make it actually work

The original author apparently never read the documentation for snprintf, or even tested that the output was correct. Passing overlapping memory to snprintf causes undefined behavior, and usually resulted in only the very last timestamp being written to metadata, and not a list at all.

[FFmpeg-devel] [PATCH 0/2] webmdashenc crash fixes

This whole file is sloppy... I found these on my very first mux with it, ever, by accident. Derek Buitenhuis (2): webmdashenc: Require the 'adaptation_sets' option to be ste webmdashenc: Validate the 'streams' adaptation sets parameter libavformat/webmdashenc.c | 11 ++- 1 file

[FFmpeg-devel] [PATCH 1/2] webmdashenc: Require the 'adaptation_sets' option to be ste

This seems to be non-optional, and if the muxer is run without it, strlen() is run on NULL, causing a segfault. Signed-off-by: Derek Buitenhuis --- libavformat/webmdashenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/webmdashenc.c

[FFmpeg-devel] [PATCH 2/2] webmdashenc: Validate the 'streams' adaptation sets parameter

It should not be a value larger than the number of streams we have, or it will cause invalid reads and/or SIGSEGV. Signed-off-by: Derek Buitenhuis --- libavformat/webmdashenc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git