Re: [FFmpeg-devel] [PATCH] avcodec/aacps: move checks for valid length outside the stereo_interpolate dsp function

2017-06-15 Thread James Almer
On 6/14/2017 11:33 PM, James Almer wrote: > On 6/3/2017 2:04 PM, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/aacps.c | 7 --- >> libavcodec/x86/aacpsdsp.asm | 6 -- >> 2 files changed, 4 insertions(+), 9 deletions(-) > > I'll push

[FFmpeg-devel] [PATCH] avformat/hlsenc: donnot show duplicate segment warning at byterange mode

2017-06-15 Thread Steven Liu
When the hlsenc at BYTERANGE mode, it should not show the warning message: "Duplicated segment filename detected:" Reported-by: Marco Signed-off-by: Steven Liu --- libavformat/hlsenc.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH] avcodec/x86: add an 8-bit simple IDCT function based on the x86-64 high depth functions

2017-06-15 Thread Michael Niedermayer
On Thu, Jun 15, 2017 at 05:08:33PM +0200, James Darnley wrote: > Includes add/put functions > > Rounding contributed by Ronald S. Bultje > --- > I must be stupid. I dropped the stack space change somewhere. > > libavcodec/tests/x86/dct.c | 2 + > libavcodec/x86/idctdsp_init.c| 23

Re: [FFmpeg-devel] Patch for FPE (floating point exception)

2017-06-15 Thread Michael Niedermayer
On Tue, Jun 06, 2017 at 06:41:55PM +0200, Robert Nagtegaal wrote: > Dear developers, > > Most unfortunately I found 2 bugs in ffserver.c Both are related to > floating point bugs. I wrote a patch and submitted it on git: > > https://github.com/masikh/FFmpeg/commit/50326ef568.patch > commit

[FFmpeg-devel] Why the tag “DURATION” is a necessity in Matroska files?

2017-06-15 Thread 21naown
Hello, I would like to know why the tag “DURATION” in Matroska files (.mkv) is a necessity? Even mkvmerge lets the choice to use it or not with “--enable-durations”, in addition it is written “Write durations for all blocks. This will increase file size and does not offer any additional

Re: [FFmpeg-devel] [PATCH] Update decode_simple_internal() to get the side data correctly.

2017-06-15 Thread James Almer
On 6/14/2017 9:04 PM, John Rummell wrote: > From 6418fc43b06cea4cf49e410d474ae92022c4dbd1 Mon Sep 17 00:00:00 2001 > From: John Rummell > Date: Wed, 14 Jun 2017 14:43:04 -0700 > Subject: [PATCH] Update decode_simple_internal() to get the side data > correctly. > > When

Re: [FFmpeg-devel] Patch to fix Chromium issues with ARMv8

2017-06-15 Thread Hendrik Leppkes
On Sat, Jun 3, 2017 at 12:57 AM, Amaury LeLeyzour wrote: > Hi there, > > > Here's a patch requested by Google in the context of the Chromium project. > See: > > https://bugs.chromium.org/p/chromium/issues/detail?id=686903 > > > The ARMv8 deprecates some IT block usage

[FFmpeg-devel] Patch for FPE (floating point exception)

2017-06-15 Thread Robert Nagtegaal
Dear developers, Most unfortunately I found 2 bugs in ffserver.c Both are related to floating point bugs. I wrote a patch and submitted it on git: https://github.com/masikh/FFmpeg/commit/50326ef568.patch I hope it helps! Kind regards, Robert Nagtegaal Alias: Masikh

[FFmpeg-devel] [PATCH] Update decode_simple_internal() to get the side data correctly.

2017-06-15 Thread John Rummell
From 6418fc43b06cea4cf49e410d474ae92022c4dbd1 Mon Sep 17 00:00:00 2001 From: John Rummell Date: Wed, 14 Jun 2017 14:43:04 -0700 Subject: [PATCH] Update decode_simple_internal() to get the side data correctly. When FF_API_MERGE_SD is set, the compressed side data is

Re: [FFmpeg-devel] [PATCH] Add A53 Closed Captions to MPEG header if they are available.

2017-06-15 Thread Brian Matherly
Indeed, multiple entries of the same type are really a bad idea and we basically made them impossible with stream sidedata, although maybe not with frame side data yet. We should not add API for them or encourage their use. If there is a real need for multiple of the same type, maybe the type

[FFmpeg-devel] Patch to fix Chromium issues with ARMv8

2017-06-15 Thread Amaury LeLeyzour
Hi there, Here's a patch requested by Google in the context of the Chromium project. See: https://bugs.chromium.org/p/chromium/issues/detail?id=686903 The ARMv8 deprecates some IT block usage that this patch tries to address. I've ran some regression tests (the part that works on a native

Re: [FFmpeg-devel] [PATCH] lavc: add mpeg2 decoder/hwaccel to mediacodec

2017-06-15 Thread Aman Gupta
On Fri, Jun 2, 2017 at 6:16 AM, Matthieu Bouron wrote: > Hi, > > On Fri, Jun 02, 2017 at 04:23:41AM -0400, Aman Gupta wrote: > > From: Aman Gupta > > > > Android TV and FireOS hardware supports mpeg2 hardware decoding via > MediaCodec. > > --- > >

Re: [FFmpeg-devel] [PATCH] nvenc: Make AUD optional for h264_nvenc and hevc_nvenc

2017-06-15 Thread Yogender Kumar Gupta
Yes, please try the latest driver version. Thanks Yogender > On 13-Jun-2017, at 6:47 PM, Ali KIZIL wrote: > > 2017-01-05 13:29 GMT+03:00 Yogender Gupta : > There is BUG in Nvidia NVENC when you use AUD for H264 with B-frames, >> it will return

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-06-15 Thread Paul B Mahol
On 6/15/17, Thomas Mundt wrote: > 2017-06-15 21:23 GMT+02:00 Nicolas George : > >> Le septidi 27 prairial, an CCXXV, Thomas Mundt a ecrit : >> > Hmm, before rewriting and sending this patch I asked if it would have a >> > chance to be pushed just to fix the

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-06-15 Thread Thomas Mundt
2017-06-15 21:23 GMT+02:00 Nicolas George : > Le septidi 27 prairial, an CCXXV, Thomas Mundt a écrit : > > Hmm, before rewriting and sending this patch I asked if it would have a > > chance to be pushed just to fix the ticket which is open for a very long > > time. Your answer

[FFmpeg-devel] [PATCH 3/3] avcodec/h264: Fix mix of lossless and lossy MBs decoding

2017-06-15 Thread Ronald S. Bultje
From: Anton Mitrofanov Signed-off-by: Ronald S. Bultje --- libavcodec/h264_cabac.c | 16 libavcodec/h264_cavlc.c | 16 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/libavcodec/h264_cabac.c

[FFmpeg-devel] [PATCH 2/3] avcodec/h264_mb: Fix 8x8dct in lossless for new versions of x264

2017-06-15 Thread Ronald S. Bultje
From: Anton Mitrofanov Signed-off-by: Ronald S. Bultje --- libavcodec/h264_mb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h264_mb.c b/libavcodec/h264_mb.c index 638dcba..cb9fe85 100644 --- a/libavcodec/h264_mb.c +++

[FFmpeg-devel] [PATCH 1/3] avcodec/h264_cabac: Fix CABAC+8x8dct in 4:4:4

2017-06-15 Thread Ronald S. Bultje
From: Anton Mitrofanov Use the correct ctxIdxInc calculation for coded_block_flag. Keep old behavior for old versions of x264 for backward compatibility. Signed-off-by: Ronald S. Bultje --- libavcodec/h264_cabac.c | 47

[FFmpeg-devel] [PATCH 1/2] avcodec/ffv1: Increase the maximum number of slices to 1024

2017-06-15 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/ffv1.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ffv1.h b/libavcodec/ffv1.h index c2bae1e6da..653138b070 100644 --- a/libavcodec/ffv1.h +++ b/libavcodec/ffv1.h @@ -74,7 +74,7 @@ typedef

[FFmpeg-devel] [PATCH 2/2] avcodec/ffv1enc: Try to choose slice count so that slice packet sizes are within the supported size

2017-06-15 Thread Michael Niedermayer
Fixes assertion failure Signed-off-by: Michael Niedermayer --- libavcodec/ffv1enc.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index 7f31606775..e59d540737 100644 --- a/libavcodec/ffv1enc.c

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-06-15 Thread Nicolas George
Le septidi 27 prairial, an CCXXV, Thomas Mundt a écrit : > Hmm, before rewriting and sending this patch I asked if it would have a > chance to be pushed just to fix the ticket which is open for a very long > time. Your answer gave me the assumtion that you´re okay with it. > I thought your only

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-06-15 Thread Thomas Mundt
2017-06-15 20:00 GMT+02:00 Nicolas George : > Le quintidi 25 prairial, an CCXXV, Thomas Mundt a écrit : > > Patch attached. This fixes ticket #2674. I inserted a FIXME message as a > > reminder. > > Please comment. > > I am sorry to say I do not like it. The timestamp computation

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_fps: fix duration

2017-06-15 Thread Nicolas George
Le quintidi 25 prairial, an CCXXV, Thomas Mundt a écrit : > Patch attached. This fixes ticket #2674. I inserted a FIXME message as a > reminder. > Please comment. I am sorry to say I do not like it. The timestamp computation code in vf_fps is already quite complex, and this patch is making it

Re: [FFmpeg-devel] [PATCH] ffmpeg: remove misleading and incorrect error messages

2017-06-15 Thread wm4
Those are warnings, not error messages. Fixed locally. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] ffmpeg: remove misleading and incorrect error messages

2017-06-15 Thread wm4
It is wrong/incorrect in two aspects: 1. The pixel format is not enough to guarantee that the resulting file will be any more compatible with media players. 2. Media players not supporting higher profiles are not necessarily outdated (in fact this is simply an arrogant statement that

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't offer H.264 compatibility warning for NV12 input

2017-06-15 Thread wm4
On Thu, 15 Jun 2017 12:10:27 -0300 James Almer wrote: > On 6/15/2017 11:43 AM, wm4 wrote: > > On Thu, 15 Jun 2017 16:22:34 +0200 > > Michael Niedermayer wrote: > > > >> no, but that doesnt mean we can make false statments about other > >> people or

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/vorbisenc: Stop tracking number of samples per frame

2017-06-15 Thread Rostislav Pehlivanov
On 14 June 2017 at 21:59, Tyler Jones wrote: > Each frame is now padded with 0 values if not enough samples are > present, and all frames are guaranteed to have exactly > 1 << (venc->log2_blocksize[1] - 1) samples. > > Signed-off-by: Tyler Jones > ---

[FFmpeg-devel] [PATCH] avcodec/x86: add an 8-bit simple IDCT function based on the x86-64 high depth functions

2017-06-15 Thread James Darnley
Includes add/put functions Rounding contributed by Ronald S. Bultje --- I must be stupid. I dropped the stack space change somewhere. libavcodec/tests/x86/dct.c | 2 + libavcodec/x86/idctdsp_init.c| 23 ++ libavcodec/x86/simple_idct.h | 9

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't offer H.264 compatibility warning for NV12 input

2017-06-15 Thread James Almer
On 6/15/2017 11:43 AM, wm4 wrote: > On Thu, 15 Jun 2017 16:22:34 +0200 > Michael Niedermayer wrote: > >> no, but that doesnt mean we can make false statments about other >> people or their work. >> >> Theres the moral wrong >> >> Theres the technical wrong, of not

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't offer H.264 compatibility warning for NV12 input

2017-06-15 Thread wm4
On Thu, 15 Jun 2017 16:22:34 +0200 Michael Niedermayer wrote: > no, but that doesnt mean we can make false statments about other > people or their work. > > Theres the moral wrong > > Theres the technical wrong, of not correctly stating the problem and > that

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't offer H.264 compatibility warning for NV12 input

2017-06-15 Thread Michael Niedermayer
On Thu, Jun 15, 2017 at 02:12:09PM +0200, Paul B Mahol wrote: > On 6/15/17, Michael Niedermayer wrote: > > On Thu, Jun 15, 2017 at 01:14:34PM +0200, wm4 wrote: > > [...] > >> By default, ffmpeg CLI's design is something like "fuck the user". I'm > > > > This is not true,

[FFmpeg-devel] [PATCH 6/6] avcodec/x86: add an 8-bit simple IDCT function based on the x86-64 high depth functions

2017-06-15 Thread James Darnley
Includes add/put functions Rounding contributed by Ronald S. Bultje --- libavcodec/tests/x86/dct.c | 2 + libavcodec/x86/idctdsp_init.c| 23 ++ libavcodec/x86/simple_idct.h | 9 libavcodec/x86/simple_idct10.asm | 94 4 files

[FFmpeg-devel] [PATCH 2/6] avcodec/x86: cleanup simple_idct10

2017-06-15 Thread James Darnley
Use named arguments for the functions so we can remove a define. The stride/linesize argument is now ptrdiff_t type so we no longer need to sign extend the register. --- libavcodec/x86/proresdsp.asm | 2 +- libavcodec/x86/simple_idct10.asm | 8 ++--

[FFmpeg-devel] [PATCH 3/6] avcodec/x86: modify simple_idct10 macros to add an action paramter

2017-06-15 Thread James Darnley
--- libavcodec/x86/proresdsp.asm | 2 +- libavcodec/x86/simple_idct10.asm | 8 +++ libavcodec/x86/simple_idct10_template.asm | 37 +-- 3 files changed, 25 insertions(+), 22 deletions(-) diff --git a/libavcodec/x86/proresdsp.asm

[FFmpeg-devel] [PATCH 4/6] avcodec/x86: allow future 8-bit simple idct to use slightly different coefficients

2017-06-15 Thread James Darnley
--- libavcodec/x86/proresdsp.asm | 18 ++ libavcodec/x86/simple_idct10.asm | 29 + libavcodec/x86/simple_idct10_template.asm | 19 +++ 3 files changed, 50 insertions(+), 16 deletions(-) diff --git

[FFmpeg-devel] [PATCH 5/6] avcodec/x86: allow future 8-bit simple idct to have "DC only hack"

2017-06-15 Thread James Darnley
Created by Ronald S. Bultje --- libavcodec/x86/simple_idct10_template.asm | 38 +++ 1 file changed, 38 insertions(+) diff --git a/libavcodec/x86/simple_idct10_template.asm b/libavcodec/x86/simple_idct10_template.asm index d8ea0bcc6b..51baf84c82 100644 ---

[FFmpeg-devel] [PATCH 0/6] [v2] sse2/avx functions for 8-bit simple idct

2017-06-15 Thread James Darnley
After a lot of work by all involved this is the latest patch set. This includes the results of Ronald's work: rounding, minor coeff differences, "DC only hack". I need a proper term for this "DC only hack" because it is not DC only. It is for the lowest frequency of each row. I squashed all 3

[FFmpeg-devel] [PATCH 1/6] fate: add test of -idct simpleauto

2017-06-15 Thread James Darnley
--- tests/fate/video.mak | 3 +++ tests/ref/fate/idct-simpleauto | 27 +++ 2 files changed, 30 insertions(+) create mode 100644 tests/ref/fate/idct-simpleauto diff --git a/tests/fate/video.mak b/tests/fate/video.mak index d1d35335f2..455c1d3564 100644 ---

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't offer H.264 compatibility warning for NV12 input

2017-06-15 Thread wm4
On Thu, 15 Jun 2017 18:17:37 +0530 Gyan wrote: > On Thu, Jun 15, 2017 at 4:44 PM, wm4 wrote: > > > > Forcing the "High" or maybe "Main" profile is enough to ensure > > compatibility. > > > > Result of encoding a PNG sequence, forcing High

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't offer H.264 compatibility warning for NV12 input

2017-06-15 Thread Gyan
On Thu, Jun 15, 2017 at 4:44 PM, wm4 wrote: > Forcing the "High" or maybe "Main" profile is enough to ensure > compatibility. > Result of encoding a PNG sequence, forcing High profile, but without -pix_fmt - No pixel format specified, yuv444p for H.264

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't offer H.264 compatibility warning for NV12 input

2017-06-15 Thread Paul B Mahol
On 6/15/17, Michael Niedermayer wrote: > On Thu, Jun 15, 2017 at 01:14:34PM +0200, wm4 wrote: > [...] >> By default, ffmpeg CLI's design is something like "fuck the user". I'm > > This is not true, nor are statments like this useful. > Whatever problem there is, it is not

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't offer H.264 compatibility warning for NV12 input

2017-06-15 Thread Michael Niedermayer
On Thu, Jun 15, 2017 at 01:14:34PM +0200, wm4 wrote: [...] > By default, ffmpeg CLI's design is something like "fuck the user". I'm This is not true, nor are statments like this useful. Whatever problem there is, it is not and never was FFmpegs design to fuck the user. Quite the opposite ... If

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't offer H.264 compatibility warning for NV12 input

2017-06-15 Thread wm4
On Thu, 15 Jun 2017 16:12:00 +0530 Gyan wrote: > On Thu, Jun 15, 2017 at 3:04 PM, wm4 wrote: > > > > It's wrong and dumb because the pixfmt is not enough to tell whether > > the encoder will produce a file with w widely compatible profile. > > >

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't offer H.264 compatibility warning for NV12 input

2017-06-15 Thread Gyan
On Thu, Jun 15, 2017 at 3:04 PM, wm4 wrote: > It's wrong and dumb because the pixfmt is not enough to tell whether > the encoder will produce a file with w widely compatible profile. > yuv420p is not sufficient to ensure compatibility but !yuv420p is sufficient to ensure

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't offer H.264 compatibility warning for NV12 input

2017-06-15 Thread wm4
On Thu, 15 Jun 2017 09:42:48 +0530 Gyan wrote: > On Thu, Jun 15, 2017 at 4:59 AM, wm4 wrote: > > > > > > av_log(NULL, AV_LOG_WARNING, > > > "No pixel format specified, %s for H.264 encoding > > chosen.\n" > > >

Re: [FFmpeg-devel] [PATCH] libavformat/wtvdec: return AVERROR_EOF on EOF

2017-06-15 Thread Nicolas George
Le septidi 17 prairial, an CCXXV, Daniel Kucera a écrit : > Signed-off-by: Daniel Kucera > --- > libavformat/wtvdec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/wtvdec.c b/libavformat/wtvdec.c > index 3ac4501306..ee19fd84da

Re: [FFmpeg-devel] [PATCH] libavformat/file: return AVERROR_EOF on EOF

2017-06-15 Thread Nicolas George
Le septidi 17 prairial, an CCXXV, Daniel Kucera a écrit : > Signed-off-by: Daniel Kucera > --- > libavformat/file.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/file.c b/libavformat/file.c > index 264542a36a..1fb83851c0 100644 > ---

Re: [FFmpeg-devel] [PATCH] libavformat/subfile: return AVERROR_EOF on EOF

2017-06-15 Thread Nicolas George
Le septidi 17 prairial, an CCXXV, Daniel Kucera a écrit : > Signed-off-by: Daniel Kucera > --- > libavformat/subfile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/subfile.c b/libavformat/subfile.c > index fa971e1902..497cf85211

Re: [FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF

2017-06-15 Thread Nicolas George
Le septidi 17 prairial, an CCXXV, Daniel Kucera a écrit : > Signed-off-by: Daniel Kucera > --- > libavformat/cache.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I think this is correct, but I do not maintain that file and the code has spaghetti