Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo: Fix all but one tsan warning in fate-vsynth1-mpeg4

2017-07-09 Thread Ronald S. Bultje
Hi, On Sun, Jul 9, 2017 at 9:19 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpegvideo.c | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c > index e29558b3a2..574b38

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo: Fix all but one tsan warning in fate-vsynth1-mpeg4

2017-07-09 Thread Muhammad Faiz
On Mon, Jul 10, 2017 at 8:19 AM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpegvideo.c | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c > index e29558b3a2..574b3854e0

[FFmpeg-devel] [PATCH] avcodec/mpegvideo: Fix all but one tsan warning in fate-vsynth1-mpeg4

2017-07-09 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/mpegvideo.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index e29558b3a2..574b3854e0 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@ -495,7

Re: [FFmpeg-devel] [PATCH] avformat/avio: Remove no-op code in url_find_protocol().

2017-07-09 Thread Muhammad Faiz
On Fri, Jul 7, 2017 at 1:32 PM, Muhammad Faiz wrote: > On Fri, Jul 7, 2017 at 11:27 AM, Wan-Teh Chang > wrote: >> Hi Muhammad, >> >> On Thu, Jul 6, 2017 at 7:56 PM, Muhammad Faiz wrote: >>> On Fri, Jul 7, 2017 at 9:18 AM, Wan-Teh Chang >>> wrote: In url_find_protocol(), proto_str is either

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-09 Thread Ivan Kalvachev
On 7/9/17, Ronald S. Bultje wrote: > Hi, > > On Sun, Jul 9, 2017 at 4:39 AM, Reimar Döffinger > wrote: > >> On 09.07.2017, at 02:52, "Ronald S. Bultje" wrote: >> > On Sat, Jul 8, 2017 at 5:17 PM, Michael Niedermayer >> >> > wrote: >> > >> >> >> >> Does anyone object to this patch ? >> >> Or doe

Re: [FFmpeg-devel] [PATCH] movenc: write clap tag

2017-07-09 Thread Dave Rice
> On Jul 7, 2017, at 7:06 PM, Derek Buitenhuis > wrote: > > On 7/7/2017 10:13 PM, James Almer wrote: >> Isn't this necessary only for files with raw video? As is, this box >> would be written on any mov file with a video stream. > > This was addressed a previous email: > >http://lists.ffm

Re: [FFmpeg-devel] [PATCH] movenc: write clap tag

2017-07-09 Thread Dave Rice
> On Jul 7, 2017, at 11:32 AM, Derek Buitenhuis > wrote: > > On 7/7/2017 3:20 AM, Dave Rice wrote: >> Resolves https://trac.ffmpeg.org/ticket/6145 and writes a clap atom that is >> coincident with the frames width and height. >> >> >> From 23d80d0d47829fed61e817b1e7c3f6d420c9ab5c Mon Sep 17

[FFmpeg-devel] [PATCH] web/template_head2: Add net neutrality script

2017-07-09 Thread Michael Niedermayer
See: https://www.battleforthenet.com/july12/ Signed-off-by: Michael Niedermayer --- src/template_head2 | 1 + 1 file changed, 1 insertion(+) diff --git a/src/template_head2 b/src/template_head2 index a0b11ab..d7bb7bd 100644 --- a/src/template_head2 +++ b/src/template_head2 @@ -3,6 +3,7 @@

[FFmpeg-devel] [PATCH] h264: Support multi-field closed captions by using AVBufferRef and not resetting per field

2017-07-09 Thread Kieran Kunhya
$subj 0001-h264-Support-multi-field-closed-captions-by-using-AV.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Ticket 6375, Too many packets buffered for output stream

2017-07-09 Thread Reimar Döffinger
On 09.07.2017, at 22:37, Hendrik Leppkes wrote: > > Either extremely badly intereleaved streams or streams that just start > super late in the file have always been very problematic for decoding, > resulting in various hacks over the years to add "best-guess" default > values so at least somethi

Re: [FFmpeg-devel] Ticket 6375, Too many packets buffered for output stream

2017-07-09 Thread Hendrik Leppkes
On Sun, Jul 9, 2017 at 1:38 PM, Reimar Döffinger wrote: > On 09.07.2017, at 13:09, Michael Niedermayer wrote: > >> Hi all >> >> It does appear this regression affects alot of people, judging from >> the multiple different people in the ticket. >> Also people ask me about this, for example baptist

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-09 Thread Reimar Döffinger
On 09.07.2017, at 16:08, "Ronald S. Bultje" wrote: > Hi, > > On Sun, Jul 9, 2017 at 4:39 AM, Reimar Döffinger > wrote: > >> On 09.07.2017, at 02:52, "Ronald S. Bultje" wrote: >>> On Sat, Jul 8, 2017 at 5:17 PM, Michael Niedermayer >> >>> wrote: >>> Does anyone object to this patch

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-07-09 Thread Marton Balint
On Sun, 9 Jul 2017, Paul B Mahol wrote: On 7/9/17, Marton Balint wrote: On Sun, 9 Jul 2017, Paul B Mahol wrote: On 7/9/17, Marton Balint wrote: On Sat, 24 Jun 2017, Nicolas George wrote: Le sextidi 6 messidor, an CCXXV, Paul B Mahol a ecrit : The reverted commit breaks lot of filter

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-07-09 Thread Paul B Mahol
On 7/9/17, Marton Balint wrote: > > On Sun, 9 Jul 2017, Paul B Mahol wrote: > >> On 7/9/17, Marton Balint wrote: >>> >>> On Sat, 24 Jun 2017, Nicolas George wrote: >>> Le sextidi 6 messidor, an CCXXV, Paul B Mahol a ecrit : > The reverted commit breaks lot of filters and I failed to find

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-07-09 Thread Marton Balint
On Sun, 9 Jul 2017, Paul B Mahol wrote: On 7/9/17, Marton Balint wrote: On Sat, 24 Jun 2017, Nicolas George wrote: Le sextidi 6 messidor, an CCXXV, Paul B Mahol a ecrit : The reverted commit breaks lot of filters and I failed to find fix, the only logical solution It breaks a corner-cas

[FFmpeg-devel] [PATCH] avfilter: add ADM filter

2017-07-09 Thread Ashish Singh
Hi, this is ADM filter also known as DLM (Detail loss metric), one of the component filters of VMAF. It takes two videos as input. Run it using: ffmpeg -i main -i ref -lavfi adm -f null - Currently it outputs the average adm score over all frames. --- Changelog| 1 + doc/filters

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-07-09 Thread Paul B Mahol
On 7/9/17, Marton Balint wrote: > > On Sat, 24 Jun 2017, Nicolas George wrote: > >> Le sextidi 6 messidor, an CCXXV, Paul B Mahol a ecrit : >>> The reverted commit breaks lot of filters and I failed to find fix, >>> the only logical solution >> >> It breaks a corner-case option of, indeed a lot of

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

2017-07-09 Thread Marton Balint
On Sat, 24 Jun 2017, Nicolas George wrote: Le sextidi 6 messidor, an CCXXV, Paul B Mahol a écrit : The reverted commit breaks lot of filters and I failed to find fix, the only logical solution It breaks a corner-case option of, indeed a lot of, filters. I have not yet been able to track down

Re: [FFmpeg-devel] [PATCH] avcodec/noise_bsf: add support for dropping packets

2017-07-09 Thread Marton Balint
On Sat, 8 Jul 2017, Michael Niedermayer wrote: On Sat, Jul 08, 2017 at 01:21:32PM +0200, Marton Balint wrote: Signed-off-by: Marton Balint --- doc/bitstream_filters.texi | 14 +++--- libavcodec/noise_bsf.c | 8 libavcodec/version.h | 2 +- 3 files changed, 20 ins

[FFmpeg-devel] [PATCH] avfilter: add ANSNR filter

2017-07-09 Thread Ashish Singh
--- Changelog| 1 + doc/filters.texi | 20 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/ansnr.h | 29 libavfilter/vf_ansnr.c | 418 +++ 6 files changed, 470 insertions(+) cre

[FFmpeg-devel] [PATCH] avfilter: add ANSNR filter

2017-07-09 Thread Ashish Singh
Hi, added metadata scores and changed multipe string comparisons to few integer comparisons. --- Changelog| 1 + doc/filters.texi | 20 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/ansnr.h | 29 libavfilter/vf_ansnr.c

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-09 Thread Michael Niedermayer
On Sun, Jul 09, 2017 at 10:08:50AM -0400, Ronald S. Bultje wrote: > Hi, > > On Sun, Jul 9, 2017 at 4:39 AM, Reimar Döffinger > wrote: > > > On 09.07.2017, at 02:52, "Ronald S. Bultje" wrote: > > > On Sat, Jul 8, 2017 at 5:17 PM, Michael Niedermayer > > > > > wrote: > > > > > >> > > >> Does any

Re: [FFmpeg-devel] [PATCH] avcodec/pthread_slice: rewrite implementation

2017-07-09 Thread Muhammad Faiz
On Sun, Jul 9, 2017 at 6:45 PM, Ronald S. Bultje wrote: > Hi, > > On Sun, Jul 9, 2017 at 6:27 AM, Muhammad Faiz wrote: >> >> Avoid pthread_cond_broadcast that wakes up all workers. Make each of them >> uses distict mutex/cond. Also let main thread help running jobs. > > > Hm... I'm not against th

[FFmpeg-devel] [PATCH] avcodec/aacps (fixed point): Fix multiple signed integer overflows

2017-07-09 Thread Michael Niedermayer
Fixes: runtime error: signed integer overflow: 1421978265 - -1810326882 cannot be represented in type 'int' Fixes: 2527/clusterfuzz-testcase-minimized-5260915396050944 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niede

[FFmpeg-devel] [PATCH v2] avcodec/pthread_slice: rewrite implementation

2017-07-09 Thread Muhammad Faiz
Avoid pthread_cond_broadcast that wakes up all workers. Make each of them uses distict mutex/cond. Also let main thread help running jobs, but still allocate thread_count workers. The last worker is currently unused, emulated by main thread. Similar to 'avfilter/pthread: rewrite implementation' Be

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-09 Thread Ronald S. Bultje
Hi, On Sun, Jul 9, 2017 at 4:39 AM, Reimar Döffinger wrote: > On 09.07.2017, at 02:52, "Ronald S. Bultje" wrote: > > On Sat, Jul 8, 2017 at 5:17 PM, Michael Niedermayer > > > wrote: > > > >> > >> Does anyone object to this patch ? > >> Or does anyone have a better idea on how to fix this ? > >

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-07-09 Thread Clément Bœsch
On Sun, Jul 09, 2017 at 02:28:28PM +0200, Clément Bœsch wrote: [...] > 544 > 00:53:43,780 --> 00:53:45,941 > <> - he calmed himself. > Side note here: "<<" and ">>" are used for « and ». It's important to not break this case IMO. > > 545 > 00:53:46,216 --> 00:53:49,083 > < the hotel is within e

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-07-09 Thread Clément Bœsch
On Sat, Jul 08, 2017 at 11:07:48PM +0200, Michael Niedermayer wrote: [...] > 5 days passed with no comments and no suggestions on how to implement > this better. > does anyone object to the fix as in the patch to be applied ? misc patterns I found you may want to give a try (note that these are co

Re: [FFmpeg-devel] [PATCH] avcodec/pthread_slice: rewrite implementation

2017-07-09 Thread Ronald S. Bultje
Hi, On Sun, Jul 9, 2017 at 6:27 AM, Muhammad Faiz wrote: > Avoid pthread_cond_broadcast that wakes up all workers. Make each of them > uses distict mutex/cond. Also let main thread help running jobs. Hm... I'm not against this, but I actually had plans to write some extensions and allow the ma

Re: [FFmpeg-devel] Ticket 6375, Too many packets buffered for output stream

2017-07-09 Thread Reimar Döffinger
On 09.07.2017, at 13:09, Michael Niedermayer wrote: > Hi all > > It does appear this regression affects alot of people, judging from > the multiple different people in the ticket. > Also people ask me about this, for example baptiste yesterday hit it > too. > > I belive multiple people where in

[FFmpeg-devel] Ticket 6375, Too many packets buffered for output stream

2017-07-09 Thread Michael Niedermayer
Hi all It does appear this regression affects alot of people, judging from the multiple different people in the ticket. Also people ask me about this, for example baptiste yesterday hit it too. I belive multiple people where in favour of the change that caused this regression. Does someone who wa

[FFmpeg-devel] [PATCH] avcodec/pthread_slice: rewrite implementation

2017-07-09 Thread Muhammad Faiz
Avoid pthread_cond_broadcast that wakes up all workers. Make each of them uses distict mutex/cond. Also let main thread help running jobs. Similar to 'avfilter/pthread: rewrite implementation' Benchmark on x86_64 with 4 cpus (2 cores x 2 hyperthread) ./ffmpeg -threads $threads -thread_type slice -

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-09 Thread Ivan Kalvachev
On 7/9/17, Ronald S. Bultje wrote: > Hi, > > On Sat, Jul 8, 2017 at 5:17 PM, Michael Niedermayer > wrote: > >> On Mon, Jul 03, 2017 at 01:37:09AM +0200, Michael Niedermayer wrote: >> > On Sun, Jul 02, 2017 at 02:24:53PM +0100, Rostislav Pehlivanov wrote: >> > > On 2 July 2017 at 03:28, Michael Ni

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-09 Thread Reimar Döffinger
On 09.07.2017, at 02:52, "Ronald S. Bultje" wrote: > On Sat, Jul 8, 2017 at 5:17 PM, Michael Niedermayer > wrote: > >> >> Does anyone object to this patch ? >> Or does anyone have a better idea on how to fix this ? >> if not id like to apply it > > > I think Rostislav's point is: why fix it,