Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

25.08.2017 0:17, Marton Balint пише: [...] Ok. If it works in v3, then I guess it is OK to apply as is. Let me know when you want me to do that. please apply -- Maksym Veremeyenko ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter/af_firequalizer: add min_phase option

On Wed, Aug 23, 2017 at 1:38 AM, Muhammad Faiz wrote: > Signed-off-by: Muhammad Faiz > --- > doc/filters.texi | 3 + > libavfilter/af_firequalizer.c | 147 > +- > 2 files changed, 147 insertions(+), 3

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

On 8/24/2017 9:36 PM, Ivan Kalvachev wrote: > On 8/25/17, James Almer wrote: >> On 8/24/2017 8:26 PM, Ivan Kalvachev wrote: >>> On 8/24/17, James Almer wrote: On 8/24/2017 12:01 PM, wm4 wrote: > On Thu, 24 Aug 2017 11:20:17 +0200 > Michael

Re: [FFmpeg-devel] [PATCH v2] mjpeg: Add support for ICC side data

On Thu, Aug 24, 2017 at 02:33:33PM +0100, Derek Buitenhuis wrote: > JPEGs store embedded profiles under the APP2 marker, signified > with a "ICC_PROFILE" null-terminated string header, and can be > split across multiple APP2 markers, out of order. > > Signed-off-by: Derek Buitenhuis

Re: [FFmpeg-devel] [PATCH] utils: Do not expand a macro with 'defined' in it

On Thu, Aug 24, 2017 at 09:02:33PM +0100, Derek Buitenhuis wrote: > Fixes: > > libswscale/utils.c:1632:5: warning: macro expansion producing 'defined' > has undefined behavior [-Wexpansion-to-defined] > #if USE_MMAP > ^ > libswscale/utils.c:1577:49: note: expanded from macro

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

On 8/25/17, James Almer wrote: > On 8/24/2017 8:26 PM, Ivan Kalvachev wrote: >> On 8/24/17, James Almer wrote: >>> On 8/24/2017 12:01 PM, wm4 wrote: On Thu, 24 Aug 2017 11:20:17 +0200 Michael Niedermayer wrote: >

Re: [FFmpeg-devel] [PATCH 6/6] avformat/hls: Fix DoS due to infinite loop

2017-08-25 7:15 GMT+08:00 Michael Niedermayer : > Fixes: loop.m3u > > The max iteration count of 1 is arbitrary and ideas for a better solution > are welcome Why not give a option to user for set the reload_count and limit from 1 - 1? > > Found-by: Xiaohei and

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

On Thu, Aug 24, 2017 at 2:27 AM, Michael Niedermayer wrote: > > can the insertions be done in groups instead of one at a time ? > so that it basically merges 2 lists (O(n)) instead of inserting > one at a time O(n^2) > ? > This would significantly improve the worst case

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

+michael This patch is also necessary now that you've applied the ctts fixes in the previous patch. Thanks. - dale On Fri, Aug 4, 2017 at 4:04 PM, Dale Curtis wrote: > Sample sent privately. I didn't find any non-fuzzer samples that no longer > demux in our Chrome

Re: [FFmpeg-devel] Autotools full recompilation

On 8/24/2017 7:19 PM, Yan wrote: High! I'm using latest ffmpeg from this mirror (https://github.com/FFmpeg) I was building it with different options: ./configure ./configure --libdir=$dev/FFmpeg/libavcodec/ ./configure --enable-shared ./configure --enable-shared --enable-pic And after

[FFmpeg-devel] [PATCH] avcodec/imgconvert: remove deprecation guards for a function that's not declared as such

Signed-off-by: James Almer --- The deprecation seems to have been imported from libav but never made effective. libavcodec/imgconvert.c | 2 -- libavcodec/version.h| 3 --- 2 files changed, 5 deletions(-) diff --git a/libavcodec/imgconvert.c b/libavcodec/imgconvert.c

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

On 8/24/2017 8:26 PM, Ivan Kalvachev wrote: > On 8/24/17, James Almer wrote: >> On 8/24/2017 12:01 PM, wm4 wrote: >>> On Thu, 24 Aug 2017 11:20:17 +0200 >>> Michael Niedermayer wrote: >>> On Thu, Aug 24, 2017 at 10:52:55AM +0200, wm4 wrote: >

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

On 8/24/17, James Almer wrote: > On 8/24/2017 12:01 PM, wm4 wrote: >> On Thu, 24 Aug 2017 11:20:17 +0200 >> Michael Niedermayer wrote: >> >>> On Thu, Aug 24, 2017 at 10:52:55AM +0200, wm4 wrote: On Wed, 23 Aug 2017 19:23:12 -0300 James Almer

[FFmpeg-devel] Autotools full recompilation

High! I'm using latest ffmpeg from this mirror (https://github.com/FFmpeg) I was building it with different options: ./configure ./configure --libdir=$dev/FFmpeg/libavcodec/ ./configure --enable-shared ./configure --enable-shared --enable-pic And after each time the whole project got

[FFmpeg-devel] [PATCH 5/6] avformat/asfdec: Fix DoS due to lack of eof check

From: 孙浩 and 张洪亮(望初) Fixes: loop.asf Found-by: Xiaohei and Wangchu from Alibaba Security Team Signed-off-by: Michael Niedermayer --- libavformat/asfdec_f.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavformat/asfdec_f.c

[FFmpeg-devel] [PATCH 3/6] avformat/rl2: Fix DoS due to lack of eof check

From: 孙浩 and 张洪亮(望初) Fixes: loop.rl2 Found-by: Xiaohei and Wangchu from Alibaba Security Team Signed-off-by: Michael Niedermayer --- libavformat/rl2.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libavformat/rl2.c

[FFmpeg-devel] [PATCH 6/6] avformat/hls: Fix DoS due to infinite loop

Fixes: loop.m3u The max iteration count of 1 is arbitrary and ideas for a better solution are welcome Found-by: Xiaohei and Wangchu from Alibaba Security Team Signed-off-by: Michael Niedermayer --- libavformat/hls.c | 4 1 file changed, 4 insertions(+) diff

[FFmpeg-devel] [PATCH 2/6] avformat/rmdec: Fix DoS due to lack of eof check

From: 孙浩 and 张洪亮(望初) Fixes: loop.ivr Found-by: Xiaohei and Wangchu from Alibaba Security Team Signed-off-by: Michael Niedermayer --- libavformat/rmdec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c

[FFmpeg-devel] [PATCH 1/6] avformat/cinedec: Fix DoS due to lack of eof check

From: 孙浩 and 张洪亮(望初) Fixes: loop.cine Found-by: Xiaohei and Wangchu from Alibaba Security Team Signed-off-by: Michael Niedermayer --- libavformat/cinedec.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/cinedec.c

[FFmpeg-devel] [PATCH 4/6] avformat/mvdec: Fix DoS due to lack of eof check

Fixes: loop.mv Found-by: Xiaohei and Wangchu from Alibaba Security Team Signed-off-by: Michael Niedermayer --- libavformat/mvdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mvdec.c b/libavformat/mvdec.c index 0e12c8c6c1..f7aa4cbaec 100644 ---

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Thanks a lot Martin !!! all sorted out thanks to your kind help. I had run fate previously but obviously missed something; so re-run and it's ok. I created two tests per your advice testing for a third channel in a stereo file and then in a 2.1 file. Instead of CRC, I've used MD5 because the

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

On Wed, 23 Aug 2017, Maksym Veremeyenko wrote: 22.08.2017 23:14, Maksym Veremeyenko пише: [...] One more thing I noticed testing, maybe you can take a look: rgba and rgb0 format is not working (I used the V1 SDK), only audio frames are received, but no apparent error is shown. On the other

Re: [FFmpeg-devel] [PATCH] utils: Do not expand a macro with 'defined' in it

On 8/24/2017 9:02 PM, Derek Buitenhuis wrote: > Fixes: > > libswscale/utils.c:1632:5: warning: macro expansion producing 'defined' > has undefined behavior [-Wexpansion-to-defined] > #if USE_MMAP > ^ > libswscale/utils.c:1577:49: note: expanded from macro 'USE_MMAP' >

[FFmpeg-devel] [PATCH] utils: Do not expand a macro with 'defined' in it

Fixes: libswscale/utils.c:1632:5: warning: macro expansion producing 'defined' has undefined behavior [-Wexpansion-to-defined] #if USE_MMAP ^ libswscale/utils.c:1577:49: note: expanded from macro 'USE_MMAP' #define USE_MMAP (HAVE_MMAP && HAVE_MPROTECT && defined

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

2017-08-24 21:16 GMT+02:00 pkv.stream : > Hi > working on creating a fate test. > I am stumbling on probably a dumb issue; I want to re-use a file already > used for mapchan test: > > FATE_MAPCHAN-$(CONFIG_CHANNELMAP_FILTER) += fate-mapchan-6ch-extract-2 >

[FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Hi working on creating a fate test. I am stumbling on probably a dumb issue; I want to re-use a file already used for mapchan test: FATE_MAPCHAN-$(CONFIG_CHANNELMAP_FILTER) += fate-mapchan-6ch-extract-2 fate-mapchan-6ch-extract-2: tests/data/asynth-22050-6.wav (first two lines in ffmpeg.mak)

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

On 8/24/2017 12:01 PM, wm4 wrote: > On Thu, 24 Aug 2017 11:20:17 +0200 > Michael Niedermayer wrote: > >> On Thu, Aug 24, 2017 at 10:52:55AM +0200, wm4 wrote: >>> On Wed, 23 Aug 2017 19:23:12 -0300 >>> James Almer wrote: >>> On 8/21/2017 2:51

Re: [FFmpeg-devel] Merge all libraries (was: all: avoid data imports across DLL) boundaries

Le septidi 7 fructidor, an CCXXV, Kieran Kunhya a écrit : > You clearly are not aware how much random junk in all libs is still enabled > with --disable-everything. > I don't use avformat, why should it be linked into my code. Why should it not, if it makes things simpler for everybody? That is

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

On Thu, 24 Aug 2017 11:20:17 +0200 Michael Niedermayer wrote: > On Thu, Aug 24, 2017 at 10:52:55AM +0200, wm4 wrote: > > On Wed, 23 Aug 2017 19:23:12 -0300 > > James Almer wrote: > > > > > On 8/21/2017 2:51 PM, wm4 wrote: > > > > From: Pedro

Re: [FFmpeg-devel] Merge all libraries (was: all: avoid data imports across DLL) boundaries

> > I did not manage to find a real drawback. If somebody finds it a bad > idea, then please explain to me what benefit we get from having several > separate libraries. This is not a rhetorical question, I really would > like an explanation. But I do not agree with the obvious argument of > file

[FFmpeg-devel] Merge all libraries (was: all: avoid data imports across DLL) boundaries

Le sextidi 6 fructidor, an CCXXV, James Almer a écrit : > Speaking of which, do you or anyone else want to help with applying the > bump right now instead of waiting until the merges are resumed? If we are requesting help for a bump, I would like to propose seriously and request help for the

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

On 8/24/2017 5:52 AM, wm4 wrote: > On Wed, 23 Aug 2017 19:23:12 -0300 > James Almer wrote: > >> On 8/21/2017 2:51 PM, wm4 wrote: >>> From: Pedro Pombeiro >>> >>> DLL data imports cause problems on Windows. They normally require >>> each variable to be

[FFmpeg-devel] [PATCH v2] mjpeg: Add support for ICC side data

JPEGs store embedded profiles under the APP2 marker, signified with a "ICC_PROFILE" null-terminated string header, and can be split across multiple APP2 markers, out of order. Signed-off-by: Derek Buitenhuis --- libavcodec/mjpegdec.c | 104

Re: [FFmpeg-devel] [PATCH] mjpeg: Add support for ICC side data

On 8/24/2017 1:22 AM, Michael Niedermayer wrote: > should be ok i think Rostislav asked me on IRC to try with MJPEG, so I am going to try and synthesize such a file and work on a v2. I don't suppose you, or anyone else has an MJPEG file with ICC profiles embedded? :) - Derek

[FFmpeg-devel] [PATCH]lavf/rawenc: Add G.726 muxers

Hi! Attached patch makes creating G.726 files slightly easier. Please comment, Carl Eugen From 9c6effa57ba37d8881a213da66e23e6c25c46665 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 24 Aug 2017 13:06:06 +0200 Subject: [PATCH] lavf/rawenc: Add little- and

Re: [FFmpeg-devel] [PATCH]lavc/put_bits: Remove usage of BITSTREAM_WRITER_LE.

2017-08-23 0:56 GMT+02:00 Ivan Kalvachev : > On 8/22/17, Ronald S. Bultje wrote: >> Hi, >> >> On Mon, Aug 21, 2017 at 11:16 AM, Carl Eugen Hoyos >> wrote: >> >>> Hi! >>> >>> Attached patch tries to slightly simplify and clean up the

Re: [FFmpeg-devel] [PATCH]lavf/g726: Add a raw little-endian G.726 demuxer

2017-08-21 17:24 GMT+02:00 Carl Eugen Hoyos : > 2017-08-18 19:25 GMT+02:00 Carl Eugen Hoyos : >> Hi! >> >> Attached patch allows to read files produced by the "ITU compatible >> binary G726 encoder" attached to ticket #6596. > > New patch attached that also

Re: [FFmpeg-devel] [PATCH]lsws/rgb2rgb: Add unscaled 48 to 64bit conversion

2017-08-24 2:27 GMT+02:00 Michael Niedermayer : > On Wed, Aug 23, 2017 at 02:21:40PM +0200, Carl Eugen Hoyos wrote: >> Hi! >> > >> Attached patch fixes ticket #6608. > > iam not sure thats the correct fix for the ticket but the patch is a > good idea none the less > thus

[FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Thanks a lot Martin. I had spotted ffmpeg.mak but your input is very helpful Le 24 août 2017 11:32 AM, "Martin Vignali" a écrit : 2017-08-24 11:03 GMT+02:00 Kv Pham : > Ah ok! > Sure, I will do that. I need first to acquaint myself more with

Re: [FFmpeg-devel] [PATCH 1/2] ffprobe: Fix null pointer dereference with color primaries

On Tue, Aug 22, 2017 at 06:34:35PM +0200, Michael Niedermayer wrote: > Found-by: AD-lab of venustech > Signed-off-by: Michael Niedermayer > --- > ffprobe.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) patchet applied [...] -- Michael

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

2017-08-24 11:03 GMT+02:00 Kv Pham : > Ah ok! > Sure, I will do that. I need first to acquaint myself more with fate. > > > Hello, You can take a look at ./tests/fate/ffmpeg.mak (begin of the file seems to have test for map_channel) I think you need to add two test, one

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

On Thu, Aug 24, 2017 at 10:52 AM, wm4 wrote: > On Wed, 23 Aug 2017 19:23:12 -0300 > James Almer wrote: > >> On 8/21/2017 2:51 PM, wm4 wrote: >> > From: Pedro Pombeiro >> > >> > DLL data imports cause problems on Windows. They

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/hevc_ps: Check delta_pocs in ff_hevc_decode_short_term_rps()

On Mon, Aug 21, 2017 at 02:15:50AM +0200, Michael Niedermayer wrote: > Fixes: integer overflow > Fixes: 2893/clusterfuzz-testcase-minimized-5809330567774208 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

On Wed, Aug 23, 2017 at 03:39:01PM -0700, Dale Curtis wrote: > On Sat, Aug 19, 2017 at 3:50 PM, Michael Niedermayer > wrote: > > > On Sun, Aug 20, 2017 at 12:48:30AM +0200, Michael Niedermayer wrote: > > > On Fri, Aug 18, 2017 at 03:57:45PM -0700, Dale Curtis wrote: > >

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

On Thu, Aug 24, 2017 at 10:52:55AM +0200, wm4 wrote: > On Wed, 23 Aug 2017 19:23:12 -0300 > James Almer wrote: > > > On 8/21/2017 2:51 PM, wm4 wrote: > > > From: Pedro Pombeiro > > > > > > DLL data imports cause problems on Windows. They normally

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Ah ok! Sure, I will do that. I need first to acquaint myself more with fate. Le 24 août 2017 10:52 AM, "Michael Niedermayer" a écrit : On Thu, Aug 24, 2017 at 10:36:20AM +0200, Kv Pham wrote: > Yes I did a make fate. Went ok. > Is there a log to attach ? Or stdout ? i

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec_h264: Fix heap-buffer-overflow

On Wed, Aug 23, 2017 at 10:50:42PM +0200, Michael Niedermayer wrote: > Fixes: rtp_sdp/poc.sdp > > Found-by: Bingchang > Signed-off-by: Michael Niedermayer > --- > libavformat/rtpdec_h264.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

On Wed, Aug 23, 2017 at 03:39:01PM -0700, Dale Curtis wrote: > On Sat, Aug 19, 2017 at 3:50 PM, Michael Niedermayer > wrote: > > > On Sun, Aug 20, 2017 at 12:48:30AM +0200, Michael Niedermayer wrote: > > > On Fri, Aug 18, 2017 at 03:57:45PM -0700, Dale Curtis wrote: > >

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

On Wed, 23 Aug 2017 19:23:12 -0300 James Almer wrote: > On 8/21/2017 2:51 PM, wm4 wrote: > > From: Pedro Pombeiro > > > > DLL data imports cause problems on Windows. They normally require > > each variable to be correctly marked with

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

On Thu, Aug 24, 2017 at 10:36:20AM +0200, Kv Pham wrote: > Yes I did a make fate. Went ok. > Is there a log to attach ? Or stdout ? i meant can you add a test that tests the new feature when one runs make fate that is if the user runs "make fate" it would execute ffmpeg with map and "trailing ?"

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Yes I did a make fate. Went ok. Is there a log to attach ? Or stdout ? Le 24 août 2017 10:34 AM, "Michael Niedermayer" a écrit : On Thu, Aug 24, 2017 at 08:17:58AM +0200, pkv.stream wrote: > Le 24/08/2017 à 2:30 AM, Michael Niedermayer a écrit : > >On Wed, Aug 23, 2017

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

On Thu, Aug 24, 2017 at 08:17:58AM +0200, pkv.stream wrote: > Le 24/08/2017 à 2:30 AM, Michael Niedermayer a écrit : > >On Wed, Aug 23, 2017 at 06:48:14PM +0200, pkv.stream wrote: > >>Hello, > >> > >>the following patch allows one to add a trailing ? to -map_channel > >>as in -map option. > >> >

Re: [FFmpeg-devel] [PATCH] avfilter: Add vmaf filter

On Thu, Aug 24, 2017 at 07:35:41AM +0530, Ashish Pratap Singh wrote: > On Aug 24, 2017 05:13, "Michael Niedermayer" wrote: > > On Thu, Aug 24, 2017 at 12:58:53AM +0530, Ashish Pratap Singh wrote: > > From: Ashish Singh > > > > Hi, this is vmaf

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

Le 24/08/2017 à 2:30 AM, Michael Niedermayer a écrit : On Wed, Aug 23, 2017 at 06:48:14PM +0200, pkv.stream wrote: Hello, the following patch allows one to add a trailing ? to -map_channel as in -map option. E.g: -map_channel 0.0.2? so that if the channel does not exist, the command does not