Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-10-01 Thread pkv.stream
forgot to say a few things: - only the order and the type of the element (sce, cpe or lfe) really matters for the encoding; the encoder does not use the front, side or back info; I have used that fact for instance for 7.1 and 7.1(wide) or 7.1(wide-side): same PCE config can be used and works pe

Re: [FFmpeg-devel] [PATCH]lavf/img2dec: Auto-detect svg images

2017-10-01 Thread Clément Bœsch
On Mon, Oct 02, 2017 at 01:20:15AM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch implements auto-detection of svg images. > > Please review, Carl Eugen > From f06137f38f166740565e58d5c7c88777508f59ec Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Mon, 2 Oct 2017 01:13:29 +0

[FFmpeg-devel] [PATCH] fate: add test for iTunes gapless MP3

2017-10-01 Thread Christopher Snowhill
I've finally assembled a fate test for this patch. The test file goes here: /gapless/gapless-itunes.mp3 I have uploaded a copy here: https://f.losno.co/gapless-itunes.mp3 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman

[FFmpeg-devel] [PATCH] fate: add test for iTunes gapless MP3

2017-10-01 Thread Christopher Snowhill
--- tests/fate/gapless.mak| 3 ++- tests/ref/fate/gapless-mp3-itunes | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 tests/ref/fate/gapless-mp3-itunes diff --git a/tests/fate/gapless.mak b/tests/fate/gapless.mak index 0253b9ec61..46b3b98c13 100644 --- a/

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/proresdec2: Use LAST_SKIP_BITS where possible

2017-10-01 Thread James Almer
On 10/1/2017 11:18 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/proresdec2.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/proresdec2.c b/libavcodec/proresdec2.c > index 22dc70eeb4..9647aa7ebc 100644

[FFmpeg-devel] [PATCH 3/3] avcodec/decklink_dec: use av_packet_add_side_data()

2017-10-01 Thread James Almer
It uses the existing buffer instead of allocating a new one. Signed-off-by: James Almer --- Untested libavdevice/decklink_dec.cpp | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 386c64a177..025fee8602 10

[FFmpeg-devel] [PATCH 2/3] avcodec/decklink_dec: remove av_dup_packet() usage

2017-10-01 Thread James Almer
It's no longer needed after the last commit. Signed-off-by: James Almer --- Untested libavdevice/decklink_dec.cpp | 4 1 file changed, 4 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index b0c2fb8791..386c64a177 100644 --- a/libavdevice/decklink_dec

[FFmpeg-devel] [PATCH 1/3] avcodec/decklink_dec: use av_packet_from_data() to create packets from an already allocated buffer

2017-10-01 Thread James Almer
As a side effect, the packets will now be refcounted. Signed-off-by: James Almer --- Untested libavdevice/decklink_dec.cpp | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 8a14094474..b0c2fb8791 1

[FFmpeg-devel] [PATCH 2/3] avcodec/proresdec2: SKIP_BITS() does not work with len=32

2017-10-01 Thread Michael Niedermayer
Fixes: invalid shift Fixes: 3482/clusterfuzz-testcase-minimized-5446915875405824 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/proresdec2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[FFmpeg-devel] [PATCH 1/3] avcodec/hevcdsp_template: Fix undefined shift

2017-10-01 Thread Michael Niedermayer
Fixes: runtime error: left shift of negative value -255 Fixes: 3373/clusterfuzz-testcase-minimized-5604083912146944 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hevcdsp_template.c | 2 +- 1

[FFmpeg-devel] [PATCH 3/3] avcodec/proresdec2: Use LAST_SKIP_BITS where possible

2017-10-01 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/proresdec2.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/proresdec2.c b/libavcodec/proresdec2.c index 22dc70eeb4..9647aa7ebc 100644 --- a/libavcodec/proresdec2.c +++ b/libavcodec/proresdec2.c @@

[FFmpeg-devel] [PATCH] avcodec/encode: remove usage of av_dup_packet()

2017-10-01 Thread James Almer
Signed-off-by: James Almer --- libavcodec/encode.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index 525ee1f5d6..dd50486bcf 100644 --- a/libavcodec/encode.c +++ b/libavcodec/encode.c @@ -222,10 +222,12 @@ int

Re: [FFmpeg-devel] libavcodec/blockdsp : add AVX version

2017-10-01 Thread Ronald S. Bultje
Hi, On Sun, Oct 1, 2017 at 7:46 PM, Martin Vignali wrote: > I also modify several decoder/encoder, in order to fix the DECLARE_ALIGNED > from 16 to 32 > How did you decide which ones to change? Ronald ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg

Re: [FFmpeg-devel] libavcodec/blockdsp : add AVX version

2017-10-01 Thread James Almer
On 10/1/2017 8:46 PM, Martin Vignali wrote: > Hello, > > After taking a look on blockdsp > ./tests/checkasm/checkasm --test=blockdsp --bench > > the result of clear_blocks is slower on my computer than the C version > except if we add an avx version > > In attach patch to add avx version > for c

[FFmpeg-devel] libavcodec/blockdsp : add AVX version

2017-10-01 Thread Martin Vignali
Hello, After taking a look on blockdsp ./tests/checkasm/checkasm --test=blockdsp --bench the result of clear_blocks is slower on my computer than the C version except if we add an avx version In attach patch to add avx version for clear_block and clear_blocks result : (Kaby Lake, Mac os 10.12)

Re: [FFmpeg-devel] [PATCH] build: don't strip binaries during compilation

2017-10-01 Thread James Almer
On 10/1/2017 8:31 PM, Carl Eugen Hoyos wrote: > 2017-10-02 1:27 GMT+02:00 James Almer : >> On 10/1/2017 8:22 PM, Carl Eugen Hoyos wrote: >>> 2017-10-02 1:20 GMT+02:00 James Almer : On 10/1/2017 8:18 PM, Carl Eugen Hoyos wrote: > 2017-10-02 0:55 GMT+02:00 James Almer : >> Do it during i

Re: [FFmpeg-devel] [PATCH] build: don't strip binaries during compilation

2017-10-01 Thread Carl Eugen Hoyos
2017-10-02 1:27 GMT+02:00 James Almer : > On 10/1/2017 8:22 PM, Carl Eugen Hoyos wrote: >> 2017-10-02 1:20 GMT+02:00 James Almer : >>> On 10/1/2017 8:18 PM, Carl Eugen Hoyos wrote: 2017-10-02 0:55 GMT+02:00 James Almer : > Do it during install instead, like with the libraries. > >

Re: [FFmpeg-devel] [PATCH] build: don't strip binaries during compilation

2017-10-01 Thread James Almer
On 10/1/2017 8:22 PM, Carl Eugen Hoyos wrote: > 2017-10-02 1:20 GMT+02:00 James Almer : >> On 10/1/2017 8:18 PM, Carl Eugen Hoyos wrote: >>> 2017-10-02 0:55 GMT+02:00 James Almer : Do it during install instead, like with the libraries. There's no benefit making a stripped copy of the

Re: [FFmpeg-devel] [PATCH] build: don't strip binaries during compilation

2017-10-01 Thread Carl Eugen Hoyos
2017-10-02 1:20 GMT+02:00 James Almer : > On 10/1/2017 8:18 PM, Carl Eugen Hoyos wrote: >> 2017-10-02 0:55 GMT+02:00 James Almer : >>> Do it during install instead, like with the libraries. >>> >>> There's no benefit making a stripped copy of the CLI tools in the >>> build folder. Doing it during i

Re: [FFmpeg-devel] [PATCH] build: don't strip binaries during compilation

2017-10-01 Thread James Almer
On 10/1/2017 8:18 PM, Carl Eugen Hoyos wrote: > 2017-10-02 0:55 GMT+02:00 James Almer : >> Do it during install instead, like with the libraries. >> >> There's no benefit making a stripped copy of the CLI tools in the >> build folder. Doing it during install saves build time and storage >> space. >

[FFmpeg-devel] [PATCH]lavf/img2dec: Auto-detect svg images

2017-10-01 Thread Carl Eugen Hoyos
Hi! Attached patch implements auto-detection of svg images. Please review, Carl Eugen From f06137f38f166740565e58d5c7c88777508f59ec Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 2 Oct 2017 01:13:29 +0200 Subject: [PATCH] lavf/img2dec: Auto-detect svg images. --- libavformat/img2de

Re: [FFmpeg-devel] [PATCH] build: don't strip binaries during compilation

2017-10-01 Thread Carl Eugen Hoyos
2017-10-02 0:55 GMT+02:00 James Almer : > Do it during install instead, like with the libraries. > > There's no benefit making a stripped copy of the CLI tools in the > build folder. Doing it during install saves build time and storage > space. This makes it much more difficult to request backtrac

[FFmpeg-devel] [PATCH] build: don't strip binaries during compilation

2017-10-01 Thread James Almer
Do it during install instead, like with the libraries. There's no benefit making a stripped copy of the CLI tools in the build folder. Doing it during install saves build time and storage space. Signed-off-by: James Almer --- FATE slots will love this, especially those running on disk space depr

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-10-01 Thread pkv.stream
Le 02/10/2017 à 12:43 AM, Carl Eugen Hoyos a écrit : 2017-10-02 0:40 GMT+02:00 pkv.stream : Hi atomnuker, got your PCE working; the patch you attached contains tabs, they cannot be committed to the FFmpeg repository, please remove them. (Or one tab.) thanks for pointing out. Removed the offe

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-10-01 Thread Carl Eugen Hoyos
2017-10-02 0:40 GMT+02:00 pkv.stream : > Hi atomnuker, > > got your PCE working; the patch you attached contains tabs, they cannot be committed to the FFmpeg repository, please remove them. (Or one tab.) Thank you, Carl Eugen ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-10-01 Thread pkv.stream
Hi atomnuker, got your PCE working; my previous issues where index related and were the reasons ffmpeg aac decoder would issue errors. So found out: - index is not reset between groups of front, side, back; - it runs actually for each type (SCE, CPE, LFE) - for ffmpeg aac decoder to work, the

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: deprecate av_copy_packet_side_data()

2017-10-01 Thread James Almer
On 9/25/2017 5:20 PM, James Almer wrote: > It leaks memory and destroys the dst packet in case of failure, and it > ultimately duplicates functionality already existing in the saner > av_packet_copy_props(). > > Signed-off-by: James Almer > --- > libavcodec/avcodec.h | 3 +++ > 1 file changed, 3

Re: [FFmpeg-devel] libavcodec/exr : add x86 SIMD for predictor

2017-10-01 Thread James Almer
On 10/1/2017 4:52 PM, Martin Vignali wrote: > Hello, > > in attach new patch > > pass fate test for me (X86_64 osX) > > Check asm (Kaby Lake) > > checkasm: all 5 tests passed > predictor_c: 11042.9 > predictor_ssse3: 1736.4 > predictor_avx: 1675.4 > predictor_avx2: 1245.4 > ... > > Martin Pus

Re: [FFmpeg-devel] [RFC] fate/cineform : add test for yuv 10b

2017-10-01 Thread Carl Eugen Hoyos
2017-09-25 11:46 GMT+02:00 Martin Vignali : >> >> >> Yes. >> >> Or we could switch now to a file that we know we will have >> to add. >> No strong opinion here: I just wanted to point out that we >> will need another sample - that we already have. I wonder >> if keeping the size of fate small(er) i

Re: [FFmpeg-devel] libavcodec/exr : add x86 SIMD for predictor

2017-10-01 Thread Martin Vignali
Hello, in attach new patch pass fate test for me (X86_64 osX) Check asm (Kaby Lake) checkasm: all 5 tests passed predictor_c: 11042.9 predictor_ssse3: 1736.4 predictor_avx: 1675.4 predictor_avx2: 1245.4 ... Martin 0001-libavcodec-exr-add-x86-SIMD-for-predictor.patch Description: Binary data

Re: [FFmpeg-devel] [PATCH] avfilter: add vmafmotion filter

2017-10-01 Thread Carl Eugen Hoyos
2017-10-01 20:44 GMT+02:00 Ronald S. Bultje : > Hi, > > On Sun, Oct 1, 2017 at 12:17 PM, Carl Eugen Hoyos > wrote: > >> 2017-10-01 14:03 GMT+02:00 Ronald S. Bultje : >> > Hi, >> > >> > On Sat, Sep 30, 2017 at 3:40 PM, Carl Eugen Hoyos >> > wrote: >> >> >> Attached patch also support GBRP, I don't

Re: [FFmpeg-devel] [PATCH] avfilter: add vmafmotion filter

2017-10-01 Thread Ronald S. Bultje
Hi, On Sun, Oct 1, 2017 at 12:17 PM, Carl Eugen Hoyos wrote: > 2017-10-01 14:03 GMT+02:00 Ronald S. Bultje : > > Hi, > > > > On Sat, Sep 30, 2017 at 3:40 PM, Carl Eugen Hoyos > > wrote: > > >> Attached patch also support GBRP, I don't know if this is a good or > >> bad idea. > > > > I would per

[FFmpeg-devel] [PATCH 2/2] mov: fix non-monotonous DTS when fragments overlap in time

2017-10-01 Thread John Stebbins
--- libavformat/mov.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index c7422cd9ed..bc3c9cb35b 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4267,6 +4267,7 @@ static int mov_read_trun(MOVContext *c, AVIOCo

Re: [FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC

2017-10-01 Thread Carl Eugen Hoyos
2017-09-29 5:38 GMT+02:00 Jeyapal, Karthick : >>On 9/29/17, 7:36 AM, "James Almer" wrote: >>> >>> +static inline uint16_t parity (uint16_t x) >>> +{ >>> +uint16_t i; >>> +for (i = 4 * sizeof (x); i > 0; i /= 2) >>> +x ^= x >> i; >>> +return x & 1; >>> +} >> >>Can't you use av_p

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/dvbsubdec: Split best score computation out of loop in compute_default_clut()

2017-10-01 Thread Clément Bœsch
On Sun, Oct 01, 2017 at 06:10:36PM +0200, Michael Niedermayer wrote: > 3% faster > > Signed-off-by: Michael Niedermayer > --- > libavcodec/dvbsubdec.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/dvbsubdec.c b/libavcodec/dvbsubdec.c > index 6a40f2

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dvbsubdec: Factor a few expressions out of compute_default_clut()

2017-10-01 Thread Clément Bœsch
On Sun, Oct 01, 2017 at 06:10:35PM +0200, Michael Niedermayer wrote: > 32% faster loop > > Signed-off-by: Michael Niedermayer > --- > libavcodec/dvbsubdec.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/dvbsubdec.c b/libavcodec/dvbsubdec.c

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-10-01 Thread Carl Eugen Hoyos
2017-09-27 18:08 GMT+02:00 Carl Eugen Hoyos : > The existing amr demuxer does not allow reading streams, > it requires the 3GPP-conforming file header. > Attached patch allows reading amrnb and amrwb from (live) > streams, fixes ticket #6678. New patch with auto-detection attached, passes probech

Re: [FFmpeg-devel] [PATCH] avfilter: add vmafmotion filter

2017-10-01 Thread Carl Eugen Hoyos
2017-10-01 14:03 GMT+02:00 Ronald S. Bultje : > Hi, > > On Sat, Sep 30, 2017 at 3:40 PM, Carl Eugen Hoyos > wrote: >> Attached patch also support GBRP, I don't know if this is a good or >> bad idea. > > I would personally probably err on the side of caution, but no strong > opinions. If this work

[FFmpeg-devel] [PATCH 1/2] avcodec/dvbsubdec: Factor a few expressions out of compute_default_clut()

2017-10-01 Thread Michael Niedermayer
32% faster loop Signed-off-by: Michael Niedermayer --- libavcodec/dvbsubdec.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavcodec/dvbsubdec.c b/libavcodec/dvbsubdec.c index b683109643..6a40f2376f 100644 --- a/libavcodec/dvbsubdec.c +++ b/libavcodec/dvb

[FFmpeg-devel] [PATCH 2/2] avcodec/dvbsubdec: Split best score computation out of loop in compute_default_clut()

2017-10-01 Thread Michael Niedermayer
3% faster Signed-off-by: Michael Niedermayer --- libavcodec/dvbsubdec.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/dvbsubdec.c b/libavcodec/dvbsubdec.c index 6a40f2376f..e60bf41936 100644 --- a/libavcodec/dvbsubdec.c +++ b/libavcodec/dvbsubdec.c @@ -6

Re: [FFmpeg-devel] [PATCH V2 2/2] lavc/vaapi_decode: fix profile search when disable exact profile match.

2017-10-01 Thread Mark Thompson
On 29/09/17 02:58, Jun Zhao wrote: > From 94604d623de1fec6f363dcda4d61712865257a0a Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Thu, 21 Sep 2017 02:44:42 -0400 > Subject: [PATCH V2 2/2] lavc/vaapi_decode: fix profile search when disable > exact profile match. > > when disable exact profile,

Re: [FFmpeg-devel] libavcodec/exr : add x86 SIMD for predictor

2017-10-01 Thread James Almer
On 10/1/2017 11:35 AM, Henrik Gramner wrote: > On Sun, Oct 1, 2017 at 4:14 PM, James Almer wrote: >> We normally use int for counters, and don't mix declaration and statements. >> And in any case ptrdiff_t would be "more correct" for this. > > Ah right. C90, ugh. Too used to C99. No, we're c99.

[FFmpeg-devel] [PATCH] avdevice/decklink_dec: fix multipacket op47 decoding

2017-10-01 Thread Marton Balint
It was disabled by mistake. Signed-off-by: Marton Balint --- libavdevice/decklink_dec.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 9f6c4598ba..cbad4d6ee2 100644 --- a/libavdevice/decklink_dec.cpp +++ b/l

Re: [FFmpeg-devel] [PATCH V2 1/2] ffmpeg: re-enable hwaccel_lax_profile_check use hwaccel_flags.

2017-10-01 Thread Mark Thompson
On 29/09/17 02:58, Jun Zhao wrote: > From e2a7cce88d2a47c7e598b59d24258fea8d809c22 Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Thu, 21 Sep 2017 02:41:29 -0400 > Subject: [PATCH V2 1/2] ffmpeg: re-enable hwaccel_lax_profile_check use > hwaccel_flags. > > re-enable hwaccel_lax_profile_check

Re: [FFmpeg-devel] libavcodec/exr : add x86 SIMD for predictor

2017-10-01 Thread Henrik Gramner
On Sun, Oct 1, 2017 at 4:14 PM, James Almer wrote: > We normally use int for counters, and don't mix declaration and statements. > And in any case ptrdiff_t would be "more correct" for this. Ah right. C90, ugh. Too used to C99. Yeah, feel free to use whatever datatype that's most appropriate for

Re: [FFmpeg-devel] libavcodec/exr : add x86 SIMD for predictor

2017-10-01 Thread James Almer
On 10/1/2017 9:47 AM, Henrik Gramner wrote: > On Fri, Sep 22, 2017 at 11:12 PM, Martin Vignali > wrote: >> +static void predictor_scalar(uint8_t *src, ptrdiff_t size) >> +{ >> +uint8_t *t= src + 1; >> +uint8_t *stop = src + size; >> + >> +while (t < stop) { >> +int d = (int

Re: [FFmpeg-devel] libavcodec/exr : add x86 SIMD for predictor

2017-10-01 Thread Henrik Gramner
On Fri, Sep 22, 2017 at 11:12 PM, Martin Vignali wrote: > +static void predictor_scalar(uint8_t *src, ptrdiff_t size) > +{ > +uint8_t *t= src + 1; > +uint8_t *stop = src + size; > + > +while (t < stop) { > +int d = (int) t[-1] + (int) t[0] - 128; > +t[0] = d; > +

Re: [FFmpeg-devel] [PATCH] avfilter: add vmafmotion filter

2017-10-01 Thread Ronald S. Bultje
Hi, On Sat, Sep 30, 2017 at 3:40 PM, Carl Eugen Hoyos wrote: > 2017-09-30 20:30 GMT+02:00 Ronald S. Bultje : > > Hi Carl, > > > > On Sat, Sep 30, 2017 at 2:19 PM, Carl Eugen Hoyos > > wrote: > > > >> 2017-09-30 19:47 GMT+02:00 Ronald S. Bultje : > >> > Hi Carl, > >> > > >> > On Sat, Sep 30, 201

Re: [FFmpeg-devel] libavcodec/exr : add x86 SIMD for predictor

2017-10-01 Thread Martin Vignali
2017-09-22 23:12 GMT+02:00 Martin Vignali : > Hello, > > in attach a patch > with a port to asm of the predictor part of this patch : > > https://github.com/openexr/openexr/pull/229/commits/ > 4198128397c033d4f69e5cc0833195da500c31cf > > Tested on OSX, pass fate test for me > Check asm also pass f