Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

On Wed, 14 Feb 2018 00:11:32 -0300 James Almer wrote: > > --- > > libavcodec/avpacket.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c > > index 90b8215928..1a9be60e20 100644 > > --- a/libavcodec/avpacket.c > >

Re: [FFmpeg-devel] [PATCH] avformat/aviobuf: zero initialize the AVIOContext in ffio_init_context()

On Tue, 13 Feb 2018 22:27:49 -0300 James Almer wrote: > This makes sure no field is ever used uninitialized. > > Signed-off-by: James Almer > --- > I think i prefer this one. > > libavformat/aviobuf.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: remove unnecessary calls to ff_init_buffer_info()

On Tue, 13 Feb 2018 21:18:00 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > Tested with FATE using one and four threads, frame and slice. > > libavcodec/decode.c| 2 -- > libavcodec/pthread_frame.c | 2 -- > libavcodec/smvjpegdec.c

Re: [FFmpeg-devel] [PATCH] avcodec: remove av_codec_init_static()

On Wed, 14 Feb 2018 07:07:09 +0700 Muhammad Faiz wrote: > On Tue, Feb 13, 2018 at 3:57 AM, wm4 wrote: > > On Mon, 12 Feb 2018 12:42:10 +0700 > > Muhammad Faiz wrote: > > > >> Modify the behavior of init_static_data(). > >> > >>

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mpegenc - accept PCM_DVD streams

On 2/14/2018 3:59 AM, Michael Niedermayer wrote: On Mon, Jan 29, 2018 at 06:53:06PM +0530, Gyan Doshi wrote: On 1/29/2018 3:47 PM, Carl Eugen Hoyos wrote: How did you test this patch? By remuxing with patched ffmpeg and then checking with ffprobe, but not ffplay! muxer side changes

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

On 2/14/2018 12:22 AM, Yusuke Nakamura wrote: > 2018-02-14 12:11 GMT+09:00 James Almer : > >> On 2/13/2018 11:43 PM, Yusuke Nakamura wrote: >>> This makes you need not call av_init_packet before av_packet_copy_props >> like the following. >>> >>> AVPacket dst; >>>

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-14 12:11 GMT+09:00 James Almer : > On 2/13/2018 11:43 PM, Yusuke Nakamura wrote: > > This makes you need not call av_init_packet before av_packet_copy_props > like the following. > > > > AVPacket dst; > > av_packet_copy_props(, ); > > In this scenario, dst->side_data is

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

On 2/13/2018 11:43 PM, Yusuke Nakamura wrote: > This makes you need not call av_init_packet before av_packet_copy_props like > the following. > > AVPacket dst; > av_packet_copy_props(, ); In this scenario, dst->side_data is uninitialized, and bad things can happen when av_packet_copy_props

[FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

This makes you need not call av_init_packet before av_packet_copy_props like the following. AVPacket dst; av_packet_copy_props(, ); --- libavcodec/avpacket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index 90b8215928..1a9be60e20 100644 ---

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: add support for low-power encoding

>-Original Message- >From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of >Mark Thompson >Sent: Wednesday, February 14, 2018 2:58 AM >To: ffmpeg-devel@ffmpeg.org >Subject: Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: add support >for low-power encoding > >On

[FFmpeg-devel] [PATCH] avformat/aviobuf: zero initialize the AVIOContext in ffio_init_context()

This makes sure no field is ever used uninitialized. Signed-off-by: James Almer --- I think i prefer this one. libavformat/aviobuf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index

[FFmpeg-devel] [PATCH] avformat/aviobuf: initialize all checksum fields

Calling ffio_ensure_seekback() right after initializing an AVIOContext with ffio_init_context() would result in a use of uninitialised value. Fixes fate-adts-id3v2-demux when using valgrind. Signed-off-by: James Almer --- Maybe we should do a memset(s, 0, sizeof(*s)) at the

[FFmpeg-devel] [PATCH 2/2] avcodec/decode: remove ff_init_buffer_info()

It's a duplicate function. This reduces differences with libav. Signed-off-by: James Almer --- libavcodec/decode.c | 9 ++--- libavcodec/internal.h | 6 -- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c

[FFmpeg-devel] [PATCH 1/2] avcodec: remove unnecessary calls to ff_init_buffer_info()

Signed-off-by: James Almer --- Tested with FATE using one and four threads, frame and slice. libavcodec/decode.c| 2 -- libavcodec/pthread_frame.c | 2 -- libavcodec/smvjpegdec.c| 1 - 3 files changed, 5 deletions(-) diff --git a/libavcodec/decode.c

Re: [FFmpeg-devel] [PATCH]lavf/rtpdec*: Constify all RTPDynamicProtocolHandler

2018-02-14 1:00 GMT+01:00 Muhammad Faiz : > On Tue, Feb 13, 2018 at 4:22 AM, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch marks the RTPDynamicProtocolHandler as const. >> >> Please comment, Carl Eugen >> >> From e219322aa7396db6ecb6ab02fd5b42b42271f27f

Re: [FFmpeg-devel] Fix stts_data memory allocation

"unsigned" is perfectly fine. Just trying to be consistent with the line above. On Tue, Feb 13, 2018 at 4:06 PM, Carl Eugen Hoyos wrote: > 2018-02-13 23:48 GMT+01:00 Xiaohan Wang (王消寒) : > > Thank you for the fix! > (What's wrong with "unsigned"?) > >

Re: [FFmpeg-devel] Fix stts_data memory allocation

2018-02-13 23:48 GMT+01:00 Xiaohan Wang (王消寒) : Thank you for the fix! (What's wrong with "unsigned"?) Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavf/rtpdec*: Constify all RTPDynamicProtocolHandler

On Tue, Feb 13, 2018 at 4:22 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch marks the RTPDynamicProtocolHandler as const. > > Please comment, Carl Eugen > > From e219322aa7396db6ecb6ab02fd5b42b42271f27f Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH] avcodec: remove av_codec_init_static()

On Tue, Feb 13, 2018 at 3:57 AM, wm4 wrote: > On Mon, 12 Feb 2018 12:42:10 +0700 > Muhammad Faiz wrote: > >> Modify the behavior of init_static_data(). >> >> Signed-off-by: Muhammad Faiz >> --- > > Seems OK, but I'm also not sure about

Re: [FFmpeg-devel] [PATCH] avcodec: remove av_codec_init_static()

On Tue, Feb 13, 2018 at 2:40 AM, James Almer wrote: > On 2/12/2018 2:42 AM, Muhammad Faiz wrote: >> Modify the behavior of init_static_data(). >> >> Signed-off-by: Muhammad Faiz >> --- >> libavcodec/allcodecs.c | 16 >> libavcodec/avcodec.h

Re: [FFmpeg-devel] Abort early on decode_slice error

On Tue, Feb 13, 2018 at 12:24:41PM -0800, Xiaohan Wang (王消寒) wrote: > New patch as discussed offline: > > > > On Sat, Feb 3, 2018 at 2:29 AM, Xiaohan Wang (王消寒) > wrote: > > > > > > h264_cavlc.c |1 + > 1 file changed, 1 insertion(+) >

[FFmpeg-devel] [PATCH] avcodec/h264_cabac: Tighten allowed coeff_abs range

Fixes: integer overflows Reported-by: "Xiaohan Wang (王消寒)" Based on limits in "8.5 Transform coefficient decoding process and picture construction process prior to deblocking filter process" --- libavcodec/h264_cabac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[FFmpeg-devel] Fix stts_data memory allocation

From 241d5e45eb8750521d07d07aa55ea637359ab55d Mon Sep 17 00:00:00 2001 From: Xiaohan Wang Date: Tue, 13 Feb 2018 14:45:14 -0800 Subject: [PATCH] ffmpeg: Fix stts_data memory allocation In this loop, |i| is the "index". And the memory allocated should be at least the current

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mpegenc - accept PCM_DVD streams

On Mon, Jan 29, 2018 at 06:53:06PM +0530, Gyan Doshi wrote: > > On 1/29/2018 3:47 PM, Carl Eugen Hoyos wrote: > > >How did you test this patch? > > By remuxing with patched ffmpeg and then checking with ffprobe, but not > ffplay! muxer side changes should be tested against something else than

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mpegenc - accept PCM_DVD streams

On Tue, Feb 13, 2018 at 12:36:15AM +0530, Gyan Doshi wrote: > > On 2/3/2018 3:59 AM, Michael Niedermayer wrote: > > >>Subject: [PATCH v2] avformat/mpegenc - accept PCM_DVD streams > >> > >>PCM_S16BE stream packets in MPEG-PS have a 3-byte header > >>and recognized as PCM_DVD by the demuxer which

Re: [FFmpeg-devel] Abort early on decode_slice error

New patch as discussed offline: On Sat, Feb 3, 2018 at 2:29 AM, Xiaohan Wang (王消寒) wrote: > > From e8ad6159640c913773583a8b551ecebcff6b9c63 Mon Sep 17 00:00:00 2001 From: Xiaohan Wang Date: Sat, 3 Feb 2018 01:43:35 -0800 Subject: [PATCH] ffmpeg: Set

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: Don't pass VAConfigAttribEncPackedHeaders with value set to 0

On 13/02/18 18:52, Mark Thompson wrote: > On 13/02/18 08:24, Haihao Xiang wrote: >> Recent Intel i965 driver commit strictly disallows application to set >> unsupported attribute values, VA_ENC_PACKED_HEADER_NONE (0) is not used >> in Intel i965 driver, so application shouldn't pass this value to

Re: [FFmpeg-devel] [PATCH 1/3] Add libcodec2 en/decoder

tis 2018-02-13 klockan 19:02 +0100 skrev Michael Niedermayer: > On Fri, Jan 12, 2018 at 11:32:30AM +0100, Tomas Härdin wrote: > > ping? > > breaks the recently (after teh patchset) added fate-codec_desc Hrm, a good excuse to set up and dig into how FATE works. I want to add some tests of my own

Re: [FFmpeg-devel] [PATCH] avformat/pcm: decrease delay when reading PCM streams.

On Tue, 13 Feb 2018, Philipp M. Scholl wrote: The blocksize of the PCM decoder is hard-coded. This creates unnecessary delay when reading low-rate (<100Hz) streams. This creates issues when multiplexing multiple streams, since other inputs are only opened/read after a low-rate input block was

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: add support for low-power encoding

On 09/02/18 01:23, Xiang, Haihao wrote: > >> On 06/02/18 08:17, Haihao Xiang wrote: >>> Although VAEntrypointEncSliceLP was added in old version of VAAPI, we >>> never implemented it for VAAPI H265 encoder before. so it is reasonable >>> to require VAAPI 1.0 >>> >>> Signed-off-by: Haihao Xiang

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: Don't pass VAConfigAttribEncPackedHeaders with value set to 0

On 13/02/18 08:24, Haihao Xiang wrote: > Recent Intel i965 driver commit strictly disallows application to set > unsupported attribute values, VA_ENC_PACKED_HEADER_NONE (0) is not used > in Intel i965 driver, so application shouldn't pass this value to the > driver. On the other hand,

Re: [FFmpeg-devel] [PATCH 1/3] mpegvideo_parser: implement parsing of the picture structure field

On Tue, Feb 13, 2018 at 08:39:09PM +0200, Jan Ekström wrote: > On Tue, Feb 13, 2018 at 2:13 PM, Michael Niedermayer > wrote: > > ... > > If there are 2 fields in a packet that can be as 2 field pictures or > > as a interlaced frame coded in a way thats inseperable. Then

Re: [FFmpeg-devel] [PATCH 1/3] mpegvideo_parser: implement parsing of the picture structure field

On Tue, Feb 13, 2018 at 2:13 PM, Michael Niedermayer wrote: > ... > If there are 2 fields in a packet that can be as 2 field pictures or > as a interlaced frame coded in a way thats inseperable. Then you have > 2 timestamps really and might have information associated with

Re: [FFmpeg-devel] [PATCH 1/3] Add libcodec2 en/decoder

On Fri, Jan 12, 2018 at 11:32:30AM +0100, Tomas Härdin wrote: > ping? breaks the recently (after teh patchset) added fate-codec_desc [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are best at talking, realize last or never when they are wrong.

[FFmpeg-devel] [PATCH v3 6/8] lavfi/silencedetect: Fix missing log at eos

From: nicolas gaullier Fixes ticket #6968 --- libavfilter/af_silencedetect.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/libavfilter/af_silencedetect.c b/libavfilter/af_silencedetect.c index

Re: [FFmpeg-devel] [PATCH v2 6/8] avfilter/silencedetect: fix for ticket 6968 Fix missing log of silence_end at end of stream

> +av_ts2timestr(duration_ts, _base)); ^ this does not build, and looks like a typo Sorry, this is ugly, I had indeed replaced manually two occurrences (s->time_base => _base) at the last minute just before sending

Re: [FFmpeg-devel] [PATCH v2 6/8] avfilter/silencedetect: fix for ticket 6968 Fix missing log of silence_end at end of stream

On Mon, Feb 12, 2018 at 10:48:28AM +0100, Nicolas Gaullier wrote: > From: nicolas gaullier > > --- > libavfilter/af_silencedetect.c | 33 +++-- > 1 file changed, 27 insertions(+), 6 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] avformat/pcm: decrease delay when reading PCM streams.

tis 2018-02-13 klockan 15:11 +0100 skrev Philipp M. Scholl: >  The blocksize of the PCM decoder is hard-coded. This creates >  unnecessary delay when reading low-rate (<100Hz) streams. This creates > issues when multiplexing multiple streams, since other inputs are only > opened/read after a

Re: [FFmpeg-devel] [PATCH] avformat/pcm: decrease delay when reading PCM streams.

On Tue, Feb 13, 2018 at 3:11 PM, Philipp M. Scholl wrote: > The blocksize of the PCM decoder is hard-coded. This creates > unnecessary delay when reading low-rate (<100Hz) streams. This creates > issues when multiplexing multiple streams, since other inputs are only >

[FFmpeg-devel] [PATCH] avformat/pcm: decrease delay when reading PCM streams.

The blocksize of the PCM decoder is hard-coded. This creates unnecessary delay when reading low-rate (<100Hz) streams. This creates issues when multiplexing multiple streams, since other inputs are only opened/read after a low-rate input block was completely read. This patch decreases the

Re: [FFmpeg-devel] [PATCH] libavfilter : cuda linkage changed for vf_scale_cuda & vf_thumbnail_cuda

On 13.02.2018 12:38, Hendrik Leppkes wrote: > On Tue, Feb 13, 2018 at 12:31 PM, Roman Arzumanyan > wrote: >> Please find attached the patch that introduces structure to store CUDA >> function pointers to be used within scale & thumbnail filters. >> > > The entire point

Re: [FFmpeg-devel] [PATCH 1/3] Fix computation of vs->start_pos

On Mon, Feb 12, 2018 at 02:23:07PM +0530, Amit Kale wrote: > Reset vs->start_pos when beginning a new file. > --- >  libavformat/hlsenc.c | 5 - >  1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index cc13c94e97..9970c4c575 100644

Re: [FFmpeg-devel] [PATCH 1/3] mpegvideo_parser: implement parsing of the picture structure field

Hi On Mon, Feb 12, 2018 at 03:13:46AM +0200, Jan Ekström wrote: > On Mon, Feb 12, 2018 at 12:23 AM, Michael Niedermayer > wrote: > > > > I think a better API is needed to export the picture_structure correctly. > > > > I might be misunderstanding the problem at hand, but

Re: [FFmpeg-devel] [PATCH] libavfilter : cuda linkage changed for vf_scale_cuda & vf_thumbnail_cuda

On Tue, Feb 13, 2018 at 12:31 PM, Roman Arzumanyan wrote: > Please find attached the patch that introduces structure to store CUDA > function pointers to be used within scale & thumbnail filters. > The entire point of our dynlink_cuda.h was to not include the full

Re: [FFmpeg-devel] fate/exr : add test for ticket 6994 (long name flag)

2018-02-09 9:22 GMT+01:00 Martin Vignali : > Hello, > > Patch in attach add test for ticket 6994 (flag long name) > > Sample can be found here : > https://we.tl/WBnt10VSA1 > > and need to be put inside ./fate-suite/exr > > Can be test with : > make fate-exr

[FFmpeg-devel] [PATCH] libavfilter : cuda linkage changed for vf_scale_cuda & vf_thumbnail_cuda

Please find attached the patch that introduces structure to store CUDA function pointers to be used within scale & thumbnail filters. -- BR, Roman Arzumanyan --- This email message is for the sole use of the

Re: [FFmpeg-devel] Purely synthetic PTS and DTS...

sön 2018-02-11 klockan 17:44 -0500 skrev Tony Di Croce: > I have video frames in a buffer in memory... and I know their frame > rate > (and other information like resolution, etc)... I am attempting to > mux this > video into an mp4... But I don't know how to set PTS/DTS > appropriately. I > have

Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

fre 2018-02-09 klockan 11:29 +0100 skrev Carl Eugen Hoyos: > 2018-01-15 22:36 GMT+01:00 Tomas Härdin : > > > > +if (p->buf[4] >  EXPECTED_CODEC2_MINOR_VERSION) score -= > > > AVPROBE_SCORE_MAX/5; > > > +if (p->buf[5] >  AVPRIV_CODEC2_MODE_MAX)score -= > > >

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h265: add support for low-power encoding

> > On 06/02/18 08:17, Haihao Xiang wrote: > > > Although VAEntrypointEncSliceLP was added in old version of VAAPI, we > > > never implemented it for VAAPI H265 encoder before. so it is reasonable > > > to require VAAPI 1.0 > > > > > > Signed-off-by: Haihao Xiang > > >

[FFmpeg-devel] [PATCH] lavc/vaapi_encode: Don't pass VAConfigAttribEncPackedHeaders with value set to 0

Recent Intel i965 driver commit strictly disallows application to set unsupported attribute values, VA_ENC_PACKED_HEADER_NONE (0) is not used in Intel i965 driver, so application shouldn't pass this value to the driver. On the other hand, VA_ENC_PACKED_HEADER_NONE (0) means the driver doesn't

[FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: Return AVERROR(ENOSYS)

The corresponding feature is not implemented for old versions of VA-API, the returned value should be AVERROR(ENOSYS) Signed-off-by: Haihao Xiang --- libavcodec/vaapi_encode_h264.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH] avcodec: remove Libav ABI compatibility hacks

On Tue, Feb 13, 2018 at 6:45 AM, wm4 wrote: > On Tue, 13 Feb 2018 02:04:18 -0300 > James Almer wrote: > >> On 2/13/2018 1:50 AM, wm4 wrote: >> > On Tue, 13 Feb 2018 01:44:22 -0300 >> > James Almer wrote: >> > >> >> On 2/13/2018 1:33