Re: [FFmpeg-devel] [PATCH] avcodec/ffv1: Support for GBRAP10 and GBRAP12

2018-02-14 Thread Michael Niedermayer
On Wed, Feb 14, 2018 at 09:48:20AM +0100, Jerome Martinez wrote: > Add support for 10- and 12-bit/component RGB with Alpha encoding and > decoding in FFV1. > > Benched with START/STOP_TIMER around "for (x = 0; x < w; x++)" part during > decoding, before the previous patch and with the previous pat

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mpegenc - accept PCM_DVD streams

2018-02-14 Thread Michael Niedermayer
On Tue, Feb 13, 2018 at 12:36:15AM +0530, Gyan Doshi wrote: > > On 2/3/2018 3:59 AM, Michael Niedermayer wrote: > > >>Subject: [PATCH v2] avformat/mpegenc - accept PCM_DVD streams > >> > >>PCM_S16BE stream packets in MPEG-PS have a 3-byte header > >>and recognized as PCM_DVD by the demuxer which

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mpegenc - accept PCM_DVD streams

2018-02-14 Thread Michael Niedermayer
On Tue, Feb 13, 2018 at 12:33:56AM +0530, Gyan Doshi wrote: > > On 2/3/2018 4:02 AM, Michael Niedermayer wrote: > > >>--- a/libavformat/mpegenc.c > >>+++ b/libavformat/mpegenc.c > > >>+ > >>+if (st->codecpar->codec_id == AV_CODEC_ID_PCM_DVD) { > >>+/* Skip first 3 bytes of packet dat

Re: [FFmpeg-devel] [PATCH v2] avformat/pcm: decrease delay when reading PCM streams.

2018-02-14 Thread Michael Niedermayer
On Wed, Feb 14, 2018 at 03:11:54PM +0100, Philipp M. Scholl wrote: > Hi there, > > thanks for the feedback. I made the following changes to the patch: > > - hard-code to 40ms delay. Wasn't really sure what a good value is. But given >that the is mainly for encoding low-rate sensor data in a

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-14 Thread James Almer
On 2/14/2018 8:13 PM, wm4 wrote: > On Wed, 14 Feb 2018 19:59:32 -0300 > James Almer wrote: > >> On 2/14/2018 7:54 PM, wm4 wrote: >>> On Wed, 14 Feb 2018 18:57:37 -0300 >>> James Almer wrote: >>> On 2/14/2018 4:21 PM, wm4 wrote: > On Wed, 14 Feb 2018 13:14:19 -0300 > James Almer

Re: [FFmpeg-devel] [PATCH] avformat/aviobuf: zero initialize the AVIOContext in ffio_init_context()

2018-02-14 Thread James Almer
On 2/14/2018 2:29 PM, James Almer wrote: > On 2/14/2018 2:17 AM, wm4 wrote: >> On Tue, 13 Feb 2018 22:27:49 -0300 >> James Almer wrote: >> >>> This makes sure no field is ever used uninitialized. >>> >>> Signed-off-by: James Almer >>> --- >>> I think i prefer this one. >>> >>> libavformat/aviobu

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: remove unnecessary calls to ff_init_buffer_info()

2018-02-14 Thread James Almer
On 2/14/2018 2:15 AM, wm4 wrote: > On Tue, 13 Feb 2018 21:18:00 -0300 > James Almer wrote: > >> Signed-off-by: James Almer >> --- >> Tested with FATE using one and four threads, frame and slice. >> >> libavcodec/decode.c| 2 -- >> libavcodec/pthread_frame.c | 2 -- >> libavcodec/smvjpeg

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-14 Thread wm4
On Wed, 14 Feb 2018 19:59:32 -0300 James Almer wrote: > On 2/14/2018 7:54 PM, wm4 wrote: > > On Wed, 14 Feb 2018 18:57:37 -0300 > > James Almer wrote: > > > >> On 2/14/2018 4:21 PM, wm4 wrote: > >>> On Wed, 14 Feb 2018 13:14:19 -0300 > >>> James Almer wrote: > >>> > On 2/14/2018

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-14 Thread James Almer
On 2/14/2018 7:54 PM, wm4 wrote: > On Wed, 14 Feb 2018 18:57:37 -0300 > James Almer wrote: > >> On 2/14/2018 4:21 PM, wm4 wrote: >>> On Wed, 14 Feb 2018 13:14:19 -0300 >>> James Almer wrote: >>> On 2/14/2018 2:25 AM, wm4 wrote: > On Wed, 14 Feb 2018 00:11:32 -0300 > James Almer

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-14 Thread wm4
On Wed, 14 Feb 2018 18:57:37 -0300 James Almer wrote: > On 2/14/2018 4:21 PM, wm4 wrote: > > On Wed, 14 Feb 2018 13:14:19 -0300 > > James Almer wrote: > > > >> On 2/14/2018 2:25 AM, wm4 wrote: > >>> On Wed, 14 Feb 2018 00:11:32 -0300 > >>> James Almer wrote: > >>> > > --- > >

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-14 Thread James Almer
On 2/14/2018 4:21 PM, wm4 wrote: > On Wed, 14 Feb 2018 13:14:19 -0300 > James Almer wrote: > >> On 2/14/2018 2:25 AM, wm4 wrote: >>> On Wed, 14 Feb 2018 00:11:32 -0300 >>> James Almer wrote: >>> > --- > libavcodec/avpacket.c | 1 + > 1 file changed, 1 insertion(+) > > dif

Re: [FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread wm4
On Wed, 14 Feb 2018 16:22:12 +0100 Nicolas George wrote: > Tomas Härdin (2018-02-14): > >Devs that work on companies that need > > the proprietary stuff that is. It's always a tradeoff. > > Devs that work on companies that need the proprietary stuff could ma

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-14 Thread wm4
On Wed, 14 Feb 2018 13:14:19 -0300 James Almer wrote: > On 2/14/2018 2:25 AM, wm4 wrote: > > On Wed, 14 Feb 2018 00:11:32 -0300 > > James Almer wrote: > > > >>> --- > >>> libavcodec/avpacket.c | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/libavcodec/avpacket.c b/libavc

[FFmpeg-devel] GSOC mentored project : Super Resolution filter

2018-02-14 Thread Shivam Saboo
Hi Dev-Community, I am Shivam Saboo from India. I am pursuing B.Tech in Computer Science and Engineering at Indian Institute of Information Technology, Vadodara. I am new to FFmpeg and wish to contribute as a GSoC applicant this year. I am very interested in Deep Learning especially in the field

Re: [FFmpeg-devel] [PATCH] avformat/aviobuf: zero initialize the AVIOContext in ffio_init_context()

2018-02-14 Thread James Almer
On 2/14/2018 2:17 AM, wm4 wrote: > On Tue, 13 Feb 2018 22:27:49 -0300 > James Almer wrote: > >> This makes sure no field is ever used uninitialized. >> >> Signed-off-by: James Almer >> --- >> I think i prefer this one. >> >> libavformat/aviobuf.c | 4 +++- >> 1 file changed, 3 insertions(+), 1

Re: [FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread Hendrik Leppkes
On Wed, Feb 14, 2018 at 4:22 PM, Nicolas George wrote: > Tomas Härdin (2018-02-14): >> Devs that work on companies that need >> the proprietary stuff that is. It's always a tradeoff. > > Devs that work on companies that need the proprietary stuff could make > u

Re: [FFmpeg-devel] [PATCH] avpacket: Set dst->side_data_elems to 0 within av_packet_copy_props.

2018-02-14 Thread James Almer
On 2/14/2018 2:25 AM, wm4 wrote: > On Wed, 14 Feb 2018 00:11:32 -0300 > James Almer wrote: > >>> --- >>> libavcodec/avpacket.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c >>> index 90b8215928..1a9be60e20 100644 >>> --- a/libavcodec

Re: [FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread Carl Eugen Hoyos
2018-02-14 16:28 GMT+01:00 Maksym Veremeyenko : > NDI sdk has a dynamic library loading method, if it used, > then only headers files required during building binaries. The feature would be removed from the non-free list if the library sources are published under a (GPL-compatible) open-source so

Re: [FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread Maksym Veremeyenko
14.02.2018 14:45, Hendrik Leppkes пише: On Wed, Feb 14, 2018 at 1:32 PM, Kyle Schwarz wrote: On Wed, Feb 14, 2018 at 7:20 AM, Carl Eugen Hoyos wrote: 2018-02-14 13:12 GMT+01:00 Kyle Schwarz : On Wed, Feb 14, 2018 at 6:54 AM, Carl Eugen Hoyos wrote: 2018-02-14 12:21 GMT+01:00 Kyle Schwarz :

Re: [FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread Nicolas George
Tomas Härdin (2018-02-14): > Devs that work on companies that need > the proprietary stuff that is. It's always a tradeoff. Devs that work on companies that need the proprietary stuff could make use of the weight of said companies to get the proprietary stuff r

Re: [FFmpeg-devel] [PATCH v2] avformat/pcm: decrease delay when reading PCM streams.

2018-02-14 Thread Tomas Härdin
On 2018-02-14 15:11, Philipp M. Scholl wrote: Hi there, thanks for the feedback. I made the following changes to the patch: - hard-code to 40ms delay. Wasn't really sure what a good value is. But given that the is mainly for encoding low-rate sensor data in audio streams, together w

Re: [FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread Tomas Härdin
On 2018-02-14 15:16, Nicolas George wrote: Tomas Härdin (2018-02-14): Oh yeah, that puts a damper on things. The only way around that is dlopen() or RPC, neither of which is going to make it into FFmpeg At some point, vendors will need to realize we chose a copyleft license to forthe them to pl

Re: [FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread Nicolas George
Tomas Härdin (2018-02-14): > Oh yeah, that puts a damper on things. The only way around that is dlopen() > or RPC, neither of which is going to make it into FFmpeg At some point, vendors will need to realize we chose a copyleft license to forthe them to play nice, not to put extra burdens on devel

[FFmpeg-devel] [PATCH v2] avformat/pcm: decrease delay when reading PCM streams.

2018-02-14 Thread Philipp M. Scholl
Hi there, thanks for the feedback. I made the following changes to the patch: - hard-code to 40ms delay. Wasn't really sure what a good value is. But given that the is mainly for encoding low-rate sensor data in audio streams, together with a video recording, 40ms should be fine in most c

Re: [FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread Tomas Härdin
On 2018-02-14 14:48, Ricardo Constantino wrote: On 14 February 2018 at 12:56, Tomas Härdin wrote: On 2018-02-14 13:50, Kyle Schwarz wrote: On Wed, Feb 14, 2018 at 7:45 AM, Hendrik Leppkes wrote: On Wed, Feb 14, 2018 at 1:32 PM, Kyle Schwarz wrote: On Wed, Feb 14, 2018 at 7:20 AM, Carl

Re: [FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread Ricardo Constantino
On 14 February 2018 at 12:56, Tomas Härdin wrote: > On 2018-02-14 13:50, Kyle Schwarz wrote: > >> On Wed, Feb 14, 2018 at 7:45 AM, Hendrik Leppkes >> wrote: >> >>> On Wed, Feb 14, 2018 at 1:32 PM, Kyle Schwarz wrote: >>> On Wed, Feb 14, 2018 at 7:20 AM, Carl Eugen Hoyos wrote: >

Re: [FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread Carl Eugen Hoyos
2018-02-14 13:50 GMT+01:00 Kyle Schwarz : > On Wed, Feb 14, 2018 at 7:45 AM, Hendrik Leppkes wrote: >> On Wed, Feb 14, 2018 at 1:32 PM, Kyle Schwarz wrote: >>> On Wed, Feb 14, 2018 at 7:20 AM, Carl Eugen Hoyos >>> wrote: 2018-02-14 13:12 GMT+01:00 Kyle Schwarz : > On Wed, Feb 14, 2018

Re: [FFmpeg-devel] [PATCH] avcodec: remove av_codec_init_static()

2018-02-14 Thread James Almer
On 2/14/2018 2:09 AM, wm4 wrote: > On Wed, 14 Feb 2018 07:07:09 +0700 > Muhammad Faiz wrote: > >> On Tue, Feb 13, 2018 at 3:57 AM, wm4 wrote: >>> On Mon, 12 Feb 2018 12:42:10 +0700 >>> Muhammad Faiz wrote: >>> Modify the behavior of init_static_data(). Signed-off-by: Muhammad F

Re: [FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread Tomas Härdin
On 2018-02-14 13:50, Kyle Schwarz wrote: On Wed, Feb 14, 2018 at 7:45 AM, Hendrik Leppkes wrote: On Wed, Feb 14, 2018 at 1:32 PM, Kyle Schwarz wrote: On Wed, Feb 14, 2018 at 7:20 AM, Carl Eugen Hoyos wrote: 2018-02-14 13:12 GMT+01:00 Kyle Schwarz : On Wed, Feb 14, 2018 at 6:54 AM, Carl Eug

Re: [FFmpeg-devel] [PATCH 1/2] avformat/aviobuf: add ff_read_line_to_bprint and ff_read_line_to_bprint_overwrite functions

2018-02-14 Thread Nicolas George
Marton Balint (2018-02-11): > It is a 500% speed improvement on a 260 MB line compared to using > av_bprint_chars, so I'd rather leave it as is. I can add a comment saying > "for performance reasons we fill a temporary buffer, and use av_bprint > functions on chunks of data". This is assuming read

Re: [FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread Kyle Schwarz
On Wed, Feb 14, 2018 at 7:45 AM, Hendrik Leppkes wrote: > On Wed, Feb 14, 2018 at 1:32 PM, Kyle Schwarz wrote: >> On Wed, Feb 14, 2018 at 7:20 AM, Carl Eugen Hoyos wrote: >>> 2018-02-14 13:12 GMT+01:00 Kyle Schwarz : On Wed, Feb 14, 2018 at 6:54 AM, Carl Eugen Hoyos wrote: > 2018

[FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB 12-bit packed decoding

2018-02-14 Thread Jerome Martinez
On 08/02/2018 11:28, Jerome Martinez wrote: Currently RGB and RGBA 12-bit are supported by DPX decoder only if component values are padded (packing "Filled to 32-bit words, method A"). This patch adds decoding of RGB and RGBA 12-bit with no padding (packing "Packed into 32-bit words"). As I ha

[FFmpeg-devel] [PATCH] avcodec/exr: Check remaining bits in last get code loop

2018-02-14 Thread Michael Niedermayer
Fixes: runtime error: shift exponent -7 is negative Fixes: 3902/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-6081926122176512 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/ex

Re: [FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread Hendrik Leppkes
On Wed, Feb 14, 2018 at 1:32 PM, Kyle Schwarz wrote: > On Wed, Feb 14, 2018 at 7:20 AM, Carl Eugen Hoyos wrote: >> 2018-02-14 13:12 GMT+01:00 Kyle Schwarz : >>> On Wed, Feb 14, 2018 at 6:54 AM, Carl Eugen Hoyos >>> wrote: 2018-02-14 12:21 GMT+01:00 Kyle Schwarz : Sorry, I wasn't immed

Re: [FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread Kyle Schwarz
On Wed, Feb 14, 2018 at 7:20 AM, Carl Eugen Hoyos wrote: > 2018-02-14 13:12 GMT+01:00 Kyle Schwarz : >> On Wed, Feb 14, 2018 at 6:54 AM, Carl Eugen Hoyos wrote: >>> 2018-02-14 12:21 GMT+01:00 Kyle Schwarz : >>> Sorry, I wasn't immediately able to find the sources for the >>> ndi library: Please p

Re: [FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread Carl Eugen Hoyos
2018-02-14 13:12 GMT+01:00 Kyle Schwarz : > On Wed, Feb 14, 2018 at 6:54 AM, Carl Eugen Hoyos wrote: >> 2018-02-14 12:21 GMT+01:00 Kyle Schwarz : >> Sorry, I wasn't immediately able to find the sources for the >> ndi library: Please post a link. > > The only official way I know to get the SDK is b

Re: [FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread Kyle Schwarz
On Wed, Feb 14, 2018 at 6:54 AM, Carl Eugen Hoyos wrote: > 2018-02-14 12:21 GMT+01:00 Kyle Schwarz : > Sorry, I wasn't immediately able to find the sources for the > ndi library: Please post a link. The only official way I know to get the SDK is by providing them with an email when selecting "Dow

Re: [FFmpeg-devel] [PATCH] avformat/aviobuf: initialize all checksum fields

2018-02-14 Thread Carl Eugen Hoyos
2018-02-14 1:54 GMT+01:00 James Almer : > Calling ffio_ensure_seekback() right after initializing an AVIOContext > with ffio_init_context() would result in a use of uninitialised value. > > Fixes fate-adts-id3v2-demux when using valgrind. > > Signed-off-by: James Almer > --- > Maybe we should do a

Re: [FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread Carl Eugen Hoyos
2018-02-14 12:21 GMT+01:00 Kyle Schwarz : > The NewTek SDK headers are MIT licensed, so FFmpeg > shouldn't need to be nonfree to include this library. Sorry, I wasn't immediately able to find the sources for the ndi library: Please post a link. Carl Eugen _

[FFmpeg-devel] [PATCH] configure: Change license required for NewTek SDK

2018-02-14 Thread Kyle Schwarz
The NewTek SDK headers are MIT licensed, so FFmpeg shouldn't need to be nonfree to include this library. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 99c53d482a..f3a0bbafa6 100755 --- a/configure +++ b/configure @@ -1569,7 +1569,6 @@

Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

2018-02-14 Thread Tomas Härdin
tis 2018-02-13 klockan 11:48 +0100 skrev Tomas Härdin: > fre 2018-02-09 klockan 11:29 +0100 skrev Carl Eugen Hoyos: > > 2018-01-15 22:36 GMT+01:00 Tomas Härdin : > > > > > > +if (p->buf[4] >  EXPECTED_CODEC2_MINOR_VERSION) score -= > > > > AVPROBE_SCORE_MAX/5; > > > > +if (p->buf[5] >  AVP

[FFmpeg-devel] [PATCH] avcodec/ffv1: Support for GBRAP10 and GBRAP12

2018-02-14 Thread Jerome Martinez
Add support for 10- and 12-bit/component RGB with Alpha encoding and decoding in FFV1. Benched with START/STOP_TIMER around "for (x = 0; x < w; x++)" part during decoding, before the previous patch and with the previous patch + this patch, no obvious impact (+/-1%), e.g. with 1 second of gbrp1