[FFmpeg-devel] [PATCH 2/2] lavf/vaapi_encode: fix to set the default max bitrate for AVC VBR

2018-03-11 Thread Pengfei Qu
And for VBR mode, generally the max bit rate is bigger than the taraget bitrate. For CBR mode, the max bitrate is same as the target bitrate. when there is no specfic setting for the max bit rate parameter, here the default value 95% is used to caculate the default max bitrate

[FFmpeg-devel] [PATCH 1/2] lavc/vaapi_encode: fix the caculation overflow

2018-03-11 Thread Pengfei Qu
this fix the overflow during the caculation before value assignment. Signed-off-by: Pengfei Qu --- libavcodec/vaapi_encode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 36c85a3..78347d4

Re: [FFmpeg-devel] [PATCH] ffprobe: fix infinite loop in subtitle decoding

2018-03-11 Thread wm4
On Sun, 11 Mar 2018 18:12:05 +0100 Marton Balint wrote: > Fixes a regression since 2a88ebd096f3c748a2d99ed1b60b22879b3c567c which caused > an infinite loop in the subtitle decoding. > > Fixes ticket #6796. > > Signed-off-by: Marton Balint > --- >

[FFmpeg-devel] [PATCH V2 04/11] lavc/extract_extradata_bsf: support dump options.

2018-03-11 Thread Jun Zhao
From b6af8d9d77411c15922d98b710f3c335ee898603 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Thu, 8 Mar 2018 14:05:53 +0800 Subject: [PATCH V2 04/11] lavc/extract_extradata_bsf: support dump options. support dump bit stream filter options Signed-off-by: Jun Zhao

[FFmpeg-devel] [PATCH V2 11/11] lavu/opt: update fate to support dump bit stream filter option.

2018-03-11 Thread Jun Zhao
From ec00625932e794c52c816d35cca5fade8cdfa4a9 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Sat, 10 Mar 2018 13:35:03 +0800 Subject: [PATCH V2 11/11] lavu/opt: update fate to support dump bit stream filter option. Signed-off-by: Jun Zhao ---

[FFmpeg-devel] [PATCH V2 10/11] doc/fftools-common-opts: allow printing bsf details.

2018-03-11 Thread Jun Zhao
From 4e2d8947a614c664be843532dfefa7976be4b720 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Thu, 8 Mar 2018 15:18:11 +0800 Subject: [PATCH V2 10/11] doc/fftools-common-opts: allow printing bsf details. Signed-off-by: Jun Zhao ---

[FFmpeg-devel] [PATCH V2 09/11] lavc/remove_extradata_bsf: support dump options.

2018-03-11 Thread Jun Zhao
From 6f808695a291f8ddf9b56b4d26d3e9fdd47aadd5 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Thu, 8 Mar 2018 15:00:27 +0800 Subject: [PATCH V2 09/11] lavc/remove_extradata_bsf: support dump options. support dump bit stream filter options Signed-off-by: Jun Zhao

[FFmpeg-devel] [PATCH V2 08/11] lavc/noise_bsf: support dump options.

2018-03-11 Thread Jun Zhao
From be6e5bb9188574096f1a4de2d3c9c71e14aafe3e Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Thu, 8 Mar 2018 14:57:47 +0800 Subject: [PATCH V2 08/11] lavc/noise_bsf: support dump options. support dump bit stream filter options. Signed-off-by: Jun Zhao

[FFmpeg-devel] [PATCH V2 05/11] lavc/h264_metadata_bsf: support dump options.

2018-03-11 Thread Jun Zhao
From 70221e1330749ea09b2bfbe682326f4bad913c55 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Thu, 8 Mar 2018 14:22:25 +0800 Subject: [PATCH V2 05/11] lavc/h264_metadata_bsf: support dump options. support dump bit stream filter options Signed-off-by: Jun Zhao

[FFmpeg-devel] [PATCH V2 06/11] lavc/h265_metadata_bsf: support dump options.

2018-03-11 Thread Jun Zhao
From 914eb177fc86418f584a8472d83c8017a4531458 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Thu, 8 Mar 2018 14:28:13 +0800 Subject: [PATCH V2 06/11] lavc/h265_metadata_bsf: support dump options. support dump bit stream filter options Signed-off-by: Jun Zhao

[FFmpeg-devel] [PATCH V2 07/11] lavc/mpeg2_metadata_bsf: support dump options.

2018-03-11 Thread Jun Zhao
From e1829b0456a20b6c6e2cfaedb2c581e8ad374d49 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Thu, 8 Mar 2018 14:31:30 +0800 Subject: [PATCH V2 07/11] lavc/mpeg2_metadata_bsf: support dump options. support dump bit stream filter options Signed-off-by: Jun Zhao

[FFmpeg-devel] [PATCH V2 01/11] lavu/opt: add AV_OPT_FLAG_BSF_PARAM

2018-03-11 Thread Jun Zhao
V2: update opt fate test ref file From 5cd2a18ebe1494e11b08e33ca5587f7d17f41964 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Thu, 8 Mar 2018 13:47:23 +0800 Subject: [PATCH V2 01/11] lavu/opt: add AV_OPT_FLAG_BSF_PARAM add AV_OPT_FLAG_BSF_PARAM for bit stream filter options.

[FFmpeg-devel] [PATCH V2 02/11] ffmpeg: support dump bit stream filter options.

2018-03-11 Thread Jun Zhao
From 32486e2c95683e1a215f5a4cbec3d4fc01a71e87 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Thu, 8 Mar 2018 13:50:31 +0800 Subject: [PATCH V2 02/11] ffmpeg: support dump bit stream filter options. Support dump bit stream filter option in ffmpeg -h full and ffmpeg -h

[FFmpeg-devel] [PATCH V2 03/11] lavc/dump_extradata_bsf: support dump options.

2018-03-11 Thread Jun Zhao
From e45988a0feece217ffed7f019e2978572526b9e3 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Thu, 8 Mar 2018 14:01:48 +0800 Subject: [PATCH V2 03/11] lavc/dump_extradata_bsf: support dump options. support dump bit stream filter options Signed-off-by: Jun Zhao

Re: [FFmpeg-devel] [PATCH 2/8] cbs_h265: Use helper macro for maximum values of fixed-width elements

2018-03-11 Thread Jun Zhao
On 2018/3/12 2:30, Mark Thompson wrote: > Apply the same logic as the previous patch to H.265. There are no cases > which currently overflow here, but this is still more consistent. > --- > libavcodec/cbs_h265_syntax_template.c | 16 > 1 file changed, 8 insertions(+), 8

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/nuv: rtjpeg with dimensions less than 16 would result in no decoded pixels thus reject it

2018-03-11 Thread Michael Niedermayer
On Tue, Feb 27, 2018 at 04:53:23PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 6297/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NUV_fuzzer-4882404863901696 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH] avcodec/wmalosslessdec: Reset num_saved_bits on error path

2018-03-11 Thread Michael Niedermayer
On Sun, Mar 11, 2018 at 09:41:06AM +0100, Paul B Mahol wrote: > On 3/11/18, Michael Niedermayer wrote: > > Fixes: NULL pointer dereference > > Fixes: poc-201803.wav > > Found-by: GwanYeong Kim > > > > Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 2/7] hwcontext_vaapi: Add support for legacy DRM mapping

2018-03-11 Thread Mark Thompson
On 12/03/18 00:01, Rostislav Pehlivanov wrote: > On 11 March 2018 at 22:41, Mark Thompson wrote: > >> The old vaAcquireBufferHandle() API works in fewer cases and provides >> less information than the current vaExportSurfaceHandle(), but it exists >> on older versions and is

Re: [FFmpeg-devel] [PATCH 4/7] hwcontext_opencl: Add support for mapping DRM objects to Beignet

2018-03-11 Thread Mark Thompson
On 11/03/18 23:59, Rostislav Pehlivanov wrote: > On 11 March 2018 at 22:41, Mark Thompson wrote: > >> Also use that to support mapping VAAPI to Beignet. >> --- >> configure| 16 +-- >> libavutil/hwcontext_opencl.c | 264 +- >>

Re: [FFmpeg-devel] [PATCH 01/10] lavu/opt: add AV_OPT_FLAG_BSF_PARAM

2018-03-11 Thread Jun Zhao
On 2018/3/10 3:32, Michael Niedermayer wrote: > On Thu, Mar 08, 2018 at 04:41:43PM +0800, Jun Zhao wrote: >> opt.c |1 + >> opt.h |1 + >> 2 files changed, 2 insertions(+) >> f19d1e433e7008fa7ea9868c973367833dc86878 >> 0001-lavu-opt-add-AV_OPT_FLAG_BSF_PARAM.patch >> From

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix integer overflows related to sample_duration

2018-03-11 Thread Michael Niedermayer
On Sat, Mar 10, 2018 at 10:48:16PM +0100, Michael Niedermayer wrote: > Fixes: runtime error: signed integer overflow: -9166684017437101870 + > -2495066639299164439 cannot be represented in type > > Fixes: Chromium bug 791349 > > Reported-by: Matt Wolenetz > Reviewed-by:

Re: [FFmpeg-devel] [PATCH 2/7] hwcontext_vaapi: Add support for legacy DRM mapping

2018-03-11 Thread Rostislav Pehlivanov
On 11 March 2018 at 22:41, Mark Thompson wrote: > The old vaAcquireBufferHandle() API works in fewer cases and provides > less information than the current vaExportSurfaceHandle(), but it exists > on older versions and is already used by the OpenCL code. This probably > doesn't

Re: [FFmpeg-devel] [PATCH 4/7] hwcontext_opencl: Add support for mapping DRM objects to Beignet

2018-03-11 Thread Rostislav Pehlivanov
On 11 March 2018 at 22:41, Mark Thompson wrote: > Also use that to support mapping VAAPI to Beignet. > --- > configure| 16 +-- > libavutil/hwcontext_opencl.c | 264 +- > - > 2 files changed, 138 insertions(+), 142

Re: [FFmpeg-devel] [PATCH 6/7] vf_scale_vaapi: Apply cropping rectangle to input

2018-03-11 Thread Rostislav Pehlivanov
On 11 March 2018 at 22:41, Mark Thompson wrote: > --- > libavfilter/vf_scale_vaapi.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavfilter/vf_scale_vaapi.c b/libavfilter/vf_scale_vaapi.c > index c19e23ccd0..d6529d5235 100644 > ---

Re: [FFmpeg-devel] [PATCH 3/7] hwcontext_vaapi: Pass correct read/write flags when exporting surfaces

2018-03-11 Thread Rostislav Pehlivanov
On 11 March 2018 at 22:41, Mark Thompson wrote: > --- > libavutil/hwcontext_vaapi.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c > index 15f1c4d1c0..8e4bef9f1b 100644 > ---

Re: [FFmpeg-devel] [PATCH 7/7] doc/indevs: Add example using cropping to capture part of a plane

2018-03-11 Thread Rostislav Pehlivanov
On 11 March 2018 at 22:41, Mark Thompson wrote: > --- > doc/indevs.texi | 8 > 1 file changed, 8 insertions(+) > > diff --git a/doc/indevs.texi b/doc/indevs.texi > index 6951940a93..02d1cb3d86 100644 > --- a/doc/indevs.texi > +++ b/doc/indevs.texi > @@ -462,6 +462,14 @@

[FFmpeg-devel] [PATCH] avcodec/cscd: Error out when LZ* decompression fails

2018-03-11 Thread Michael Niedermayer
Fixes: Timeout Fixes: 6304/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CSCD_fuzzer-5754772461191168 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cscd.c | 8

Re: [FFmpeg-devel] [PATCH] h264_slice: correct atomics usage

2018-03-11 Thread Aman Gupta
On Sun, Mar 11, 2018 at 4:01 PM, Rostislav Pehlivanov wrote: > Reported by tmm1 > > Signed-off-by: Rostislav Pehlivanov > --- > libavcodec/h264_slice.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

[FFmpeg-devel] [PATCH] h264_slice: correct atomics usage

2018-03-11 Thread Rostislav Pehlivanov
Reported by tmm1 Signed-off-by: Rostislav Pehlivanov --- libavcodec/h264_slice.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index 90e05ed8f1..b381397b4d 100644 --- a/libavcodec/h264_slice.c +++

[FFmpeg-devel] [PATCH] avcodec/h264_slice: fix access to atomic error_count

2018-03-11 Thread Aman Gupta
From: Aman Gupta --- libavcodec/h264_slice.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index 90e05ed8f1..d0f38783ee 100644 --- a/libavcodec/h264_slice.c +++ b/libavcodec/h264_slice.c @@ -2762,7

[FFmpeg-devel] [PATCH 7/7] doc/indevs: Add example using cropping to capture part of a plane

2018-03-11 Thread Mark Thompson
--- doc/indevs.texi | 8 1 file changed, 8 insertions(+) diff --git a/doc/indevs.texi b/doc/indevs.texi index 6951940a93..02d1cb3d86 100644 --- a/doc/indevs.texi +++ b/doc/indevs.texi @@ -462,6 +462,14 @@ Capture from CRTC ID 42 at 60fps, map the result to VAAPI, convert to NV12 and e

[FFmpeg-devel] [PATCH 5/7] vf_crop: Add support for cropping hardware frames

2018-03-11 Thread Mark Thompson
Set the cropping fields in the AVFrame. --- libavfilter/vf_crop.c | 61 --- 1 file changed, 43 insertions(+), 18 deletions(-) diff --git a/libavfilter/vf_crop.c b/libavfilter/vf_crop.c index 0fdc4949e3..0b1b8a048b 100644 --- a/libavfilter/vf_crop.c

[FFmpeg-devel] [PATCH 4/7] hwcontext_opencl: Add support for mapping DRM objects to Beignet

2018-03-11 Thread Mark Thompson
Also use that to support mapping VAAPI to Beignet. --- configure| 16 +-- libavutil/hwcontext_opencl.c | 264 +-- 2 files changed, 138 insertions(+), 142 deletions(-) diff --git a/configure b/configure index 5e38bdab17..5051fd1abf

[FFmpeg-devel] [PATCH 6/7] vf_scale_vaapi: Apply cropping rectangle to input

2018-03-11 Thread Mark Thompson
--- libavfilter/vf_scale_vaapi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavfilter/vf_scale_vaapi.c b/libavfilter/vf_scale_vaapi.c index c19e23ccd0..d6529d5235 100644 --- a/libavfilter/vf_scale_vaapi.c +++ b/libavfilter/vf_scale_vaapi.c @@ -100,13

[FFmpeg-devel] [PATCH 3/7] hwcontext_vaapi: Pass correct read/write flags when exporting surfaces

2018-03-11 Thread Mark Thompson
--- libavutil/hwcontext_vaapi.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index 15f1c4d1c0..8e4bef9f1b 100644 --- a/libavutil/hwcontext_vaapi.c +++ b/libavutil/hwcontext_vaapi.c @@ -1094,15 +1094,20 @@

[FFmpeg-devel] [PATCH 2/7] hwcontext_vaapi: Add support for legacy DRM mapping

2018-03-11 Thread Mark Thompson
The old vaAcquireBufferHandle() API works in fewer cases and provides less information than the current vaExportSurfaceHandle(), but it exists on older versions and is already used by the OpenCL code. This probably doesn't have much use directly, but it will be used to replace the ad-hoc OpenCL

[FFmpeg-devel] [PATCH 1/7] hwcontext_vaapi: Fix condition for DRM device derivation

2018-03-11 Thread Mark Thompson
vaGetDisplayDRM() is required for this code to work, libdrm is not. --- libavutil/hwcontext_vaapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index af9a136ef0..99f76b9169 100644 --- a/libavutil/hwcontext_vaapi.c

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay: add show property/command

2018-03-11 Thread Lou Logan
On Sun, Mar 11, 2018, at 2:16 PM, Bodecs Bela wrote: > > I have found the info about it. For others who may be curious: https://ffmpeg.org/ffmpeg-filters.html#Timeline-editing See supported filters with: ffmpeg -filters Todo: Mention which filters support timeline in filters.texi.

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay: add show property/command

2018-03-11 Thread Bodecs Bela
2018.03.11. 23:09 keltezéssel, Bodecs Bela írta: 2018.03.11. 23:04 keltezéssel, Nicolas George írta: Bodecs Bela (2018-03-11): I frequently use overlay video filter. Sometimes it is needed to dinamically hide/show the ovelaid video. (e.g during live streaming). Currently the only

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay: add show property/command

2018-03-11 Thread Bodecs Bela
2018.03.11. 23:04 keltezéssel, Nicolas George írta: Bodecs Bela (2018-03-11): I frequently use overlay video filter. Sometimes it is needed to dinamically hide/show the ovelaid video. (e.g during live streaming). Currently the only possibility to hide the overlaid video is to position it to

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay: add show property/command

2018-03-11 Thread Nicolas George
Bodecs Bela (2018-03-11): > I frequently use overlay video filter. Sometimes it is needed to dinamically > hide/show the ovelaid video. (e.g during live streaming). > Currently the only possibility to hide the overlaid video is to position it > to off site area of the visible region. > This patch

[FFmpeg-devel] [PATCH] avfilter/vf_overlay: add show property/command

2018-03-11 Thread Bodecs Bela
Dear All, I frequently use overlay video filter. Sometimes it is needed to dinamically hide/show the ovelaid video. (e.g during live streaming). Currently the only possibility to hide the overlaid video is to position it to off site area of the visible region. This patch creates a new,

[FFmpeg-devel] [PATCH] add convolution_opencl

2018-03-11 Thread Danil Iashchenko
--- configure | 1 + libavfilter/Makefile| 1 + libavfilter/allfilters.c| 1 + libavfilter/opencl/convolution.cl | 42 libavfilter/opencl_source.h | 3 + libavfilter/vf_convolution_opencl.c | 464

[FFmpeg-devel] [PATCH] libavfilter/vf_convolution_opencl.c: add opencl version of libavfilter/convolution.c filter

2018-03-11 Thread Danil Iashchenko
Hi there. Thank you for your advices. I implemented 4 matrix / 4 rdiv / 4 bias option for each plane of image, fixed mem-leaks, added error messages if the matrix is invalid. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_convolution_opencl.c: add opencl version of libavfilter/convolution.c filter

2018-03-11 Thread Danil Iashchenko
Hi there. Thank you for your advices. I implemented 4 matrix / 4 rdiv / 4 bias support, fixed mem-leaks, add error messages if matrix is incorrect, removed local kernel. Kind regards. Danil ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 7/8] cbs: Add a table of all supported codec IDs

2018-03-11 Thread Mark Thompson
On 11/03/18 19:04, James Almer wrote: > On 3/11/2018 3:30 PM, Mark Thompson wrote: >> Use it as the set of codec IDs supported by the trace_headers BSF. >> --- >> configure | 1 - >> libavcodec/cbs.c | 13 + >> libavcodec/cbs.h | 8

Re: [FFmpeg-devel] [PATCH 6/8] h264_metadata: Remove unused fields

2018-03-11 Thread Hendrik Leppkes
On Sun, Mar 11, 2018 at 7:55 PM, James Almer wrote: > On 3/11/2018 3:30 PM, Mark Thompson wrote: >> The SEI NAL is unused since 69062d0f9b6aef5d9d9b8c9c9b5cfb23037caddb, >> while the AUD NAL is small and would more sensibly be on the stack. >> --- >>

Re: [FFmpeg-devel] [PATCH 7/8] cbs: Add a table of all supported codec IDs

2018-03-11 Thread James Almer
On 3/11/2018 3:30 PM, Mark Thompson wrote: > Use it as the set of codec IDs supported by the trace_headers BSF. > --- > configure | 1 - > libavcodec/cbs.c | 13 + > libavcodec/cbs.h | 8 > libavcodec/trace_headers_bsf.c | 9

Re: [FFmpeg-devel] [PATCH 6/8] h264_metadata: Remove unused fields

2018-03-11 Thread James Almer
On 3/11/2018 4:02 PM, Mark Thompson wrote: > On 11/03/18 18:55, James Almer wrote: >> On 3/11/2018 3:30 PM, Mark Thompson wrote: >>> The SEI NAL is unused since 69062d0f9b6aef5d9d9b8c9c9b5cfb23037caddb, >>> while the AUD NAL is small and would more sensibly be on the stack. >>> --- >>>

Re: [FFmpeg-devel] [PATCH 6/8] h264_metadata: Remove unused fields

2018-03-11 Thread Mark Thompson
On 11/03/18 18:55, James Almer wrote: > On 3/11/2018 3:30 PM, Mark Thompson wrote: >> The SEI NAL is unused since 69062d0f9b6aef5d9d9b8c9c9b5cfb23037caddb, >> while the AUD NAL is small and would more sensibly be on the stack. >> --- >> libavcodec/h264_metadata_bsf.c | 12 +--- >> 1 file

Re: [FFmpeg-devel] [PATCH 6/8] h264_metadata: Remove unused fields

2018-03-11 Thread James Almer
On 3/11/2018 3:30 PM, Mark Thompson wrote: > The SEI NAL is unused since 69062d0f9b6aef5d9d9b8c9c9b5cfb23037caddb, > while the AUD NAL is small and would more sensibly be on the stack. > --- > libavcodec/h264_metadata_bsf.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) > >

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/trace_headers: move the reference in the bsf internal buffer

2018-03-11 Thread James Almer
On 3/11/2018 3:32 PM, Mark Thompson wrote: > On 11/03/18 17:58, James Almer wrote: >> There's no need to allocate a new packet for it. >> >> Signed-off-by: James Almer >> --- >> libavcodec/trace_headers_bsf.c | 30 ++ >> 1 file changed, 14

Re: [FFmpeg-devel] fate/hap : add test for hap encoding

2018-03-11 Thread Martin Vignali
2017-11-26 18:25 GMT+01:00 Martin Vignali : > Hello, > > Patch in attach, add test for hap encoding (currently not cover) (patch > 002) > and move decoding tests to a separate file (patch 001) > > decoding can be test with > make fate-hap SAMPLES=fate-suite/ > > and

[FFmpeg-devel] [PATCH 2/8] cbs_h265: Use helper macro for maximum values of fixed-width elements

2018-03-11 Thread Mark Thompson
Apply the same logic as the previous patch to H.265. There are no cases which currently overflow here, but this is still more consistent. --- libavcodec/cbs_h265_syntax_template.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] lavc: Add filter_units bitstream filter

2018-03-11 Thread Mark Thompson
On 08/03/18 04:01, James Almer wrote: > On 3/6/2018 3:49 PM, Mark Thompson wrote: >> This can remove units with types in or not in a given set from a stream. >> For example, it can be used to remove all non-VCL NAL units from an H.264 or >> H.265 stream. >> --- >> On 06/03/18 17:27, Hendrik

[FFmpeg-devel] [PATCH 4/8] h264_metadata: Add support for A/53 closed captions

2018-03-11 Thread Mark Thompson
--- libavcodec/h264_metadata_bsf.c | 121 + 1 file changed, 121 insertions(+) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index 36047887ca..d340c55990 100644 --- a/libavcodec/h264_metadata_bsf.c +++

[FFmpeg-devel] [PATCH 3/8] h264_metadata: Add support for display orientation SEI messages

2018-03-11 Thread Mark Thompson
--- libavcodec/h264_metadata_bsf.c | 169 - 1 file changed, 165 insertions(+), 4 deletions(-) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index 466823cda6..36047887ca 100644 --- a/libavcodec/h264_metadata_bsf.c +++

[FFmpeg-devel] [PATCH 5/8] h264_metadata: Update documentation

2018-03-11 Thread Mark Thompson
Improve documentation for the delete_filler option, and add the display_orientation and a53_cc options. --- doc/bitstream_filters.texi | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/doc/bitstream_filters.texi

[FFmpeg-devel] [PATCH 1/8] cbs_h264: Fix overflow in shifts

2018-03-11 Thread Mark Thompson
The type of the result of a shift operation is unaffected by the type of the right operand, so some existing code overflows with undefined behaviour when the element length is 32. Add a helper macro to calculate the maximum value correctly and then use it everywhere this pattern appears.

Re: [FFmpeg-devel] avcodec/hapqa_extract_bsf : add bsf filter for haqqa (to hapq or hapalpha only) conversion

2018-03-11 Thread James Almer
On 3/11/2018 3:20 PM, Martin Vignali wrote: > 2018-03-11 18:45 GMT+01:00 James Almer : > >> On 3/11/2018 2:08 PM, Martin Vignali wrote: >>> Work for me, changed. >>> >>> New patchs in attach, with these changes. >> >> Please combine the last three patches (bsf, docs and

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/trace_headers: move the reference in the bsf internal buffer

2018-03-11 Thread Mark Thompson
On 11/03/18 17:58, James Almer wrote: > There's no need to allocate a new packet for it. > > Signed-off-by: James Almer > --- > libavcodec/trace_headers_bsf.c | 30 ++ > 1 file changed, 14 insertions(+), 16 deletions(-) > > diff --git

[FFmpeg-devel] [PATCH 8/8] lavc: Add filter_units bitstream filter

2018-03-11 Thread Mark Thompson
This can remove units with types in or not in a given set from a stream. For example, it can be used to remove all non-VCL NAL units from an H.264 or H.265 stream. --- doc/bitstream_filters.texi | 29 + libavcodec/Makefile| 1 + libavcodec/bitstream_filters.c | 1 +

[FFmpeg-devel] [PATCH 6/8] h264_metadata: Remove unused fields

2018-03-11 Thread Mark Thompson
The SEI NAL is unused since 69062d0f9b6aef5d9d9b8c9c9b5cfb23037caddb, while the AUD NAL is small and would more sensibly be on the stack. --- libavcodec/h264_metadata_bsf.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/libavcodec/h264_metadata_bsf.c

[FFmpeg-devel] [PATCH 7/8] cbs: Add a table of all supported codec IDs

2018-03-11 Thread Mark Thompson
Use it as the set of codec IDs supported by the trace_headers BSF. --- configure | 1 - libavcodec/cbs.c | 13 + libavcodec/cbs.h | 8 libavcodec/trace_headers_bsf.c | 9 + 4 files changed, 22 insertions(+), 9

Re: [FFmpeg-devel] avcodec/hapqa_extract_bsf : add bsf filter for haqqa (to hapq or hapalpha only) conversion

2018-03-11 Thread Martin Vignali
2018-03-11 18:45 GMT+01:00 James Almer : > On 3/11/2018 2:08 PM, Martin Vignali wrote: > > Work for me, changed. > > > > New patchs in attach, with these changes. > > Please combine the last three patches (bsf, docs and changelog entry) > into a single one. > Changed > > >

[FFmpeg-devel] [PATCH 6/6] avcodec/mov2textsub: move the reference in the bsf internal buffer

2018-03-11 Thread James Almer
There's no need to allocate a new packet for it. Signed-off-by: James Almer --- libavcodec/movsub_bsf.c | 26 +++--- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/libavcodec/movsub_bsf.c b/libavcodec/movsub_bsf.c index

[FFmpeg-devel] [PATCH 4/6] avcodec/trace_headers: move the reference in the bsf internal buffer

2018-03-11 Thread James Almer
There's no need to allocate a new packet for it. Signed-off-by: James Almer --- libavcodec/trace_headers_bsf.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/libavcodec/trace_headers_bsf.c b/libavcodec/trace_headers_bsf.c

[FFmpeg-devel] [PATCH 3/6] avcodec/remove_extradata: move the reference in the bsf internal buffer

2018-03-11 Thread James Almer
There's no need to allocate a new packet for it. Signed-off-by: James Almer --- libavcodec/remove_extradata_bsf.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/libavcodec/remove_extradata_bsf.c b/libavcodec/remove_extradata_bsf.c index

[FFmpeg-devel] [PATCH 2/6] avcodec/extract_extradata: move the reference in the bsf internal buffer

2018-03-11 Thread James Almer
There's no need to allocate a new packet for it. Signed-off-by: James Almer --- libavcodec/extract_extradata_bsf.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/extract_extradata_bsf.c b/libavcodec/extract_extradata_bsf.c index

[FFmpeg-devel] [PATCH 5/6] avcodec/chomp: move the reference in the bsf internal buffer

2018-03-11 Thread James Almer
There's no need to allocate a new packet for it. Signed-off-by: James Almer --- libavcodec/chomp_bsf.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavcodec/chomp_bsf.c b/libavcodec/chomp_bsf.c index cc94380535..0d29a9a1d9 100644 ---

[FFmpeg-devel] [PATCH 1/6] avcodec/dca_core: move the reference in the bsf internal buffer

2018-03-11 Thread James Almer
There's no need to allocate a new packet for it. Signed-off-by: James Almer --- libavcodec/dca_core_bsf.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/libavcodec/dca_core_bsf.c b/libavcodec/dca_core_bsf.c index 9edc0cfd61..cd3bc6fe99 100644 ---

Re: [FFmpeg-devel] avcodec/hapqa_extract_bsf : add bsf filter for haqqa (to hapq or hapalpha only) conversion

2018-03-11 Thread James Almer
On 3/11/2018 2:08 PM, Martin Vignali wrote: > Work for me, changed. > > New patchs in attach, with these changes. Please combine the last three patches (bsf, docs and changelog entry) into a single one. > > Martin > > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > index

[FFmpeg-devel] [PATCH] ffprobe: fix infinite loop in subtitle decoding

2018-03-11 Thread Marton Balint
Fixes a regression since 2a88ebd096f3c748a2d99ed1b60b22879b3c567c which caused an infinite loop in the subtitle decoding. Fixes ticket #6796. Signed-off-by: Marton Balint --- fftools/ffprobe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] avcodec/hapqa_extract_bsf : add bsf filter for haqqa (to hapq or hapalpha only) conversion

2018-03-11 Thread Martin Vignali
Hello, Thanks for the comments. > + > > +av_log(bsf, AV_LOG_DEBUG, "Texture to keep : %d.\n", ctx->texture); > > There's no point printing this on every packet. Either add an init() > callback function and put it there, or remove it altogether since it's > of dubious usefulness. > Removed.

Re: [FFmpeg-devel] [PATCH] h264_mp4toannexb_bsf: Fix start code size of parameter sets.

2018-03-11 Thread Yusuke Nakamura
2018-02-13 1:45 GMT+09:00 Yusuke Nakamura : > Any parameter set shall have start code of at least 4 byte size. > --- > libavcodec/h264_mp4toannexb_bsf.c| 22 +++--- > tests/ref/fate/h264-bsf-mp4toannexb | 2 +- >

Re: [FFmpeg-devel] [PATCH] lavf/rtsp: fix the type of the timeout option.

2018-03-11 Thread wm4
On Sun, 11 Mar 2018 14:49:37 +0100 Michael Niedermayer wrote: > On Sun, Mar 11, 2018 at 03:03:06AM +0100, wm4 wrote: > > On Sat, 10 Mar 2018 20:37:20 +0100 > > Nicolas George wrote: > > > > > A timeout is a duration of time, therefore the correct type

Re: [FFmpeg-devel] avcodec/hapqa_extract_bsf : add bsf filter for haqqa (to hapq or hapalpha only) conversion

2018-03-11 Thread James Almer
On 3/11/2018 10:47 AM, Martin Vignali wrote: > Hello > > New patchs in attach : > - check texture type, for rgb or alpha keep (don't assume first texture is > rgb and second texture is alpha) > - change options, to use "color" or "alpha". > - Translate french comments > - add changelog entry > >

Re: [FFmpeg-devel] avcodec/hapqa_extract_bsf : add bsf filter for haqqa (to hapq or hapalpha only) conversion

2018-03-11 Thread Martin Vignali
Hello New patchs in attach : - check texture type, for rgb or alpha keep (don't assume first texture is rgb and second texture is alpha) - change options, to use "color" or "alpha". - Translate french comments - add changelog entry Not entirely sure, of the options part of the bsf filter.

Re: [FFmpeg-devel] [PATCH] lavf/rtsp: fix the type of the timeout option.

2018-03-11 Thread Michael Niedermayer
On Sun, Mar 11, 2018 at 03:03:06AM +0100, wm4 wrote: > On Sat, 10 Mar 2018 20:37:20 +0100 > Nicolas George wrote: > > > A timeout is a duration of time, therefore the correct type for it > > is AV_OPT_TYPE_DURATION. It has the benefit of offering a better > > user interface,

Re: [FFmpeg-devel] [PATCH] avcodec/arm/hevcdsp_sao : add NEON optimization for sao

2018-03-11 Thread Yingming Fan
> On 11 Mar 2018, at 8:54 PM, Carl Eugen Hoyos wrote: > > 2018-03-08 8:03 GMT+01:00 Yingming Fan : >> From: Meng Wang > >> +stride_dst /= sizeof(uint8_t); >> +stride_src /= sizeof(uint8_t); > > FFmpeg requires

Re: [FFmpeg-devel] [PATCH] avcodec/arm/hevcdsp_sao : add NEON optimization for sao

2018-03-11 Thread Carl Eugen Hoyos
2018-03-08 8:03 GMT+01:00 Yingming Fan : > From: Meng Wang > +stride_dst /= sizeof(uint8_t); > +stride_src /= sizeof(uint8_t); FFmpeg requires sizeof(uint8_t) to be 1, please simplify your patch accordingly. Why is the wrapper

Re: [FFmpeg-devel] avformat/mov : add support for read/write Adobe Alpha Udta

2018-03-11 Thread Martin Vignali
> > +av_log(c->fc, AV_LOG_ERROR, > > + "unknown value for ALFA udta (%llu)\n", alpha_val); > > the %llu looks wrong for the type > > > New patch in attach replacing %llu with %"PRIu64 Martin 0001-avformat-mov-add-support-for-Adobe-Alpha-metadata.patch Description: Binary

[FFmpeg-devel] fate/mov : add test for ffprobe and alpha metadata

2018-03-11 Thread Martin Vignali
Hello, Patch in attach add test for adobe alpha metadata in mov file Sample can be found here : https://we.tl/d4AIvKE3wV and need to be put inside ./fate-suite/mov can be test with : make fate-mov SAMPLES=fate-suite Need to be apply after patch in discussion : avformat/mov : add support for

Re: [FFmpeg-devel] GSoC

2018-03-11 Thread Mark Thompson
On 11/03/18 04:36, Dylan Fernando wrote: > On Thu, Mar 8, 2018 at 8:57 AM, Mark Thompson wrote: > >> On 07/03/18 03:56, Dylan Fernando wrote: >>> Thanks, it works now >>> >>> Would trying to implement an OpenCL version of vf_fade be a good idea >> for a >>> qualification task, or

Re: [FFmpeg-devel] Type mismatch in ADPCM

2018-03-11 Thread Carl Eugen Hoyos
2018-03-11 11:27 GMT+01:00 Carlo Bramini : > Hello, > I see. I expected that adding that could be considered out of the coding > guidelines. You misunderstand: The issue is not (afaict) the coding guidelines but the fact that the change would mean we claim a compatibility

Re: [FFmpeg-devel] Type mismatch in ADPCM

2018-03-11 Thread Carlo Bramini
Hello, I see. I expected that adding that could be considered out of the coding guidelines. However, what about the patch attached for fixing the declaration of ff_adpcm_afc_coeffs[2][16]? Although it works because the binary values are the same, this is wrong, independently by the fact that

Re: [FFmpeg-devel] [PATCH] avcodec/wmalosslessdec: Reset num_saved_bits on error path

2018-03-11 Thread Paul B Mahol
On 3/11/18, Michael Niedermayer wrote: > Fixes: NULL pointer dereference > Fixes: poc-201803.wav > Found-by: GwanYeong Kim > > Signed-off-by: Michael Niedermayer > --- > libavcodec/wmalosslessdec.c | 1 + > 1 file changed, 1