Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

> > Are you sure this is correct? The links above describe '©nam' as the > title of the content, and 'name' as 'Name of Object", whatever that is > supposed to mean. > From the spec, '©nam' appears to be a localized entry, which can also be set per-track in Quicktime (exposed via their

[FFmpeg-devel] [PATCH 1/3] avcodec/h264_metadata: fix memory leak in case of output packet creation failure

Some function calls may fail after the output packet is initialized. Signed-off-by: James Almer --- libavcodec/h264_metadata_bsf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index

[FFmpeg-devel] [PATCH 2/3] avcodec/h265_metadata: fix memory leak in case of output packet creation failure

Some function calls may fail after the output packet is initialized. Signed-off-by: James Almer --- libavcodec/h265_metadata_bsf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/h265_metadata_bsf.c b/libavcodec/h265_metadata_bsf.c index

[FFmpeg-devel] [PATCH 3/3] avcodec/mpeg2_metadata: fix memory leak in case of output packet creation failure

Some function calls may fail after the output packet is initialized. Signed-off-by: James Almer --- libavcodec/mpeg2_metadata_bsf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/mpeg2_metadata_bsf.c b/libavcodec/mpeg2_metadata_bsf.c index

Re: [FFmpeg-devel] [PATCH v3 5/7] lavf, lavd: add AVClass for lavd & use iterate API

On Mon, Mar 19, 2018 at 07:35:39PM +, Josh de Kock wrote: > Add an AVClass for AVDevice as the .child_class_next member for lavf's > AVClass will no longer find devices. > --- > fftools/cmdutils.c | 10 + > fftools/ffmpeg_opt.c | 2 +- > libavdevice/Makefile | 1 + >

[FFmpeg-devel] Asynchronously delivering data to FFmpeg, and extending the API to do this...

Hi all, I’m looking at the API and trying to figure out how to adapt it to our use, but without much luck. If I get this working, I’ll try to upstream the enhancement in case it’s generically useful. The problem in a nutshell is we’re using libevent2 and everything is event-driven, including

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_superframe_split: move the reference in the bsf internal buffer

On 3/19/2018 4:22 PM, James Almer wrote: > On 3/16/2018 7:39 PM, James Almer wrote: >> There's no need to allocate a new packet for it. >> >> Signed-off-by: James Almer >> --- >> libavcodec/vp9_superframe_split_bsf.c | 21 ++--- >> 1 file changed, 10

Re: [FFmpeg-devel] [PATCH 1/2] fftools/cmdutils: add logflags option

On Mon, Mar 19, 2018 at 09:31:44AM +0100, Tobias Rapp wrote: > On 14.03.2018 09:55, Tobias Rapp wrote: > >Allows to set the AV_LOG_PRINT_LEVEL and AV_LOG_SKIP_REPEATED flags > >using a distinct command-line option, similar to other flag options. > >Previously only the AV_LOG_SKIP_REPEATED flag was

Re: [FFmpeg-devel] [FFmpeg][PATCH] lavc/cfhd: introduced interlaced using temporal horizontal transform

On Mon, Mar 19, 2018 at 03:17:59PM +0530, Gagandeep Singh wrote: > interlaced files require horizontal-temporal transform that has been added. > Output is not satisfactory yet! > --- > libavcodec/cfhd.c | 137 > +- > libavcodec/cfhd.h | 3 +-

[FFmpeg-devel] [PATCH] avformat/mov: Check STSC and remove invalid entries

Fixes assertion failure Fixes: crbug 822547, crbug 822666 and crbug 823009 Affects: aark15sd_9A62E2FA.mp4 Found-by: ClusterFuzz Reviewed-by: Matt Wolenetz Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 20 1 file

Re: [FFmpeg-devel] [PATCH]lavfi/deshake: Check alignment before calling asm init function

2018-03-16 20:02 GMT+01:00, James Almer : > On 3/16/2018 3:55 PM, Carl Eugen Hoyos wrote: >> +aligned = !((unsigned long)in->data[0] & 15 | in->linesize[0] & 15); > > Should be intptr_t, not unsigned long. Definitely, thank you! Pushed with that change, Carl Eugen

Re: [FFmpeg-devel] [PATCH] lavfi: Add OpenCL avgblur filter

2018-03-18 19:50 GMT+01:00, Mark Thompson : > On 18/03/18 18:36, Carl Eugen Hoyos wrote: >> 2018-03-18 19:12 GMT+01:00, Mark Thompson : [...] > I was just wondering if there was any specific reason > why you were encouraging it in this case Because it is good

Re: [FFmpeg-devel] [PATCH] area changed:in cfhd height initialization was buggy for chroma plane

2018-03-16 11:27 GMT+01:00, Gagandeep Singh : > From: Gagandeep Singh > diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c > index fd834b..a064cd1599 100644 > --- a/libavcodec/cfhd.c > +++ b/libavcodec/cfhd.c > @@ -195,14 +195,14 @@ static int

Re: [FFmpeg-devel] OpenCV filter should be built as C++, and C builds fail since OpenCV 3.4.1

On 3/20/18, Carl Eugen Hoyos wrote: > 2018-03-19 21:49 GMT+01:00, Derek Buitenhuis : > >> libutvideo was handled 100% incorrectly. We hardcoded >> libstdc++ as a dependency > > Which worked fine on osx (and all other systems that were > ever

Re: [FFmpeg-devel] [PATCH] lavfi: Add OpenCL avgblur filter

On 19/03/18 02:30, dylanf...@gmail.com wrote: > From: drfer3 > > Behaves like the existing avgblur filter, except working on OpenCL > hardware frames. Takes exactly the same options. > --- > configure | 1 + > libavfilter/Makefile|

[FFmpeg-devel] [PATCH] avcodec/mediacodecdec: propagate SAR to h/w frames

From: Aman Gupta Allows consumers who are converting hardware buffers to OpenGL textures to render the frames at the intended display resolution. --- libavcodec/mediacodecdec_common.c | 13 + libavcodec/mediacodecdec_common.h | 2 ++ 2 files changed, 15 insertions(+)

Re: [FFmpeg-devel] OpenCV filter should be built as C++, and C builds fail since OpenCV 3.4.1

2018-03-19 21:49 GMT+01:00, Derek Buitenhuis : > libutvideo was handled 100% incorrectly. We hardcoded > libstdc++ as a dependency Which worked fine on osx (and all other systems that were ever tested). More important imo is that Jeff forgot to attach his patch.

[FFmpeg-devel] [PATCH 3/3] hwcontext_opencl: Avoid deprecation warnings when built with post-1.2 headers

Matching the previous commit. This is not applied to the installed header because it could incorrectly suppress the warning inside user programs. --- libavutil/hwcontext_opencl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/hwcontext_opencl.c b/libavutil/hwcontext_opencl.c

[FFmpeg-devel] [PATCH 2/3] lavif/opencl: Avoid deprecation warnings when built with post-1.2 headers

The intended target is OpenCL 1.2, so disable warnings for APIs deprecated after that. This primarily applies to clCreateCommandQueue(), we can't use the replacement clCreateCommandQueueWithProperties() because it was introduced in OpenCL 2.0. Also remove some unnecessary includes from overlay

Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

On 3/19/2018 9:11 PM, Courtland Idstrom wrote: > Track title (atom 'name') is a well defined user data atom for mov files. > Existing code (for mp4) only writes title metadata if present. > > Relevant reference docs: > > >

Re: [FFmpeg-devel] OpenCV filter should be built as C++, and C builds fail since OpenCV 3.4.1

On 19 March 2018 at 20:57, Nicolas George wrote: > Derek Buitenhuis (2018-03-19): > > libutvideo was handled 100% incorrectly. We hardcoded libstdc++ as a > > dependency, but the proper solution was to link with CXX instead of CC. > > This is not a *proper* solution, since it

Re: [FFmpeg-devel] [PATCH] avfilter: add hrtfm filter

On 3/19/18, Nicolas George wrote: > Paul B Mahol (2018-03-19): >> No I will not! > > Changes are to be sent to the mailing-list, that is the policy. You are > not allowed to change it unilaterally. I'm not aware of such policy. ___

Re: [FFmpeg-devel] OpenCV filter should be built as C++, and C builds fail since OpenCV 3.4.1

On 3/19/2018 8:57 PM, Nicolas George wrote: > Derek Buitenhuis (2018-03-19): >> libutvideo was handled 100% incorrectly. We hardcoded libstdc++ as a >> dependency, but the proper solution was to link with CXX instead of CC. > > This is not a *proper* solution, since it does not scale to the case

[FFmpeg-devel] [PATCH v2] lavf/movenc: write track title metadata for mov files

Track title (atom 'name') is a well defined user data atom for mov files. Existing code (for mp4) only writes title metadata if present. Relevant reference docs:

Re: [FFmpeg-devel] OpenCV filter should be built as C++, and C builds fail since OpenCV 3.4.1

Derek Buitenhuis (2018-03-19): > libutvideo was handled 100% incorrectly. We hardcoded libstdc++ as a > dependency, but the proper solution was to link with CXX instead of CC. This is not a *proper* solution, since it does not scale to the case where several languages all have that requirement.

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: do not finish output streams manually on eof even if no input is provided

On Mon, 19 Mar 2018, Michael Niedermayer wrote: On Sun, Mar 18, 2018 at 08:09:09PM +0100, Marton Balint wrote: The generic code should be able to finish the streams just fine initializing and flushing the filters and codecs properly. Signed-off-by: Marton Balint ---

Re: [FFmpeg-devel] OpenCV filter should be built as C++, and C builds fail since OpenCV 3.4.1

On 3/19/2018 5:01 PM, Jan Ekström wrote: > On Mon, Mar 19, 2018 at 6:28 PM, wm4 wrote: >> On Mon, 19 Mar 2018 09:35:22 -0400 >> Jeff Cook wrote: >> >>> Hello, >>> >>> Please see the bug report at https://github.com/opencv/opencv/issues/10963

Re: [FFmpeg-devel] [PATCH] avfilter: add hrtfm filter

Paul B Mahol (2018-03-19): > No I will not! Changes are to be sent to the mailing-list, that is the policy. You are not allowed to change it unilaterally. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter: add hrtfm filter

On 3/19/18, Nicolas George wrote: > Paul B Mahol (2018-03-19): >> If there are no more comments, I would like to push >> an improved version of this. > > If it is changed compared to what was sent to the mailing-list, re-send > it to the mailing-list. No I will not! And what can

Re: [FFmpeg-devel] [PATCH v3 3/7] cmdutils: use new iteration APIs

Josh de Kock (2018-03-19): > +x(av_muxer_iterate, ofmt, muxdemuxers != SHOW_DEMUXERS && > !device_only); > +x(av_demuxer_iterate, ifmt, muxdemuxers != SHOW_MUXERS && > !device_only); > +#if CONFIG_AVDEVICE > +x(av_outdev_iterate, ofmt, muxdemuxers != SHOW_DEMUXERS); > +

Re: [FFmpeg-devel] [PATCH] avfilter: add hrtfm filter

Paul B Mahol (2018-03-19): > If there are no more comments, I would like to push > an improved version of this. If it is changed compared to what was sent to the mailing-list, re-send it to the mailing-list. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH] avfilter: add hrtfm filter

On 3/16/18, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 60 ++ > libavfilter/Makefile | 1 + > libavfilter/af_hrtfm.c | 486 > +++ > libavfilter/allfilters.c |

[FFmpeg-devel] [PATCH v3 7/7] lavf/img2dec: use new iteration API

--- libavformat/img2dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index f3f52c83b3..159617f046 100644 --- a/libavformat/img2dec.c +++ b/libavformat/img2dec.c @@ -324,6 +324,7 @@ int ff_img_read_header(AVFormatContext *s1)

[FFmpeg-devel] [PATCH v3 4/7] fftools/ff*.c: use iteration API to find formats

With the new API, if avdevice_register_all() isn't called av_find_input_format() wont find devices, so switch to the new API to make sure devices would always be checked if they are available even if devices are not registered through the old API. --- fftools/ffmpeg_opt.c | 25

[FFmpeg-devel] [PATCH v3 6/7] lav*, tests: remove several register_all() calls

--- doc/examples/filter_audio.c | 2 -- doc/examples/filtering_audio.c | 2 -- doc/examples/filtering_video.c | 2 -- doc/examples/transcoding.c | 2 -- fftools/ffmpeg.c | 6 -- fftools/ffplay.c | 7 --- fftools/ffprobe.c| 4

[FFmpeg-devel] [PATCH v3 0/7] Implementation of option one

This set 'finishes' off the new API, it creates duct tape between the lavd and lavf libraries such that the groundwork for separating them is there, but lavd still requires lavf for the time-being. I have tagged this set with v3 (while they may not all be v3), to redirect review to this thread as

[FFmpeg-devel] [PATCH v3 3/7] cmdutils: use new iteration APIs

--- fftools/cmdutils.c | 239 + 1 file changed, 112 insertions(+), 127 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 708a849f51..2da313cc0a 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -1250,19 +1250,11

[FFmpeg-devel] [PATCH v3 5/7] lavf, lavd: add AVClass for lavd & use iterate API

Add an AVClass for AVDevice as the .child_class_next member for lavf's AVClass will no longer find devices. --- fftools/cmdutils.c | 10 + fftools/ffmpeg_opt.c | 2 +- libavdevice/Makefile | 1 + libavdevice/avdevice.h | 1 + libavdevice/options.c | 115

[FFmpeg-devel] [PATCH v3 2/7] lavfi: add new iteration API

--- configure| 24 +- doc/APIchanges | 4 + doc/writing_filters.txt | 6 +- libavfilter/allfilters.c | 818 +-- libavfilter/avfilter.c | 45 --- libavfilter/avfilter.h | 29 +- libavfilter/version.h| 3 + 7

[FFmpeg-devel] [PATCH v3 1/7] checkasm/Makefile: add EXTRALIBS-libavformat

--- tests/checkasm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile index 0520e264e2..ae7e810d25 100644 --- a/tests/checkasm/Makefile +++ b/tests/checkasm/Makefile @@ -61,7 +61,7 @@ tests/checkasm/checkasm.o: CFLAGS +=

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_superframe_split: move the reference in the bsf internal buffer

On 3/16/2018 7:39 PM, James Almer wrote: > There's no need to allocate a new packet for it. > > Signed-off-by: James Almer > --- > libavcodec/vp9_superframe_split_bsf.c | 21 ++--- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: fallback to codecpar parameters on input filter eof

On Mon, 19 Mar 2018, wm4 wrote: On Sun, 18 Mar 2018 20:09:08 +0100 Marton Balint wrote: Fixes ticket #6854 and the following simpler case: ffmpeg -f lavfi -i testsrc=d=1 -f lavfi -i testsrc=d=0 -filter_complex overlay -f null none Signed-off-by: Marton Balint

Re: [FFmpeg-devel] [DISCUSSION] New iteration APIs, lavf and lavd

On 19 March 2018 at 02:59, Josh de Kock wrote: > Hi, > > The new iteration API to replace the old _next() is nearing the end of > it's completion with the lavfi patch on the mailing list and only one > outstanding issue: > > AVOptions would not be found for devices as there is

Re: [FFmpeg-devel] [DISCUSSION] New iteration APIs, lavf and lavd

Josh de Kock (2018-03-19): > The new iteration API to replace the old _next() is nearing the end of it's > completion with the lavfi patch on the mailing list and only one outstanding > issue: > > AVOptions would not be found for devices as there is no AVClass for lavd. At > the moment it would

Re: [FFmpeg-devel] OpenCV filter should be built as C++, and C builds fail since OpenCV 3.4.1

On Mon, Mar 19, 2018 at 6:28 PM, wm4 wrote: > On Mon, 19 Mar 2018 09:35:22 -0400 > Jeff Cook wrote: > >> Hello, >> >> Please see the bug report at https://github.com/opencv/opencv/issues/10963 , >> which discusses OpenCV's failure to build as

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: add av_packet_make_writable()

On 3/19/2018 1:32 PM, wm4 wrote: > On Mon, 19 Mar 2018 12:42:16 -0300 > James Almer wrote: > >> Useful as well to quickly make a packet reference counted when it >> isn't already so. >> >> Signed-off-by: James Almer >> --- >> libavcodec/avcodec.h | 11

Re: [FFmpeg-devel] [DISCUSSION] New iteration APIs, lavf and lavd

On 3/19/18, wm4 wrote: > On Mon, 19 Mar 2018 02:59:54 + > Josh de Kock wrote: > >> Hi, >> >> The new iteration API to replace the old _next() is nearing the end of >> it's completion with the lavfi patch on the mailing list and only one >> outstanding

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: fallback to codecpar parameters on input filter eof

On Sun, 18 Mar 2018 20:09:08 +0100 Marton Balint wrote: > Fixes ticket #6854 and the following simpler case: > > ffmpeg -f lavfi -i testsrc=d=1 -f lavfi -i testsrc=d=0 -filter_complex > overlay -f null none > > Signed-off-by: Marton Balint > --- >

Re: [FFmpeg-devel] [DISCUSSION] New iteration APIs, lavf and lavd

On Mon, 19 Mar 2018 02:59:54 + Josh de Kock wrote: > Hi, > > The new iteration API to replace the old _next() is nearing the end of > it's completion with the lavfi patch on the mailing list and only one > outstanding issue: > > AVOptions would not be found for devices

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: add av_packet_make_writable()

On Mon, 19 Mar 2018 12:42:16 -0300 James Almer wrote: > Useful as well to quickly make a packet reference counted when it > isn't already so. > > Signed-off-by: James Almer > --- > libavcodec/avcodec.h | 11 +++ > libavcodec/avpacket.c | 24

Re: [FFmpeg-devel] OpenCV filter should be built as C++, and C builds fail since OpenCV 3.4.1

On Mon, 19 Mar 2018 09:35:22 -0400 Jeff Cook wrote: > Hello, > > Please see the bug report at https://github.com/opencv/opencv/issues/10963 , > which discusses OpenCV's failure to build as pure C since upstream version > 3.4.1, and also discusses how all modules

Re: [FFmpeg-devel] OpenCV filter should be built as C++, and C builds fail since OpenCV 3.4.1

On Mon, 19 Mar 2018 09:35:22 -0400 Jeff Cook wrote: > Hello, > > Please see the bug report at https://github.com/opencv/opencv/issues/10963 , > which discusses OpenCV's failure to build as pure C since upstream version > 3.4.1, and also discusses how all modules

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: add av_packet_make_writable()

On 3/19/2018 12:45 PM, Paul B Mahol wrote: > On 3/19/18, James Almer wrote: >> Useful as well to quickly make a packet reference counted when it >> isn't already so. >> >> Signed-off-by: James Almer >> --- >> libavcodec/avcodec.h | 11 +++ >>

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: add av_packet_make_writable()

On 3/19/18, James Almer wrote: > Useful as well to quickly make a packet reference counted when it > isn't already so. > > Signed-off-by: James Almer > --- > libavcodec/avcodec.h | 11 +++ > libavcodec/avpacket.c | 24 > 2

[FFmpeg-devel] [PATCH] avcodec/avpacket: add av_packet_make_writable()

Useful as well to quickly make a packet reference counted when it isn't already so. Signed-off-by: James Almer --- libavcodec/avcodec.h | 11 +++ libavcodec/avpacket.c | 24 2 files changed, 35 insertions(+) diff --git a/libavcodec/avcodec.h

Re: [FFmpeg-devel] [FFmpeg][PATCH] lavc/cfhd: introduced interlaced using temporal horizontal transform

On 3/19/2018 6:47 AM, Gagandeep Singh wrote: > interlaced files require horizontal-temporal transform that has been added. > Output is not satisfactory yet! > --- > libavcodec/cfhd.c | 137 > +- > libavcodec/cfhd.h | 3 +- > 2 files changed,

[FFmpeg-devel] OpenCV filter should be built as C++, and C builds fail since OpenCV 3.4.1

Hello, Please see the bug report at https://github.com/opencv/opencv/issues/10963 , which discusses OpenCV's failure to build as pure C since upstream version 3.4.1, and also discusses how all modules that use OpenCV 2 or later should be compiled as C++ to avoid esoteric issues and serious

Re: [FFmpeg-devel] [PATCH] ffmpeg.c - drain all decoded frames during stream_loop flush

On 3/16/2018 10:24 AM, Gyan Doshi wrote: Revised patch only drains 1 packet per call and loops via transcode_step() till EOF, just like when decoders are truly closed. Functionally the same result as first version. On 3/15/2018 3:31 PM, Gyan Doshi wrote: Fixes a bug with flushing decoders

[FFmpeg-devel] [FFmpeg][PATCH] lavc/cfhd: introduced interlaced using temporal horizontal transform

interlaced files require horizontal-temporal transform that has been added. Output is not satisfactory yet! --- libavcodec/cfhd.c | 137 +- libavcodec/cfhd.h | 3 +- 2 files changed, 107 insertions(+), 33 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 1/2] fftools/cmdutils: add logflags option

On 14.03.2018 09:55, Tobias Rapp wrote: Allows to set the AV_LOG_PRINT_LEVEL and AV_LOG_SKIP_REPEATED flags using a distinct command-line option, similar to other flag options. Previously only the AV_LOG_SKIP_REPEATED flag was supported as a prefix to the "loglevel" option value. Signed-off-by:

Re: [FFmpeg-devel] [PATCH] lavc/cfhd: added interlaced frame decoding

On 3/19/18, Gagandeep Singh wrote: > On Sat, Mar 17, 2018 at 5:00 PM, Carl Eugen Hoyos > wrote: > Wrong way. Post patch against master ffmpeg, not against previous patch. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] lavc/cfhd: added interlaced frame decoding

On Sat, Mar 17, 2018 at 5:00 PM, Carl Eugen Hoyos wrote: > 2018-03-17 10:42 GMT+01:00, Gagandeep Singh : > > ticket #5522: interlaced frame required horizontal-temporal inverse > > transform. though the output is not satisfactory yet. > > > diff