Re: [FFmpeg-devel] [PATCH] vf_libvmaf: Fix memory leak

Hi, On Sun, Mar 25, 2018 at 9:44 AM, enctac wrote: > Fixes ticket #6967 > --- > libavfilter/vf_libvmaf.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavfilter/vf_libvmaf.c b/libavfilter/vf_libvmaf.c > index dfe474c40c..42c6b66b69 100644 > ---

[FFmpeg-devel] [PATCH 3/6] lavf: move avpriv function definition to internal.h

Signed-off-by: Josh de Kock --- libavdevice/alldevices.c | 1 + libavformat/allformats.c | 1 + libavformat/avformat.h | 2 -- libavformat/internal.h | 1 + 4 files changed, 3 insertions(+), 2 deletions(-) diff --git a/libavdevice/alldevices.c b/libavdevice/alldevices.c

[FFmpeg-devel] [PATCH 5/6] Revert "avformat/format: temporarily use old next api"

This reverts commit 909e00ae816df9b6a05b1c4d0cafb794d4d0ca28. There is no need to use the old API anymore as the new API now behaves in the same way (treating devices as formats when loaded). Signed-off-by: Josh de Kock --- libavformat/format.c | 19 --- 1

[FFmpeg-devel] [PATCH 4/6] lav*, tests: remove several register_all calls

avdevice_register_all() is still required to register devices into lavf (this is required due to lavd being somewhat of a hack). Signed-off-by: Josh de Kock --- doc/examples/filter_audio.c | 2 -- doc/examples/filtering_audio.c | 2 -- doc/examples/filtering_video.c |

[FFmpeg-devel] [PATCH 6/6] lavf/format: use const AVInputFormat for iteration

Signed-off-by: Josh de Kock --- libavformat/format.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/format.c b/libavformat/format.c index 1b2ce22e25..1c66afb7e6 100644 --- a/libavformat/format.c +++ b/libavformat/format.c @@ -117,11

[FFmpeg-devel] [PATCH 2/6] lavf/img2dec: use new iteration API

Signed-off-by: Josh de Kock --- libavformat/img2dec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index f3f52c83b3..5fda850e7d 100644 --- a/libavformat/img2dec.c +++ b/libavformat/img2dec.c @@ -323,7

[FFmpeg-devel] [PATCH 1/6] lavf/allformats: remove left-over index decrement

Signed-off-by: Josh de Kock --- libavformat/allformats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/allformats.c b/libavformat/allformats.c index 2a20548c95..cf430a9680 100644 --- a/libavformat/allformats.c +++ b/libavformat/allformats.c @@

Re: [FFmpeg-devel] [PATCH v5] avfilter: add OpenCL scale filter

On 3/31/18 10:08 PM Michael Niedermayer wrote: > doesnt apply anymore Fixed. From 2b78da0f9d2e49d3ae5d5c8c751371666ded85f3 Mon Sep 17 00:00:00 2001 From: Gabriel Machado Date: Sat, 31 Mar 2018 23:03:18 -0300 Subject: [PATCH] avfilter: add OpenCL scale filter ---

Re: [FFmpeg-devel] [PATCH] use bcrypt instead of the old wincrypt API

On Fri, Mar 30, 2018 at 02:44:52PM +0200, Steve Lhomme wrote: > Remove the wincrypt API calls since we don't support XP anymore and bcrypt is > available since Vista, even on Windows Store builds. > --- > configure | 6 +++--- > libavutil/random_seed.c | 20 ++-- >

Re: [FFmpeg-devel] [PATCH v4] avfilter: add OpenCL scale filter

On Sat, Mar 31, 2018 at 05:11:16AM +, Gabriel Machado wrote: > From: Gabriel Machado > > Implemented the scaling filters using discrete convolution and ported most > of the filters from libswscale. > > --- > configure | 1 + >

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavfi: add new iteration API

On Sun, Apr 01, 2018 at 02:27:38AM +0200, Michael Niedermayer wrote: > On Sat, Mar 31, 2018 at 11:00:18PM +, Josh de Kock wrote: > > ffmpeg | branch: master | Josh de Kock | Sun Feb 18 > > 17:20:26 2018 +| [8f1382f80e0d4184c54c14afdda6482f050fbba7] | > > committer:

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavfi: add new iteration API

On Sat, Mar 31, 2018 at 11:00:18PM +, Josh de Kock wrote: > ffmpeg | branch: master | Josh de Kock | Sun Feb 18 > 17:20:26 2018 +| [8f1382f80e0d4184c54c14afdda6482f050fbba7] | committer: > Josh de Kock > > lavfi: add new iteration API > > Signed-off-by: Josh de Kock

Re: [FFmpeg-devel] [PATCH] avfilter/vf_signature: use av_strlcpy()

On Fri, Mar 30, 2018 at 03:30:51AM +0200, Michael Niedermayer wrote: > Fixes: out of array access > > Found-by: Kira > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_signature.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH] [RFC] avformat/movenc: support writing iTunes cover image

On Sat, Mar 31, 2018 at 09:54:01AM +0300, Timo Teras wrote: > Hi > > On Sat, 31 Mar 2018 02:13:14 +0200 > Michael Niedermayer wrote: > > > On Thu, Mar 29, 2018 at 09:45:13AM +0300, Timo Teräs wrote: > > > Fixes https://trac.ffmpeg.org/ticket/2798 > > > > > > This makes

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

On Sat, Mar 31, 2018 at 03:39:58PM +0100, Derek Buitenhuis wrote: > On 3/29/2018 7:55 PM, Michael Niedermayer wrote: > >> That is not what i meant > >> > >> what i meant is to align the APIs that handle timespan related information > >> and not have totally different interfaces for each. > >> For

Re: [FFmpeg-devel] [PATCH 3/4] lavf: move avpriv function definition to internal.h

On 3/31/2018 8:30 PM, James Almer wrote: > On 3/31/2018 8:24 PM, Josh de Kock wrote: >> Signed-off-by: Josh de Kock > > Add a line saying it was mistakenly added to avformat.h > >> --- >> libavformat/avformat.h | 2 -- >> libavformat/internal.h | 1 + >> 2 files changed, 1

Re: [FFmpeg-devel] [PATCH 4/4] lav*, tests: remove several register_all calls

On 3/31/2018 8:24 PM, Josh de Kock wrote: > avdevice_register_all() is still required to register devices into > lavf (this is required due to lavd being somewhat of a hack). > [...] > diff --git a/tools/uncoded_frame.c b/tools/uncoded_frame.c > index 3aaa4b6897..efea445b5f 100644 > ---

Re: [FFmpeg-devel] [PATCH 3/4] lavf: move avpriv function definition to internal.h

On 3/31/2018 8:24 PM, Josh de Kock wrote: > Signed-off-by: Josh de Kock Add a line saying it was mistakenly added to avformat.h > --- > libavformat/avformat.h | 2 -- > libavformat/internal.h | 1 + > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git

[FFmpeg-devel] [PATCH 3/4] lavf: move avpriv function definition to internal.h

Signed-off-by: Josh de Kock --- libavformat/avformat.h | 2 -- libavformat/internal.h | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index ec4e5f45f5..a2fe7c6bb2 100644 --- a/libavformat/avformat.h +++

[FFmpeg-devel] [PATCH 4/4] lav*, tests: remove several register_all calls

avdevice_register_all() is still required to register devices into lavf (this is required due to lavd being somewhat of a hack). Signed-off-by: Josh de Kock --- doc/examples/filter_audio.c | 2 -- doc/examples/filtering_audio.c | 2 -- doc/examples/filtering_video.c |

[FFmpeg-devel] [PATCH 1/4] lavf/img2dec: use new iteration API

Signed-off-by: Josh de Kock --- libavformat/img2dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index f3f52c83b3..159617f046 100644 --- a/libavformat/img2dec.c +++ b/libavformat/img2dec.c @@ -324,6 +324,7

[FFmpeg-devel] [PATCH 2/4] Revert "avformat/format: temporarily use old next api"

This reverts commit 909e00ae816df9b6a05b1c4d0cafb794d4d0ca28. There is no need to use the old API anymore as the new API now behaves in the same way (treating devices as formats when loaded). Signed-off-by: Josh de Kock --- libavformat/format.c | 13 + 1 file

Re: [FFmpeg-devel] [PATCH] avformat/mov: parse multiple iTunes cover images

On Thu, Mar 29, 2018 at 03:59:33PM +0300, Timo Teräs wrote: > Multiple cover images are supported by having multiple data atoms > inside the covr atom. AtomicParsley and mutagen amongst others > support and document this construct. > > Signed-off-by: Timo Teräs > --- >

[FFmpeg-devel] [PATCH] lavc: prefer the mp3float decoder to the mp3 decoder

On modern x86 systems its around 2x faster. For systems without FPUs it'll be slower, but our policy is to prefer floating point implementations and to let users decide what's best (or just not compile them on systems without FPUs). Signed-off-by: Rostislav Pehlivanov ---

Re: [FFmpeg-devel] [PATCH 0/5] Add lavfi api & remove device iteration

On 2018/03/25 13:53, Josh de Kock wrote: On 2018/03/23 20:48, Josh de Kock wrote: This set is an alternative to the previous set I posted, it makes it so that the current behaviour is kept (devices are returned in by the iteration functions but must be loaded in manually). It is a compromise

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fix timestamps to be strictly monotonic for video also.

On Thu, Mar 29, 2018 at 03:58:09PM -0700, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavformat/mov.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) The commit message should explain why this change is done. Not just what is changed

Re: [FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

On Sat, Mar 31, 2018 at 8:09 PM, Jan Ekström wrote: > With certain types of input and the filter chain getting re-initialized > or re-configured, multiple nullptr AVSubtitles can get pushed into > sub2video_update() in a row from sub2video_heartbeat. > > This causes end_pts, and

Re: [FFmpeg-devel] [PATCH] avcodec/utvideodec: Set pro flag based on fourcc

On Sat, Mar 31, 2018 at 08:59:29AM +0200, Paul B Mahol wrote: > On 3/31/18, Michael Niedermayer wrote: > > This avoids mixing 8bit variants with pro and 10bit with non pro mode. > > Fixes: out of array read > > Fixes: poc_03_30.avi > > > > Found-by: GwanYeong Kim

[FFmpeg-devel] [PATCH] avcodec/aacdec_fixed: Fix integer overflow in apply_independent_coupling_fixed()

I was not able to reproduce this, this fix is based on just the fuzzer log. Fixes: 4959/clusterfuzz-testcase-minimized-6035350934781952 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCH] bug in avcodec_find_best_pix_fmt_of_list

Hello! Let me propose to review my patch for avcodec_find_best_pix_fmt_of_list. It's very old bug. Here is example: AVPixelFormat pixFmts[] = { AV_PIX_FMT_RGB24, AV_PIX_FMT_RGBA }; int loss = 0; AVPixelFormat best_fmt = avcodec_find_best_pix_fmt_of_list(pixFmts, AV_PIX_FMT_BGRA, 1, ); Now

[FFmpeg-devel] [PATCH] ffmpeg: prevent premature EOF in sub2video with nullptr AVSubtitles

With certain types of input and the filter chain getting re-initialized or re-configured, multiple nullptr AVSubtitles can get pushed into sub2video_update() in a row from sub2video_heartbeat. This causes end_pts, and on the next round pts, to become INT64_MAX, latter of which signals EOF in

Re: [FFmpeg-devel] avcodec/prores_ks : do not call estimate_alpha at each quantification step

> > probably ok, check that this does not break alpha encoding. > > Alpha encoding still work. In fact this patch improve quality, when alpha encoding is used. (Not intented at the start). The modification came from the suppression of error arg and the move of estimate_alpha. Before this patch,

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

On 3/29/2018 7:55 PM, Michael Niedermayer wrote: >> That is not what i meant >> >> what i meant is to align the APIs that handle timespan related information >> and not have totally different interfaces for each. >> For example they might share the same struct in some cases to deliver data >> They

Re: [FFmpeg-devel] [PATCH] use bcrypt instead of the old wincrypt API

On 3/30/2018 1:44 PM, Steve Lhomme wrote: > +if (BCRYPT_SUCCESS(ret)) { > +NTSTATUS ret = BCryptGenRandom(algo_handle, , sizeof(seed), 0); > +BCryptCloseAlgorithmProvider(algo_handle, 0); > +if (BCRYPT_SUCCESS(ret)) > return seed; > } How does this

Re: [FFmpeg-devel] [PATCH 0/8] HLS/DASH live streaming stability updates

Hi, On 3/30/2018 6:07 AM, vdi...@akamai.com wrote: > This patch series contains minor bug fixes and error handling functionalities > for uninterrupted long duration HLS/DASH live streaming use cases. During live > streaming, it was observed that ingest network fluctuations are common which > were

[FFmpeg-devel] avfilter/showvolume : add new options and minor clean

Hello, In attach new patchs for showvolume filter 001 : Move the clear picture part to a new func, and use it if fade option == 0. (no need to calculate it in float) 002/003 : Move "height" condition for draw volume at the start of the loop and indent 004 : add a new option for choosing the

Re: [FFmpeg-devel] avfilter/showvolume : various "fix"

Hello, > > I applied what I considered useful. > For different scale, please implement it as another option. > Ok will send a new patch > > Just use f=0 if you want instant output without fading. > With some of your patches this option wouldn no longer do anything. > > Thanks for the patch for

Re: [FFmpeg-devel] avfilter/showvolume : various "fix"

On 3/30/18, Martin Vignali wrote: > Hello, > > After discussion in user mailing list, > several patchs, trying to fix various "issue" with showvolume filter > > A wav example can be found here (1000 hz with -12 db, then -18 db then 0 > db) : > https://we.tl/X6L69kEWAN >

Re: [FFmpeg-devel] [PATCH 3/3] arm: hevcdsp: Avoid using macro expansion counters

On Sat, 31 Mar 2018, Hendrik Leppkes wrote: On Fri, Mar 30, 2018 at 9:14 PM, Martin Storsjö wrote: Clang supports the macro expansion counter (used for making unique labels within macro expansions), but not when targeting darwin. Convert uses of the counter into normal

Re: [FFmpeg-devel] [PATCH] avcodec/utvideodec: Set pro flag based on fourcc

On 3/31/18, Michael Niedermayer wrote: > This avoids mixing 8bit variants with pro and 10bit with non pro mode. > Fixes: out of array read > Fixes: poc_03_30.avi > > Found-by: GwanYeong Kim > Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] [RFC] avformat/movenc: support writing iTunes cover image

Hi On Sat, 31 Mar 2018 02:13:14 +0200 Michael Niedermayer wrote: > On Thu, Mar 29, 2018 at 09:45:13AM +0300, Timo Teräs wrote: > > Fixes https://trac.ffmpeg.org/ticket/2798 > > > > This makes movenc handle AV_DISPOSITION_ATTACHED_PIC and write > > the associated