Re: [FFmpeg-devel] [GSOC][PATCH 1/3] lavc/cfhd:3d transform decoding for both progressive and interlaced

2018-08-17 Thread Carl Eugen Hoyos
2018-08-17 8:15 GMT+02:00, Gagandeep Singh : >> also i saw on the IRC log after you logged off >> also how do i send the 3 samples i have Assuming they are small (look at the existing files in fate), upload them to your favorite file-hoster (for example dropbox) and post a link here. Carl Eugen

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/asfdec_o: Check size_bmp more fully

2018-08-17 Thread Carl Eugen Hoyos
2018-08-15 23:49 GMT+02:00, Michael Niedermayer : > ffmpeg | branch: release/3.2 | Michael Niedermayer > | Tue Jul 3 21:01:23 2018 +0200| [67149cb2f68e3e96cd75804d83827ccd03386695] > | committer: James Almer > > avformat/asfdec_o: Check size_bmp more fully It may be a simpler solution to remove

Re: [FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

2018-08-17 Thread Carl Eugen Hoyos
2018-08-03 20:28 GMT+02:00, Paweł Wegner : > One could copy the initialization to the top from the while loop: > init_sec_buffer(&outbuf[0], SECBUFFER_TOKEN, NULL, 0); > init_sec_buffer(&outbuf[1], SECBUFFER_ALERT, NULL, 0); > init_sec_buffer(&outbuf[2], SECBUFFER_EMPTY, NULL, 0); > init_s

Re: [FFmpeg-devel] [PATCH] h264: Support multi-field closed captions by using AVBufferRef and not resetting per field

2018-08-17 Thread Carl Eugen Hoyos
2018-08-16 12:52 GMT+02:00, jos...@ob-encoder.com : > @@ -429,6 +429,12 @@ int ff_h264_update_thread_context(AVCodecContext *dst, > MAX_DELAYED_PIC_COUNT + 2, h, h1); > > h->frame_recovered = h1->frame_recovered; > +if (h1->sei.a53_caption.buf_ref) { > +

Re: [FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

2018-08-17 Thread Paweł Wegner
Yes, this works as well. I attached fixed patch. On Fri, Aug 17, 2018 at 11:15 AM Carl Eugen Hoyos wrote: > 2018-08-03 20:28 GMT+02:00, Paweł Wegner : > > > One could copy the initialization to the top from the while loop: > > init_sec_buffer(&outbuf[0], SECBUFFER_TOKEN, NULL, 0); > > init_s

[FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

2018-08-17 Thread Paweł Wegner
Yes, it will work. Fixes: runtime error: passing uninitialized value to FreeContextBuffer causes a crash Signed-off-by: Paweł Wegner --- libavformat/tls_schannel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/tls_schannel.c b/libavformat/tls_schannel.c index f

[FFmpeg-devel] [PATCH v2] h264: Support multi-field closed captions by using AVBufferRef and not resetting per field

2018-08-17 Thread joshdk
From: Kieran Kunhya Signed-off-by: Josh de Kock --- libavcodec/h264_sei.c | 15 --- libavcodec/h264_sei.h | 3 +-- libavcodec/h264_slice.c | 26 ++ libavcodec/h264dec.c| 5 +++-- 4 files changed, 30 insertions(+), 19 deletions(-) diff --git a/libav

Re: [FFmpeg-devel] [PATCH 4/7] Adds gray floating-point pixel formats.

2018-08-17 Thread Sergey Lavrushkin
пт, 17 авг. 2018 г., 6:47 James Almer : > On 8/14/2018 1:23 PM, Michael Niedermayer wrote: > > On Mon, Aug 13, 2018 at 04:58:42PM +0300, Sergey Lavrushkin wrote: > >>> > >>> Just use av_clipf instead of FFMIN/FFMAX. > >> > >> > >> Changed FFMIN/FFMAX to av_clip_uint16 and av_clip_uint8. > > > > wi

Re: [FFmpeg-devel] [PATCH] libavcodec/cuviddec A53CC closed captions support added to cuviddec & nvenc

2018-08-17 Thread Carl Eugen Hoyos
2018-05-03 19:42 GMT+02:00, Timo Rothenpieler : > Slightly refactored nvenc part can be found here: > https://github.com/BtbN/FFmpeg/commit/e5d85ac3 > > Will push tomorrow if no issue with it comes up. Why is there no option to disable Closed Captions encoding? Especially as all other h264 encoder

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-17 Thread Carl Eugen Hoyos
2018-08-14 9:57 GMT+02:00, Gyan Doshi : > > > On 14-08-2018 01:20 PM, Paul B Mahol wrote: >> On 8/14/18, Gyan Doshi wrote: >>> >>> >>> On 14-08-2018 03:24 AM, Carl Eugen Hoyos wrote: >>> >> >> Why does this not use -filter_threads? > > > Didn't know it was an option. >

Re: [FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

2018-08-17 Thread Hendrik Leppkes
On Fri, Aug 17, 2018 at 12:05 PM Paweł Wegner wrote: > > Yes, it will work. > > Fixes: runtime error: passing uninitialized value to FreeContextBuffer > causes a crash > > Signed-off-by: Paweł Wegner > --- > libavformat/tls_schannel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > d

Re: [FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

2018-08-17 Thread Carl Eugen Hoyos
2018-08-17 14:36 GMT+02:00, Hendrik Leppkes : > On Fri, Aug 17, 2018 at 12:05 PM Paweł Wegner > wrote: >> >> Yes, it will work. >> >> Fixes: runtime error: passing uninitialized value to FreeContextBuffer >> causes a crash >> >> Signed-off-by: Paweł Wegner >> --- >> libavformat/tls_schannel.c |

Re: [FFmpeg-devel] [PATCH 4/7] Adds gray floating-point pixel formats.

2018-08-17 Thread Carl Eugen Hoyos
2018-08-17 14:21 GMT+02:00, Sergey Lavrushkin : > пт, 17 авг. 2018 г., 6:47 James Almer : > >> On 8/14/2018 1:23 PM, Michael Niedermayer wrote: >> > On Mon, Aug 13, 2018 at 04:58:42PM +0300, Sergey Lavrushkin wrote: >> >>> >> >>> Just use av_clipf instead of FFMIN/FFMAX. >> >> >> >> >> >> Changed F

[FFmpeg-devel] Resending Patch for hlsenc.c fixes for https://trac.ffmpeg.org/ticket/7281

2018-08-17 Thread Ronak
From 99e28c807a49cecf6ceb47ee44a85a3fdf78af64 Mon Sep 17 00:00:00 2001 From: "Ronak Patel" Date: Thu, 2 Aug 2018 09:25:12 -0400 Subject: [PATCH v3] libavformat/hlsenc: Fix HLS Manifest Generation from an N^2 algorithm to N. This fixes the creation of the hls manifest in hlsenc.c by writing the e

Re: [FFmpeg-devel] Resending Patch for hlsenc.c fixes for https://trac.ffmpeg.org/ticket/7281

2018-08-17 Thread Ronak
> On Aug 16, 2018, at 7:47 PM, Steven Liu wrote: > > > >> On Aug 16, 2018, at 22:31, Ronak wrote: >> >> From: "Ronak Patel" >> >> This fixes the creation of the hls manifest in hlsenc.c by writing the >> entire manifest at the end for VOD playlists. Live & Event Playlists are >> unaffecte

Re: [FFmpeg-devel] [PATCH] lavfi/vf_libvmaf: update to use libvmaf v1.3.9

2018-08-17 Thread Gyan Doshi
On 17-08-2018 06:12 PM, Carl Eugen Hoyos wrote: 2018-08-14 9:57 GMT+02:00, Gyan Doshi : filter_threads applies to all simple filtergraphs. The private option is specifically targeted. Isn't that better? I believe the opposite is true. Which - preference for private option or application

Re: [FFmpeg-devel] [PATCH v2] h264: Support multi-field closed captions by using AVBufferRef and not resetting per field

2018-08-17 Thread James Almer
On 8/17/2018 7:41 AM, jos...@ob-encoder.com wrote: > From: Kieran Kunhya > > Signed-off-by: Josh de Kock > --- > libavcodec/h264_sei.c | 15 --- > libavcodec/h264_sei.h | 3 +-- > libavcodec/h264_slice.c | 26 ++ > libavcodec/h264dec.c| 5 +++-- > 4

[FFmpeg-devel] [PATCH v3] h264: Support multi-field closed captions by using AVBufferRef and not resetting per field

2018-08-17 Thread joshdk
From: Kieran Kunhya Signed-off-by: Josh de Kock --- libavcodec/h264_sei.c | 15 --- libavcodec/h264_sei.h | 3 +-- libavcodec/h264_slice.c | 22 ++ libavcodec/h264dec.c| 5 +++-- 4 files changed, 26 insertions(+), 19 deletions(-) diff --git a/libavcode

Re: [FFmpeg-devel] Resending Patch for hlsenc.c fixes for https://trac.ffmpeg.org/ticket/7281

2018-08-17 Thread Steven Liu
> On Aug 17, 2018, at 21:01, Ronak wrote: > > From 99e28c807a49cecf6ceb47ee44a85a3fdf78af64 Mon Sep 17 00:00:00 2001 > From: "Ronak Patel" > Date: Thu, 2 Aug 2018 09:25:12 -0400 > Subject: [PATCH v3] libavformat/hlsenc: Fix HLS Manifest Generation from an > N^2 algorithm to N. > > This fixes

Re: [FFmpeg-devel] [PATCH 3/5] Renamed reinterlace to tinterlace

2018-08-17 Thread Thomas Mundt
Hi, 2018-08-16 13:56 GMT+02:00 Vasile Toncu : > Hi, > > Thank you for the additional testing effort. > Fixed the issue. > > thanks, the patch looks good to me as far as I can judge. It´s up to more experienced developers now to permit the license change. Can anybody please have a look at this. R

Re: [FFmpeg-devel] [PATCH 2/2] libavfilter: Removes stored DNN models. Adds support for native backend model file format in tf backend.

2018-08-17 Thread Sergey Lavrushkin
2018-08-17 17:46 GMT+03:00 Pedro Arthur : > Hi, > > You did not provided any pre trained model files, so anyone trying to > test it has to perform the whole training! > I'm attaching the models I generated, if anyone is interested in testing > it. > > When applying the filter with tf backend there

Re: [FFmpeg-devel] [PATCH v3] h264: Support multi-field closed captions by using AVBufferRef and not resetting per field

2018-08-17 Thread Joshua de Kock
On 17 August 2018 at 15:12, wrote: > From: Kieran Kunhya > > Signed-off-by: Josh de Kock > --- > libavcodec/h264_sei.c | 15 --- > libavcodec/h264_sei.h | 3 +-- > libavcodec/h264_slice.c | 22 ++ > libavcodec/h264dec.c| 5 +++-- > 4 files changed, 26

[FFmpeg-devel] HEVC HDR playback issues #7347

2018-08-17 Thread Igor.Selivanov
Dear developers, please find attached patch für Dolby Vision media support (ticket #7347). https://trac.ffmpeg.org/ticket/7347 Thanks in advance Freundliche Grüße / Best Regards / 祝好 Igor Selivanov Software Development Loewe Technologies GmbH Hildesheimer Str. 140 D-30173 Hannover Phone: +49 51

Re: [FFmpeg-devel] [PATCH 2/2 v2] avformat/av1: update ff_isom_write_av1c() to the latest revision of the spec

2018-08-17 Thread James Almer
On 8/16/2018 6:50 PM, Thomas Daede wrote: > On 08/16/2018 02:22 PM, James Almer wrote: >> This will get ISOBMFF and Matroska up to date with the revised AV1 Codec >> Configuration Box spec. >> For now keep propagating raw OBUs as extradata until all libavcodec modules >> are adapted to handle AV1Co

[FFmpeg-devel] [PATCH] avformat/nsvdec: Do not parse multiple NSVf

2018-08-17 Thread Michael Niedermayer
The specification states "NSV files may contain a single file header. " Fixes: out of array access Fixes: nsv-asan-002f473f726a0dcbd3bd53e422c4fc40b3cf3421 Found-by: Paul Ch Tested-by: Paul Ch Signed-off-by: Michael Niedermayer --- libavformat/nsvdec.c | 7 +++ 1 file changed, 7 insertions

Re: [FFmpeg-devel] [PATCH 3/3] avformat/rmdec: Fix EOF check in the stream loop in ivr_read_header()

2018-08-17 Thread Michael Niedermayer
On Thu, Aug 16, 2018 at 03:48:24PM +0200, Paul B Mahol wrote: > On 8/16/18, Michael Niedermayer wrote: > > Fixes: long running loop > > Fixes: ivr-timeout-42468cb797f52f025fb329394702f5d4d64322d6 > > > > Found-by: Paul Ch > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/rmdec.c |

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mlvdec: read_string() received unsigned size, make the argument unsigned

2018-08-17 Thread Michael Niedermayer
On Thu, Aug 16, 2018 at 03:47:55PM +0200, Paul B Mahol wrote: > On 8/16/18, Michael Niedermayer wrote: > > Fixes: infinite loop > > Fixes: mlv-timeout-e3b8cab9835edecad6823baa057e029671329d04 > > > > Found-by: Paul Ch > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/mlvdec.c | 2 +

Re: [FFmpeg-devel] [PATCH] avformat/avidec: fix demuxing of all keyframes of sample 200707170736151.avi

2018-08-17 Thread Michael Niedermayer
On Thu, Aug 16, 2018 at 12:18:48PM +0200, Paul B Mahol wrote: > Hi, > > better patch attached. LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do not agree with what you have to say, but I'll defend to the death your right to say it. -- Voltaire

Re: [FFmpeg-devel] [GSOC][PATCH 1/3] lavc/cfhd:3d transform decoding for both progressive and interlaced

2018-08-17 Thread Michael Niedermayer
On Fri, Aug 17, 2018 at 11:45:04AM +0530, Gagandeep Singh wrote: > On Wed, Aug 15, 2018 at 3:12 AM Michael Niedermayer > wrote: > > > On Tue, Aug 14, 2018 at 01:12:37PM +0530, Gagandeep Singh wrote: > > > IP sample decoding patch attached herein. > > > > > > Gagandeep Singh > > > > > cfhd.c | 5

Re: [FFmpeg-devel] [GSOC][PATCH 1/3] lavc/cfhd:3d transform decoding for both progressive and interlaced

2018-08-17 Thread Michael Niedermayer
On Fri, Aug 17, 2018 at 11:45:04AM +0530, Gagandeep Singh wrote: [...] > > > [...] > > > @@ -726,14 +814,15 @@ static int cfhd_decode(AVCodecContext *avctx, void > > *data, int *got_frame, > > > } > > > } > > > } > > > - > > > -if (!s->a_width || !s->a_height || s->a

Re: [FFmpeg-devel] [PATCH 4/7] Adds gray floating-point pixel formats.

2018-08-17 Thread Michael Niedermayer
On Fri, Aug 17, 2018 at 12:46:52AM -0300, James Almer wrote: > On 8/14/2018 1:23 PM, Michael Niedermayer wrote: > > On Mon, Aug 13, 2018 at 04:58:42PM +0300, Sergey Lavrushkin wrote: > >>> > >>> Just use av_clipf instead of FFMIN/FFMAX. > >> > >> > >> Changed FFMIN/FFMAX to av_clip_uint16 and av_cl

Re: [FFmpeg-devel] HEVC HDR playback issues #7347

2018-08-17 Thread Michael Niedermayer
On Fri, Aug 17, 2018 at 12:46:23PM +, igor.seliva...@loewe.de wrote: > Dear developers, > > please find attached patch für Dolby Vision media support (ticket #7347). > https://trac.ffmpeg.org/ticket/7347 > > Thanks in advance > Freundliche Grüße / Best Regards / 祝好 > > Igor Selivanov > Softw

Re: [FFmpeg-devel] HEVC HDR playback issues #7347

2018-08-17 Thread Michael Niedermayer
On Fri, Aug 17, 2018 at 12:46:23PM +, igor.seliva...@loewe.de wrote: > Dear developers, > > please find attached patch für Dolby Vision media support (ticket #7347). > https://trac.ffmpeg.org/ticket/7347 > > Thanks in advance > Freundliche Grüße / Best Regards / 祝好 > > Igor Selivanov > Softw

Re: [FFmpeg-devel] [PATCH] lavc/hevc_ps: fix crop info for monochrome

2018-08-17 Thread Michael Niedermayer
On Fri, Aug 17, 2018 at 09:52:57AM +0800, Zhao Zhili wrote: > The values of SubWidthC and SubHeightC are 1 in the ITU-T H.265. The > current code use the value of 2. > --- > libavcodec/hevc_ps.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/

[FFmpeg-devel] [PATCH] avformat/dashdec: Fix strlen(rep_id_val) with it being NULL

2018-08-17 Thread Michael Niedermayer
Fixes: dash-crash-da39a3ee5e6b4b0d3255bfef95601890afd80709.xml Found-by: Paul Ch Signed-off-by: Michael Niedermayer --- libavformat/dashdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index f851bbf981..c6dddeb98f 100644

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: Fix strlen(rep_id_val) with it being NULL

2018-08-17 Thread Steven Liu
> On Aug 18, 2018, at 09:14, Michael Niedermayer wrote: > > Fixes: dash-crash-da39a3ee5e6b4b0d3255bfef95601890afd80709.xml > > Found-by: Paul Ch > Signed-off-by: Michael Niedermayer > --- > libavformat/dashdec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/liba