On Fri, Aug 17, 2018 at 12:46:52AM -0300, James Almer wrote: > On 8/14/2018 1:23 PM, Michael Niedermayer wrote: > > On Mon, Aug 13, 2018 at 04:58:42PM +0300, Sergey Lavrushkin wrote: > >>> > >>> Just use av_clipf instead of FFMIN/FFMAX. > >> > >> > >> Changed FFMIN/FFMAX to av_clip_uint16 and av_clip_uint8. > > > > will apply > > > > thanks > > This broke fate on some 32bit hosts. Guess float pixfmts shouldn't be > tested for bitexact output. The gbrpf32 ones aren't, for example. > http://fate.ffmpeg.org/report.cgi?time=20180816131312&slot=x86_32-debian-kfreebsd-gcc-4.4-cpuflags-mmx
hmmmm i remember i had tested this locally on 32bit can something be slightly adjusted (like an offset or factor) to avoid any values becoming close to 0.5 and rounding differently on platforms ? If not the tests should skip float pixel formats or try the nearest neighbor scaler Sergey, can you look into this (its your patch) ? (just asking to make sure not eevryone thinks someone else will work on this) thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Old school: Use the lowest level language in which you can solve the problem conveniently. New school: Use the highest level language in which the latest supercomputer can solve the problem without the user falling asleep waiting.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel