Re: [FFmpeg-devel] [PATCH] lavfi/deshake: fix deshake crash issue.

2018-09-21 Thread myp...@gmail.com
On Sat, Sep 22, 2018 at 3:25 AM Michael Niedermayer wrote: > > On Thu, Sep 20, 2018 at 10:39:37AM +0800, myp...@gmail.com wrote: > > On Wed, Sep 19, 2018 at 7:07 PM Michael Niedermayer > > wrote: > > > > > > On Tue, Sep 18, 2018 at 09:37:29PM +0800, Jun Zhao wrote: > > > > Fixes ticket #7441. > >

Re: [FFmpeg-devel] [PATCH] lavfi/deshake: fix deshake crash issue.

2018-09-21 Thread myp...@gmail.com
On Sat, Sep 22, 2018 at 6:52 AM Colin NG wrote: > > 1) The crash is caused by accessing un-allocated memory area. > 2) You can't compute the contrast outside of search window (by default, > rx=ry=16). > Yes, so I give other fix in https://patchwork.ffmpeg.org/patch/10426/, can you help to revie

[FFmpeg-devel] [PATCH 6/6] avformat/matroskadec: fix CodecID for WebVTT on Matroska

2018-09-21 Thread James Almer
D_WEBVTT/* is only valid for WebM files. Signed-off-by: James Almer --- libavformat/matroska.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavformat/matroska.c b/libavformat/matroska.c index 4d18d147fc..88575656c0 100644 --- a/libavformat/matroska.c +++ b/libavform

[FFmpeg-devel] [PATCH 5/6] avformat/matroskadec: also check ff_webm_codec_tags for valid CodecIDs

2018-09-21 Thread James Almer
Signed-off-by: James Almer --- libavformat/matroskadec.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index e6793988e1..16a326dff4 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -2188,6 +2188,14 @@ sta

Re: [FFmpeg-devel] [PATCH] avcodec/ac3dec: Fix shift signedness in mask creation

2018-09-21 Thread Michael Niedermayer
On Fri, Sep 21, 2018 at 09:30:36PM +0200, Michael Niedermayer wrote: > On Fri, Sep 21, 2018 at 10:41:18AM -0300, James Almer wrote: > > On 9/21/2018 9:30 AM, Michael Niedermayer wrote: > > > Fixes: > > > 9924/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EAC3_fuzzer-5473421772193792 > > > Fixe

Re: [FFmpeg-devel] [PATCH 1/4] avformat/matroskaenc: remove unnecessary additional codec tags

2018-09-21 Thread James Almer
On 9/21/2018 7:44 PM, Carl Eugen Hoyos wrote: > > >> Am 21.09.2018 um 23:29 schrieb James Almer : >> >> They are listed in riff.c already. >> >> Signed-off-by: James Almer >> --- >> libavformat/matroskaenc.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/libavformat/matroskaenc.c b

Re: [FFmpeg-devel] [PATCH] lavfi/deshake: fix deshake crash issue.

2018-09-21 Thread Colin NG
1) The crash is caused by accessing un-allocated memory area. 2) You can't compute the contrast outside of search window (by default, rx=ry=16). From: ffmpeg-devel on behalf of Michael Niedermayer Sent: September 21, 2018 3:24 PM To: FFmpeg development discuss

Re: [FFmpeg-devel] [PATCH 1/4] avformat/matroskaenc: remove unnecessary additional codec tags

2018-09-21 Thread Carl Eugen Hoyos
> Am 21.09.2018 um 23:29 schrieb James Almer : > > They are listed in riff.c already. > > Signed-off-by: James Almer > --- > libavformat/matroskaenc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index a0e2f426f7..61efe2e3f8

Re: [FFmpeg-devel] [PATCH 1/4] avformat/ip: factorize some IP filtering and resolving functions to a new file

2018-09-21 Thread Michael Niedermayer
On Fri, Sep 21, 2018 at 12:11:59AM +0200, Marton Balint wrote: > These are based on the very similar UDP and RTP protocol functions. > > Signed-off-by: Marton Balint [...] > new file mode 100644 > index 00..23794a6f05 > --- /dev/null > +++ b/libavformat/ip.h > @@ -0,0 +1,70 @@ > +/* > + *

[FFmpeg-devel] [PATCH 4/4] avformat/matroskaenc: reindent after the previous commit

2018-09-21 Thread James Almer
Signed-off-by: James Almer --- libavformat/matroskaenc.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 36fcfaab3f..d3e221e413 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/mat

[FFmpeg-devel] [PATCH 1/4] avformat/matroskaenc: remove unnecessary additional codec tags

2018-09-21 Thread James Almer
They are listed in riff.c already. Signed-off-by: James Almer --- libavformat/matroskaenc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index a0e2f426f7..61efe2e3f8 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaen

[FFmpeg-devel] [PATCH 3/4] avformat/matroskaenc: refactor checks for allowed codecs in WebM

2018-09-21 Thread James Almer
Use the new ff_webm_codec_tags[] array for this purpose. Signed-off-by: James Almer --- libavformat/matroskaenc.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 63bf6fb6b9..36fcfaab3

[FFmpeg-devel] [PATCH 2/4] avformat/matroskaenc: implement AVOutputFormat.query_codec for webm

2018-09-21 Thread James Almer
Signed-off-by: James Almer --- libavformat/matroska.c| 16 libavformat/matroska.h| 1 + libavformat/matroskaenc.c | 11 +++ libavformat/version.h | 2 +- 4 files changed, 29 insertions(+), 1 deletion(-) diff --git a/libavformat/matroska.c b/libavformat/matr

[FFmpeg-devel] Initialize DirectShow source filters with IFileSourceFilter::Load

2018-09-21 Thread Maxim Ershtein
Hello, ffmpeg allows capturing a/v from custom DirectShow source filters, and provides some methods to pass parameters to these filters, but these methods seem insufficient. So ffmpeg offers to launch a filter configuration dialog via -show_video_device_dialog , however, it doesn't work on some f

[FFmpeg-devel] [PATCH] avfilter: add afftdn filter

2018-09-21 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- configure|3 + doc/filters.texi | 44 ++ libavfilter/Makefile |1 + libavfilter/af_afftdn.c | 1050 ++ libavfilter/allfilters.c |1 + 5 files changed, 1099 insertions(+) create mode 100

Re: [FFmpeg-devel] [PATCH] avcodec/ac3dec: Fix shift signedness in mask creation

2018-09-21 Thread Michael Niedermayer
On Fri, Sep 21, 2018 at 10:41:18AM -0300, James Almer wrote: > On 9/21/2018 9:30 AM, Michael Niedermayer wrote: > > Fixes: > > 9924/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EAC3_fuzzer-5473421772193792 > > Fixes: left shift of 1 by 63 places cannot be represented in type 'long > > long'

Re: [FFmpeg-devel] [PATCH] lavfi/deshake: fix deshake crash issue.

2018-09-21 Thread Michael Niedermayer
On Thu, Sep 20, 2018 at 10:39:37AM +0800, myp...@gmail.com wrote: > On Wed, Sep 19, 2018 at 7:07 PM Michael Niedermayer > wrote: > > > > On Tue, Sep 18, 2018 at 09:37:29PM +0800, Jun Zhao wrote: > > > Fixes ticket #7441. > > > > > > Signed-off-by: Jun Zhao > > > --- > > > libavfilter/vf_deshake.

[FFmpeg-devel] [PATCH 0/1] Minor fix to prevent confusing logs when demuxing fragmented mp4

2018-09-21 Thread Nick Ryan
Minor fix to prevent confusing logs when demuxing fragmented mp4 Nick Ryan (1): fix - increment index_entry_pos after log statement so that logs for index entries derived from trun atom use correct index libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 (A

[FFmpeg-devel] [PATCH 1/1] fix - increment index_entry_pos after log statement so that logs for index entries derived from trun atom use correct index

2018-09-21 Thread Nick Ryan
Signed-off-by: Nick Ryan --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index ec57a05803..540e5ca057 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4856,11 +4856,11 @@ static int mov_read_trun(MOVContext

Re: [FFmpeg-devel] [PATCH] lavf/matroska: Allow AV1 in WebM

2018-09-21 Thread James Almer
On 8/20/2018 2:12 PM, Hendrik Leppkes wrote: > On Mon, Aug 20, 2018 at 7:09 PM James Almer wrote: >> >> On 8/20/2018 1:44 PM, Kagami Hiiragi wrote: >>> Nothing prevents it to work except this check. AV1 is already supported >>> by Matroska muxer and aomenc produces WebM/AV1 files as well. >>> >>>

Re: [FFmpeg-devel] [PATCH] avcodec/ac3dec: Fix shift signedness in mask creation

2018-09-21 Thread James Almer
On 9/21/2018 9:30 AM, Michael Niedermayer wrote: > Fixes: > 9924/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EAC3_fuzzer-5473421772193792 > Fixes: left shift of 1 by 63 places cannot be represented in type 'long long' > > Found-by: continuous fuzzing process > https://github.com/google/oss

[FFmpeg-devel] [PATCH] avcodec/ac3dec: Fix shift signedness in mask creation

2018-09-21 Thread Michael Niedermayer
Fixes: 9924/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EAC3_fuzzer-5473421772193792 Fixes: left shift of 1 by 63 places cannot be represented in type 'long long' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nied

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/eac3dec: Check that channel_map does not contain more than EAC3_MAX_CHANNELS

2018-09-21 Thread Michael Niedermayer
On Wed, Jun 27, 2018 at 08:11:14PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/ac3dec.c | 27 --- > libavcodec/ac3tab.c | 18 ++ > libavcodec/ac3tab.h | 2 ++ > libavcodec/eac3dec.c | 14 -- > 4

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: add support for selecting devices based on their unique ID

2018-09-21 Thread Marton Balint
On Fri, 21 Sep 2018, Jeyapal, Karthick wrote: On 9/21/18 3:35 AM, Marton Balint wrote: Also bump the API version requirement to 10.9.5, because on olders versions there were some reports of crashes using the undocumented, yet available BMDDeckLinkDeviceHandle. If we are using an undocument

[FFmpeg-devel] [PATCH V2] lavfi/deshake: fix deshake crash issue.

2018-09-21 Thread Jun Zhao
Fixes ticket #7441. for block contrast calculate, the block is like this: |< stride---| +---> X | |w = 16 |(cx,cy)+--+ | | | |h=blocksize| | | | | | +-

Re: [FFmpeg-devel] [PATCH] avcodec: add native iLBC decoder

2018-09-21 Thread Paul B Mahol
On 9/13/18, Carl Eugen Hoyos wrote: > 2018-09-13 13:03 GMT+02:00, Paul B Mahol : > >> @@ -0,0 +1,263 @@ >> +/* >> + * Copyright (c) 2013, The WebRTC project authors. All rights reserved. >> + * >> + * Redistribution and use in source and binary forms, with or without >> + * modification, are permi

Re: [FFmpeg-devel] [PATCH] libavcodec/vp8dec: fix the multi-thread HWAccel decode error

2018-09-21 Thread myp...@gmail.com
On Fri, Sep 21, 2018 at 12:08 PM Xiang, Haihao wrote: > > On Thu, 2018-08-09 at 15:09 +0800, Jun Zhao wrote: > > the root cause is update_dimentions call get_pixel_format will > > Typo? s/dimentions/dimensions. And I see the same typo a few times in this > log. > Ha, a good catch. > > trigger th