Re: [FFmpeg-devel] [PATCH v5 1/4] lavc/libdavs2: fix sequence incomplete output error

2018-11-14 Thread hwren
Any comments on these patches? At 2018-11-02 21:30:08, "hwren" wrote: >Signed-off-by: hwren >--- > libavcodec/libdavs2.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > >diff --git a/libavcodec/libdavs2.c b/libavcodec/libdavs2.c >index cadf995..e36bfed 100644 >---

[FFmpeg-devel] [PATCH] avcodec/cbs_av1: don't abort when splitting Temporal Units containing OBUs with no obu_size field

2018-11-14 Thread James Almer
The ISOBMFF and Matroska specs allow the last OBU in a Sample/Block to have obu_has_size_field equal to 0. Signed-off-by: James Almer --- See https://0x0.st/sUsU.mp4 It apparently can't be decoded with either aom or dav1d atm, but the latter should be able to soon. You can try remuxing it using

Re: [FFmpeg-devel] [PATCH 0/2] Update vf_bwdif to use yadif_common v2

2018-11-14 Thread Philip Langdale
On Tue, 13 Nov 2018 02:11:15 +0100 Thomas Mundt wrote: > Am So., 11. Nov. 2018 um 20:47 Uhr schrieb Philip Langdale < > phil...@overt.org>: > > > vf_bwdif's frame management logic is almost identical to that of > > yadif. The only difference is that it tracks the first and last > > fields in

Re: [FFmpeg-devel] [PATCH] web/index: add news entry for release 4.1

2018-11-14 Thread Michael Niedermayer
On Wed, Nov 14, 2018 at 01:40:09PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > src/index | 50 ++ > 1 file changed, 50 insertions(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB He

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cbs_av1: fix parsing signed integer values

2018-11-14 Thread James Almer
On 11/14/2018 8:04 PM, Mark Thompson wrote: > On 14/11/18 22:39, James Almer wrote: >> On 11/14/2018 7:24 PM, Mark Thompson wrote: >>> On 11/11/18 02:24, James Almer wrote: Signed-off-by: James Almer --- See https://0x0.st/sljR.webm libavcodec/cbs_av1.c | 30

Re: [FFmpeg-devel] [PATCH] [HLS] Add LANGUAGE attribute to #EXT-X-MEDIA tag for audio-only variant streams.

2018-11-14 Thread Philippe Symons
Hello everyone, Here is the new version of the patch in which the comments on the curly braces have been resolved as well. I hope it's okay now. Best regards, Philippe Symons Op do 15 nov. 2018 om 00:13 schreef Philippe Symons < philippe.sym...@gmail.com>: > Hold on, I just noticed the

Re: [FFmpeg-devel] [PATCH] configure: Add missing xlib dependency for VAAPI X11 code

2018-11-14 Thread Mark Thompson
On 14/11/18 23:02, James Almer wrote: > On 11/14/2018 7:59 PM, Mark Thompson wrote: >> Fixes #7538. >> --- >> $ ../configure --disable-vdpau --enable-vaapi >> ... >> $ rm libavutil/libavutil.pc ; make libavutil/libavutil.pc ; cat >> libavutil/libavutil.pc >> ... >> >> Before: >> Libs: -L${libdir}

Re: [FFmpeg-devel] [PATCH] [HLS] Add LANGUAGE attribute to #EXT-X-MEDIA tag for audio-only variant streams.

2018-11-14 Thread Philippe Symons
Hold on, I just noticed the feedback on the curly braces. I'll create a new version of the patch to resolve this as well. Op wo 14 nov. 2018 om 23:49 schreef Philippe Symons < philippe.sym...@gmail.com>: > Hello, > > I've created a new version of the patch in which the second empty line was >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cbs_av1: fix parsing signed integer values

2018-11-14 Thread Mark Thompson
On 14/11/18 22:39, James Almer wrote: > On 11/14/2018 7:24 PM, Mark Thompson wrote: >> On 11/11/18 02:24, James Almer wrote: >>> Signed-off-by: James Almer >>> --- >>> See https://0x0.st/sljR.webm >>> >>> libavcodec/cbs_av1.c | 30 +- >>> 1 file changed, 9

Re: [FFmpeg-devel] [PATCH] configure: Add missing xlib dependency for VAAPI X11 code

2018-11-14 Thread James Almer
On 11/14/2018 7:59 PM, Mark Thompson wrote: > Fixes #7538. > --- > $ ../configure --disable-vdpau --enable-vaapi > ... > $ rm libavutil/libavutil.pc ; make libavutil/libavutil.pc ; cat > libavutil/libavutil.pc > ... > > Before: > Libs: -L${libdir} -lavutil -pthread -L/usr/local/lib -lva-drm

[FFmpeg-devel] [PATCH] configure: Add missing xlib dependency for VAAPI X11 code

2018-11-14 Thread Mark Thompson
Fixes #7538. --- $ ../configure --disable-vdpau --enable-vaapi ... $ rm libavutil/libavutil.pc ; make libavutil/libavutil.pc ; cat libavutil/libavutil.pc ... Before: Libs: -L${libdir} -lavutil -pthread -L/usr/local/lib -lva-drm -lva -L/usr/local/lib -lva-x11 -lva -lm -L/usr/local/lib -lva

Re: [FFmpeg-devel] [PATCH] [HLS] Add LANGUAGE attribute to #EXT-X-MEDIA tag for audio-only variant streams.

2018-11-14 Thread Philippe Symons
Hello, I've created a new version of the patch in which the second empty line was removed. I couldn't find any other feedback inline in your response, so that's all I changed. Best regards, Philippe Symons Op di 13 nov. 2018 om 03:29 schreef Liu Steven : > > > > 在 2018年11月13日,上午6:36,Philippe

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cbs_av1: fix parsing signed integer values

2018-11-14 Thread James Almer
On 11/14/2018 7:24 PM, Mark Thompson wrote: > On 11/11/18 02:24, James Almer wrote: >> Signed-off-by: James Almer >> --- >> See https://0x0.st/sljR.webm >> >> libavcodec/cbs_av1.c | 30 +- >> 1 file changed, 9 insertions(+), 21 deletions(-) >> >> diff --git

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cbs_av1: fix parsing signed integer values

2018-11-14 Thread Mark Thompson
On 11/11/18 02:24, James Almer wrote: > Signed-off-by: James Almer > --- > See https://0x0.st/sljR.webm > > libavcodec/cbs_av1.c | 30 +- > 1 file changed, 9 insertions(+), 21 deletions(-) > > diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c > index

Re: [FFmpeg-devel] [PATCH v2] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-11-14 Thread Carl Eugen Hoyos
2018-11-14 20:59 GMT+01:00, Jan Ekström : > So what if I just make a patch without dvh1 that you have > already implemented, and then we call that a day? I thought I suggested that but I may misremember. Sorry, Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_av1: fix storage size for segmentation_params feature_value fields

2018-11-14 Thread Mark Thompson
On 11/11/18 02:24, James Almer wrote: > The valid range is -255 to 255. > > Signed-off-by: James Almer > --- > libavcodec/cbs_av1.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/cbs_av1.h b/libavcodec/cbs_av1.h > index f662265f75..84622ed189 100644 > ---

[FFmpeg-devel] [PATCH] hevcdec: Fix get_format behaviour when the user declines to pick a format

2018-11-14 Thread Mark Thompson
Maintain the context pixfmt as NONE in this case, indicating that if the user requests more decoding then get_format() will need to be called again. Also remove the pixfmt setting from inside set_sps() and make it explicit, so that the behaviour is clearer. --- libavcodec/hevcdec.c | 28

Re: [FFmpeg-devel] [PATCH v2] ffmpeg: Add option to force a specific decode format

2018-11-14 Thread Mark Thompson
On 14/11/18 01:35, Fu, Linjie wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Mark Thompson >> Sent: Wednesday, November 14, 2018 09:11 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v2] ffmpeg: Add option to

[FFmpeg-devel] [PATCH v2] hwcontext_vaapi: Add option to set driver name

2018-11-14 Thread Mark Thompson
For example: -init_hw_device vaapi:/dev/dri/renderD128,driver=foo This may be more convenient that using the environment variable, and allows loading different drivers for different devices in the same process. --- On 14/11/18 12:05, Michael Niedermayer wrote: > On Wed, Nov 14, 2018 at 12:21:07AM

[FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 temporal scalability configuration options

2018-11-14 Thread Ard Oerlemans
This commit adds configuration options to libvpxenc.c that can be used to enable VP8 temporal scalability. It also adds a way to programmatically set the per-frame encoding flags which can be used to control usage and updates of reference frames while encoding with temporal scalability enabled.

Re: [FFmpeg-devel] [PATCH] avcodec/vc1: correct aspect ratio calculation

2018-11-14 Thread Michael Niedermayer
Hi On Wed, Nov 14, 2018 at 10:57:25AM +0100, Jerome Borsboom wrote: > According to VC-1 spec: > * Display size defaults to max coded size when not explicitly set in > sequence header > * Aspect ratio in the sequence header refers to the Display size elements. > Therefore, the aspect ratio for the

[FFmpeg-devel] [PATCH 1/1] avcodec/vaapi_encode: add frame-skip func

2018-11-14 Thread Jing SUN
frame-skip is required to implement network bandwidth self-adaptive vaapi encoding. To make a frame skipped, allocate its frame side data of AV_FRAME_DATA_SKIP_FRAME type and set its value to 1. Signed-off-by: Jing SUN --- libavcodec/vaapi_encode.c | 132

Re: [FFmpeg-devel] [PATCH v2] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

2018-11-14 Thread Jan Ekström
On Sat, Nov 10, 2018 at 3:36 PM Carl Eugen Hoyos wrote: > > 2018-11-08 17:34 GMT+01:00, Jan Ekström : > > > Then regarding the rest. Do I understand correctly that you do > > not trust dolby's specification and/or mpeg-4 ra and would only > > like identifiers be added that have been seen in the

Re: [FFmpeg-devel] [PATCH 1/2] lavu: add locale-independent sscanf implementation

2018-11-14 Thread Paul B Mahol
On 11/12/18, Paul B Mahol wrote: > Copied and adopted from musl implementation. > * converted all 'long double' to 'double' > * removed %m support > > Signed-off-by: Paul B Mahol > --- > libavutil/Makefile | 1 + > libavutil/avsscanf.c | 971 +++ >

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: set FLAC manifest codec string to "flac"

2018-11-14 Thread Jan Ekström
On Wed, Nov 14, 2018 at 11:55 AM Paul B Mahol wrote: > > On 11/14/18, Jan Ekström wrote: > > Internally in ISOBMFF the FLAC-in-ISOBMFF draft uses the "fLaC" > > as the identifier for FLACSampleEntry, but what the browsers > > seem to eat for MPEG-DASH manifests is plain "flac". > > > > Verified

Re: [FFmpeg-devel] [PATCH] avcodec/vc1: correct aspect ratio calculation

2018-11-14 Thread Carl Eugen Hoyos
2018-11-14 17:16 GMT+01:00, Jerome Borsboom : >>> +av_reduce(>sample_aspect_ratio.num, >>> + >sample_aspect_ratio.den, >>> + v->disp_horiz_size * v->aspect_ratio.num * h, >>> + v->disp_vert_size * v->aspect_ratio.den * w, >>> + 1 << 30); >>

[FFmpeg-devel] [PATCH] web/index: add news entry for release 4.1

2018-11-14 Thread James Almer
Signed-off-by: James Almer --- src/index | 50 ++ 1 file changed, 50 insertions(+) diff --git a/src/index b/src/index index bbfca29..0dcf6c1 100644 --- a/src/index +++ b/src/index @@ -37,6 +37,56 @@ News + November 6th, 2018, FFmpeg

Re: [FFmpeg-devel] [PATCH] avcodec/vc1: correct aspect ratio calculation

2018-11-14 Thread Jerome Borsboom
>> +av_reduce(>sample_aspect_ratio.num, >> + >sample_aspect_ratio.den, >> + v->disp_horiz_size * v->aspect_ratio.num * h, >> + v->disp_vert_size * v->aspect_ratio.den * w, >> + 1 << 30); > >> +ff_set_sar(avctx,

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: set FLAC manifest codec string to "flac"

2018-11-14 Thread Jan Ekström
On Wed, Nov 14, 2018, 17:22 Carl Eugen Hoyos 2018-11-14 2:21 GMT+01:00, Jan Ekström : > > Internally in ISOBMFF the FLAC-in-ISOBMFF draft uses the "fLaC" > > as the identifier for FLACSampleEntry, but what the browsers > > seem to eat for MPEG-DASH manifests is plain "flac". > > Does this patch

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/libdav1d: fix build after a recent API break

2018-11-14 Thread James Almer
On 11/14/2018 12:38 PM, Nicolas George wrote: > James Almer (2018-11-14): >> -res = dav1d_decode(dav1d->c, data, ); >> +res = dav1d_send_data(dav1d->c, data); >> +if (res < 0) { >> +if (res == -EINVAL) >> +res = AVERROR_INVALIDDATA; >> +if (res != -EAGAIN)

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/libdav1d: fix build after a recent API break

2018-11-14 Thread Nicolas George
James Almer (2018-11-14): > -res = dav1d_decode(dav1d->c, data, ); > +res = dav1d_send_data(dav1d->c, data); > +if (res < 0) { > +if (res == -EINVAL) > +res = AVERROR_INVALIDDATA; > +if (res != -EAGAIN) > +return res; > +} > + > +res =

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/libdav1d: fix build after a recent API break

2018-11-14 Thread Carl Eugen Hoyos
2018-11-14 16:19 GMT+01:00, James Almer : > On 11/14/2018 12:03 PM, Carl Eugen Hoyos wrote: >> 2018-11-14 14:06 GMT+01:00, James Almer : >>> ffmpeg | branch: master | James Almer | Wed Nov 14 >>> 10:05:25 2018 -0300| [752659327d4ac73640781376d214a26765f971f4] | >>> committer: >>> James Almer >>>

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: set FLAC manifest codec string to "flac"

2018-11-14 Thread Carl Eugen Hoyos
2018-11-14 2:21 GMT+01:00, Jan Ekström : > Internally in ISOBMFF the FLAC-in-ISOBMFF draft uses the "fLaC" > as the identifier for FLACSampleEntry, but what the browsers > seem to eat for MPEG-DASH manifests is plain "flac". Does this patch also answer the recent discussion about specifications

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/libdav1d: fix build after a recent API break

2018-11-14 Thread James Almer
On 11/14/2018 12:03 PM, Carl Eugen Hoyos wrote: > 2018-11-14 14:06 GMT+01:00, James Almer : >> ffmpeg | branch: master | James Almer | Wed Nov 14 >> 10:05:25 2018 -0300| [752659327d4ac73640781376d214a26765f971f4] | committer: >> James Almer >> >> avcodec/libdav1d: fix build after a recent API

Re: [FFmpeg-devel] [PATCH] avcodec/vc1: correct aspect ratio calculation

2018-11-14 Thread Carl Eugen Hoyos
2018-11-14 10:57 GMT+01:00, Jerome Borsboom : > +av_reduce(>sample_aspect_ratio.num, > + >sample_aspect_ratio.den, > + v->disp_horiz_size * v->aspect_ratio.num * h, > + v->disp_vert_size * v->aspect_ratio.den * w, > + 1 << 30); > +

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/libdav1d: fix build after a recent API break

2018-11-14 Thread Carl Eugen Hoyos
2018-11-14 14:06 GMT+01:00, James Almer : > ffmpeg | branch: master | James Almer | Wed Nov 14 > 10:05:25 2018 -0300| [752659327d4ac73640781376d214a26765f971f4] | committer: > James Almer > > avcodec/libdav1d: fix build after a recent API break > > Signed-off-by: James Almer > >>

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Add support for per-stream container type selection.

2018-11-14 Thread Andrey Semashev
On 11/14/18 4:52 PM, Jeyapal, Karthick wrote: On 11/14/18 1:41 PM, Andrey Semashev wrote: On 11/12/18 3:55 PM, Andrey Semashev wrote: Suppose you want to create a DASH stream consisting of VP8, H264, Vorbis and Opus substreams to cover the best compatibility with clients (which are mostly

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Add support for per-stream container type selection.

2018-11-14 Thread Jeyapal, Karthick
On 11/14/18 1:41 PM, Andrey Semashev wrote: > On 11/12/18 3:55 PM, Andrey Semashev wrote: > > On 11/12/18 3:12 PM, Jeyapal, Karthick wrote: > >> > >> On 11/12/18 5:20 PM, Andrey Semashev wrote: > >>> On 11/12/18 8:20 AM, Jeyapal, Karthick wrote: > > On 11/8/18 10:27 PM, Andrey Semashev

Re: [FFmpeg-devel] [PATCH] avfilter: add astretch filter

2018-11-14 Thread Nicolas George
Paul B Mahol (2018-11-14): > > libavfilter/Makefile | 1 + > > libavfilter/af_astretch.c | 330 ++ > > libavfilter/allfilters.c | 1 + > > 3 files changed, 332 insertions(+) > > create mode 100644 libavfilter/af_astretch.c > Will apply. You forgot

Re: [FFmpeg-devel] [PATCH] hwcontext_vaapi: Add option to set driver name

2018-11-14 Thread Michael Niedermayer
On Wed, Nov 14, 2018 at 12:21:07AM +, Mark Thompson wrote: > For example: -init_hw_device vaapi:/dev/dri/renderD128,driver=foo > > This may be more convenient that using the environment variable, and allows > loading different drivers for different devices in the same process. > --- >

Re: [FFmpeg-devel] HEVC decoder for Raspberry Pi

2018-11-14 Thread John Cox
Hi >Hi > >On Tue, Nov 13, 2018 at 03:52:18PM +, John Cox wrote: >> Hi >> >> I have been developing a hevc decoder for Raspberry Pi for some time >> now. As active development has now pretty much ceased and the code is >> believed stable it seems a good time to try presenting it to the group.

Re: [FFmpeg-devel] [PATCH v3 1/1] avcodec: implemented Media Foundation encoder wrapper

2018-11-14 Thread Paweł Wegner
On Tue, Nov 13, 2018 at 6:52 PM Michael Niedermayer wrote: > On Tue, Nov 13, 2018 at 12:23:42PM +0100, Paweł Wegner wrote: > > On Tue, Nov 13, 2018 at 11:40 AM Michael Niedermayer > > > wrote: > > > > > On Tue, Nov 13, 2018 at 09:50:17AM +0100, Paweł Wegner wrote: > > > > On Tue, Nov 13, 2018

[FFmpeg-devel] [PATCH] avcodec/vc1: correct aspect ratio calculation

2018-11-14 Thread Jerome Borsboom
According to VC-1 spec: * Display size defaults to max coded size when not explicitly set in sequence header * Aspect ratio in the sequence header refers to the Display size elements. Therefore, the aspect ratio for the coded samples (SAR) needs to take into account the scaling from coded size to

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: set FLAC manifest codec string to "flac"

2018-11-14 Thread Paul B Mahol
On 11/14/18, Jan Ekström wrote: > Internally in ISOBMFF the FLAC-in-ISOBMFF draft uses the "fLaC" > as the identifier for FLACSampleEntry, but what the browsers > seem to eat for MPEG-DASH manifests is plain "flac". > > Verified by auri_ on IRC to play with the major browsers. > --- >

[FFmpeg-devel] [PATCH] avcodec/diracdec: Check component quant

2018-11-14 Thread Michael Niedermayer
Fixes: Timeout Fixes: 10708/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5730140957442048 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/diracdec.c | 5 + 1 file

Re: [FFmpeg-devel] [PATCH] avfilter: add astretch filter

2018-11-14 Thread Paul B Mahol
On 11/10/18, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/Makefile | 1 + > libavfilter/af_astretch.c | 330 ++ > libavfilter/allfilters.c | 1 + > 3 files changed, 332 insertions(+) > create mode 100644

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Add support for per-stream container type selection.

2018-11-14 Thread Andrey Semashev
On 11/12/18 3:55 PM, Andrey Semashev wrote: On 11/12/18 3:12 PM, Jeyapal, Karthick wrote: On 11/12/18 5:20 PM, Andrey Semashev wrote: On 11/12/18 8:20 AM, Jeyapal, Karthick wrote: On 11/8/18 10:27 PM, Andrey Semashev wrote: This commit restores the ability to create DASH streams with