Re: [FFmpeg-devel] [Patch V2] lavf/qsv_scale: add scaling modes support

2019-06-24 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Li, Zhong > Sent: Friday, June 21, 2019 5:33 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [Patch V2] lavf/qsv_scale: add scaling modes > support > > > Subject: [Patch V2] lavf/qsv_scale: add scaling

Re: [FFmpeg-devel] [PATCH] movsub_bsf: Fix mov2textsub regression

2019-06-24 Thread James Almer
On 6/23/2019 10:26 PM, Philip Langdale wrote: > On Sun, 23 Jun 2019 06:46:12 +0200 > Andreas Rheinhardt wrote: > >> The mov flavour of timed text uses the first two bytes of the packet >> as a length field. And up until 11bef2fe said length field has been >> read correctly in the mov2textsub

Re: [FFmpeg-devel] [PATCH V1] lavf/flvenc: add automatic bitstream filtering

2019-06-24 Thread myp...@gmail.com
On Sat, Jun 22, 2019 at 5:54 PM Steven Liu wrote: > > > > > 在 2019年6月22日,17:04,Jun Zhao 写道: > > > > From: Jun Zhao > > > > add automatic bitstream filtering when mux AAC > > > > Signed-off-by: Jun Zhao > > --- > > libavformat/flvenc.c | 27 --- > > 1 files changed, 24

Re: [FFmpeg-devel] [PATCH v3 1/6] libavfilter/vf_overlay.c: change the comment style for the following macro defined function

2019-06-24 Thread Lance Wang
On Thu, Jun 6, 2019 at 3:10 PM wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_overlay.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavfilter/vf_overlay.c b/libavfilter/vf_overlay.c > index 0a8f089c0d..b468cedf2e

Re: [FFmpeg-devel] [PATCH 12/13] avformat/matroskadec: Improve read error/EOF checks II

2019-06-24 Thread James Almer
On 6/23/2019 8:42 PM, Andreas Rheinhardt wrote: > This commit fixes a number of bugs: > > 1. There was no check that no read error/EOF occured during > ebml_read_uint, ebml_read_sint and ebml_read_float. > 2. ebml_read_ascii and ebml_read_binary did sometimes not forward > error codes; instead

Re: [FFmpeg-devel] [PATCH 13/13] avformat/matroskadec: Improve error/EOF checks III

2019-06-24 Thread James Almer
On 6/23/2019 8:42 PM, Andreas Rheinhardt wrote: > Up until now, when an element was skipped, it was relied upon > ffio_limit to make sure that there is enough data available to skip. > ffio_limit itself relies upon the availability of the file's size. As > this needn't be available, the check has

Re: [FFmpeg-devel] [PATCH 16/37] avformat/matroskadec: Treat SimpleBlock as EBML_BIN

2019-06-24 Thread James Almer
On 5/16/2019 7:30 PM, Andreas Rheinhardt wrote: > Up until now, the SimpleBlock was treated specially: It basically had > its own EBML category and it was also included in the BlockGroup EBML > syntax (although a SimpleBlock must not exist in a BlockGroup according > to the Matroska

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Improve read error/EOF checks I

2019-06-24 Thread James Almer
On 6/24/2019 10:08 PM, Andreas Rheinhardt wrote: > ebml_read_num had a number of flaws: > > 1. The check for read errors/EOF was totally wrong. E.g. an EBML number > beginning with the invalid 0x00 would be considered a read error, > although it is just invalid data. > 2. The check for read

Re: [FFmpeg-devel] [PATCH v10 1/2] lavf/vf_transpose: add exif orientation support

2019-06-24 Thread Jun Li
On Mon, Jun 17, 2019 at 5:31 PM Jun Li wrote: > > > On Sat, Jun 15, 2019 at 7:09 PM Jun Li wrote: > >> >> >> On Tue, Jun 11, 2019 at 7:05 PM Jun Li wrote: >> >>> >>> On Sun, Jun 9, 2019 at 2:28 PM Jun Li wrote: >>> Add exif orientation support and expose an option. ---

Re: [FFmpeg-devel] [PATCH V1 2/3] ffmpeg_opt: Respect default disposition when select audio/video

2019-06-24 Thread myp...@gmail.com
On Fri, Jun 21, 2019 at 10:36 PM Michael Niedermayer wrote: > > On Thu, Jun 20, 2019 at 12:50:33PM +0800, Jun Zhao wrote: > > From: Jun Zhao > > > > Respect default disposition when select audio/video > > > > Signed-off-by: Jun Zhao > > --- > > fftools/ffmpeg_opt.c |6 -- > > 1 files

[FFmpeg-devel] [PATCH] avformat/matroskadec: Improve read error/EOF checks I

2019-06-24 Thread Andreas Rheinhardt
ebml_read_num had a number of flaws: 1. The check for read errors/EOF was totally wrong. E.g. an EBML number beginning with the invalid 0x00 would be considered a read error, although it is just invalid data. 2. The check for read errors/EOF was done just once, after reading the first byte of the

Re: [FFmpeg-devel] [PATCH 11/13] avformat/matroskadec: Improve read error/EOF checks I

2019-06-24 Thread James Almer
On 6/23/2019 8:42 PM, Andreas Rheinhardt wrote: > ebml_read_num had a number of flaws: > > 1. The check for read errors/EOF was totally wrong. E.g. an EBML number > beginning with the invalid 0x00 would be considered a read error, > although it is just invalid data. > 2. The check for read

Re: [FFmpeg-devel] [PATCH 04/37] avformat/matroskadec: Don't zero unnecessarily

2019-06-24 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > It is only necessary to zero the initial allocated memory used to store > the size of laced frames if the block used Xiph lacing. Otherwise no > unintialized data was ever used, so use av_malloc instead of av_mallocz. > > Also use the correct type

Re: [FFmpeg-devel] [PATCH 1/2] configure: print_in_columns: Replace pr with awk

2019-06-24 Thread Alexander Strasser
On 2019-05-05 11:36 +0200, Alexander Strasser wrote: > > > Am 5. Mai 2019 03:53:20 MESZ schrieb "Guo, Yejun" : > > > > > >> -Original Message- > >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > >Of > >> Alexander Strasser > >> Sent: Thursday, May 02, 2019 12:08 AM

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: produce a 0 byte packet when a dequeued buffer's size is unexpected

2019-06-24 Thread Alexander Strasser
On 2019-06-05 22:04 +0200, Alexander Strasser wrote: > From: Stephan Hilb > > Behave like we do for V4L2_BUF_FLAG_ERROR, implemented in commit 28f20d2ff4 . > > For some devices (probably also related to the V4L driver implementation) > it happens that when invoking the ioctl DQBUF, the returned

Re: [FFmpeg-devel] [PATCH V5 1/2] configure: sort decoder/encoder/filter/... names in alphabet order

2019-06-24 Thread Alexander Strasser
On 2019-06-03 06:24 +, Guo, Yejun wrote: > > > > -Original Message- > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > > avih > > Sent: Monday, June 03, 2019 6:29 AM > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH

[FFmpeg-devel] [PATCH] libavformat/mux: Fix audio_preload

2019-06-24 Thread Andreas Rheinhardt
Commit 31f9032b added the audio_preload feature; its goal is to interleave audio earlier than the rest. Unfortunately, it has never ever worked, because the check for whether a packet should be interleaved before or after another packet was completely wrong: When audio_preload vanishes,

Re: [FFmpeg-devel] [PATCH] Add DICOM Support

2019-06-24 Thread Michael Niedermayer
On Mon, Jun 24, 2019 at 09:18:13PM +0530, Shivam wrote: > Hi! > >     The code is to add DICOM Support. The patch is only for uncompressed > dicom files using explicit value representation. I would extend it, once i > clarify some doubts. As dicom image files contain lots of metadata about >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bink: Fix integer overflow in unquantize_dct_coeffs()

2019-06-24 Thread Michael Niedermayer
On Sat, Jun 22, 2019 at 08:46:20AM +0200, Michael Niedermayer wrote: > On Fri, Jun 21, 2019 at 09:12:36AM +0200, Reimar Döffinger wrote: > > > > > > On 18.06.2019, at 14:55, Michael Niedermayer wrote: > > > > > Fixes: signed integer overflow: -3447 * 2883584 cannot be represented in > > >

Re: [FFmpeg-devel] [PATCH V3 1/3] tools/python: add script to convert TensorFlow model (.pb) to native model (.model)

2019-06-24 Thread Pedro Arthur
Em seg, 24 de jun de 2019 às 12:24, Guo, Yejun escreveu: > > yes, good idea. Do you happen to know how to apply such repo? thanks. > I think you should ask Michael. > > > > Em qua, 19 de jun de 2019 às 21:29, Guo, Yejun > > escreveu: > > > > > > > > > > > > > -Original Message- > > > >

[FFmpeg-devel] [PATCH] avformat/hlsenc: temp_file usage for master playlist and vtt playlist

2019-06-24 Thread Bodecs Bela
Dear All, currently master playlist and subtitle playlist creation does not use temporary files even when temp_file flag is set. Most of the use cases it is not a problem because master playlist creation happens once on the beginning of the whole process. But if master playlist is periodically

[FFmpeg-devel] [PATCH] Add DICOM Support

2019-06-24 Thread Shivam
Hi!     The code is to add DICOM Support. The patch is only for uncompressed dicom files using explicit value representation. I would extend it, once i clarify some doubts. As dicom image files contain lots of metadata about the patient. So, should i display that data while demuxing or

Re: [FFmpeg-devel] [PATCH V3 1/3] tools/python: add script to convert TensorFlow model (.pb) to native model (.model)

2019-06-24 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Pedro Arthur > Sent: Monday, June 24, 2019 11:13 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V3 1/3] tools/python: add script to convert >

Re: [FFmpeg-devel] [PATCH V3 1/3] tools/python: add script to convert TensorFlow model (.pb) to native model (.model)

2019-06-24 Thread Pedro Arthur
LGTM. BTW I think we should have an ffmpeg controlled repo hosting the scripts to train the network and also some pretrained files to easy testing. Em qua, 19 de jun de 2019 às 21:29, Guo, Yejun escreveu: > > > > > -Original Message- > > From: Guo, Yejun > > Sent: Thursday, June 13,

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/qdm2: Do not read out of array in fix_coding_method_array()

2019-06-24 Thread Moritz Barsnick
On Mon, Jun 24, 2019 at 01:01:02 +0200, Michael Niedermayer wrote: > +if (sb + (j + k) / 64 > 29) { [...] > if (coding_method[ch][sb + (j + k) / 64][(j + k) % 64] > > coding_method[ch][sb][j]) { You could do the "sb + (j + k) / 64]" calculation only once

Re: [FFmpeg-devel] [PATCH] dash: change default MP4 extension to .m4s

2019-06-24 Thread Alfred E. Heggestad
On 24/06/2019 11:24, Jeyapal, Karthick wrote: On 6/20/19 3:00 PM, Alfred E. Heggestad wrote: On 20/06/2019 05:19, Jeyapal, Karthick wrote: On 6/19/19 3:08 PM, Alfred E. Heggestad wrote: On 19/06/2019 07:21, Jeyapal, Karthick wrote: On 6/18/19 1:48 PM, Alfred E. Heggestad wrote: On

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: better error log message for var_stream_map content

2019-06-24 Thread Steven Liu
Bodecs Bela 于2019年6月22日周六 下午10:01写道: > > Dear All, > > When multiple variant streams are specified by var_stream_map option, > %v is expected either in the filename or in the last sub-directory name, > but only in one of them. When both of them contain %v string, current > error message only

Re: [FFmpeg-devel] [PATCH] dash: change default MP4 extension to .m4s

2019-06-24 Thread Jeyapal, Karthick
On 6/20/19 3:00 PM, Alfred E. Heggestad wrote: > > > On 20/06/2019 05:19, Jeyapal, Karthick wrote: >> >> On 6/19/19 3:08 PM, Alfred E. Heggestad wrote: >>> On 19/06/2019 07:21, Jeyapal, Karthick wrote: On 6/18/19 1:48 PM, Alfred E. Heggestad wrote: > On 18/06/2019 04:02, Steven Liu