Re: [FFmpeg-devel] [PATCH v6] Fix integer parameters size check in SDP fmtp line

2019-06-28 Thread Reimar Döffinger
I don't think we should be using errno when avoidable, and it is avoidable here by disallowing min/max int32 values themselves. Or using strtoll. I'm also rather sceptical about allowing negative values here, does that make sense? Admittedly the type is set to just "int", but maybe it should be

Re: [FFmpeg-devel] [PATCH 4/4] avformat/vividas: Fixes overflow in shift in recover_key()

2019-06-28 Thread Reimar Döffinger
On 28.06.2019, at 22:53, Michael Niedermayer wrote: > Fixes: left shift of 133 by 24 places cannot be represented in type 'int' > Fixes: > 15365/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5716153105645568 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] dashdec: Fix reading values from SegmentTimeline inside, Period

2019-06-28 Thread Steven Liu
> 在 2019年6月29日,07:03,Stefan _ 写道: > > Hi, > > attached patch fixes a small oversight in dashdec. > > YouTube uses DASH manifests structured like this for live recordings, > seeking is currently broken in those cases. > >

[FFmpeg-devel] [PATCH] dashdec: Fix reading values from SegmentTimeline inside, Period

2019-06-28 Thread Stefan _
Hi, attached patch fixes a small oversight in dashdec. YouTube uses DASH manifests structured like this for live recordings, seeking is currently broken in those cases. From b0eceb6bbe0c931d8c67a22980816bf3f8dd0bbe Mon Sep 17 00:00:00 2001 From: sfan5 Date: Sat, 29 Jun 2019 00:51:28 +0200

Re: [FFmpeg-devel] [PATCH] Add DICOM Support

2019-06-28 Thread Paul B Mahol
On 6/29/19, Michael Niedermayer wrote: > On Fri, Jun 28, 2019 at 02:02:29PM +0530, Shivam wrote: >> >> On 6/27/19 9:21 PM, Michael Niedermayer wrote: >> >On Wed, Jun 26, 2019 at 11:33:05PM +0530, Shivam wrote: >> >>On 6/26/19 4:37 PM, Michael Niedermayer wrote: >> >>>On Wed, Jun 26, 2019 at

Re: [FFmpeg-devel] [PATCH] Add DICOM Support

2019-06-28 Thread Michael Niedermayer
On Fri, Jun 28, 2019 at 02:02:29PM +0530, Shivam wrote: > > On 6/27/19 9:21 PM, Michael Niedermayer wrote: > >On Wed, Jun 26, 2019 at 11:33:05PM +0530, Shivam wrote: > >>On 6/26/19 4:37 PM, Michael Niedermayer wrote: > >>>On Wed, Jun 26, 2019 at 09:54:56AM +0200, Paul B Mahol wrote: > On

[FFmpeg-devel] [PATCH 4/4] avformat/vividas: Fixes overflow in shift in recover_key()

2019-06-28 Thread Michael Niedermayer
Fixes: left shift of 133 by 24 places cannot be represented in type 'int' Fixes: 15365/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5716153105645568 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCH 3/4] avcodec/sanm: Optimize fill_frame() with av_memcpy_backptr()

2019-06-28 Thread Michael Niedermayer
Fixes: Timeout (76 sec -> 24 sec) Fixes: 15043/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SANM_fuzzer-5699856238116864 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/sanm.c | 4 +++-

[FFmpeg-devel] [PATCH 2/4] avcodec/tta: Limit decoder to 16 channels

2019-06-28 Thread Michael Niedermayer
libtta 2.3 has a limit of 6 channels, so 16 is substantially above the "official" already Fixes: OOM Fixes: 15249/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TTA_fuzzer-5643988125614080 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 1/4] avcodec/rv10: Fix integer overflow in aspect ratio compare

2019-06-28 Thread Michael Niedermayer
Fixes: signed integer overflow: 2040 * 1187872 cannot be represented in type 'int' Fixes: 15368/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV20_fuzzer-5681657136283648 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add back alpha processing removed in 9cefb9e7ec

2019-06-28 Thread Carl Eugen Hoyos
Am Fr., 28. Juni 2019 um 20:29 Uhr schrieb Paul B Mahol : > > On 6/28/19, Carl Eugen Hoyos wrote: > > Am Fr., 28. Juni 2019 um 19:48 Uhr schrieb Paul B Mahol : > >> > >> Signed-off-by: Paul B Mahol > >> --- > >> libavcodec/cfhd.c | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add back alpha processing removed in 9cefb9e7ec

2019-06-28 Thread Paul B Mahol
On 6/28/19, Carl Eugen Hoyos wrote: > Am Fr., 28. Juni 2019 um 19:48 Uhr schrieb Paul B Mahol : >> >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/cfhd.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c >> index 846d334b9b..49a5a2c30a

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add back alpha processing removed in 9cefb9e7ec

2019-06-28 Thread Carl Eugen Hoyos
Am Fr., 28. Juni 2019 um 19:48 Uhr schrieb Paul B Mahol : > > Signed-off-by: Paul B Mahol > --- > libavcodec/cfhd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c > index 846d334b9b..49a5a2c30a 100644 > --- a/libavcodec/cfhd.c > +++

[FFmpeg-devel] [PATCH] avcodec/cfhd: add back alpha processing removed in 9cefb9e7ec

2019-06-28 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/cfhd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c index 846d334b9b..49a5a2c30a 100644 --- a/libavcodec/cfhd.c +++ b/libavcodec/cfhd.c @@ -884,6 +884,8 @@ static int cfhd_decode(AVCodecContext *avctx, void

Re: [FFmpeg-devel] [PATCH 2/3] lavc/mjpeg_parser: use ff_mjpeg_decode_header to parse frame info

2019-06-28 Thread James Almer
On 6/27/2019 9:59 AM, Zhong Li wrote: > Signed-off-by: Zhong Li > --- > libavcodec/mjpeg_parser.c | 158 > +- > 1 file changed, 157 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/mjpeg_parser.c b/libavcodec/mjpeg_parser.c > index

Re: [FFmpeg-devel] [PATCH v3] avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation

2019-06-28 Thread Michael Niedermayer
On Thu, Jun 27, 2019 at 06:06:22AM +, Jacob Siddall wrote: > The previous calculation code did not account for the fact that the > copy_offset for the start of the frame array is at index 0, yet the > scan line number from the rfc4175 RTP header starts at 1. > This caused 2 issues to appear: >

Re: [FFmpeg-devel] [PATCH v3] lavf/vf_find_rect: add the dual input support function

2019-06-28 Thread Michael Niedermayer
On Fri, Jun 28, 2019 at 05:23:22PM +0200, Paul B Mahol wrote: > On 6/28/19, Limin Wang wrote: > > On Fri, Jun 28, 2019 at 09:49:27AM +0200, Michael Niedermayer wrote: > >> On Thu, Jun 27, 2019 at 05:40:31PM +0800, lance.lmw...@gmail.com wrote: > >> > From: Limin Wang > >> > > >> > Please using

Re: [FFmpeg-devel] [PATCH v3] lavf/vf_find_rect: add the dual input support function

2019-06-28 Thread Paul B Mahol
On 6/28/19, Limin Wang wrote: > On Fri, Jun 28, 2019 at 09:49:27AM +0200, Michael Niedermayer wrote: >> On Thu, Jun 27, 2019 at 05:40:31PM +0800, lance.lmw...@gmail.com wrote: >> > From: Limin Wang >> > >> > Please using the below command for the testing: >> > ./ffmpeg -i input.ts -i ref.png

[FFmpeg-devel] [PATCH V2 1/2] doc/muxers: fix and update docs for HLS muxer

2019-06-28 Thread Jun Zhao
From: Jun Zhao fix and update docs for HLS muxer Signed-off-by: Jun Zhao --- doc/muxers.texi | 24 1 files changed, 16 insertions(+), 8 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index dd64672..d179584 100644 --- a/doc/muxers.texi +++

Re: [FFmpeg-devel] [PATCH v3] lavf/vf_find_rect: add the dual input support function

2019-06-28 Thread Limin Wang
On Fri, Jun 28, 2019 at 09:49:27AM +0200, Michael Niedermayer wrote: > On Thu, Jun 27, 2019 at 05:40:31PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Please using the below command for the testing: > > ./ffmpeg -i input.ts -i ref.png -filter_complex > >

[FFmpeg-devel] [PATCH V2 2/2] doc/muxers: fix docs format for DASH muxer

2019-06-28 Thread Jun Zhao
From: Jun Zhao fix docs format for DASH muxer Signed-off-by: Jun Zhao --- doc/muxers.texi | 62 -- 1 files changed, 32 insertions(+), 30 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index d179584..c220bd2 100644 ---

[FFmpeg-devel] [PATCH V2 0/2] Fix and update docs for HLS/DASH muxer

2019-06-28 Thread Jun Zhao
V2: - remove hyphen from option name in the docs Jun Zhao (2): doc/muxers: fix and update docs for HLS muxer doc/muxers: fix docs format for DASH muxer doc/muxers.texi | 86 ++ 1 files changed, 48 insertions(+), 38 deletions(-)

Re: [FFmpeg-devel] [PATCH V1 1/2] doc/muxers: fix and update docs for HLS muxer

2019-06-28 Thread Gyan
On 28-06-2019 07:02 PM, Jun Zhao wrote: From: Jun Zhao fix and update docs for HLS muxer Signed-off-by: Jun Zhao --- doc/muxers.texi | 68 ++ 1 files changed, 38 insertions(+), 30 deletions(-) diff --git a/doc/muxers.texi

[FFmpeg-devel] [PATCH V1 2/2] doc/muxers: fix docs format for DASH muxer

2019-06-28 Thread Jun Zhao
From: Jun Zhao fix docs format for DASH muxer Signed-off-by: Jun Zhao --- doc/muxers.texi |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index d93d1cf..044c838 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -256,7 +256,7 @@

[FFmpeg-devel] [PATCH V1 1/2] doc/muxers: fix and update docs for HLS muxer

2019-06-28 Thread Jun Zhao
From: Jun Zhao fix and update docs for HLS muxer Signed-off-by: Jun Zhao --- doc/muxers.texi | 68 ++ 1 files changed, 38 insertions(+), 30 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index dd64672..d93d1cf 100644 ---

Re: [FFmpeg-devel] [PATCH 2/2] lavc/mjpegdec: make code aligned

2019-06-28 Thread Michael Niedermayer
On Thu, Jun 27, 2019 at 04:58:24PM +0800, Zhong Li wrote: > Signed-off-by: Zhong Li > --- > libavcodec/mjpegdec.c | 450 > +- > 1 file changed, 225 insertions(+), 225 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 1/3] lavc/mjpegdec: add function ff_mjpeg_decode_header

2019-06-28 Thread Michael Niedermayer
On Thu, Jun 27, 2019 at 08:59:12PM +0800, Zhong Li wrote: > It will be reused in the following mjpeg_parser patch > > Signed-off-by: Zhong Li > --- > Mark Thompson: This seems suspicious - MJPEG is generally 4:2:2 (e.g. UVC > requires it), so I would expect a 4:2:2 format to be the default

[FFmpeg-devel] [PATCH] avformat/hlsenc: changing all filename length to MAX_URL_SIZE

2019-06-28 Thread Bodecs Bela
Dear All, throughout hlsenc code, all filename related buffer lengths are set hardcoded as 1024. This PATCH change it to general value as MAX_URL_SIZE of internal.h please review this patch. thank you in advance, best regards, Bela >From 6814aa8c06a37e4f298dd5acc84081cc4283321e Mon Sep 17

Re: [FFmpeg-devel] [PATCH 1/5] lavu/pixfmt: add Y210/AYUV/Y410 pixel formats

2019-06-28 Thread James Darnley
On 2019-06-28 03:03, Hendrik Leppkes wrote: > On Fri, Jun 28, 2019 at 1:26 AM James Darnley wrote: >> >> On 2019-06-28 04:26, Linjie Fu wrote: >>> Previously, media driver provided planar format(like 420 8 bit), but >>> for HEVC Range Extension (422/444 8/10 bit), the decoded image is >>>

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: new interlaced mux mode

2019-06-28 Thread Andreas Håkon
Hi, > Thank you for reviewing! New version [v2] at: https://patchwork.ffmpeg.org/patch/13745/ Regards. A.H. --- ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

[FFmpeg-devel] libavformat/mpegtsenc: new interleaved mux mode [v2]

2019-06-28 Thread Andreas Håkon
Hi, This is the second version of my patch for an “interleaved mpeg-TS mux”. Supersedes: https://patchwork.ffmpeg.org/patch/13487/ Please, read the original thread for checks about the patch. Changes from the initial version: 1. Option name changed from “mpegts_extra_mux” to

Re: [FFmpeg-devel] [PATCH] add FF_DECODE_ERROR_DECODE_SLICES flag for AVFrame.decode_error_flags

2019-06-28 Thread Amir Z
Sorry Michael I missed this one. I submitted an updated patch. Thanks Amir On Sat, Jun 22, 2019 at 11:13 AM Michael Niedermayer wrote: > On Fri, Jun 21, 2019 at 07:15:55AM -0700, Amir Pauker wrote: > > FF_DECODE_ERROR_DECODE_SLICES is set when decoding slices result with > error(s) but the

[FFmpeg-devel] [PATCH] add FF_DECODE_ERROR_DECODE_SLICES flag for AVFrame.decode_error_flags

2019-06-28 Thread Amir Pauker
avutil: add FF_DECODE_ERROR_DECODE_SLICES for AVFrame.decode_error_flags Signed-off-by: Amir Pauker --- doc/APIchanges | 3 +++ libavutil/frame.h | 1 + libavutil/version.h | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index

Re: [FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-28 Thread Andreas Håkon
Hi Marton, > Maybe it's too much work for little benefit, but instead of this a more > generic "setts" bitstream filter might be implemented which can be used to > set both PTS and DTS similar to how the setpts/asetpts filter works for > frames. New version (ready to merge) is here:

[FFmpeg-devel] libavcodec: add timer bitstream filter

2019-06-28 Thread Andreas Håkon
Hi, This is a refined version of the initial version for the new “timer” BSF. Supersedes: https://patchwork.ffmpeg.org/patch/13699/ Changes from the last version: 1. Name changed from “delayer” to “timer”. 2. Enabled negative offset values (aka time advance). 3. Improved less verbose log

Re: [FFmpeg-devel] [PATCH] Add DICOM Support

2019-06-28 Thread Shivam
On 6/27/19 9:21 PM, Michael Niedermayer wrote: On Wed, Jun 26, 2019 at 11:33:05PM +0530, Shivam wrote: On 6/26/19 4:37 PM, Michael Niedermayer wrote: On Wed, Jun 26, 2019 at 09:54:56AM +0200, Paul B Mahol wrote: On 6/26/19, Michael Niedermayer wrote: On Tue, Jun 25, 2019 at 01:52:09PM

Re: [FFmpeg-devel] [PATCH 2/3] lavc/mjpeg_parser: use ff_mjpeg_decode_header to parse frame info

2019-06-28 Thread Michael Niedermayer
On Thu, Jun 27, 2019 at 08:59:13PM +0800, Zhong Li wrote: > Signed-off-by: Zhong Li > --- > libavcodec/mjpeg_parser.c | 158 > +- > 1 file changed, 157 insertions(+), 1 deletion(-) this breaks mjpeg decoding for example tickets/3229/bad.avi

[FFmpeg-devel] [PATCH V2 3/4] lavf/dump: More disposition flag dump

2019-06-28 Thread Jun Zhao
From: Jun Zhao More disposition flag dump Signed-off-by: Jun Zhao --- libavformat/dump.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/libavformat/dump.c b/libavformat/dump.c index bb8c72f..1c44656 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@

Re: [FFmpeg-devel] [PATCH v3] lavf/vf_find_rect: add the dual input support function

2019-06-28 Thread Michael Niedermayer
On Thu, Jun 27, 2019 at 05:40:31PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Please using the below command for the testing: > ./ffmpeg -i input.ts -i ref.png -filter_complex > find_rect,cover_rect=cover.jpg:mode=cover output.ts > > I have updated the help document for the

[FFmpeg-devel] [PATCH V2 2/4] ffmpeg_opt: Respect default disposition when select audio/video

2019-06-28 Thread Jun Zhao
From: Jun Zhao Respect default disposition when select audio/video Signed-off-by: Jun Zhao --- fftools/ffmpeg_opt.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 53d688b..f5ca18a 100644 ---

[FFmpeg-devel] [PATCH V2 1/4] lavf/utils: Respect default disposition when select the AVStream

2019-06-28 Thread Jun Zhao
From: Jun Zhao Respect default disposition when select the AVStream Signed-off-by: Jun Zhao --- libavformat/utils.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 3d764c1..886cd6f 100644 --- a/libavformat/utils.c +++

[FFmpeg-devel] [PATCH V2 4/4] fate: add disposition default test case

2019-06-28 Thread Jun Zhao
From: Jun Zhao add disposition default test case Signed-off-by: Jun Zhao --- tests/fate/ffmpeg.mak |4 + tests/ref/fate/ffmpeg-disposition_default | 106 + 2 files changed, 110 insertions(+), 0 deletions(-) create mode 100644

[FFmpeg-devel] [PATCH V2 0/4] Respect default disposition when select stream

2019-06-28 Thread Jun Zhao
V2: - Add FATE test case, the test clip will upload to FATE server Jun Zhao (4): lavf/utils: Respect default disposition when select the AVStream ffmpeg_opt: Respect default disposition when select audio/video lavf/dump: More disposition flag dump fate: add disposition default test case

Re: [FFmpeg-devel] [PATCH v6] Fix integer parameters size check in SDP fmtp line

2019-06-28 Thread Olivier MAIGNIAL
Hello here! A simple ping about this patch If you have any question, feel free to ask! Regards, Olivier On Wed, Jun 19, 2019 at 3:38 PM Olivier Maignial wrote: > === PROBLEM === > > I was trying to record h264 + aac streams from an RTSP server to mp4 file. > using this command line: >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: temp_file usage for master playlist and vtt playlist

2019-06-28 Thread Liu Steven
> 在 2019年6月28日,上午4:36,Bodecs Bela 写道: > > ping > > 2019.06.24. 18:01 keltezéssel, Bodecs Bela írta: >> Dear All, >> >> currently master playlist and subtitle playlist creation does not use >> temporary files even when temp_file flag is set. Most of the use cases >> it is not a problem