On 01.07.2019, at 00:51, Carl Eugen Hoyos wrote:
> Hi!
>
> I believe attached patch fixes undefined behaviour and ticket #7981.
Same here, I think it makes more sense to check the "size" instead of the
pointer.
But I also suspect we might want to think of a way to not need all these
explici
On 01.07.2019, at 01:12, Carl Eugen Hoyos wrote:
> Undefined behaviour was reported in ticket #7981, attached patch tries
> to fix it.
I suspect it makes more sense to check header_len against 0?
And is the NULL pointer really undefined behaviour even if length is 0?
On 02-07-2019 06:16 AM, Guo, Yejun wrote:
-Original Message-
From: Guo, Yejun
Sent: Thursday, June 13, 2019 1:31 PM
To: ffmpeg-devel@ffmpeg.org
Cc: Guo, Yejun
Subject: [PATCH V3 2/3] doc/filters: update how to generate native model for sr
filter
Signed-off-by: Guo, Yejun
---
doc/
addi/daddi are deprecated by MIPS for years, and MIPS r6 remove
them.
They should be replace with addiu:
ADDIU performs the same arithmetic operation but
does not trap on overflow.
---
libavcodec/mips/cabac.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/mip
Signed-off-by: Steven Liu
---
tests/fate/hlsenc.mak| 11 ++
tests/ref/fate/hls-init-time | 313 +++
2 files changed, 324 insertions(+)
create mode 100644 tests/ref/fate/hls-init-time
diff --git a/tests/fate/hlsenc.mak b/tests/fate/hlsenc.mak
index e81fb5
> -Original Message-
> From: Guo, Yejun
> Sent: Thursday, June 13, 2019 1:31 PM
> To: ffmpeg-devel@ffmpeg.org
> Cc: Guo, Yejun
> Subject: [PATCH V3 2/3] doc/filters: update how to generate native model for
> sr
> filter
>
> Signed-off-by: Guo, Yejun
> ---
> doc/filters.texi | 5 -
Am 02.07.19 um 00:28 schrieb Ulf Zibis:
>> If this could be done without float/double that would be preferred as it
>> avoids inaccuracies / slight differences between platforms
> I too thought on that, but the existing functions too rely on
> float/double. Should I anyway provide a solution with
Thanks Michael for your review, answers inline ...
Am 01.07.19 um 17:16 schrieb Michael Niedermayer:
>> timestamp.h | 78
>>
>> 1 file changed, 73 insertions(+), 5 deletions(-)
>> 3d1275421b1b8d4952815151158c7af954d38ca6 timestamp_2
On 7/1/2019 11:24 AM, Michael Niedermayer wrote:
> On Sun, Jun 30, 2019 at 11:18:55PM -0300, James Almer wrote:
>> On 6/30/2019 10:43 PM, James Almer wrote:
>>> On 6/30/2019 7:16 PM, Michael Niedermayer wrote:
Fixes:
15295/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-567
For audio packets with dts != AV_NOPTS_VALUE the dts the dts was
converted twice to the muxer's timebase during streamcopy, once as a
normal packet and once specifically as an audio packet. This has been
changed.
Signed-off-by: Andreas Rheinhardt
---
You are right. Seems that this is not covered
mån 2019-07-01 klockan 01:47 +0200 skrev Carl Eugen Hoyos:
> Hi!
>
> Attached patch fixes the only (remaining) issue I see with the sample
> of ticket #7980.
>
> Please comment, Carl Eugen
Looks OK to me
/Tomas
___
ffmpeg-devel mailing list
ffmpeg-dev
On Mon, Jul 01, 2019 at 01:47:46AM +0200, Carl Eugen Hoyos wrote:
> Hi!
>
> Attached patch fixes the only (remaining) issue I see with the sample
> of ticket #7980.
>
> Please comment, Carl Eugen
> zmbvenc.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 39d38ac46b445460b0f27a
On Mon, Jul 01, 2019 at 01:08:34PM +0200, Carl Eugen Hoyos wrote:
> Hi!
>
> Attached patch fixes an invalid left shift reported in ticket #7982.
>
> Please comment, Carl Eugen
> r210enc.c |6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 9db2195a8e6d3c90726c2bf92119ff6043d4dd99
On Sun, Jun 30, 2019 at 12:34:06AM +0200, Andreas Rheinhardt wrote:
> For audio packets with dts != AV_NOPTS_VALUE the dts the dts was
> converted twice to the muxer's timebase during streamcopy, once as a
> normal packet and once specifically as an audio packet. This has been
> changed.
>
> Signe
On Mon, Jul 01, 2019 at 11:51:30AM +0200, Ulf Zibis wrote:
>
> Am 29.06.19 um 18:12 schrieb Ulf Zibis:
> > Hi,
> >
> > for my developement of another filter I need additional timestamp print
> > formats.
> >
> > So I like to share my efforts. Are you interested to include them to the
> > project?
On Sun, Jun 30, 2019 at 11:18:55PM -0300, James Almer wrote:
> On 6/30/2019 10:43 PM, James Almer wrote:
> > On 6/30/2019 7:16 PM, Michael Niedermayer wrote:
> >> Fixes:
> >> 15295/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5675655187922944
> >>
> >> Found-by: continuous fuzzing
On Sun, Jun 30, 2019 at 10:43:33PM -0300, James Almer wrote:
> On 6/30/2019 7:16 PM, Michael Niedermayer wrote:
> > Fixes:
> > 15295/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5675655187922944
> >
> > Found-by: continuous fuzzing process
> > https://github.com/google/oss-fuzz/
On Sun, Jun 30, 2019 at 05:04:38PM +0500, Anton Novikov wrote:
> When I truncate the packet at next SOC, I get:
> [jpeg2000 @ 0x55ce0298aa40] SIZ
> [jpeg2000 @ 0x55ce0298aa40] SIZ width=2056 height=2168 tile_width=2056
> tile_height=2168 tile_offset_x=0 tile_offset_y=0 xtiles=1 ytiles=1
> [jpeg2000
On Sun, Jun 30, 2019 at 12:00:43AM +0100, Cameron Cawley wrote:
> ---
> libavformat/rpl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
this doesnt apply, against which branch is that patch ?
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I
Hi Paul,
> > I disagree. Based on your code the 4 modes do this:
> > < -1 = 0
> > -1 = WRITE_HEADER
> > 0 = WRITE_HEADER | ONE_PACKET_ONLY
> >
> > > 0 = ONE_PACKET_ONLY
> >
> > You documented the meaning of the "modes" in two places and created two
> > helper functions to make sure you pass the co
Em seg, 1 de jul de 2019 às 05:21, Guo, Yejun escreveu:
>
>
>
> > -Original Message-
> > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of
> > Pedro Arthur
> > Sent: Monday, June 24, 2019 11:13 PM
> > To: FFmpeg development discussions and patches
> > Subject: Re: [
Hi Marton,
> > > > > > - ts_st->payload = av_mallocz(ts->pes_payload_size);
> > > > > > + ts_st->payload = av_mallocz(ts->parallel_mux ?
> > > > > > MAX_PES_PAYLOAD : ts->pes_payload_size);
> > > > > >
> > > > >
> > > > > Could you clarify why this needs to be changed?
>
Am Mo., 1. Juli 2019 um 14:26 Uhr schrieb Peter Ross :
>
> ---
> Small patch, to extract timestamp from IFV file header.
lgtm if tested.
Thank you, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmp
---
Small patch, to extract timestamp from IFV file header.
libavformat/ifv.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavformat/ifv.c b/libavformat/ifv.c
index 03c682bb9d..6acbb29a75 100644
--- a/libavformat/ifv.c
+++ b/libavformat/ifv.c
@@ -90,7 +90,10 @@ static
> 在 2019年7月1日，下午7:03，Moritz Barsnick 写道：
>
> On Mon, Jul 01, 2019 at 17:43:59 +0800, Steven Liu wrote:
>> -av_log(h, AV_LOG_ERROR, "URL read error: %d\n", read_ret);
>> +av_log(h, AV_LOG_ERROR, "URL read error: %s\n",
>> av_err2str(read_ret));
>
Signed-off-by: Steven Liu
---
libavformat/http.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/http.c b/libavformat/http.c
index 5a937994cf..579debcd35 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -1638,7 +1638,7 @@ static int http_shutdown(URLCont
On Mon, Jul 1, 2019 at 7:08 PM Carl Eugen Hoyos wrote:
>
> Hi!
>
> Attached patch fixes an invalid left shift reported in ticket #7982.
>
> Please comment, Carl Eugen
Ha, great catch:), LGTM
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://f
Hi!
Attached patch fixes an invalid left shift reported in ticket #7982.
Please comment, Carl Eugen
From cfe1ae9a1e95dee72ff0e0a45ce8caab98a1bd0b Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos
Date: Mon, 1 Jul 2019 13:06:02 +0200
Subject: [PATCH] lavc/r210enc: Fix undefined behaviour encoding r
On Mon, Jul 01, 2019 at 17:43:59 +0800, Steven Liu wrote:
> -av_log(h, AV_LOG_ERROR, "URL read error: %d\n", read_ret);
> +av_log(h, AV_LOG_ERROR, "URL read error: %s\n",
> av_err2str(read_ret));
^^
You c
Andreas Rheinhardt (12019-06-20):
> The subfile protocol treats an end of 0 as meaning "until EOF"; this got
> implemented by simply setting the end to INT64_MAX. But seeking relative
> to EOF or AVSEEK_SIZE seeking hasn't been adapted; the result is that
> e.g. the duration of transport streams is
Am 29.06.19 um 18:12 schrieb Ulf Zibis:
> Hi,
>
> for my developement of another filter I need additional timestamp print
> formats.
>
> So I like to share my efforts. Are you interested to include them to the
> project?
>
> For libavutil/timestamp.h I'm also wondering, why these format functions
> 在 2019年7月1日，下午4:49，Nicolas George 写道：
>
> Liu Steven (12019-07-01):
>> Just leave the old numeric code to some people like it. I think the
>> better to remove it, but i cannot sure if that is useful to other
>> people :D.
>
> Many places only print the error message. I see no difference spec
Liu Steven (12019-07-01):
> For example:
> When i debug the code: it give me message:
>
> [http @ 0x7ff64540c200] URL read error: -541478725
> after patch:
> [http @ 0x7ff64540c200] URL read error: End of file
>
> I think the message after patch is easier to understand :D
I do
Signed-off-by: Steven Liu
---
libavformat/http.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/http.c b/libavformat/http.c
index 5a937994cf..f687dc3ae2 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -1638,7 +1638,7 @@ static int http_shutdown(URLCont
> 在 2019年7月1日，下午4:49，Nicolas George 写道：
>
> Liu Steven (12019-07-01):
>> Just leave the old numeric code to some people like it. I think the
>> better to remove it, but i cannot sure if that is useful to other
>> people :D.
>
> Many places only print the error message. I see no difference spec
Liu Steven (12019-07-01):
> Just leave the old numeric code to some people like it. I think the
> better to remove it, but i cannot sure if that is useful to other
> people :D.
Many places only print the error message. I see no difference specific
to this specific place.
Regards,
--
Nicolas G
> 在 2019年7月1日，下午3:47，Nicolas George 写道：
>
> Steven Liu (12019-07-01):
>> Signed-off-by: Steven Liu
>> ---
>> libavformat/http.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Any reason to leave the nummeric code at all?
Just leave the old numeric code to some people like it. I t
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of
> myp...@gmail.com
> Sent: Monday, July 1, 2019 3:28 PM
> To: FFmpeg development discussions and patches
> Cc: Xiang, Haihao
> Subject: Re: [FFmpeg-devel] [PATCH v3] libavcodec/vp8dec: fix the
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of
> Pedro Arthur
> Sent: Monday, June 24, 2019 11:13 PM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH V3 1/3] tools/python: add script to convert
> Tensor
> -Original Message-
> From: Guo, Yejun
> Sent: Monday, July 01, 2019 4:08 PM
> To: ffmpeg-devel@ffmpeg.org
> Cc: Guo, Yejun
> Subject: [PATCH 1/2] dnn: add layer pad which is equivalent to tf.pad
>
> the reason to add this layer first is that vf_sr uses it in its
> tensorflow model, an
Signed-off-by: Guo, Yejun
---
tests/Makefile | 5 +-
tests/dnn/Makefile | 11 +++
tests/dnn/dnn-layer-pad-test.c | 201 +
tests/fate/dnn.mak | 8 ++
4 files changed, 224 insertions(+), 1 deletion(-)
create mode
the reason to add this layer first is that vf_sr uses it in its
tensorflow model, and the next plan is to update the python script
to convert tf.pad into native model.
Signed-off-by: Guo, Yejun
---
libavfilter/dnn/Makefile | 1 +
libavfilter/dnn/dnn_backend_native_layer_p
Steven Liu (12019-07-01):
> Signed-off-by: Steven Liu
> ---
> libavformat/http.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Any reason to leave the nummeric code at all?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
__
On Mon, Jul 1, 2019 at 2:38 PM Wang, Shaofei wrote:
>
> Hello here,
> A simple ping about this patch
> Please feel free to ask if you have any question
Is it this patch https://patchwork.ffmpeg.org/patch/13723/ fix the same issue?
___
ffmpeg-devel mailin
Signed-off-by: Steven Liu
---
libavformat/http.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/http.c b/libavformat/http.c
index 5a937994cf..1ee4d5189c 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -1638,7 +1638,7 @@ static int http_shutdown(URLCont
45 matches
Mail list logo
