[FFmpeg-devel] [PATCH 4/5 v2] mlpenc: improve lpc filtering

2019-07-09 Thread Jai Luthra
* fix a possible memory leak (apply_filter returned before freeing) * use apply_filters in process_major_frame * revert back to checking bounds with 24 bitdepth, as huff offset takes care of it Signed-off-by: Jai Luthra --- v2: remove unused variables in process_major_frame --- libavcodec/mlpe

Re: [FFmpeg-devel] [PATCH 1/5] mlpenc: fix lossless check error in number_sbits

2019-07-09 Thread Jai Luthra
On Wed, Jul 10, 2019 at 12:14:56AM +0200, Lynne wrote: Jul 9, 2019, 9:18 PM by m...@jailuthra.in: we need two bits instead of one bit to represent -1 in bitstream Signed-off-by: Jai Luthra --- libavcodec/mlpenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: add hdr10, linear, hlg color transfer function for videotoolboxenc

2019-07-09 Thread Dennis Mungai
On Wed, Jul 10, 2019, 03:05 Aman Gupta wrote: > On Wed, Jun 26, 2019 at 4:25 AM wrote: > > > From: Limin Wang > > > > Below is the testing ffmpeg command for the setting: > > ./ffmpeg -i input.ts -c:v hevc_videotoolbox -color_primaries bt2020 > > -colorspace bt2020_ncl -color_trc smpte2084 smpt

[FFmpeg-devel] [PATCH] avcodec/utils, avcodec_open2: close codec on failure

2019-07-09 Thread James Zern
after a successful init if the function fails for another reason close the codec without requiring FF_CODEC_CAP_INIT_CLEANUP which is meant to cover init failures themselves. fixes a memory leak in those cases. BUG=oss-fuzz:15529 Signed-off-by: James Zern --- libavcodec/utils.c | 5 - 1 fil

[FFmpeg-devel] [PATCH] avfilter: add rawdump filter

2019-07-09 Thread U. Artie Eoff
This filter enables raw frames to be dumped to a file before they are sent through the auto-inserted scaler filter and useful when you want unscaled raw frames in an output file. Signed-off-by: U. Artie Eoff --- Changelog| 1 + doc/filters.texi | 20 + libavfilter/

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: add hdr10, linear, hlg color transfer function for videotoolboxenc

2019-07-09 Thread Aman Gupta
On Wed, Jun 26, 2019 at 4:25 AM wrote: > From: Limin Wang > > Below is the testing ffmpeg command for the setting: > ./ffmpeg -i input.ts -c:v hevc_videotoolbox -color_primaries bt2020 > -colorspace bt2020_ncl -color_trc smpte2084 smpte2048.ts > ./ffmpeg -i input.ts -c:v hevc_videotoolbox -color

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: respect program number when merging streams

2019-07-09 Thread Aman Gupta
On Tue, Jul 9, 2019 at 2:07 PM Marton Balint wrote: > merge_pmt_versions was not usable if multiple programs were present because > when it was searching for candidate streams it did not make sure that the > PMT was > of the same program. This caused the streams of all programs to get merged > in

Re: [FFmpeg-devel] [PATCH 1/5] mlpenc: fix lossless check error in number_sbits

2019-07-09 Thread Lynne
Jul 9, 2019, 9:18 PM by m...@jailuthra.in: > we need two bits instead of one bit to represent -1 in bitstream > > Signed-off-by: Jai Luthra > --- > libavcodec/mlpenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c > index deb17

Re: [FFmpeg-devel] [PATCH 1/2] avformat/rpl: Replace strcpy with av_strlcpy

2019-07-09 Thread Cameron Cawley
The second use of strcpy() that this patch fixes was added in commit 0e9c01f. Regards Cameron On Fri, 5 Jul 2019 at 17:47, Michael Niedermayer wrote: > On Sun, Jun 30, 2019 at 12:00:43AM +0100, Cameron Cawley wrote: > > --- > > libavformat/rpl.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2

[FFmpeg-devel] [PATCH v2] avcodec/cbs_h265: add support for Alpha Channel Info SEI messages

2019-07-09 Thread James Almer
As defined in sections F.14.2.8 and F.14.3.8 Signed-off-by: James Almer --- libavcodec/cbs_h2645.c| 1 + libavcodec/cbs_h265.h | 12 +++ libavcodec/cbs_h265_syntax_template.c | 29 +++ libavcodec/hevc_sei.h | 1 +

Re: [FFmpeg-devel] [PATCHv4] avcodec: Add librav1e encoder

2019-07-09 Thread James Almer
On 7/9/2019 3:34 PM, Derek Buitenhuis wrote: > Port to the new send/receive API by: James Almer . > > Signed-off-by: Derek Buitenhuis > --- > Lots of stuff happened since v3! > > * The C API / library is now in rav1e's main repo, and officially supported. > * rav1e will bump the soname and pkg-c

[FFmpeg-devel] [PATCH] avformat/mpegts: respect program number when merging streams

2019-07-09 Thread Marton Balint
merge_pmt_versions was not usable if multiple programs were present because when it was searching for candidate streams it did not make sure that the PMT was of the same program. This caused the streams of all programs to get merged into a single (garbled) program. This patch makes sure that the

Re: [FFmpeg-devel] [PATCH] mlpenc: fix lossless failures, add sanity checks

2019-07-09 Thread Jai Luthra
On Tue, Jul 09, 2019 at 08:26:19PM +0200, Carl Eugen Hoyos wrote: Please split the patch into self-contained changes with appropriate commit messages. Thank you, Carl Eugen Cool, I've done more fixes will send a new patch set as a separate thread thx

Re: [FFmpeg-devel] [PATCHv4] avcodec: Add librav1e encoder

2019-07-09 Thread Moritz Barsnick
Hi, On Tue, Jul 09, 2019 at 19:34:33 +0100, Derek Buitenhuis wrote: > Port to the new send/receive API by: James Almer . Two nits: > +Sets the minimum quantizer (ceiling) to use when in bitrate mdoe. Typo -> "mode" > +av_log(avctx, AV_LOG_ERROR, "Unknown return code from > rav1e_send_

[FFmpeg-devel] [PATCH 3/5] mlpenc: prevent negative lsb_bits lshift

2019-07-09 Thread Jai Luthra
Fixes Coverity CID 1396239. Signed-off-by: Jai Luthra --- libavcodec/mlpenc.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c index 1cee38c82f..41030f6f07 100644 --- a/libavcodec/mlpenc.c +++ b/libavcodec/mlpenc.c @@ -1,6

[FFmpeg-devel] [PATCH 4/5] mlpenc: improve lpc filtering

2019-07-09 Thread Jai Luthra
* fix a possible memory leak (apply_filter returned before freeing) * use apply_filters in process_major_frame * revert back to checking bounds with 24 bitdepth, as huff offset takes care of it Signed-off-by: Jai Luthra --- libavcodec/mlpenc.c | 20 +++- 1 file changed, 11 insert

[FFmpeg-devel] [PATCH 5/5] mlpenc: clean up and enable 24-bit encoding

2019-07-09 Thread Jai Luthra
Signed-off-by: Jai Luthra --- libavcodec/mlpenc.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c index 9805e7ff23..4124df6d8f 100644 --- a/libavcodec/mlpenc.c +++ b/libavcodec/mlpenc.c @@ -94,8 +94

[FFmpeg-devel] [PATCH 1/5] mlpenc: fix lossless check error in number_sbits

2019-07-09 Thread Jai Luthra
we need two bits instead of one bit to represent -1 in bitstream Signed-off-by: Jai Luthra --- libavcodec/mlpenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c index deb171645c..f4948451f1 100644 --- a/libavcodec/mlpenc.c +++ b/lib

[FFmpeg-devel] [PATCH 2/5] mlpenc: fix huff offset calculation

2019-07-09 Thread Jai Luthra
huff offset wasn't always within the bounds before, which lead to corrupt encoding that didn't always trigger lossless check failures Signed-off-by: Jai Luthra --- libavcodec/mlpenc.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc

[FFmpeg-devel] [PATCHv2] avformat/movenc: use unspecified language by default

2019-07-09 Thread Marton Balint
English was used before. Signed-off-by: Marton Balint --- Changelog | 1 + libavformat/movenc.c | 2 +- libavformat/version.h | 2 +- tests/ref/acodec/alac | 2 +- tests/ref/acodec/pc

Re: [FFmpeg-devel] [PATCHv4] avcodec: Add librav1e encoder

2019-07-09 Thread Derek Buitenhuis
On 09/07/2019 19:34, Derek Buitenhuis wrote: > * Added two pass support. As a side note, I really dislike the stats_out/stats_in API, since it requires the whole stats be held in memory. This my become problematic when rav1e adds temporal RDO (think mbtree) and the stats files grow a lot. - Derek

Re: [FFmpeg-devel] [PATCHv4] avcodec: Add librav1e encoder

2019-07-09 Thread Derek Buitenhuis
On 09/07/2019 19:34, Derek Buitenhuis wrote: > +Go to @url{https://github.com/lu-zero/crav1e/} and follow the instructions > to build > +the C library. To enable using rav1e in FFmpeg, pass @code{--enable-librav1e} > +to @file{./configure}. Eugh. This is supposed to point to https://github.com/xi

[FFmpeg-devel] [PATCHv4] avcodec: Add librav1e encoder

2019-07-09 Thread Derek Buitenhuis
Port to the new send/receive API by: James Almer . Signed-off-by: Derek Buitenhuis --- Lots of stuff happened since v3! * The C API / library is now in rav1e's main repo, and officially supported. * rav1e will bump the soname and pkg-config version on any breaking changes. * C API is now as fast

Re: [FFmpeg-devel] [PATCH] mlpenc: fix lossless failures, add sanity checks

2019-07-09 Thread Carl Eugen Hoyos
> Am 09.07.2019 um 19:23 schrieb Jai Luthra : > > Signed-off-by: Jai Luthra > --- > libavcodec/mlpenc.c | 72 +++-- > 1 file changed, 37 insertions(+), 35 deletions(-) > > diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c > index deb171645c..09a8336

[FFmpeg-devel] [PATCH] mlpenc: fix lossless failures, add sanity checks

2019-07-09 Thread Jai Luthra
Signed-off-by: Jai Luthra --- libavcodec/mlpenc.c | 72 +++-- 1 file changed, 37 insertions(+), 35 deletions(-) diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c index deb171645c..09a8336b47 100644 --- a/libavcodec/mlpenc.c +++ b/libavcodec/mlpenc.c @

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix video frame lost sync for the dual input ts files with audio

2019-07-09 Thread Michael Niedermayer
On Mon, Jul 08, 2019 at 06:34:12PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > How to reproduce the problem(use two ts files with audio stream): > ffmpeg -i left_w_a.ts -i right_w_a.ts -filter_complex "hstack=inputs=2" -f > null - > > With above command, the audio stream of the

[FFmpeg-devel] [PATCH] avcodec/truemotion2: Fix several integer overflows in tm2_motion_block()

2019-07-09 Thread Michael Niedermayer
Fixes: 15524/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-5173148372172800 Fixes: signed integer overflow: 13701388 - -2134868270 cannot be represented in type 'int' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signe

Re: [FFmpeg-devel] [PATCH] MIPS: replace addi with addiu

2019-07-09 Thread Shiyou Yin
>-Original Message- >From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel-boun...@ffmpeg.org] >On Behalf Of >YunQiang Su >Sent: Tuesday, July 2, 2019 11:53 AM >To: ffmpeg-devel@ffmpeg.org >Cc: YunQiang Su >Subject: [FFmpeg-devel] [PATCH] MIPS: replace addi with addiu > >addi/daddi ar

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc.c Accurrate time output in program_date_time (corrected)

2019-07-09 Thread myp...@gmail.com
On Tue, Jul 9, 2019 at 7:42 PM Pavel Pilar wrote: > > --- > libavformat/hlsenc.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 00c725af18..94fd713834 100644 > --- a/libavformat/hlsenc.c > +++ b/libavformat

[FFmpeg-devel] [PATCH] avutil/mips: optimize UNPCK&SAD macros with MSA2.0 instruction.

2019-07-09 Thread Shiyou Yin
Loongson 3A4000 and 2k1000 has supported MSA2.0. This patch optimized SAD_UB2_UH,UNPCK_R_SH_SW,UNPCK_SB_SH and UNPCK_SH_SW with MSA2.0 instruction. --- configure | 5 + libavutil/mips/generic_macros_msa.h | 42 ++--- 2 files changed,

[FFmpeg-devel] [PATCH] libavformat/hlsenc.c Accurrate time output in program_date_time (corrected)

2019-07-09 Thread Pavel Pilar
--- libavformat/hlsenc.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 00c725af18..94fd713834 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2653,6 +2653,9 @@ static int hls_init(AVFormatContext

Re: [FFmpeg-devel] [PATCH v3] libavcodec/vp9: fix ref-frame size judging method

2019-07-09 Thread Paul B Mahol
On 7/9/19, Ronald S. Bultje wrote: > Hi, > > On Mon, Jul 8, 2019 at 6:23 PM Yan Cen wrote: > >> From: yancen >> >> There is no need all reference frame demension is valid in libvpx. >> > > Haven't we discussed this before? Anyway, it seems you're really eager to > get this in, so I'll drop my ob

Re: [FFmpeg-devel] [PATCH v3] libavcodec/vp9: fix ref-frame size judging method

2019-07-09 Thread Ronald S. Bultje
Hi, On Mon, Jul 8, 2019 at 6:23 PM Yan Cen wrote: > From: yancen > > There is no need all reference frame demension is valid in libvpx. > Haven't we discussed this before? Anyway, it seems you're really eager to get this in, so I'll drop my objection. (I still think this could cause issues in

Re: [FFmpeg-devel] [PATCH 1/6] truehd_core: Disable 16-channel presentation

2019-07-09 Thread Paul B Mahol
On 7/6/19, Andreas Rheinhardt wrote: > The most serious bit of the substream_info header field (in a mayor sync > packet) indicates whether a 16-channel presentation is present in the > bitstream. If set, the extended_substream_info header field contains > information about the 16-channel presenta

Re: [FFmpeg-devel] [PATCH 3/6] truehd_core: Return error in case of error

2019-07-09 Thread Paul B Mahol
On 7/6/19, Andreas Rheinhardt wrote: > Several checks (e.g. when the size of the input packet is too small) > simply used "goto fail", but didn't set the return value appropriately > for an error. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/truehd_core_bsf.c | 14 ++ > 1

Re: [FFmpeg-devel] [PATCH] accurrate time output in program_date_time

2019-07-09 Thread myp...@gmail.com
On Tue, Jul 9, 2019 at 4:43 PM Pavel Pilar wrote: > > --- > libavformat/hlsenc.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 057134f410..00c725af18 100644 > --- a/libavformat/hlsenc.c > +++ b/libavformat/hlsenc.c > @@ -23,6 +

Re: [FFmpeg-devel] [PATCH] avcodec/audiotoolboxdec: Fix decoding 24 Bit ALAC

2019-07-09 Thread myp...@gmail.com
On Tue, Jul 9, 2019 at 12:37 AM Davis wrote: > > "avctx->bits_per_raw_sample" always returns 0. > Tested with 24 Bit ALAC. The result is bit-perfect. > Fix #7287. > --- > libavcodec/audiotoolboxdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/audiotoolboxd

[FFmpeg-devel] [PATCH] accurrate time output in program_date_time

2019-07-09 Thread Pavel Pilar
--- libavformat/hlsenc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 057134f410..00c725af18 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -23,6 +23,7 @@ #include "config.h" #include #include +#include #if HAV