Not OK, there is threading in filter. See execute call.
On 10/25/19, Andriy Gelman wrote:
> From: Andriy Gelman
>
> Unset flag because there is no threading in filter.
> ---
> libavfilter/af_anlmdn.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/libavfilter/af_anlmd
On 10/25/19, Limin Wang wrote:
> On Wed, Oct 23, 2019 at 06:07:24PM +0200, Paul B Mahol wrote:
>> Why?
>>
> Sorry, I haven't get your question, you mean why to use system
> standard c lib API?
What are gains?
>
>> On 10/23/19, lance.lmw...@gmail.com wrote:
>> > From: Limin Wang
>> >
>> > Sig
On Thu, Oct 24, 2019 at 19:23:48 -0500, ckenn...@ellation.com wrote:
> ffmpeg -i encode.mp4 -i reference.mp4 \
>-filter_complex "[0:v][1:v]phqm=stats_file=out.log" \
>-an -codec:v rawvideo -y -f null /dev/null
-f null doesn't require -c:v rawvideo.
> OBJS-$(CONFIG_OCV_FIL
While the function adding a new element to the keyframe index checked
the allocation, the caller didn't check the return value. This has been
changed. To do so, the return value has been changed to an ordinary ret
instead of pb->error. This doesn't pose a problem, as write_packet() in
mux.c already
Might happen for annex B H.264.
Signed-off-by: Andreas Rheinhardt
---
This patchset was actually meant as a reply to [1], but I made an error
with the in-reply-to headers.
[1]: http://ffmpeg.org/pipermail/ffmpeg-devel/2019-October/252057.html
libavformat/flvenc.c | 3 ++-
1 file changed, 2 ins
Fixes memleaks when the trailer is never written or when shift_data()
fails when writing the trailer.
Signed-off-by: Andreas Rheinhardt
---
libavformat/flvenc.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c
index a2bd7
Using a linked list had very much overhead (the pointer to the next
entry increased the size of the index entry struct from 16 to 24 bytes,
not to mention the overhead of having separate allocations), so it is
better to (re)allocate a continuous array for the index.
Signed-off-by: Andreas Rheinhar
Completely agree, just worried that it might cause incompatibility issues from
some users down the line.
On the other hand, Unified Streaming is always using UTC timestamps on their
PDT:
https://docs.unified-streaming.com/documentation/live/recommended-settings.html#timecode
This would make th
Am Fr., 25. Okt. 2019 um 02:24 Uhr schrieb :
> +// convert from avframe to iplimage format
> +static void fill_iplimage_from_frame(IplImage *img, const AVFrame *frame,
> enum AVPixelFormat pixfmt)
> +{
> +IplImage *tmpimg;
> +int depth, channels_nb;
> +
> +if (pixfmt == AV_PIX_FM
Signed-off-by: Paul B Mahol
---
libavfilter/vf_lut3d.c | 165 +++--
1 file changed, 108 insertions(+), 57 deletions(-)
diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c
index a525039baa..8ef1bb7385 100644
--- a/libavfilter/vf_lut3d.c
+++ b/libavfilt
Signed-off-by: Paul B Mahol
---
libavfilter/vf_lut3d.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c
index 8ef1bb7385..edaf9a711e 100644
--- a/libavfilter/vf_lut3d.c
+++ b/libavfilter/vf_lut3d.c
@@ -55,7 +55,7 @@ struct rgbvec
I think this is the best solution, with just one new flag +utc_pdt that will
force timestamps of PDT to be in UTC with the format -MM-DDThh:mm:ssZ. Too
many flags will be confusing, and the "zulu" name can be a bit confusing so I
removed any mention of that.
Ole Andre Birkedal
‐‐‐ Orig
On Thu, Oct 24, 2019 at 9:35 PM Lou Logan wrote:
> On Tue, Oct 22, 2019, at 10:05 AM, Paul B Mahol wrote:
> > probably ok
>
> Pushed b293ec7188b6b39ac769f358a2f4a95d0a49c1b7.
>
> Now giant download button is more giant, but I will adjust the CSS.
I would recommend adding the following to the butt
Fixes: signed integer overflow: -2147450880 - 65535 cannot be represented in
type 'int'
Fixes:
18393/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_INTERPLAY_ACM_fuzzer-5667520110919680
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed
Fixes: signed integer overflow: 2046820356 * 8 cannot be represented in type
'int'
Fixes:
18391/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_COOK_fuzzer-5631674666188800
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Micha
Fixes: left shift of negative value -30
Fixes:
18392/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_IMA_OKI_fuzzer-5631771831435264
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/adp
On Fri, 25. Oct 09:47, Paul B Mahol wrote:
> Not OK, there is threading in filter. See execute call.
sorry, missed this one.
--
Andriy
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscr
On Fri, Oct 25, 2019 at 09:51:33AM +0200, Paul B Mahol wrote:
> On 10/25/19, Limin Wang wrote:
> > On Wed, Oct 23, 2019 at 06:07:24PM +0200, Paul B Mahol wrote:
> >> Why?
> >>
> > Sorry, I haven't get your question, you mean why to use system
> > standard c lib API?
>
> What are gains?
Our imp
From: Limin Wang
1, Test server configure:
[root@localhost ~]# cat /proc/cpuinfo |grep "model name"
model name : Intel(R) Xeon(R) CPU E5-2650 v2 @ 2.60GHz
model name : Intel(R) Xeon(R) CPU E5-2650 v2 @ 2.60GHz
...
[root@localhost ~]# free -h
totalusedfree
Am Fr., 25. Okt. 2019 um 17:37 Uhr schrieb :
> -.capabilities = AV_CODEC_CAP_DR1,
> +.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_SLICE_THREADS |
> +AV_CODEC_CAP_FRAME_THREADS
In your tests: Was slice threading or frame threading more effective?
Carl Eugen
libavutil/parseutils.h has been included in 22bbd6e8 for av_parse_time()
and the header has not been removed when said function was replaced by
ff_parse_creation_time_metadata() in ea1bf08a.
Signed-off-by: Andreas Rheinhardt
---
libavformat/asfenc.c | 1 -
1 file changed, 1 deletion(-)
diff --g
8d5604a6 added libavcodec/profiles.h, yet this header was not used, as
the FF_PROFILE_AV1_* defines are contained in libavcodec/avcodec.h.
Signed-off-by: Andreas Rheinhardt
---
libavformat/av1.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/av1.c b/libavformat/av1.c
index b36c5e
bswap.h was included since 7b114c09, yet since 3788a3c0 no explicit use
of anything from bswap.h has been made, so remove this header.
(Only AV_RL32 is used and while this might imply swapping on
big-endian systems, it is contained in libavutil/intreadwrite.h.)
Signed-off-by: Andreas Rheinhardt
04d2540c added intreadwrite.h to avienc.c, although there was (and is)
no need to do so. The inclusion seems to be a mistake as this commit
added a AV_WL32 to avidec.c.
Signed-off-by: Andreas Rheinhardt
---
libavformat/avienc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/avien
libavcodec/internal.h has been included since 36e61e24/67286fa9 for
avpriv_bprint_to_extradata(). The latter function has been replaced
by ff_bprint_to_codecpar_extradata() in 6f69f7a8, making the header
superfluous.
Signed-off-by: Andreas Rheinhardt
---
libavformat/assdec.c | 1 -
1 file change
50ed6e3c added several asserts and the relevant header to concatdec.c;
14e09244 removed these asserts, but forgot to remove the header.
Signed-off-by: Andreas Rheinhardt
---
libavformat/concatdec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/concatdec.c b/libavformat/concatdec
15d838b7 included libavutil/parseutils.h in order to use
av_parse_video_size(); the latter function isn't used any more since
33b6d215, so the header can be removed.
Signed-off-by: Andreas Rheinhardt
---
libavformat/bintext.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/bintext
aiffdec.c calls ff_mov_read_chan() whose declaration was in isom.h until
c4dba58f; from that commit onwards, isom.h was not needed anymore, yet
it hasn't been removed.
libavutil/mathematics.h has been included in 3383a53e for ldexp(), but
this function and the whole header isn't used any more since
75af0e6a added opt.h to dvenc.c for an option; 6b35f1a2 removed said
option, yet forgot to remove the header as well.
Signed-off-by: Andreas Rheinhardt
---
libavformat/dvenc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/dvenc.c b/libavformat/dvenc.c
index 93c103b316..8eb58cf43
Both attributes.h and bswap.h have been included from the very beginning
of this muxer without there being any reason to do so.
Signed-off-by: Andreas Rheinhardt
---
libavformat/dss.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavformat/dss.c b/libavformat/dss.c
index e5b0be9deb..d7f
When the APE tag parsing code was moved into its own file in 191e34cd,
intreadwrite.h was included despite not being used for parsing APE tags.
Signed-off-by: Andreas Rheinhardt
---
libavformat/apetag.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/apetag.c b/libavformat/apetag.
avassert.h has been simply copied over when libavformat/fifo_test.c was
split from libavformat/tests/fifo_muxer.c.
Signed-off-by: Andreas Rheinhardt
---
libavformat/fifo_test.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/fifo_test.c b/libavformat/fifo_test.c
index 02ec215cbb..
They have simply been copied when dashenc.c was split up in 837580f4.
Signed-off-by: Andreas Rheinhardt
---
libavformat/dash.c | 17 -
1 file changed, 17 deletions(-)
diff --git a/libavformat/dash.c b/libavformat/dash.c
index d2501f013a..168cd3c548 100644
--- a/libavformat/dash.
Since their inception, the filmstrip muxer and demuxer included
intreadwrite.h; it was unneeded all the time.
Signed-off-by: Andreas Rheinhardt
---
libavformat/filmstripdec.c | 1 -
libavformat/filmstripenc.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/libavformat/filmstripdec.c b/libav
On Fri, Oct 25, 2019 at 01:17:16PM +0200, Deby Page wrote:
> On Thu, Oct 24, 2019 at 9:35 PM Lou Logan wrote:
> > On Tue, Oct 22, 2019, at 10:05 AM, Paul B Mahol wrote:
> > > probably ok
> >
> > Pushed b293ec7188b6b39ac769f358a2f4a95d0a49c1b7.
> >
> > Now giant download button is more giant, but I
On Fri, Oct 25, 2019 at 11:27:48AM +0200, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> libavfilter/vf_lut3d.c | 165 +++--
> 1 file changed, 108 insertions(+), 57 deletions(-)
>
LGTM
[...]
--
Clément B.
On Fri, Oct 25, 2019 at 11:11:46AM +0200, Andreas Rheinhardt wrote:
> Using a linked list had very much overhead (the pointer to the next
> entry increased the size of the index entry struct from 16 to 24 bytes,
> not to mention the overhead of having separate allocations), so it is
> better to (re
On Fri, Oct 25, 2019 at 08:07:37PM +0200, Andreas Rheinhardt wrote:
> 04d2540c added intreadwrite.h to avienc.c, although there was (and is)
> no need to do so. The inclusion seems to be a mistake as this commit
> added a AV_WL32 to avidec.c.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavfo
On Fri, Oct 25, 2019 at 08:07:33PM +0200, Andreas Rheinhardt wrote:
> libavutil/parseutils.h has been included in 22bbd6e8 for av_parse_time()
> and the header has not been removed when said function was replaced by
> ff_parse_creation_time_metadata() in ea1bf08a.
>
> Signed-off-by: Andreas Rheinh
On Fri, Oct 25, 2019 at 08:07:36PM +0200, Andreas Rheinhardt wrote:
> bswap.h was included since 7b114c09, yet since 3788a3c0 no explicit use
> of anything from bswap.h has been made, so remove this header.
>
> (Only AV_RL32 is used and while this might imply swapping on
> big-endian systems, it i
On Fri, Oct 25, 2019 at 03:38:07AM +0200, Andreas Rheinhardt wrote:
> Prevents memleaks if the trailer is never written.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/aiffenc.c | 13 +
> 1 file changed, 9 insertions(+), 4 deletions(-)
will apply
thx
[...]
--
Michael
On Fri, Oct 25, 2019 at 11:27:49AM +0200, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> libavfilter/vf_lut3d.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c
> index 8ef1bb7385..edaf9a711e 100644
> --- a/libavf
On Fri, Oct 25, 2019 at 10:52:19AM +0200, Andreas Rheinhardt wrote:
> While the function adding a new element to the keyframe index checked
> the allocation, the caller didn't check the return value. This has been
> changed. To do so, the return value has been changed to an ordinary ret
> instead o
On Fri, Oct 25, 2019 at 05:57:44PM -0300, James Almer wrote:
> On 10/25/2019 5:44 PM, Michael Niedermayer wrote:
> > On Fri, Oct 25, 2019 at 11:11:46AM +0200, Andreas Rheinhardt wrote:
> >> Using a linked list had very much overhead (the pointer to the next
> >> entry increased the size of the inde
On 10/25/2019 5:44 PM, Michael Niedermayer wrote:
> On Fri, Oct 25, 2019 at 11:11:46AM +0200, Andreas Rheinhardt wrote:
>> Using a linked list had very much overhead (the pointer to the next
>> entry increased the size of the index entry struct from 16 to 24 bytes,
>> not to mention the overhead of
On Fri, 2019-10-25 at 02:17 +, Fu, Linjie wrote:
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Rogozhkin, Dmitry V
> > Sent: Friday, October 25, 2019 05:17
> > To: ffmpeg-devel@ffmpeg.org
> > Subject: Re: [FFmpeg-devel] ffmpeg-qsv: Is opaque memory allocation
> > path
On 10/25/19, Clément Bœsch wrote:
> On Fri, Oct 25, 2019 at 11:27:49AM +0200, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol
>> ---
>> libavfilter/vf_lut3d.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c
>> index 8
On Fri, Oct 25, 2019, at 3:17 AM, Deby Page wrote:
>
> I would recommend adding the following to the button's CSS, wrapping
> the button to multiple lines on smaller screens:
> white-space: normal;
Thanks. Pushed, but with errors:
remote: lessc --clean-css src/less/style.less >
htdocs/css/sty
On Fri, Oct 25, 2019 at 06:39:46PM +0200, Carl Eugen Hoyos wrote:
> Am Fr., 25. Okt. 2019 um 17:37 Uhr schrieb :
>
> > -.capabilities = AV_CODEC_CAP_DR1,
> > +.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_SLICE_THREADS |
> > +AV_CODEC_CAP_FRAME_THREADS
It's related t
From: Limin Wang
Or it'll cause invalid color and s->filter is NULL.
Please reproduce it with below command on big endian system:
$ ./ffmpeg -f lavfi -i "anoisesrc=d=60:c=1:r=48000" -f s16le -c:a pcm_s16le -f
null -
Segmentation fault (core dumped)
Signed-off-by: Limin Wang
---
libavfilter/
On Fri, Oct 25, 2019 at 11:12 PM Michael Niedermayer
wrote:
> On Fri, Oct 25, 2019 at 10:52:19AM +0200, Andreas Rheinhardt wrote:
> > While the function adding a new element to the keyframe index checked
> > the allocation, the caller didn't check the return value. This has been
> > changed. To d
On Fri, Oct 25, 2019 at 10:44 PM Michael Niedermayer
wrote:
> On Fri, Oct 25, 2019 at 11:11:46AM +0200, Andreas Rheinhardt wrote:
> > Using a linked list had very much overhead (the pointer to the next
> > entry increased the size of the index entry struct from 16 to 24 bytes,
> > not to mention
Fixes ticket #8336.
Signed-off-by: James Almer
---
libavfilter/avf_showfreqs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavfilter/avf_showfreqs.c b/libavfilter/avf_showfreqs.c
index c44ac564ac..645754ded3 100644
--- a/libavfilter/avf_showfreqs.c
+++ b/libavfilter/avf_showfreqs.c
@@
From: Christopher Kennedy
this adds a phqm filter and OpenCV img_hash based resource usable
by the phqm and future filters using image hash functionality
from OpenCV.
C++ to C handling so that full OpenCV functionality and API can
be used instead of the C versions (which are incomplete and
don't
Both attributes.h and bswap.h have been included from the very beginning
of this muxer without there being any reason to do so.
Signed-off-by: Andreas Rheinhardt
---
The earlier mail claimed this to be about avformat/ass. Sorry.
libavformat/dss.c | 2 --
1 file changed, 2 deletions(-)
diff --g
55 matches
Mail list logo
