[FFmpeg-devel] [PATCH v3] Add support for playing Audible AAXC (.aaxc) files

2020-04-07 Thread Vesselin Bontchev
From cb25a130797370e2801cecc34740764c6d2d264b Mon Sep 17 00:00:00 2001 From: Vesselin Bontchev Date: Sat, 1 Jan 2000 09:00:00 + Subject: [PATCH v3] Add support for playing Audible AAXC (.aaxc) files The AAXC container format is the same as the (already supported) Audible AAX format but it

[FFmpeg-devel] [PATCH v1] doc/utils: add more examples for valid time duration

2020-04-07 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/utils.texi | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/utils.texi b/doc/utils.texi index 05a2f81626..ca599f145b 100644 --- a/doc/utils.texi +++ b/doc/utils.texi @@ -126,6 +126,15 @@ The following examples are all valid

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-07 Thread Limin Wang
On Wed, Apr 08, 2020 at 02:16:23AM +0200, pkv wrote: > Hi > > Le 08/04/2020 à 12:33 am, Limin Wang a écrit : > >On Tue, Apr 07, 2020 at 08:25:44PM +0200, pkv wrote: > >>Hi > >> > >>new patch for latency option following the comments from N. George. > >I recall I had submit a patchset for related

[FFmpeg-devel] [PATCH v3] avformat/dashenc: remove the arbitrary restrictions for filename

2020-04-07 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/dashenc.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 94d463972a..903fdd0aa6 100644 --- a/libavformat/dashenc.c +++

Re: [FFmpeg-devel] [PATCH v2] avformat/dashenc: remove the arbitrary restrictions for filename

2020-04-07 Thread Limin Wang
On Wed, Apr 08, 2020 at 01:54:12AM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/dashenc.c | 28 > > 1 file changed, 12 insertions(+), 16 deletions(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-07 Thread pkv
Hi Le 08/04/2020 à 12:33 am, Limin Wang a écrit : On Tue, Apr 07, 2020 at 08:25:44PM +0200, pkv wrote: Hi new patch for latency option following the comments from N. George. I recall I had submit a patchset for related option incliding latency.

[FFmpeg-devel] [PATCH v4 2/2] libavcodec/libaomenc.c: Support lossless encoding

2020-04-07 Thread Ryo Hirafuji
From: Ryo Hirafuji AV1 support lossless encoding. In this patch, I added a command line flag to enable it. Fixes ticket #7600 --- libavcodec/libaomenc.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index

[FFmpeg-devel] [PATCH v4 1/2] libavcodec/libaomenc.c: Support gray input

2020-04-07 Thread Ryo Hirafuji
From: Ryo Hirafuji AV1 decoders, libaomdec and libdav1d, both support grayscale image. However, libaomenc does not support it yet. In this patch, I add a grayscale image support also to libaomenc. Fixes ticket #7599 --- libavcodec/libaomenc.c | 40 +--- 1

Re: [FFmpeg-devel] [PATCH v2] avformat/dashenc: remove the arbitrary restrictions for filename

2020-04-07 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/dashenc.c | 28 > 1 file changed, 12 insertions(+), 16 deletions(-) > > diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c > index 94d4639..f80f6f2 100644 > ---

[FFmpeg-devel] [PATCH v2] avformat/dashenc: remove the arbitrary restrictions for filename

2020-04-07 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/dashenc.c | 28 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 94d4639..f80f6f2 100644 --- a/libavformat/dashenc.c +++

Re: [FFmpeg-devel] [PATCH] avfilter/vf_drawtext: only test available exceptions

2020-04-07 Thread Carl Eugen Hoyos
Am Di., 7. Apr. 2020 um 02:46 Uhr schrieb Rosen Penev : > > soft float systems do not define these macros under musl. > > Fixes: Ticket7102 I will push this if nobody objects. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Update context on double init

2020-04-07 Thread Carl Eugen Hoyos
Am Di., 7. Apr. 2020 um 15:38 Uhr schrieb Anton Khirnov : > I believe such non-constructive information-free comments should be > - disregarded > - treated as a breach of the code of conduct, once we have an > enforceable one (which is hopefully soon) This is not he first time that you send an

Re: [FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Update context on double init

2020-04-07 Thread Michael Niedermayer
On Tue, Apr 07, 2020 at 10:55:39AM +0200, Paul B Mahol wrote: > On 4/6/20, Michael Niedermayer wrote: > > On Mon, Apr 06, 2020 at 12:00:21PM +0200, Anton Khirnov wrote: > >> Quoting Michael Niedermayer (2020-04-05 00:38:41) > >> > Fixes: memleak > >> > >> Memleak of what/where/why? This is highly

Re: [FFmpeg-devel] [PATCH v1] avformat/dashenc: use av_asprintf()

2020-04-07 Thread Limin Wang
On Tue, Apr 07, 2020 at 07:08:56PM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/dashenc.c | 23 ++- > > 1 file changed, 6 insertions(+), 17 deletions(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-07 Thread Ross Nicholson
Thank you for the explanation Marton. It's make perfect sense to me know. So UNLIMITED would be the right choice here. All of your other comments are addressed in the latest version. Thanks again for reviewing. On Tue, 7 Apr 2020 at 22:03, Marton Balint wrote: > > > On Tue, 7 Apr 2020, Ross

[FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-07 Thread phunkyfish
--- libavformat/rtsp.c | 48 +- 1 file changed, 39 insertions(+), 9 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index cd6fc32a29..07ac371903 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -21,6 +21,7 @@ #include

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-07 Thread Limin Wang
On Tue, Apr 07, 2020 at 08:25:44PM +0200, pkv wrote: > Hi > > new patch for latency option following the comments from N. George. I recall I had submit a patchset for related option incliding latency. https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200331140808.8839-2-lance.lmw...@gmail.com/

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

2020-04-07 Thread Vittorio Giovara
On Tue, Apr 7, 2020 at 7:58 AM Paul B Mahol wrote: > On 4/7/20, Vittorio Giovara wrote: > > On Sat, Dec 22, 2018 at 3:18 PM Paul B Mahol wrote: > > > >> On 12/22/18, Steinar H. Gunderson wrote: > >> > On Sat, Dec 22, 2018 at 09:04:26PM +0100, Paul B Mahol wrote: > >> >> I can not accept

[FFmpeg-devel] [PATCH 07/10] avformat/Makefile: Don't add dependency twice

2020-04-07 Thread Andreas Rheinhardt
as has happened with flac_picture.o and the Matroska demuxer. Signed-off-by: Andreas Rheinhardt --- libavformat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index eab8fe5c49..09d5c7df4b 100644 --- a/libavformat/Makefile

[FFmpeg-devel] [PATCH 06/10] avformat/Makefile: Remove false dependencies of WebM and Matroska muxer

2020-04-07 Thread Andreas Rheinhardt
These muxers don't depend on the WebM Chunk or the WebM DASH Manifest muxers. Furthermore, remove some #if checks in webm_chunk.c and webmdashenc.c. They are always true now that webm_chunk.c and webmdashenc.c are only compiled when their corresponding muxers are enabled. Signed-off-by: Andreas

[FFmpeg-devel] [PATCH 10/10] avformat/filmstripenc: Use ff_raw_write_packet()

2020-04-07 Thread Andreas Rheinhardt
The only difference of the currently used write_packet()-function to ff_raw_write_packet() is that the former also counts the number of frames. Yet doing so in the muxer itself is unnecessary as this is already done generically in write_packet() in libavformat/mux.c. Signed-off-by: Andreas

[FFmpeg-devel] [PATCH 05/10] avformat/Makefile: Remove false dependency of WebM DASH manifest muxer

2020-04-07 Thread Andreas Rheinhardt
It does not use anything from libavformat/matroska.c. Signed-off-by: Andreas Rheinhardt --- libavformat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index f72fa6fb1a..b34e5bc3ce 100644 --- a/libavformat/Makefile +++

[FFmpeg-devel] [PATCH 03/10] avformat/webm_chunk: Remove superfluous headers

2020-04-07 Thread Andreas Rheinhardt
libavutil/avstring.h is unnecessary since 8a632b3e. The other unnecessary headers were never used. Signed-off-by: Andreas Rheinhardt --- libavformat/webm_chunk.c | 9 - 1 file changed, 9 deletions(-) diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c index

[FFmpeg-devel] [PATCH 02/10] configure, libavformat/Makefile: Fix webm_chunk dependencies

2020-04-07 Thread Andreas Rheinhardt
The webm_chunk muxer requires the WebM muxer, yet it does not directly require anything from libavformat/matroska.c (it does not even include the corresponding header). So remove the dependency from the Makefile and add a _select to configure. Signed-off-by: Andreas Rheinhardt --- configure

[FFmpeg-devel] [PATCH 04/10] avformat/webmdashenc: Remove unnecessary header

2020-04-07 Thread Andreas Rheinhardt
avio_internal.h has been included in this muxer since the beginning and was never needed. Signed-off-by: Andreas Rheinhardt --- libavformat/webmdashenc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c index 08fe976b15..401cfe52d5 100644

[FFmpeg-devel] [PATCH 09/10] avformat/rso: Don't reimplement ff_raw_write_packet()

2020-04-07 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/Makefile | 2 +- libavformat/rsoenc.c | 9 ++--- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index 850f250b80..554b0bfbf8 100644 --- a/libavformat/Makefile +++

[FFmpeg-devel] [PATCH 08/10] avformat/amr: Don't reimplement ff_raw_write_packet()

2020-04-07 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/Makefile | 2 +- libavformat/amr.c| 9 ++--- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index 09d5c7df4b..850f250b80 100644 --- a/libavformat/Makefile +++

Re: [FFmpeg-devel] [PATCH] avformat/segment: always use interleaved writes for formats with custom interleaving

2020-04-07 Thread Marton Balint
On Wed, 1 Apr 2020, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/segment.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 2a838c7da7..60b72b7d15 100644 --- a/libavformat/segment.c +++

Re: [FFmpeg-devel] [PATCH] avcodec/binkaudio: Check sample_rate to avoid integer overflow

2020-04-07 Thread Michael Niedermayer
On Sat, Apr 04, 2020 at 11:38:43PM +0200, Michael Niedermayer wrote: > On Sun, Feb 09, 2020 at 09:28:48PM +0100, Michael Niedermayer wrote: > > On Sat, Feb 01, 2020 at 11:48:06PM +0100, Michael Niedermayer wrote: > > > On Sat, Feb 01, 2020 at 04:17:10PM +0100, Paul B Mahol wrote: > > > > On

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-07 Thread Marton Balint
On Tue, 7 Apr 2020, Ross Nicholson wrote: Great, thanks again. A question about AV_BPRINT_SIZE_AUTOMATIC. Is there a heuristic for when to use this versus unlimited? Or is it that generally if you would have used a buffer of 1000 or less automatic is the right choice? It depends on

[FFmpeg-devel] [PATCH 1/2] avcodec/pngdec: Check length in fdAT

2020-04-07 Thread Michael Niedermayer
Fixes: 21089/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APNG_fuzzer-5135981419429888 Fixes: out of array read Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/pngdec.c | 2 +- 1 file

[FFmpeg-devel] [PATCH 2/2] tools/target_dec_fuzzer: Adjust threshold for PNG and APNG

2020-04-07 Thread Michael Niedermayer
Fixes: Timeout (84sec -> 2sec) Fixes: 21127/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APNG_fuzzer-5098412367413248 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 2

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-07 Thread Ross Nicholson
Great, thanks again. A question about AV_BPRINT_SIZE_AUTOMATIC. Is there a heuristic for when to use this versus unlimited? Or is it that generally if you would have used a buffer of 1000 or less automatic is the right choice? > On 7 Apr 2020, at 20:50, Marton Balint wrote: > >  > >> On

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-07 Thread Marton Balint
On Tue, 7 Apr 2020, phunkyfish wrote: --- libavformat/rtsp.c | 48 +- 1 file changed, 39 insertions(+), 9 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index cd6fc32a29..dad3f7915e 100644 --- a/libavformat/rtsp.c +++

Re: [FFmpeg-devel] [PATCH 14/23] lavc/movtextenc: simplify style record updates

2020-04-07 Thread Philip Langdale
On Mon, 6 Apr 2020 11:52:09 -0600 John Stebbins wrote: > Makes style update code easier to extend for style types not yet > handled --- > libavcodec/movtextenc.c | 131 > +++- 1 file changed, 62 > insertions(+), 69 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 15/23] lavc/movtextenc: fix unclosed style records

2020-04-07 Thread Philip Langdale
On Mon, 6 Apr 2020 11:52:10 -0600 John Stebbins wrote: > The last record at the end of each dialog was never closed > --- > libavcodec/movtextenc.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c > index 05532cd544..d389111419

Re: [FFmpeg-devel] [PATCH v3 1/2] libavcodec/libaomenc.c: Support gray input

2020-04-07 Thread Ryo Hirafuji
James, thank you for your review! > You can merge these with the AV_PIX_FMT_YUV420P* cases below, doing > something like > enccfg->monochrome = avctx->pix_fmt == AV_PIX_FMT_GRAY8; > and > enccfg->monochrome = avctx->pix_fmt == AV_PIX_FMT_GRAY10 || > avctx->pix_fmt ==

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-07 Thread Nicolas George
pkv (12020-04-07): > new patch for latency option following the comments from N. George. Thanks. > > = > > Updated protocol doc for srt to specify the unit of various latency options. > Furthermore the type of the latency options is changed to > AV_OPT_TYPE_DURATION > (following comment

[FFmpeg-devel] [PATCH] avformat/libsrt: Change latency option to milliseconds

2020-04-07 Thread pkv
Hi new patch for latency option following the comments from N. George. = Updated protocol doc for srt to specify the unit of various latency options. Furthermore the type of the latency options is changed to AV_OPT_TYPE_DURATION (following comment from N. George). The microsecond unit

Re: [FFmpeg-devel] [PATCH v3 1/2] libavcodec/libaomenc.c: Support gray input

2020-04-07 Thread James Almer
On 4/7/2020 3:11 PM, Ryo Hirafuji wrote: > From: Ryo Hirafuji > > AV1 decoders, libaomdec and libdav1d, both support grayscale image. > However, libaomenc does not support it yet. > In this patch, I add a grayscale image support also to libaomenc. > > Fixes ticket #7599 > --- >

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-07 Thread Paul B Mahol
On 4/7/20, James Almer wrote: > On 4/7/2020 2:55 PM, Paul B Mahol wrote: >> On 4/7/20, Anton Khirnov wrote: >>> Quoting Paul B Mahol (2020-04-07 16:29:23) On 4/7/20, Anton Khirnov wrote: > Quoting Paul B Mahol (2020-04-06 16:27:54) >> On 4/6/20, James Almer wrote: >>> On

Re: [FFmpeg-devel] [PATCH v2 1/2] libavcodec/libaomenc.c: Support gray input

2020-04-07 Thread Ryo Hirafuji
Sorry, I forgot to add "Fixes ticket ..." I will send again as v3. 2020年4月8日(水) 3:04 Ryo Hirafuji : > From: Ryo Hirafuji > > AV1 decoders, libaomdec and libdav1d, both support grayscale image. > However, libaomenc does not support it yet. > In this patch, I add a grayscale image support also

[FFmpeg-devel] [PATCH v2 2/2] libavcodec/libaomenc.c: Support lossless encoding

2020-04-07 Thread Ryo Hirafuji
From: Ryo Hirafuji AV1 support lossless encoding. In this patch, I added a command line flag to enable it. --- libavcodec/libaomenc.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index a3c5ae8f54..2133abb1a7

[FFmpeg-devel] [PATCH v3 1/2] libavcodec/libaomenc.c: Support gray input

2020-04-07 Thread Ryo Hirafuji
From: Ryo Hirafuji AV1 decoders, libaomdec and libdav1d, both support grayscale image. However, libaomenc does not support it yet. In this patch, I add a grayscale image support also to libaomenc. Fixes ticket #7599 --- libavcodec/libaomenc.c | 51 -- 1

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-07 Thread James Almer
On 4/7/2020 2:55 PM, Paul B Mahol wrote: > On 4/7/20, Anton Khirnov wrote: >> Quoting Paul B Mahol (2020-04-07 16:29:23) >>> On 4/7/20, Anton Khirnov wrote: Quoting Paul B Mahol (2020-04-06 16:27:54) > On 4/6/20, James Almer wrote: >> On 4/6/2020 7:01 AM, Paul B Mahol wrote:

[FFmpeg-devel] [PATCH v3 2/2] libavcodec/libaomenc.c: Support lossless encoding

2020-04-07 Thread Ryo Hirafuji
From: Ryo Hirafuji AV1 support lossless encoding. In this patch, I added a command line flag to enable it. Fixes ticket #7600 --- libavcodec/libaomenc.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index

Re: [FFmpeg-devel] [PATCH] avcodec/ffwavesynth: Correct undefined overflow of PINK_UNIT

2020-04-07 Thread Nicolas George
James Almer (12020-04-07): > Can't you make PINK_UNIT 128UL or 128ULL? Or will that affect other > checks negatively? Elsewhere, it's used as index in a small array, that would be strange. Regards, -- Nicolas George signature.asc Description: PGP signature

[FFmpeg-devel] [PATCH v2 1/2] libavcodec/libaomenc.c: Support gray input

2020-04-07 Thread Ryo Hirafuji
From: Ryo Hirafuji AV1 decoders, libaomdec and libdav1d, both support grayscale image. However, libaomenc does not support it yet. In this patch, I add a grayscale image support also to libaomenc. --- libavcodec/libaomenc.c | 51 -- 1 file changed, 44

Re: [FFmpeg-devel] [PATCH] avcodec/ffwavesynth: Correct undefined overflow of PINK_UNIT

2020-04-07 Thread James Almer
On 1/17/2020 8:11 PM, Michael Niedermayer wrote: > Fixes: signed integer overflow: 9223372036854775775 + 128 cannot be > represented in type 'long' > Fixes: > 20054/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5686385113825280 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-07 Thread Paul B Mahol
On 4/7/20, Anton Khirnov wrote: > Quoting Paul B Mahol (2020-04-07 16:29:23) >> On 4/7/20, Anton Khirnov wrote: >> > Quoting Paul B Mahol (2020-04-06 16:27:54) >> >> On 4/6/20, James Almer wrote: >> >> > On 4/6/2020 7:01 AM, Paul B Mahol wrote: >> >> >> On 3/20/20, Paul B Mahol wrote: >> >>

Re: [FFmpeg-devel] avformat/libsrt: Change latency option to milliseconds

2020-04-07 Thread Nicolas George
pkv (12020-04-07): > you mean AV_OPT_TYPE_DURATION ? Exactly. > what's the reason for keeping these options in microseconds ? > > (to the extent the unit is documented it does not really matter, in truth; > it's just more convenient in ms). Some timings do require a better accuracy, more will

Re: [FFmpeg-devel] [PATCH] avcodec/ffwavesynth: Correct undefined overflow of PINK_UNIT

2020-04-07 Thread Nicolas George
Michael Niedermayer (12020-04-07): > will apply Sorry. No problem. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

[FFmpeg-devel] [PATCH] avformat/Makefile: Add missing rawenc dependency for iLBC muxer

2020-04-07 Thread Andreas Rheinhardt
Forgotten in ab502fab. Signed-off-by: Andreas Rheinhardt --- Sorry for this mistake in ab502fab. 054ce5f786f0bff2491bda5497850d2390621176 is not a real fix, because --disable-everything --enable-muxer=ilbc would still fail. libavformat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] avformat/libsrt: Change latency option to milliseconds

2020-04-07 Thread pkv
Le 07/04/2020 à 6:42 pm, Nicolas George a écrit : pkv (12020-04-07): The latency option (and related options) are currently in microseconds in FFmpeg (avformat/libsrt.c). The libsrt API documents them in milliseconds while FFmpeg doc does not specify any unit. This patch changes these options

Re: [FFmpeg-devel] [PATCH v1] avformat/dashenc: use av_asprintf()

2020-04-07 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/dashenc.c | 23 ++- > 1 file changed, 6 insertions(+), 17 deletions(-) > > diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c > index 94d4639..0c281a4 100644 > ---

Re: [FFmpeg-devel] [PATCH 7/8] avcodec/pcm_rechunk_bsf: add bitstream filter to rechunk pcm audio

2020-04-07 Thread Andreas Rheinhardt
Marton Balint: > Signed-off-by: Marton Balint > --- > Changelog | 1 + > doc/bitstream_filters.texi | 30 ++ > libavcodec/Makefile| 1 + > libavcodec/bitstream_filters.c | 1 + > libavcodec/pcm_rechunk_bsf.c | 206 >

[FFmpeg-devel] [PATCH v14] libavcodec/jpeg2000dec.c: Add support for PPT marker

2020-04-07 Thread gautamramk
From: Gautam Ramakrishnan This patch adds functional changes to support the PPT marker. This patch fixes bug ticket #4610. --- libavcodec/jpeg2000dec.c | 91 +++- 1 file changed, 80 insertions(+), 11 deletions(-) diff --git a/libavcodec/jpeg2000dec.c

Re: [FFmpeg-devel] [PATCH] avcodec/ffwavesynth: Correct undefined overflow of PINK_UNIT

2020-04-07 Thread Michael Niedermayer
On Sat, Jan 18, 2020 at 12:11:44AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 9223372036854775775 + 128 cannot be > represented in type 'long' > Fixes: > 20054/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5686385113825280 > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH 2/3] tools/target_dec_fuzzer: Adjust threshold for screenpresso

2020-04-07 Thread Michael Niedermayer
On Wed, Jan 29, 2020 at 10:55:28PM +0100, Michael Niedermayer wrote: > Fixes: Timeout (332 -> 21 sec) > Fixes: > 20280/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SCREENPRESSO_fuzzer-6238663432470528 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avcodec/xvididct: Fix integer overflow in MULT()

2020-04-07 Thread Michael Niedermayer
On Sat, Feb 01, 2020 at 01:12:03AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 23170 * 95058 cannot be represented in type > 'int' > Fixes: > 20295/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MJPEG_fuzzer-5800212870463488 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/flacdsp_template: Fix invalid shifts in decorrelate

2020-04-07 Thread Michael Niedermayer
On Sun, Feb 02, 2020 at 01:16:37AM +0100, Michael Niedermayer wrote: > Fixes: left shift of negative value -2 > Fixes: > 20303/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLAC_fuzzer-5096829297623040 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] avformat/libsrt: Change latency option to milliseconds

2020-04-07 Thread Nicolas George
pkv (12020-04-07): > The latency option (and related options) are currently in microseconds in > FFmpeg (avformat/libsrt.c). > The libsrt API documents them in milliseconds while FFmpeg doc does not > specify any unit. > This patch changes these options to milliseconds and updates the FFmpeg doc.

[FFmpeg-devel] [PATCH v1] avformat/dashenc: use av_asprintf()

2020-04-07 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/dashenc.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 94d4639..0c281a4 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c

[FFmpeg-devel] avformat/libsrt: Change latency option to milliseconds

2020-04-07 Thread pkv
Hi, The latency option (and related options) are currently in microseconds in FFmpeg (avformat/libsrt.c). The libsrt API documents them in milliseconds while FFmpeg doc does not specify any unit. This patch changes these options to milliseconds and updates the FFmpeg doc. The microsecond

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-07 Thread Anton Khirnov
Quoting Paul B Mahol (2020-04-07 16:29:23) > On 4/7/20, Anton Khirnov wrote: > > Quoting Paul B Mahol (2020-04-06 16:27:54) > >> On 4/6/20, James Almer wrote: > >> > On 4/6/2020 7:01 AM, Paul B Mahol wrote: > >> >> On 3/20/20, Paul B Mahol wrote: > >> >>> Signed-off-by: Paul B Mahol > >> >>>

[FFmpeg-devel] [PATCH 20/23] lavc/movtextenc: handle cancel overrides callback

2020-04-07 Thread John Stebbins
--- libavcodec/movtextenc.c | 43 - 1 file changed, 34 insertions(+), 9 deletions(-) diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c index 9e657c9635..2d3c416407 100644 --- a/libavcodec/movtextenc.c +++ b/libavcodec/movtextenc.c @@ -69,6

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-07 Thread Jean-Baptiste Kempf
On Tue, Apr 7, 2020, at 16:29, Paul B Mahol wrote: > If you are new dictator/leader of FFmpeg There is no dictator and there should not be one. If there was one leader, it would be Michael, because of his involvement and longevity in the project. He denied that role, which is why we're

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-07 Thread James Almer
On 4/7/2020 11:29 AM, Paul B Mahol wrote: > On 4/7/20, Anton Khirnov wrote: >> Quoting Paul B Mahol (2020-04-06 16:27:54) >>> On 4/6/20, James Almer wrote: On 4/6/2020 7:01 AM, Paul B Mahol wrote: > On 3/20/20, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >>

Re: [FFmpeg-devel] movtext decode/encode improvements

2020-04-07 Thread John Stebbins
On Mon, 2020-04-06 at 15:03 -0700, John Stebbins wrote: > On Mon, 2020-04-06 at 13:16 -0700, Philip Langdale wrote: > > On Mon, 6 Apr 2020 11:51:55 -0600 > > John Stebbins wrote: > > > > > Patch series adds more complete decoding and encoding of color, > > > alpha, > > > font size, font name,

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-07 Thread Paul B Mahol
On 4/7/20, Anton Khirnov wrote: > Quoting Paul B Mahol (2020-04-06 16:27:54) >> On 4/6/20, James Almer wrote: >> > On 4/6/2020 7:01 AM, Paul B Mahol wrote: >> >> On 3/20/20, Paul B Mahol wrote: >> >>> Signed-off-by: Paul B Mahol >> >>> --- >> >>> configure |1 + >> >>>

Re: [FFmpeg-devel] [PATCH v13] libavcodec/jpeg2000dec.c: Add support for PPT marker

2020-04-07 Thread Michael Niedermayer
On Tue, Apr 07, 2020 at 01:16:02AM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch adds functional changes to support the > PPT marker. This patch fixes bug ticket #4610. > --- > libavcodec/jpeg2000dec.c | 85 ++-- > 1 file

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-07 Thread Anton Khirnov
Quoting Paul B Mahol (2020-04-06 16:27:54) > On 4/6/20, James Almer wrote: > > On 4/6/2020 7:01 AM, Paul B Mahol wrote: > >> On 3/20/20, Paul B Mahol wrote: > >>> Signed-off-by: Paul B Mahol > >>> --- > >>> configure |1 + > >>> libavcodec/Makefile |1 + > >>>

Re: [FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Update context on double init

2020-04-07 Thread Paul B Mahol
On 4/7/20, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-04-06 15:15:17) >> On Mon, Apr 06, 2020 at 12:00:21PM +0200, Anton Khirnov wrote: >> > Quoting Michael Niedermayer (2020-04-05 00:38:41) >> > > Fixes: memleak >> > >> > Memleak of what/where/why? This is highly non-obvious. >> >>

Re: [FFmpeg-devel] [PATCH v3] avutil/frame: Use av_realloc_array()

2020-04-07 Thread Michael Niedermayer
On Thu, Dec 26, 2019 at 08:33:38AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavutil/frame.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/libavutil/frame.c b/libavutil/frame.c > index e403809..2e763ef

Re: [FFmpeg-devel] [PATCH]lavc/amrwb: Output silence for frames marked as broken

2020-04-07 Thread Anton Khirnov
Quoting Carl Eugen Hoyos (2020-04-06 15:32:43) > Am Mo., 6. Apr. 2020 um 10:42 Uhr schrieb Anton Khirnov : > > > > Quoting Carl Eugen Hoyos (2020-04-05 17:37:15) > > > Am So., 5. Apr. 2020 um 02:01 Uhr schrieb Carl Eugen Hoyos > > > : > > > > > > > Attached patch makes the output of the file in

Re: [FFmpeg-devel] [PATCH 10/14] h264_sei: use a separate reader for the individual SEI messages

2020-04-07 Thread James Almer
On 4/7/2020 10:57 AM, Anton Khirnov wrote: > Quoting James Almer (2020-03-27 16:08:11) >> On 3/27/2020 9:57 AM, Anton Khirnov wrote: >>> This tells the parsing functions the payload size and prevents them from >>> overreading. >>> --- >>> libavcodec/h264_sei.c | 33

Re: [FFmpeg-devel] [PATCH 10/14] h264_sei: use a separate reader for the individual SEI messages

2020-04-07 Thread Anton Khirnov
Quoting James Almer (2020-03-27 16:08:11) > On 3/27/2020 9:57 AM, Anton Khirnov wrote: > > This tells the parsing functions the payload size and prevents them from > > overreading. > > --- > > libavcodec/h264_sei.c | 33 +++-- > > 1 file changed, 19 insertions(+), 14

Re: [FFmpeg-devel] [PATCH 08/14] decode: plug leaks on error in update_frame_pool()

2020-04-07 Thread Anton Khirnov
Quoting James Almer (2020-03-27 16:03:46) > On 3/27/2020 9:57 AM, Anton Khirnov wrote: > > --- > > libavcodec/decode.c | 8 +--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > > index 8925ce6edc..f43dc0dd5d 100644 > > ---

Re: [FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Update context on double init

2020-04-07 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-04-06 15:15:17) > On Mon, Apr 06, 2020 at 12:00:21PM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2020-04-05 00:38:41) > > > Fixes: memleak > > > > Memleak of what/where/why? This is highly non-obvious. > > yes, i tend to be terse on "security"

Re: [FFmpeg-devel] [PATCH 1/5] avformat/smacker: Read extradata directly into extradata

2020-04-07 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The Smacker demuxer reads four consecutive 32bit values from the file > header into its demux context (as four uint32_t), converting it to > native endianness in the process and then writing these four values > later (after extradata has been allocated) to extradata as four

Re: [FFmpeg-devel] [PATCH 1/2] avformat/webmdashenc: Check codec types

2020-04-07 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> The WebM DASH Manifest muxer only supports VP8, VP9, Vorbis and Opus, >> but there was no check for this. The codec type is used to get a pointer >> to a string containing the codec name or NULL if it is not one of those >> four codecs. Said pointer has

Re: [FFmpeg-devel] [PATCH] avcodec/cbs: Avoid leaving the ... out in calls to variadic macros

2020-04-07 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> According to C99, there has to be at least one argument for every ... >> in a variadic function-like macro. In practice most (all?) compilers also >> allow to leave it completely out, but it is nevertheless required: In a >> variadic macro "there shall

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: prevent null pointer use on init_frames() failure

2020-04-07 Thread Peter Ross
Signed-off-by: Peter Ross Reviewed-by: James Almer --- libavcodec/vp9.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 7ee375d4d0..2e6cd912a5 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -1216,17 +1216,14 @@

[FFmpeg-devel] [PATCH] avcodec/vp3: fix indentation

2020-04-07 Thread Peter Ross
--- libavcodec/vp3.c | 68 1 file changed, 34 insertions(+), 34 deletions(-) some cosmetic changes for vp3/4 conditional blocks diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index 2ae54255c6..c9259abd03 100644 --- a/libavcodec/vp3.c +++

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

2020-04-07 Thread Paul B Mahol
On 4/7/20, Vittorio Giovara wrote: > On Sat, Dec 22, 2018 at 3:18 PM Paul B Mahol wrote: > >> On 12/22/18, Steinar H. Gunderson wrote: >> > On Sat, Dec 22, 2018 at 09:04:26PM +0100, Paul B Mahol wrote: >> >> I can not accept internal conversion to RGB. This is subsampled format >> >> after all.

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

2020-04-07 Thread Vittorio Giovara
On Sat, Dec 22, 2018 at 3:18 PM Paul B Mahol wrote: > On 12/22/18, Steinar H. Gunderson wrote: > > On Sat, Dec 22, 2018 at 09:04:26PM +0100, Paul B Mahol wrote: > >> I can not accept internal conversion to RGB. This is subsampled format > >> after all. > > > > Well, it's not Y'CbCr, so if so,

[FFmpeg-devel] [PATCH] avformat/aadec: Check toc_size to contain the minimum to demuxer uses

2020-04-07 Thread Michael Niedermayer
Fixes: out of array access Fixes: stack-buffer-overflow-READ-0x0831fff1 Found-by: GalyCannon Signed-off-by: Michael Niedermayer --- libavformat/aadec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/aadec.c b/libavformat/aadec.c index b9dd51ebfc..63f8176a57

[FFmpeg-devel] [PATCH v8 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-04-07 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/pp_bnk.c | 290 +++ libavformat/version.h| 2 +- 5 files changed, 294 insertions(+), 1 deletion(-)

[FFmpeg-devel] [PATCH v8 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-04-07 Thread Zane van Iperen
Adds support for the soundbank files used by the Pro Pinball series of games. Please CC for review. v8: - change "goto done" to a return + "goto fail" - Handle truncated files - Fix potential byte counter desync v7: - Fix empty lines - Use av_malloc_array() instead of

[FFmpeg-devel] [PATCH v8 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-04-07 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 33 + libavcodec/adpcm_data.c | 13 + libavcodec/adpcm_data.h | 2 ++ libavcodec/allcodecs.c

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-07 Thread Ross Nicholson
Hey Nicolas, Thanks for the review. I have incorporated your comments in the latest version. I have to get some users local to the problematic streams to do the testing, they are not available in my region. It has made it somewhat problematic to get this far ;) phunkyfish On Mon, 6 Apr 2020 at

[FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-07 Thread phunkyfish
--- libavformat/rtsp.c | 48 +- 1 file changed, 39 insertions(+), 9 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index cd6fc32a29..dad3f7915e 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -21,6 +21,7 @@ #include

Re: [FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Update context on double init

2020-04-07 Thread Nicolas George
Paul B Mahol (12020-04-07): > I rejected patch, because Lynee reported over IRC, which you > thankfully completely ignored, bug that stops playing files. Next time, save everybody some time and say it directly there. Politeness is not for everybody else but you. -- Nicolas George

Re: [FFmpeg-devel] [PATCH v7 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-04-07 Thread Zane van Iperen
On Mon, 6 Apr 2020 17:39:13 +0200 "Andreas Rheinhardt" wrote: > > +/* Parse and validate each track. */ > > +for (int i = 0; i < hdr.track_count; i++) { > > +PPBnkTrack e; > > + > > +if ((ret = avio_read(s->pb, buf, PP_BNK_TRACK_SIZE)) < 0) { > > +goto done; >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Update context on double init

2020-04-07 Thread Paul B Mahol
On 4/6/20, Michael Niedermayer wrote: > On Mon, Apr 06, 2020 at 12:00:21PM +0200, Anton Khirnov wrote: >> Quoting Michael Niedermayer (2020-04-05 00:38:41) >> > Fixes: memleak >> >> Memleak of what/where/why? This is highly non-obvious. > > yes, i tend to be terse on "security" fixes so as not to

[FFmpeg-devel] [PATCH v3] avformat/hlsenc: add hls_fmp4_init_resend option

2020-04-07 Thread Steven Liu
add option for resend init file after m3u8 refresh everytime. Signed-off-by: Steven Liu --- doc/muxers.texi | 3 +++ libavformat/hlsenc.c | 41 - 2 files changed, 39 insertions(+), 5 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: add hls_fmp4_init_resend option

2020-04-07 Thread Steven Liu
Ignore this patch please, I will submit v3 to modify all the refresh to resend. > 2020年4月7日 下午1:46,Steven Liu 写道: > > add option for resend init file after m3u8 refresh everytime. > > Signed-off-by: Steven Liu > --- > doc/muxers.texi | 3 +++ > libavformat/hlsenc.c | 41

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

2020-04-07 Thread Paul B Mahol
On 4/7/20, Carl Eugen Hoyos wrote: > Am Fr., 21. Dez. 2018 um 19:48 Uhr schrieb Paul B Mahol : >> >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/Makefile | 1 + >> libavcodec/allcodecs.c | 1 + >> libavcodec/avcodec.h| 1 + >> libavcodec/codec_desc.c | 7 + >>

Re: [FFmpeg-devel] ERROR: avisynth/avisynth_c.h not found

2020-04-07 Thread Ricardo Constantino
On Tue, 7 Apr 2020 at 09:42, Ricardo Constantino wrote: > > > On Mon, 6 Apr 2020 at 23:42, Helmut K. C. Tessarek > wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA512 >> >> >> On 2020-04-05 20:02, Marton Balint wrote: >> > The headers got removed because the ffmpeg source tree is no

Re: [FFmpeg-devel] ERROR: avisynth/avisynth_c.h not found

2020-04-07 Thread Ricardo Constantino
On Mon, 6 Apr 2020 at 23:42, Helmut K. C. Tessarek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > > On 2020-04-05 20:02, Marton Balint wrote: > > The headers got removed because the ffmpeg source tree is no place for > > third party library headers. > > I get that and it makes

  1   2   >