Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/mpeg12dec: switch to AVBufferRef buffer for a53 caption

2020-06-26 Thread Martin Storsjö
On Fri, 26 Jun 2020, Limin Wang wrote: ffmpeg | branch: master | Limin Wang | Sun Jun 21 20:57:22 2020 +0800| [a705bcd763e344fac191e157ffeddc285388b7fa] | committer: Limin Wang avcodec/mpeg12dec: switch to AVBufferRef buffer for a53 caption Signed-off-by: Limin Wang http://git.videolan.o

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/jpeg2000dec.c: Remove log2_chroma check in pixel format selection

2020-06-26 Thread Gautam Ramakrishnan
On Sat, Jun 27, 2020 at 5:04 AM Michael Niedermayer wrote: > > On Mon, Jun 22, 2020 at 12:12:08AM +0530, gautamr...@gmail.com wrote: > > From: Gautam Ramakrishnan > > > > The log2_chroma_wh is derived from the sample separations of the > > codestream if the file is a j2k codestream. Not sure if s

[FFmpeg-devel] [PATCH 1/2] avformat/isom: update mov_mdhd_language_map

2020-06-26 Thread Zhao Zhili
This is a map from 'Macintosh Language Codes' to 'ISO639-2/T'. Some items in the map are ISO639-2/B, some are ISO639-1. German: ger => deu Dutch: dut = nld Swedish: sve => swe Icelandic: ice => isl Croatian: hr => hrv Chinese: chi => zho Faroese: fo => fao Farsi/Persian: "" => fas Flemish: "" => n

[FFmpeg-devel] [PATCH 2/2] avformat/isom: move some condition checks outside of loop

2020-06-26 Thread Zhao Zhili
--- libavformat/isom.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavformat/isom.c b/libavformat/isom.c index e34d3f2195..bddcd6364f 100644 --- a/libavformat/isom.c +++ b/libavformat/isom.c @@ -430,9 +430,11 @@ int ff_mov_iso639_to_lang(const char lang[4], int mp

Re: [FFmpeg-devel] [PATCH] avfilter/vf_showinfo: add a \n for end of ERROR and WARNNING log

2020-06-26 Thread lance . lmwang
On Fri, Jun 26, 2020 at 03:39:49PM +0200, Paul B Mahol wrote: > lgtm Thank for review, will apply. > > On 6/26/20, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Note for info level, one extra \n will be print after the log. > > > > Signed-off-by: Limin Wang > > --- > > libavfilt

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/jpeg2000dec.c: Remove log2_chroma check in pixel format selection

2020-06-26 Thread Michael Niedermayer
On Mon, Jun 22, 2020 at 12:12:08AM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > The log2_chroma_wh is derived from the sample separations of the > codestream if the file is a j2k codestream. Not sure if sample > separation is same is subsampling and whether using sample > se

Re: [FFmpeg-devel] [PATCH] avfilter: add v360_vulkan filter

2020-06-26 Thread Lynne
Jun 26, 2020, 19:05 by jamr...@gmail.com: > On 6/26/2020 1:58 PM, Paul B Mahol wrote: > >> On 6/26/20, James Almer wrote: >> >>> On 6/26/2020 1:13 PM, Paul B Mahol wrote: >>> On 6/26/20, Paul B Mahol wrote: > On 6/24/20, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol

[FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg.c: Add an option "multiple_output_final_stats"

2020-06-26 Thread Wang Cao
From: Wang Cao * "multiple_output_final_stats" is used to display stats for each output when ffmpeg completes processing. * Also refactor to add a new function to print verbose stats for input/output so that the behavior is same as before by default. Signed-off-by: Wang Cao --- doc/ffmpeg.te

[FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg.c: Use the streams from the first output in print_final_stats.

2020-06-26 Thread Wang Cao
From: Wang Cao It appears the initial intention was to print stats for the first output. Currently all output streams are aggregated for the final stats which is inconsistent with the "size" reported in print_report. For example, when two outputs are specified, output 0 has size of 100 kB and ou

Re: [FFmpeg-devel] [RFC PATCH 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-26 Thread Gautam Ramakrishnan
On Sat, Jun 27, 2020 at 2:20 AM Gautam Ramakrishnan wrote: > > On Sat, Jun 27, 2020 at 2:17 AM Carl Eugen Hoyos wrote: > > > > > > > > > Am 26.06.2020 um 21:37 schrieb gautamr...@gmail.com: > > > > > > +.long_name = NULL_IF_CONFIG_SMALL("AVFrame to AVPacket > > > passthrough"), > > > > T

Re: [FFmpeg-devel] [PATCH 2/2] Add VDPAU to list of supported formats

2020-06-26 Thread Philip Langdale
On Fri, 26 Jun 2020 12:43:29 +0530 ManojGuptaBonda wrote: > Added VDPAU to list of supported formats for HEVC10 and 12 bit formats > also added 42010 bit to surface_parameters and new VDP chroma formats > to VDPAUPixFmtMaps > > Add HEVC 420 10/12 Bit and 444 10/12 Bit support for VDPAU > > >

Re: [FFmpeg-devel] [RFC PATCH 2/2] ilibavformat/img2dec: Added pgx demuxer

2020-06-26 Thread Carl Eugen Hoyos
> Am 26.06.2020 um 21:37 schrieb gautamr...@gmail.com: > > This patch adds support to demux the pgx > file format. Ok except for the commit message (typo). Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/li

Re: [FFmpeg-devel] [RFC PATCH 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-26 Thread Gautam Ramakrishnan
On Sat, Jun 27, 2020 at 2:17 AM Carl Eugen Hoyos wrote: > > > > > Am 26.06.2020 um 21:37 schrieb gautamr...@gmail.com: > > > > +.long_name = NULL_IF_CONFIG_SMALL("AVFrame to AVPacket > > passthrough"), > > This seems wrong as long description for the “pgx (jpeg2000 test format)”. > Thanks

Re: [FFmpeg-devel] [RFC PATCH 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-26 Thread Carl Eugen Hoyos
> Am 26.06.2020 um 21:37 schrieb gautamr...@gmail.com: > > +.long_name = NULL_IF_CONFIG_SMALL("AVFrame to AVPacket passthrough"), This seems wrong as long description for the “pgx (jpeg2000 test format)”. Carl Eugen ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] [VDPAU] [PATCH 1/2] lavc/vdpau_hevc: add function to find exact vdp_profile for REXT

2020-06-26 Thread Philip Langdale
On Fri, 26 Jun 2020 17:47:32 +0300 Rémi Denis-Courmont wrote: > > Is this really supposed to be done with string matching in > libavcodec? That looks rather brittle to me. It's a fair statement, but, surprisingly, we don't have a profile enum. The profile calculator parses all the various contr

[FFmpeg-devel] [PATCH 2/3] avcodec/bitstream: Avoid allocation when creating VLC tables

2020-06-26 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/bitstream.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavcodec/bitstream.c b/libavcodec/bitstream.c index 53a2db7451..d379dbc0e8 100644 --- a/libavcodec/bitstream.c +++ b/libavcodec/bitstream.c @@ -285,7 +

[FFmpeg-devel] [PATCH 3/3] avcodec/smacker: Add FF_CODEC_CAP_INIT_CLEANUP

2020-06-26 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/smacker.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c index b4c463b4b9..9f054f071d 100644 --- a/libavcodec/smacker.c +++ b/libavcodec/smacker.c @@ -600,13 +600,11 @@ static av_co

[FFmpeg-devel] [PATCH 1/3] avcodec/bitstream: Don't check for undefined behaviour after it happened

2020-06-26 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/bitstream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/bitstream.c b/libavcodec/bitstream.c index be8a0f634d..53a2db7451 100644 --- a/libavcodec/bitstream.c +++ b/libavcodec/bitstream.c @@ -162,9 +162,9 @@ static

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mvdec: Fix integer overflow with billions of channels

2020-06-26 Thread Michael Niedermayer
On Tue, Jun 23, 2020 at 05:22:53AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: signed integer overflow: 1394614304 * 2 cannot be represented in > > type 'int' > > Fixes: > > 23491/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5697377020411904 > > > > Found-by: conti

Re: [FFmpeg-devel] [PATCH v4 1/6] avcodec/adpcm_ima_apm: support new extradata format

2020-06-26 Thread Michael Niedermayer
On Sat, Jun 20, 2020 at 10:59:14AM +, Zane van Iperen wrote: > Signed-off-by: Zane van Iperen > --- > libavcodec/adpcm.c | 17 - > 1 file changed, 12 insertions(+), 5 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0F

[FFmpeg-devel] [RFC PATCH 1/2] libavcodec/pgxdec: Add PGX decoder

2020-06-26 Thread gautamramk
From: Gautam Ramakrishnan This patch adds a pgx decoder. --- Changelog | 1 + doc/general.texi| 2 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 ++ libavcodec/codec_id.h | 1 + libavcodec/pgxdec.c | 184 ++

[FFmpeg-devel] [RFC PATCH 2/2] ilibavformat/img2dec: Added pgx demuxer

2020-06-26 Thread gautamramk
From: Gautam Ramakrishnan This patch adds support to demux the pgx file format. --- libavformat/allformats.c | 1 + libavformat/img2dec.c| 10 ++ libavformat/version.h| 2 +- 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/libavformat/allformats.c b/libavformat/a

Re: [FFmpeg-devel] [PATCH] avfilter: add v360_vulkan filter

2020-06-26 Thread James Almer
On 6/26/2020 4:16 PM, Lynne wrote: > Jun 26, 2020, 19:05 by jamr...@gmail.com: > >> On 6/26/2020 1:58 PM, Paul B Mahol wrote: >> >>> On 6/26/20, James Almer wrote: >>> On 6/26/2020 1:13 PM, Paul B Mahol wrote: > On 6/26/20, Paul B Mahol wrote: > >> On 6/24/20, Paul B Mahol

Re: [FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg: move filter/encoder PTS computation to a separate function.

2020-06-26 Thread Michael Niedermayer
On Thu, Jun 25, 2020 at 08:35:17PM +0200, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > fftools/ffmpeg.c | 45 +++-- > 1 file changed, 27 insertions(+), 18 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BA

Re: [FFmpeg-devel] [PATCH] avfilter: add v360_vulkan filter

2020-06-26 Thread James Almer
On 6/26/2020 1:58 PM, Paul B Mahol wrote: > On 6/26/20, James Almer wrote: >> On 6/26/2020 1:13 PM, Paul B Mahol wrote: >>> On 6/26/20, Paul B Mahol wrote: On 6/24/20, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > Please test it and reports benchmark results on non

Re: [FFmpeg-devel] [PATCH] avfilter: add v360_vulkan filter

2020-06-26 Thread Paul B Mahol
On 6/26/20, James Almer wrote: > On 6/26/2020 1:13 PM, Paul B Mahol wrote: >> On 6/26/20, Paul B Mahol wrote: >>> On 6/24/20, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- Please test it and reports benchmark results on non toyish GPUs. >>> >>> Please, I really need it! >>>

[FFmpeg-devel] FFMPEG convert keeping metadata

2020-06-26 Thread Luys8611
Hello devel Team. I'm luys and I need a help for ffmpeg converting. I have a .m4a file which has metadata such as speaker channel data. I need a command line to convert it to .wav file preserving all metadata. Or, it's also good that I can read those metadata by ffmpeg commend without converting.

Re: [FFmpeg-devel] [PATCH] avfilter: add v360_vulkan filter

2020-06-26 Thread James Almer
On 6/26/2020 1:13 PM, Paul B Mahol wrote: > On 6/26/20, Paul B Mahol wrote: >> On 6/24/20, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> --- >>> Please test it and reports benchmark results on non toyish GPUs. >> >> Please, I really need it! >> > > > Why nobody wants to help? > > Th

Re: [FFmpeg-devel] [PATCH] avfilter: add v360_vulkan filter

2020-06-26 Thread Paul B Mahol
On 6/26/20, Paul B Mahol wrote: > On 6/24/20, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> Please test it and reports benchmark results on non toyish GPUs. > > Please, I really need it! > Why nobody wants to help? This makes me really really sad. __

Re: [FFmpeg-devel] [PATCH v4 7/7] avcodec/nvenc: support for HEVC timecode passthrough

2020-06-26 Thread lance . lmwang
On Fri, Jun 26, 2020 at 03:11:39PM +0100, Josh de Kock wrote: > On 26/06/2020 15:03, lance.lmw...@gmail.com wrote: > > On Wed, Jun 24, 2020 at 09:43:20PM +0800, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > > > Reviewed-by: Timo Rothenpieler > > > Signed-off-by: Limin Wang > > >

Re: [FFmpeg-devel] [PATCH] libavcodec/pgx: Added pgx decoder

2020-06-26 Thread Gautam Ramakrishnan
On Fri, Jun 26, 2020 at 3:50 AM Carl Eugen Hoyos wrote: > > Am Do., 25. Juni 2020 um 09:23 Uhr schrieb Gautam Ramakrishnan > : > > > > On Thu, Jun 25, 2020 at 12:50 AM Carl Eugen Hoyos > > wrote: > > > > > +for (i = 0; i < 6; i++) { > > > > +if (header_start[i] != (char)bytestream2_g

Re: [FFmpeg-devel] [PATCH v3 6/6] avformat/hlsenc: simplify code to pass s directly

2020-06-26 Thread lance . lmwang
On Fri, Jun 26, 2020 at 04:03:58PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-06-26): > > will apply the patchset tomorrow if no objections. > > It was posted yesterday! > > @subheading Always wait long enough before pushing changes > Do NOT commit to code actively maintained by

Re: [FFmpeg-devel] [PATCH v4 7/7] avcodec/nvenc: support for HEVC timecode passthrough

2020-06-26 Thread Josh de Kock
On 26/06/2020 15:03, lance.lmw...@gmail.com wrote: On Wed, Jun 24, 2020 at 09:43:20PM +0800, lance.lmw...@gmail.com wrote: From: Limin Wang Reviewed-by: Timo Rothenpieler Signed-off-by: Limin Wang --- libavcodec/nvenc.c | 17 + libavcodec/nvenc.h | 1 + libavco

Re: [FFmpeg-devel] [PATCH v4 7/7] avcodec/nvenc: support for HEVC timecode passthrough

2020-06-26 Thread lance . lmwang
On Wed, Jun 24, 2020 at 09:43:20PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Reviewed-by: Timo Rothenpieler > Signed-off-by: Limin Wang > --- > libavcodec/nvenc.c | 17 + > libavcodec/nvenc.h | 1 + > libavcodec/nvenc_hevc.c | 1 + > 3 files change

Re: [FFmpeg-devel] [PATCH v3 6/6] avformat/hlsenc: simplify code to pass s directly

2020-06-26 Thread Nicolas George
lance.lmw...@gmail.com (12020-06-26): > will apply the patchset tomorrow if no objections. It was posted yesterday! @subheading Always wait long enough before pushing changes Do NOT commit to code actively maintained by others without permission. Send a patch to ffmpeg-devel. If no one answers wi

Re: [FFmpeg-devel] [PATCH v3 6/6] avformat/hlsenc: simplify code to pass s directly

2020-06-26 Thread lance . lmwang
On Thu, Jun 25, 2020 at 07:32:39AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Suggested-by: Nicolas George > Signed-off-by: Limin Wang > --- > libavformat/hlsenc.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavfo

[FFmpeg-devel] [PATCH] lavfi/vsrc_testsrc: switch to activate.

2020-06-26 Thread Nicolas George
Allow to set the EOF timestamp. Also: doc/filters/testsrc*: specify the rounding of the duration option. The changes in the ref files are right. For filter-fps-down, the graph is testsrc2=r=7:d=3.5,fps=3. 3.5=24.5/7, so the EOF of testsrc2 will have PTS 25/7. 25/7=(10+5/7)/3, so the EOF PTS for

Re: [FFmpeg-devel] [PATCH] ffprobe: Add option to allow unknown format private AVOptions

2020-06-26 Thread Nicolas George
Derek Buitenhuis (12020-06-26): > This useful, because by ffprobe's very nature, you use it to probe > a file and find out what it is. Requiring every format private option > to be known to the demuxer forces one to run ffprobe twice, if one > wants to use ffprobe in a generic way. > > For example

[FFmpeg-devel] [PATCH] ffprobe: Add option to allow unknown format private AVOptions

2020-06-26 Thread Derek Buitenhuis
This useful, because by ffprobe's very nature, you use it to probe a file and find out what it is. Requiring every format private option to be known to the demuxer forces one to run ffprobe twice, if one wants to use ffprobe in a generic way. For example, say one wants to probe all user-uploaded f

Re: [FFmpeg-devel] [PATCH] avfilter/vf_showinfo: add a \n for end of ERROR and WARNNING log

2020-06-26 Thread Paul B Mahol
lgtm On 6/26/20, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Note for info level, one extra \n will be print after the log. > > Signed-off-by: Limin Wang > --- > libavfilter/vf_showinfo.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/libavfi

[FFmpeg-devel] [PATCH] avfilter/vf_showinfo: add a \n for end of ERROR and WARNNING log

2020-06-26 Thread lance . lmwang
From: Limin Wang Note for info level, one extra \n will be print after the log. Signed-off-by: Limin Wang --- libavfilter/vf_showinfo.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 5315f8f..d7ee

[FFmpeg-devel] [PATCH v2 3/4] avcodec/dvbsubdec: Cosmetics

2020-06-26 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/dvbsubdec.c | 94 +- 1 file changed, 47 insertions(+), 47 deletions(-) diff --git a/libavcodec/dvbsubdec.c b/libavcodec/dvbsubdec.c index 263ba59..eea920f 100644 --- a/libavcodec/dvbsubdec

Re: [FFmpeg-devel] [PATCH 4/6] avutil/bprint: use AV_BPRINT_SIZE_AUTOMATIC instead of 1

2020-06-26 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Friday, June 26, 2020 12:47 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 4/6] avutil/bprint: use > AV_BPRINT_SIZE_AUTOMATIC instead of 1 > > Sof

[FFmpeg-devel] [PATCH v2] lavf/movenc: Use a dynamic buffer when writing the mfra box

2020-06-26 Thread Derek Buitenhuis
When doing streamed output, with e.g. +dash, if the mfra box ended up being larger than the AVIOContext write buffer, the (unchecked) seeking back to update the box size would silently fail and produce an invalid mfra box. This is similar to how other boxes are written in fragmented mode. Signed-

Re: [FFmpeg-devel] [PATCH 06/17] avformat/smoothstreaming: Add deinit function

2020-06-26 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> Signed-off-by: Andreas Rheinhardt >> --- >> libavformat/smoothstreamingenc.c | 43 >> 1 file changed, 16 insertions(+), 27 deletions(-) >> >> diff --git a/libavformat/smoothstreamingenc.c >> b/libavformat/smoothstreami

Re: [FFmpeg-devel] [PATCH v2] avformat/smoothstreaming: Don't write trailer of subcontext

2020-06-26 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Nothing written in avformat_write_trailer() for the submuxers will be > output anyway because the AVIOContexts used for actual output have been > closed before the call. Writing the trailer of the subcontext has probably > only been done in order to free the memory allocated b

Re: [FFmpeg-devel] [PATCH v13 2/3] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

2020-06-26 Thread lance . lmwang
On Fri, Jun 26, 2020 at 12:50:40PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-06-26): > > Yes, It make sense. Now there are ERROR, INFO, WARNING. Can we change all > > of the > > to INFO? If can't, then we'll had to remove the end \n and add for every > > case. > > Absolutely n

Re: [FFmpeg-devel] [PATCH 4/6] avutil/bprint: use AV_BPRINT_SIZE_AUTOMATIC instead of 1

2020-06-26 Thread lance . lmwang
On Fri, Jun 26, 2020 at 12:41:19PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-06-26): > > Sorry, I'm not clear why not to use 1 directly as it's public API? > > That is exactly what I am telling: leave it. thanks for comments, please ignore the change then. > > Regards, > > -

Re: [FFmpeg-devel] [PATCH v13 2/3] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

2020-06-26 Thread Nicolas George
lance.lmw...@gmail.com (12020-06-26): > Yes, It make sense. Now there are ERROR, INFO, WARNING. Can we change all of > the > to INFO? If can't, then we'll had to remove the end \n and add for every case. Absolutely not. ERRORs need to be visible even if INFO is hidden. Personally, I consider tha

Re: [FFmpeg-devel] [PATCH v13 2/3] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

2020-06-26 Thread lance . lmwang
On Fri, Jun 26, 2020 at 12:34:35PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-06-26): > > Yes, I have double checked the code. > > Not enouth. A \n at level INFO cannot end a line at level ERROR. > > > Yes, I have followed the same error process style like other metadtata > > e

Re: [FFmpeg-devel] [PATCH 4/6] avutil/bprint: use AV_BPRINT_SIZE_AUTOMATIC instead of 1

2020-06-26 Thread Nicolas George
Soft Works (12020-06-26): > Isn't it a clear benefit to have a named constant where the name > of the constant indicates a meaning while a plain number does not? No. If you know the API enough to use it properly, then the meaning of 1 is obvious. If you don't, the meaning of the constant is obscur

Re: [FFmpeg-devel] [PATCH 4/6] avutil/bprint: use AV_BPRINT_SIZE_AUTOMATIC instead of 1

2020-06-26 Thread Nicolas George
lance.lmw...@gmail.com (12020-06-26): > Sorry, I'm not clear why not to use 1 directly as it's public API? That is exactly what I am telling: leave it. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH 4/6] avutil/bprint: use AV_BPRINT_SIZE_AUTOMATIC instead of 1

2020-06-26 Thread lance . lmwang
On Fri, Jun 26, 2020 at 07:17:01AM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-06-26): > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavutil/bprint.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > No to gratuitous changes that pollute the

Re: [FFmpeg-devel] [PATCH v13 2/3] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

2020-06-26 Thread Nicolas George
lance.lmw...@gmail.com (12020-06-26): > Yes, I have double checked the code. Not enouth. A \n at level INFO cannot end a line at level ERROR. > Yes, I have followed the same error process style like other metadtata error > processing. Then the existing code is wrong too. Regards, -- Nicola

Re: [FFmpeg-devel] [PATCH v13 2/3] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

2020-06-26 Thread lance . lmwang
On Fri, Jun 26, 2020 at 11:55:33AM +0200, Moritz Barsnick wrote: > On Fri, Jun 26, 2020 at 17:31:36 +0800, lance.lmw...@gmail.com wrote: > > On Fri, Jun 26, 2020 at 11:15:15AM +0200, Moritz Barsnick wrote: > > > On Fri, Jun 12, 2020 at 07:54:28 +0800, lance.lmw...@gmail.com wrote: > > > > +if (

Re: [FFmpeg-devel] [PATCH v13 2/3] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

2020-06-26 Thread Moritz Barsnick
On Fri, Jun 26, 2020 at 17:31:36 +0800, lance.lmw...@gmail.com wrote: > On Fri, Jun 26, 2020 at 11:15:15AM +0200, Moritz Barsnick wrote: > > On Fri, Jun 12, 2020 at 07:54:28 +0800, lance.lmw...@gmail.com wrote: > > > +if (sd->size < uuid_size) { > > > +av_log(ctx, AV_LOG_ERROR, "invalid

Re: [FFmpeg-devel] [PATCH] lavu: make AV_TIME_BASE_Q work in C++ code

2020-06-26 Thread Hendrik Leppkes
On Fri, Jun 26, 2020 at 11:31 AM Tomas Härdin wrote: > > ons 2020-06-24 klockan 21:22 +0200 skrev Carl Eugen Hoyos: > > Am Mi., 24. Juni 2020 um 21:10 Uhr schrieb rcombs : > > > --- > > > libavutil/avutil.h | 4 > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/libavutil/avutil.

Re: [FFmpeg-devel] [PATCH v13 2/3] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

2020-06-26 Thread lance . lmwang
On Fri, Jun 26, 2020 at 11:15:15AM +0200, Moritz Barsnick wrote: > On Fri, Jun 12, 2020 at 07:54:28 +0800, lance.lmw...@gmail.com wrote: > > +if (sd->size < uuid_size) { > > +av_log(ctx, AV_LOG_ERROR, "invalid data(%d < UUID(%d-bytes))", > > sd->size, uuid_size); > > ... \n it didn't

Re: [FFmpeg-devel] [PATCH] lavu: make AV_TIME_BASE_Q work in C++ code

2020-06-26 Thread Tomas Härdin
ons 2020-06-24 klockan 21:22 +0200 skrev Carl Eugen Hoyos: > Am Mi., 24. Juni 2020 um 21:10 Uhr schrieb rcombs : > > --- > > libavutil/avutil.h | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/libavutil/avutil.h b/libavutil/avutil.h > > index 4d633156d1..c11b33f466 100644 > > --

Re: [FFmpeg-devel] [PATCH 2/2] avformat/avc, mxfenc: Avoid allocation of H264 SPS structure, fix memleak

2020-06-26 Thread Tomas Härdin
ons 2020-06-24 klockan 19:15 +0200 skrev Andreas Rheinhardt: > Up until now, ff_avc_decode_sps would parse a SPS and return some > properties from it in a freshly allocated structure. Yet said > structure > is very small and completely internal to libavformat, so there is no > reason to use the hea

Re: [FFmpeg-devel] [PATCH v13 2/3] avfilter/vf_showinfo: display H.26[45] user data unregistered sei message

2020-06-26 Thread Moritz Barsnick
On Fri, Jun 12, 2020 at 07:54:28 +0800, lance.lmw...@gmail.com wrote: > +if (sd->size < uuid_size) { > +av_log(ctx, AV_LOG_ERROR, "invalid data(%d < UUID(%d-bytes))", > sd->size, uuid_size); ... \n Moritz ___ ffmpeg-devel mailing list ffmpe

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/dvbsubdec: Cosmetics

2020-06-26 Thread lance . lmwang
On Fri, Jun 26, 2020 at 10:48:23AM +0200, Moritz Barsnick wrote: > On Fri, Jun 26, 2020 at 08:47:23 +0800, lance.lmw...@gmail.com wrote: > > region->depth = 1 << (((*buf++) >> 2) & 7); > > -if(region->depth<2 || region->depth>8){ > > +if (region->depth<2 || region->depth>8){ >

Re: [FFmpeg-devel] [PATCH 5/6] avformat/aviobuf: INT_MAX -> AV_BPRINT_SIZE_UNLIMITED

2020-06-26 Thread lance . lmwang
On Fri, Jun 26, 2020 at 05:16:03AM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/aviobuf.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/aviobuf.c b/libavfor

Re: [FFmpeg-devel] [PATCH] avfilter: add v360_vulkan filter

2020-06-26 Thread Paul B Mahol
On 6/24/20, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > Please test it and reports benchmark results on non toyish GPUs. Please, I really need it! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/f

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/dvbsubdec: Cosmetics

2020-06-26 Thread Moritz Barsnick
On Fri, Jun 26, 2020 at 08:47:23 +0800, lance.lmw...@gmail.com wrote: > region->depth = 1 << (((*buf++) >> 2) & 7); > -if(region->depth<2 || region->depth>8){ > +if (region->depth<2 || region->depth>8){ ^^ You might as well fix this as well

Re: [FFmpeg-devel] [VDPAU] [PATCH 1/2] lavc/vdpau_hevc: add function to find exact vdp_profile for REXT

2020-06-26 Thread Manoj Bonda
Thanks Philip, Updated the patch with #if gaurds and fixed the typo for AV_PIX_FMT_YUV422P10 Please review. Thanks, ManojGupta. > -Original Message- > From: VDPAU On Behalf Of Philip > Langdale > Sent: Thursday, June 25, 2020 11:43 PM > To: Manoj Bonda > Cc: vd...@lists.freedesktop.o

[FFmpeg-devel] [PATCH 1/2] lavc/vdpau_hevc: add function to find exact vdp_profile for REXT

2020-06-26 Thread ManojGuptaBonda
Add vdpau_parse_rext_profile and use profile constraint flags to determine the exact vdp_profile for HEVC_REXT. If profile mismatch is allowed, select Main profile by default. Add build object in Makefile for h265_profile_level dependency. --- libavcodec/Makefile | 2 +- libavcodec/vdpau_he

[FFmpeg-devel] [PATCH 2/2] Add VDPAU to list of supported formats

2020-06-26 Thread ManojGuptaBonda
Added VDPAU to list of supported formats for HEVC10 and 12 bit formats also added 42010 bit to surface_parameters and new VDP chroma formats to VDPAUPixFmtMaps Add HEVC 420 10/12 Bit and 444 10/12 Bit support for VDPAU YUV444P10 is defined as the 444 surface with 10bit valid data in LSBs but H/

[FFmpeg-devel] [PATCH 0/2] VDPAU HEVC 10/12 Bit Decode Support

2020-06-26 Thread ManojGuptaBonda
NVIDIA R450 driver added VDPAU support for HEVC 10/12 bit Decoding adding the same in ffmpeg. Updated version with #ifdef guards to continue compiling with older releases ManojGuptaBonda (2): lavc/vdpau_hevc: add function to find exact vdp_profile for REXT Add VDPAU to list of supported forma