On Mon, Feb 22, 2021, 15:32 Jan Ekström wrote:
> On Mon, Feb 22, 2021 at 3:19 PM Jan Ekström wrote:
> >
> > I've intentionally kept this initial version simple (no styling etc) to
> focus
> > on the basics. As this goes through review, additional features can be
> added
> > (I had initial PoC fo
> -Original Message-
> From: ffmpeg-devel On Behalf Of Reimar
> D?ffinger
> Sent: 2021年2月25日 16:22
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH V2 6/7]
> libavformat/smoothstreamingenc.c: fix build warning for
> [-Wformat-truncation=]
>
>
> > O
On Thu, 2021-02-25 at 19:05 +0800, Steven Liu wrote:
> Artem Galin 于2021年2月24日周三 下午11:46写道：
> >
> > Hello,
> >
> >
> >
> > Please find the proposal for the following two projects for GSoC this year.
> >
> > The FATE project had been proposed earlier already but I don't know why it
> > didn't
Lynne:
> Someone forgot to add `i` to the loop.
> Also, the format has a 16-char title that we don't currently
> check.
>
> Bytestream info from:
> https://github.com/dcherednik/atracdenc/blob/master/src/aea.cpp
>
> Patch attached
>
> @@ -61,12 +61,19 @@ static int aea_read_probe(const AVProbeD
Lynne:
> This allows to (re)mux Sony ATRAC1 files.
>
> Patch attached
>
> +#include "libavutil/intreadwrite.h"
> +#include "avformat.h"
> +#include "rawenc.h"
> +
> +#define AT1_SU_SIZE 212
> +
> +typedef struct AEAEncContext {
> +uint32_t frame_cnt;
> +} AEAEncContext;
> +
> +static int aea_
Incrementing pointer *ps once is faster than computing string[i] for each
time we need it.
Bug fix: For the remote possibility of a crazy-long comment section that
overflows int, this fix can also return a value larger than sizeof(int).
Signed-off-by: Jose Da Silva
---
libavcodec/xpmdec.c | 27
Incrementing pointer *pr once is faster than computing reject[j] for each
time we need it.
Signed-off-by: Jose Da Silva
---
libavcodec/xpmdec.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/libavcodec/xpmdec.c b/libavcodec/xpmdec.c
index 66a9a8008c..7b3d3a7ff5 10
Test string==0 once before looping. This avoids testing 'string!=0'
i times inside the for i loop, (plus more checks for comments).
Test reject==0 once before looping. This avoids testing 'reject!=0'
i*[strlen(reject)+1] times inside the for j loop string.
Signed-off-by: Jose Da Silva
---
libav
Search for 0 to 9 first as this is 10/16th of possible choices we want,
then search for lowercase 6/16th, or uppercase 6/16th possible choices.
This gives us a minor speed increase similar to xbmdec.c nibble search.
Some modern compilers complain if using "unsigned" without using "int".
Signed-of
On February 24, 2021 05:56:17 AM Moritz Barsnick wrote:
> On Mon, Feb 22, 2021 at 20:32:14 -0800, Jose Da Silva wrote:
> > -for (i = 0; string && string[i]; i++) {
> > +if (string == 0)
>
> "if (!string)" is the preferred style for pointers.
Works for me. Updated patches reworked for toda
This allows to (re)mux Sony ATRAC1 files.
Patch attached
>From fd2c5b70c202fd11d48efc5ed4366093351eb0de Mon Sep 17 00:00:00 2001
From: Lynne
Date: Fri, 26 Feb 2021 06:25:41 +0100
Subject: [PATCH 2/2] aeaenc: add an aea muxer
This allows to (re)mux Sony ATRAC1 files.
---
libavformat/Makefile
Someone forgot to add `i` to the loop.
Also, the format has a 16-char title that we don't currently
check.
Bytestream info from:
https://github.com/dcherednik/atracdenc/blob/master/src/aea.cpp
Patch attached
>From b72c6ead223b393a3a117bd85d41832b2edbb504 Mon Sep 17 00:00:00 2001
From: Lynne
Da
This commit adds sse3 and avx assembly optimizations for 4-point and
8-point transforms only.
The code to recombine them into higher-level transforms is non-functional
currently, so it's not included here. This is just to get some feedback
on possible optimizations.
The 4-point assembly is based
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/matroskadec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
> index 75f72d330c..3879a54af5 100644
> --- a/libavformat/matroskadec.c
> +++ b
Michael Niedermayer:
> On Wed, Feb 24, 2021 at 03:23:40PM +0100, Anton Khirnov wrote:
>> Quoting Michael Niedermayer (2021-02-15 21:31:23)
>>> Fixes: OOM
>>> Fixes:
>>> 27780/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-5097985075314688
>>>
>>> Found-by: continuous fuzzing process
>>>
Andreas Rheinhardt:
> Up until now, the wav muxer used a reallocation of the form ptr =
> av_realloc(ptr, size); that leaks upon error. Furthermore, if a
> failed reallocation happened when writing the trailer, a segfault
> would occur due to avio_write(NULL, size) because the muxer only
> prints a
On Wed, Feb 24, 2021 at 03:23:40PM +0100, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2021-02-15 21:31:23)
> > Fixes: OOM
> > Fixes:
> > 27780/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-5097985075314688
> >
> > Found-by: continuous fuzzing process
> > https://github.com/goo
AVFrame hasn't been a struct defined in libavcodec for a decade now, when
it was moved to libavutil.
Found-by: mkver
Signed-off-by: James Almer
---
libavcodec/avcodec.h | 8
libavcodec/options.c | 2 ++
libavcodec/version.h | 3 +++
3 files changed, 9 insertions(+), 4 deletions(-)
diff
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Artem Galin
> Sent: Tuesday, November 3, 2020 7:46 PM
> To: ffmpeg-devel@ffmpeg.org
> Cc: Artem Galin
> Subject: [FFmpeg-devel] [PATCH v7 3/8] libavutil/hwcontext_qsv: enabling
> d3d11va usage by default, add usage child_device_ty
On Mon, Feb 22, 2021 at 05:56:31PM +0100, Paul B Mahol wrote:
> lgtm
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is al
On 2/25/2021 1:35 PM, Andreas Rheinhardt wrote:
Only lavfutils.c needs avformat.h, not lavfutils.h.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/lavfutils.c | 1 +
libavfilter/lavfutils.h | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavfilter/lavfutils.c b/l
On 2/24/2021 10:38 PM, Guo, Yejun wrote:
Here is the warning message:
src/libavdevice/v4l2.c: In function ‘v4l2_get_device_list’:
src/libavdevice/v4l2.c:1054:58: warning: ‘%s’ directive output may be truncated
writing up to 255 bytes into a region of size 251 [-Wformat-truncation=]
s
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Artem Galin
> Sent: Thursday, February 25, 2021 12:31 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] Proposal of two projects for GSoC
>
> On Wed, 24 Feb 2021 at 17:01, Soft Wo
On Thu, Feb 25, 2021 at 6:33 PM Andreas Rheinhardt <
andreas.rheinha...@gmail.com> wrote:
> 1582e306a47977b09fddb029b999f99eb03cd485 slated it for removal with
>
typo, 'slated'.
probably ok
libavformat major version 58, but it was never removed.
>
> Signed-off-by: Andreas Rheinhardt
> ---
>
1582e306a47977b09fddb029b999f99eb03cd485 slated it for removal with
libavformat major version 58, but it was never removed.
Signed-off-by: Andreas Rheinhardt
---
libavformat/avlanguage.c | 7 ---
libavformat/avlanguage.h | 7 ---
2 files changed, 14 deletions(-)
diff --git a/libavformat
On 21/02/2021 21:02, Moritz Barsnick wrote:
>> +@item global_palette @var{integer}
>> +Writes a palette to the global GIF header whee feasible.
> ^ where
>
Fixed and pushed the set (+1 other small fix).
- Derek
___
Only lavfutils.c needs avformat.h, not lavfutils.h.
Signed-off-by: Andreas Rheinhardt
---
libavfilter/lavfutils.c | 1 +
libavfilter/lavfutils.h | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavfilter/lavfutils.c b/libavfilter/lavfutils.c
index f8f8415c80..34051ee61d 1
On 2/25/2021 1:27 PM, Andreas Rheinhardt wrote:
The whole old next API has been deprecated in commit
7e8eba2d8755962d9dca5eade57bf8f591a73c0c, yet deprecating the next
pointer has been forgotten (the next pointers of other structures are
below the public API delimiter, but such a delimiter doesn'
The whole old next API has been deprecated in commit
7e8eba2d8755962d9dca5eade57bf8f591a73c0c, yet deprecating the next
pointer has been forgotten (the next pointers of other structures are
below the public API delimiter, but such a delimiter doesn't exist for
AVCodecParser).
Signed-off-by: Andrea
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Artem Galin
> Sent: Thursday, February 25, 2021 12:34 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v7 8/8] libavfilter/vf_deinterlace_qsv:
> enabling d3d11va support, a
James Almer:
> On 2/25/2021 11:44 AM, Andreas Rheinhardt wrote:
>> James Almer:
>>> On 2/24/2021 9:31 PM, Andreas Rheinhardt wrote:
James Almer:
> On 2/24/2021 11:22 AM, Andreas Rheinhardt wrote:
>> avfilter_transform, avfilter_(add|sub|mult)_matrix are not part of
>> the
>> pu
On 2/25/2021 11:44 AM, Andreas Rheinhardt wrote:
James Almer:
On 2/24/2021 9:31 PM, Andreas Rheinhardt wrote:
James Almer:
On 2/24/2021 11:22 AM, Andreas Rheinhardt wrote:
avfilter_transform, avfilter_(add|sub|mult)_matrix are not part of the
public API (transform.h is not a public header), y
James Almer:
> On 2/24/2021 9:31 PM, Andreas Rheinhardt wrote:
>> James Almer:
>>> On 2/24/2021 11:22 AM, Andreas Rheinhardt wrote:
avfilter_transform, avfilter_(add|sub|mult)_matrix are not part of the
public API (transform.h is not a public header), yet they are currently
exported
lgtm
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
On 2/24/2021 9:31 PM, Andreas Rheinhardt wrote:
James Almer:
On 2/24/2021 11:22 AM, Andreas Rheinhardt wrote:
avfilter_transform, avfilter_(add|sub|mult)_matrix are not part of the
public API (transform.h is not a public header), yet they are currently
exported because of their name. This commi
On 2/25/2021 11:05 AM, Andreas Rheinhardt wrote:
The whole old next API has been deprecated in commit
7e8eba2d8755962d9dca5eade57bf8f591a73c0c, yet deprecating the next
pointer has been forgotten (the next pointers of other structures are
below the public API delimiter, but such a delimiter doesn
The whole old next API has been deprecated in commit
7e8eba2d8755962d9dca5eade57bf8f591a73c0c, yet deprecating the next
pointer has been forgotten (the next pointers of other structures are
below the public API delimiter, but such a delimiter doesn't exist for
AVCodecParser).
Signed-off-by: Andrea
The obstacle to do so was in filter_codec_opts: It uses searches
the AVCodec for options via the AV_OPT_SEARCH_FAKE_OBJ method, which
requires using a void * that points to a pointer to a const AVClass.
When using const AVCodec *, one can not simply use a pointer that points
to the AVCodec's pointe
x264 versions >= 153 can support multiple bitdepths; they also don't
export x264_bit_depth any more. The actual check whether a bitdepth
is supported is therefore performed at runtime in x264_encoder_open.
Ergo it is unnecessary to use init_static_data for these versions:
One can already set ff_lib
Signed-off-by: Andreas Rheinhardt
---
The actual aim is of course to remove a nonconst AVCodec.
libavformat/wavenc.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/libavformat/wavenc.c b/libavformat/wavenc.c
index b65b8b0940..078b7fcd9a 100644
--- a/libavform
On Thu, Feb 25, 2021 at 12:47 PM Nicolas George wrote:
> Werner Robitza (12021-02-25):
> > After fiddling around a bit, when I run:
> >
> > ffprobe -loglevel error -f lavfi -i "testsrc,signalstats"
> > -show_entries tags -of csv=nk=0 | head -n 1
> >
> > I get a line like:
> >
> > packet,tag:lavfi.
Werner Robitza (12021-02-25):
> Would you accept this patch if this particular function was extracted
> to an API and re-used by ffprobe? (And potentially segment.c …)
Yes, but I must warn you that the constraints on a libavutil API are
stronger than the constraints on helper functions in ffprobe.
Werner Robitza (12021-02-25):
> After fiddling around a bit, when I run:
>
> ffprobe -loglevel error -f lavfi -i "testsrc,signalstats"
> -show_entries tags -of csv=nk=0 | head -n 1
>
> I get a line like:
>
> packet,tag:lavfi.signalstats.YMIN=16,tag:lavfi.signalstats.YLOW=16,…
I doubt ffprobe di
On Thu, Feb 25, 2021 at 11:26 AM Nicolas George wrote:
> Werner Robitza (12021-02-24):
> > I didn't really duplicate anything; this was mostly from scratch. The
> > case could be made that a function for escaping CSV could be shared.
>
> The variable names seemed quite similar. Anyway, duplicating
On Thu, Feb 25, 2021 at 11:25 AM Nicolas George wrote:
>
> Werner Robitza (12021-02-25):
> > If you are referring to:
> >
> > -vf your_filter,metadata=mode=print
> >
> > That does not work in ffprobe.
>
> Of course, since ffprobe does the printing for you.
At the risk of repeating the same questi
We have more and more users demanding a better output for the side
information generated by filters and other components than savage log
output.
That probably means moving the formatted writer features of ffprobe into
proper libavutil APIs. But ffprobe only outputs to standard output, a
proper API
On Wed, 24 Feb 2021 at 17:50, Soft Works wrote:
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Artem Galin
> > Sent: Tuesday, November 3, 2020 7:46 PM
> > To: ffmpeg-devel@ffmpeg.org
> > Cc: Artem Galin
> > Subject: [FFmpeg-devel] [PATCH v7 8/8] libavfilter/vf_deinte
On Wed, 24 Feb 2021 at 17:01, Soft Works wrote:
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Artem Galin
> > Sent: Wednesday, February 24, 2021 4:40 PM
> > To: FFmpeg development discussions and patches > de...@ffmpeg.org>
> > Subject: [FFmpeg-devel] Proposal of tw
Artem Galin 于2021年2月24日周三 下午11:46写道：
>
> Hello,
>
>
>
> Please find the proposal for the following two projects for GSoC this year.
>
> The FATE project had been proposed earlier already but I don't know why it
> didn't happen.
>
> I previously got the feedback from Thilo Borgmann and would be hap
Werner Robitza (12021-02-24):
> I didn't really duplicate anything; this was mostly from scratch. The
> case could be made that a function for escaping CSV could be shared.
The variable names seemed quite similar. Anyway, duplicating a feature
is just as bad as duplicating code.
> There are at le
Werner Robitza (12021-02-25):
> If you are referring to:
>
> -vf your_filter,metadata=mode=print
>
> That does not work in ffprobe.
Of course, since ffprobe does the printing for you.
> For instance, using the patch I submitted, I can get easy to parse output
> like:
Parsing the standard outp
Werner Robitza (12021-02-25):
> > This adds a new option to the metadata filter that allows outputting CSV
> > data.
> > The separator can be set via another option.
> > Special characters are handled via escaping.
>
> Fixed a newline bug and removed unused function.
Still duplicating code from
Andreas Rheinhardt (12021-02-25):
> And why? There was never a legitimate outside user of these functions.
I agree with that. Something that was not part of the API cannot be
considered part of the ABI. If some project use these functions, they
were explicitly cheating, and they knew it.
Regards,
On Thu, Feb 25, 2021 at 1:32 AM Paul B Mahol wrote:
> On Wed, Feb 24, 2021 at 9:48 PM Werner Robitza
> wrote:
>> Could please show an example on how to achieve this with ffprobe?
> See same thread where I replied or use search.
If you are referring to:
-vf your_filter,metadata=mode=print
That
On Thu, Feb 25, 2021 at 9:34 AM Werner Robitza wrote:
>
> This adds a new option to the metadata filter that allows outputting CSV data.
> The separator can be set via another option.
> Special characters are handled via escaping.
Fixed a newline bug and removed unused function.
_
This adds a new option to the metadata filter that allows outputting CSV data.
The separator can be set via another option.
Special characters are handled via escaping.
Signed-off-by: Werner Robitza
---
doc/filters.texi | 14
libavfilter/f_metadata.c | 155 +
> On 25 Feb 2021, at 07:38, Guo, Yejun wrote:
> --- a/libavformat/smoothstreamingenc.c
> +++ b/libavformat/smoothstreamingenc.c
> @@ -501,7 +501,7 @@ static int ism_flush(AVFormatContext *s, int final)
>
> for (i = 0; i < s->nb_streams; i++) {
> OutputStream *os = &c->streams[i];
> -
57 matches
Mail list logo
