Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: accelerate seeking while reading input at native frame rate

2021-07-17 Thread Gyan Doshi
On 2021-07-18 10:42, Linjie Fu wrote: Hi Gyan, On Sun, Jul 18, 2021 at 12:24 PM Gyan Doshi wrote: On 2021-07-18 09:32, Linjie Fu wrote: On Wed, Jul 7, 2021 at 9:42 AM Linjie Fu wrote: On Sun, Jul 4, 2021 at 10:50 PM Linjie Fu wrote: From: Linjie Fu Skip the logic of frame rate emula

Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: accelerate seeking while reading input at native frame rate

2021-07-17 Thread Linjie Fu
Hi Gyan, On Sun, Jul 18, 2021 at 12:24 PM Gyan Doshi wrote: > > > > On 2021-07-18 09:32, Linjie Fu wrote: > > On Wed, Jul 7, 2021 at 9:42 AM Linjie Fu wrote: > >> On Sun, Jul 4, 2021 at 10:50 PM Linjie Fu wrote: > >>> From: Linjie Fu > >>> > >>> Skip the logic of frame rate emulation until the

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix -t inaccurate recording time

2021-07-17 Thread Gyan Doshi
On 2021-07-17 15:10, Gyan Doshi wrote: On 2021-07-10 15:42, Gyan Doshi wrote: On 2021-07-09 11:03, Shiwang.Xie wrote: Pings. Will test. Fix confirmed. Will push tomorrow if no one objects. Pushed as 694545b6d5fff5a8242b5fab8c1746e74a06f9ba Gyan

Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: accelerate seeking while reading input at native frame rate

2021-07-17 Thread Gyan Doshi
On 2021-07-18 09:32, Linjie Fu wrote: On Wed, Jul 7, 2021 at 9:42 AM Linjie Fu wrote: On Sun, Jul 4, 2021 at 10:50 PM Linjie Fu wrote: From: Linjie Fu Skip the logic of frame rate emulation until the input reaches the specified start time. Test CMD: $ffmpeg -re -ss 30 -i input.mp4 -

Re: [FFmpeg-devel] [PATCH] avfilter: add QSV variants of the stack filters

2021-07-17 Thread Linjie Fu
Hi Haihao, On Wed, Jun 9, 2021 at 3:36 PM Haihao Xiang wrote: > > Include hstack_qsv, vstack_qsv and xstack_qsv, some code is copy and > pasted from other filters > > Example: > $> ffmpeg -hwaccel qsv -c:v hevc_qsv -i input.h265 -filter_complex > "[0:v][0:v]hstack_qsv" -f null - > --- > configur

Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: accelerate seeking while reading input at native frame rate

2021-07-17 Thread Linjie Fu
On Wed, Jul 7, 2021 at 9:42 AM Linjie Fu wrote: > > On Sun, Jul 4, 2021 at 10:50 PM Linjie Fu wrote: > > > > From: Linjie Fu > > > > Skip the logic of frame rate emulation until the input reaches the > > specified start time. > > > > Test CMD: > >$ffmpeg -re -ss 30 -i input.mp4 -pix_fmt yuv4

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: add a parser flag to enable keyframe tagging heuristics

2021-07-17 Thread Andreas Rheinhardt
James Almer: > On 7/17/2021 10:23 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 7/15/2021 5:23 PM, Michael Niedermayer wrote: the concept of a keyframe is a point at which decoding can begin that really are at least 3 points the point at which packets begin to be inp

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/h264_parser: use the keyframe heuristics flag

2021-07-17 Thread James Almer
On 7/17/2021 11:19 PM, Andreas Rheinhardt wrote: James Almer: On 7/17/2021 9:30 PM, Andreas Rheinhardt wrote: James Almer: Tag only packets containing with IDR pictures as keyframes by default, same as the decoder. Fixes MP4 and Matroska muxers marking incorrect samples as Sync Samples in scen

Re: [FFmpeg-devel] [PATCH] avformat/subtitles: Deduplicate subtitles' read_(packet|seek|close)

2021-07-17 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/assdec.c| 27 +++ > libavformat/jacosubdec.c| 29 - > libavformat/lrcdec.c| 27 +++ > libavformat/mccdec.c| 27 +++---

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: add a parser flag to enable keyframe tagging heuristics

2021-07-17 Thread James Almer
On 7/17/2021 10:23 PM, Andreas Rheinhardt wrote: James Almer: On 7/15/2021 5:23 PM, Michael Niedermayer wrote: the concept of a keyframe is a point at which decoding can begin that really are at least 3 points the point at which packets begin to be input into the decoder the point at which t

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/h264_parser: use the keyframe heuristics flag

2021-07-17 Thread Andreas Rheinhardt
James Almer: > On 7/17/2021 9:30 PM, Andreas Rheinhardt wrote: >> James Almer: >>> Tag only packets containing with IDR pictures as keyframes by >>> default, same as >>> the decoder. >>> Fixes MP4 and Matroska muxers marking incorrect samples as Sync >>> Samples in >>> scenarios where this AVParser

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/argo: use pixel format provided by the demuxer

2021-07-17 Thread Andreas Rheinhardt
Zane van Iperen: > But fall back to bits_per_raw_sample, in case we're with older > libavformat. > We are still in an open ABI phase, so you do not need to care about older libavformat. > Signed-off-by: Zane van Iperen > --- > libavcodec/argo.c| 21 ++--- > libavcodec/versi

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: add a parser flag to enable keyframe tagging heuristics

2021-07-17 Thread Andreas Rheinhardt
James Almer: > On 7/15/2021 5:23 PM, Michael Niedermayer wrote: >> >> the concept of a keyframe is a point at which decoding can begin >> that really are at least 3 points >> >> the point at which packets begin to be input into the decoder >> >> the point at which the decoder is able to return some

[FFmpeg-devel] [PATCH 8/8] avformat/pp_bnk: don't set bits_per_raw_sample

2021-07-17 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/pp_bnk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/pp_bnk.c b/libavformat/pp_bnk.c index dfe5343cde..821d14a4aa 100644 --- a/libavformat/pp_bnk.c +++ b/libavformat/pp_bnk.c @@ -214,7 +214,6 @@ static int pp_bnk_read_header(AVForm

[FFmpeg-devel] [PATCH 7/8] avformat/kvag: don't set bits_per_raw_sample

2021-07-17 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/kvag.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/kvag.c b/libavformat/kvag.c index 94dc1ddc04..b5ebe418e6 100644 --- a/libavformat/kvag.c +++ b/libavformat/kvag.c @@ -80,7 +80,6 @@ static int kvag_read_header(AVFormatContext *s)

[FFmpeg-devel] [PATCH 6/8] avformat/apm: don't set bits_per_raw_sample

2021-07-17 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/apm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/apm.c b/libavformat/apm.c index 6ae53b8712..6a047c5095 100644 --- a/libavformat/apm.c +++ b/libavformat/apm.c @@ -146,7 +146,6 @@ static int apm_read_header(AVFormatContext *s)

[FFmpeg-devel] [PATCH 5/8] avformat/alp: don't set bits_per_raw_sample

2021-07-17 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/alp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/alp.c b/libavformat/alp.c index bc19f02083..4876015f4b 100644 --- a/libavformat/alp.c +++ b/libavformat/alp.c @@ -127,7 +127,6 @@ static int alp_read_header(AVFormatContext *s)

[FFmpeg-devel] [PATCH 4/8] avformat/argo_asf: don't set bits_per_raw_sample

2021-07-17 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index c3ac49fdc2..ef647ae20c 100644 --- a/libavformat/argo_asf.c +++ b/libavformat/argo_asf.c @@ -109,12 +109,7 @@ in

[FFmpeg-devel] [PATCH 3/8] avformat/argo_cvg: don't set bits_per_raw_sample

2021-07-17 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_cvg.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/argo_cvg.c b/libavformat/argo_cvg.c index 73db777199..37288a1496 100644 --- a/libavformat/argo_cvg.c +++ b/libavformat/argo_cvg.c @@ -183,7 +183,6 @@ static int argo_cvg_read_h

[FFmpeg-devel] [PATCH 2/8] avformat/argo_brp: set pixel format directly

2021-07-17 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_brp.c | 11 ++- libavformat/version.h | 2 +- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/libavformat/argo_brp.c b/libavformat/argo_brp.c index 059418cd1d..6cc0c4a3f8 100644 --- a/libavformat/argo_brp.c +++ b/libavf

[FFmpeg-devel] [PATCH 1/8] avcodec/argo: use pixel format provided by the demuxer

2021-07-17 Thread Zane van Iperen
But fall back to bits_per_raw_sample, in case we're with older libavformat. Signed-off-by: Zane van Iperen --- libavcodec/argo.c| 21 ++--- libavcodec/version.h | 2 +- 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/libavcodec/argo.c b/libavcodec/argo.c inde

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/h264_parser: use the keyframe heuristics flag

2021-07-17 Thread James Almer
On 7/17/2021 9:30 PM, Andreas Rheinhardt wrote: James Almer: Tag only packets containing with IDR pictures as keyframes by default, same as the decoder. Fixes MP4 and Matroska muxers marking incorrect samples as Sync Samples in scenarios where this AVParser is used. 1. Could you please explai

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/h264_parser: use the keyframe heuristics flag

2021-07-17 Thread Andreas Rheinhardt
James Almer: > Tag only packets containing with IDR pictures as keyframes by default, same as > the decoder. > Fixes MP4 and Matroska muxers marking incorrect samples as Sync Samples in > scenarios where this AVParser is used. > 1. Could you please explain where you got the info that Matroska key

Re: [FFmpeg-devel] [PATCH] avformat/utils: remove AVStreamInternal.orig_codec_id

2021-07-17 Thread James Almer
On 7/17/2021 7:17 PM, Andreas Rheinhardt wrote: James Almer: It's a write only field. Signed-off-by: James Almer --- libavformat/internal.h | 2 -- libavformat/utils.c| 6 -- 2 files changed, 8 deletions(-) diff --git a/libavformat/internal.h b/libavformat/internal.h index 240de9e

Re: [FFmpeg-devel] [PATCH] avformat/utils: remove AVStreamInternal.orig_codec_id

2021-07-17 Thread Andreas Rheinhardt
James Almer: > It's a write only field. > > Signed-off-by: James Almer > --- > libavformat/internal.h | 2 -- > libavformat/utils.c| 6 -- > 2 files changed, 8 deletions(-) > > diff --git a/libavformat/internal.h b/libavformat/internal.h > index 240de9e289..4b7ab082e7 100644 > --- a/lib

[FFmpeg-devel] [PATCH] fftools/ffmpeg: Fix declaration-after-statement warning

2021-07-17 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- What is actually the reason that we stick to this C90 rule? Is it because of compability with ancient compilers? (Given that we already require several C99 features, I doubt that there are compilers which would fail if we stopped adhering to the declaration-be

Re: [FFmpeg-devel] [PATCH] mxfdec.c: fixed frame wrapping detection for MXFGCP1FrameWrappedPicture essence container

2021-07-17 Thread Pierre-Anthony Lemieux
You mean something like this? diff --git a/libavformat/mxf.h b/libavformat/mxf.h index ca510f5a2f..b9fe7fe7ef 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@ -76,7 +76,7 @@ typedef enum { D10D11Wrap, RawAWrap, RawVWrap, -AlwaysFrameWrap +J2KWrap } MXFWrappingIndic

Re: [FFmpeg-devel] [PATCH] avformat/utils: remove AVStreamInternal.orig_codec_id

2021-07-17 Thread Andreas Rheinhardt
James Almer: > It's a write only field. > > Signed-off-by: James Almer > --- > libavformat/internal.h | 2 -- > libavformat/utils.c| 6 -- > 2 files changed, 8 deletions(-) > > diff --git a/libavformat/internal.h b/libavformat/internal.h > index 240de9e289..4b7ab082e7 100644 > --- a/lib

Re: [FFmpeg-devel] [PATCH] fftools/cmdutils: Allow expressions for opt_cpucount()

2021-07-17 Thread James Almer
On 7/17/2021 2:22 PM, James Almer wrote: On 7/17/2021 1:21 PM, Michael Niedermayer wrote: This allows for example "-cpucount cpu/2" to use half the available CPUs Signed-off-by: Michael Niedermayer ---   fftools/cmdutils.c | 9 ++---   1 file changed, 6 insertions(+), 3 deletions(-) diff -

Re: [FFmpeg-devel] [PATCH] mxfdec.c: fixed frame wrapping detection for MXFGCP1FrameWrappedPicture essence container

2021-07-17 Thread Marton Balint
On Mon, 12 Jul 2021, Tomas Härdin wrote: sön 2021-07-11 klockan 09:47 -0700 skrev p...@sandflow.com: From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: For JPEG 2000 essence, the MXF input format module currently uses the value of byte 14 of the essence con

Re: [FFmpeg-devel] [PATCH] fftools/cmdutils: Allow expressions for opt_cpucount()

2021-07-17 Thread James Almer
On 7/17/2021 1:21 PM, Michael Niedermayer wrote: This allows for example "-cpucount cpu/2" to use half the available CPUs Signed-off-by: Michael Niedermayer --- fftools/cmdutils.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmduti

[FFmpeg-devel] [PATCH] fftools/cmdutils: Allow expressions for opt_cpucount()

2021-07-17 Thread Michael Niedermayer
This allows for example "-cpucount cpu/2" to use half the available CPUs Signed-off-by: Michael Niedermayer --- fftools/cmdutils.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 6e875104fd..a902354669 100644 --- a/fftool

Re: [FFmpeg-devel] [PATCH] cmdutils: simplify opt_cpucount()

2021-07-17 Thread Michael Niedermayer
On Fri, Jul 16, 2021 at 09:26:16PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > fftools/cmdutils.c | 27 +++ > 1 file changed, 7 insertions(+), 20 deletions(-) Posted an alternative patch which goes the opposit direction and make use of the features of t

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: add a parser flag to enable keyframe tagging heuristics

2021-07-17 Thread Michael Niedermayer
On Fri, Jul 16, 2021 at 03:43:39PM -0300, James Almer wrote: > On 7/16/2021 1:55 PM, Michael Niedermayer wrote: > > On Thu, Jul 15, 2021 at 05:55:51PM -0300, James Almer wrote: > > > On 7/15/2021 5:23 PM, Michael Niedermayer wrote: > > > > On Wed, Jul 14, 2021 at 11:33:59AM -0300, James Almer wrote

Re: [FFmpeg-devel] [PATCH v3 00/34] avdevice (mostly dshow) enhancements

2021-07-17 Thread Diederick C. Niehorster
On Wed, Jul 7, 2021 at 8:46 AM Diederick C. Niehorster wrote: > > On Tue, Jul 6, 2021 at 11:20 AM Diederick Niehorster > wrote: > > > > This patch series implements a series of features, mostly enhancing the > > dshow avdevice, but also adding new functionality to avformat. > > This whole patchs

Re: [FFmpeg-devel] [PATCH] ffmpeg: add option readrate

2021-07-17 Thread Gyan Doshi
On 2021-07-17 19:04, Gyan Doshi wrote: On 2021-07-17 18:16, Zhao Zhili wrote:  > >> On Jul 17, 2021, at 12:07 PM, Gyan Doshi wrote: >> >> On 2021-07-17 04:50, ffmpegandmahanstreamer@e.email wrote: >>> Put the fact that -re is equivalent to -readrate 1 in the >>> deprecated message so peop

Re: [FFmpeg-devel] [PATCH] ffmpeg: add option readrate

2021-07-17 Thread Gyan Doshi
On 2021-07-17 18:16, Zhao Zhili wrote: > >> On Jul 17, 2021, at 12:07 PM, Gyan Doshi wrote: >> >> On 2021-07-17 04:50, ffmpegandmahanstreamer@e.email wrote: >>> Put the fact that -re is equivalent to -readrate 1 in the >>> deprecated message so people know what to switch to. >> >> It's alr

[FFmpeg-devel] RV: [PATCH] addroi filter: Now it can be dynamically moved with zmq command

2021-07-17 Thread Miguel Ángel Torres Font
Hi all, I am updating this patch for the addroi filter to now include the ability to dynamically move the region of interest via message passing. Through the ZeroMQ library or similar, new regions of interest in a video that is in the process of being encoded can now be sent through the command

Re: [FFmpeg-devel] [PATCH] ffmpeg: add option readrate

2021-07-17 Thread Zhao Zhili
> On Jul 17, 2021, at 12:07 PM, Gyan Doshi wrote: > > On 2021-07-17 04:50, ffmpegandmahanstreamer@e.email wrote: >> Put the fact that -re is equivalent to -readrate 1 in the deprecated message >> so people know what to switch to. > > It's already in the docs for -re as well as the ffmpeg -h

[FFmpeg-devel] [PATCH] addroi filter: Now it can be dynamically moved with zmq command

2021-07-17 Thread Miguel Ángel Torres Font
0001-addroi-filter-Now-it-can-be-dynamically-moved-with-z.patch Description: 0001-addroi-filter-Now-it-can-be-dynamically-moved-with-z.patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsu

[FFmpeg-devel] [WIP] Event loop

2021-07-17 Thread Nicolas George
Hi. Some time ago, I started working on the project to update libavformat's protocols to run with a proper event loop, instead of the several half-assed event loops we have here and there in the code. I started by writing the documentation for the low-level API, making sure it is an API that (1)

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix -t inaccurate recording time

2021-07-17 Thread Gyan Doshi
On 2021-07-10 15:42, Gyan Doshi wrote: On 2021-07-09 11:03, Shiwang.Xie wrote: Pings. Will test. Fix confirmed. Will push tomorrow if no one objects. Regards, Gyan On Sat, 5 Jun 2021, Shiwang.Xie wrote: Ping. Thanks, Shiwang.Xie On Sat, 29 May 2021, Shiwang.Xie wrote: Hi, an

[FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Set bits_per_raw_sample for ARGO

2021-07-17 Thread Michael Niedermayer
This may improve coverage of argo Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index 3d06630e46..3963eb1d2a 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_d

Re: [FFmpeg-devel] [PATCH] lavfi/vf_v360: add missing 0.5 subpixel shift

2021-07-17 Thread Paul B Mahol
Hi, I'm unable to apply this patch, please send it via attachment to new mail in this same thread. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-d

Re: [FFmpeg-devel] [PATCH 6/7] tools/target_dec_fuzzer: Fuzz FF_DEBUG_*

2021-07-17 Thread Michael Niedermayer
On Fri, Feb 07, 2020 at 02:48:30PM +0100, Michael Niedermayer wrote: > This should increase coverage > > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 9 + > 1 file changed, 9 insertions(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BA

Re: [FFmpeg-devel] [PATCH 5/7] tools/target_dec_fuzzer: Fuzz AV_CODEC_FLAG2_EXPORT_MVS

2021-07-17 Thread Michael Niedermayer
On Fri, Feb 07, 2020 at 02:48:29PM +0100, Michael Niedermayer wrote: > This should increase coverage > > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 2 ++ > 1 file changed, 2 insertions(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF13361

Re: [FFmpeg-devel] [PATCH 4/7] tools/target_dec_fuzzer: Set extradata for the parser

2021-07-17 Thread Michael Niedermayer
On Fri, Feb 07, 2020 at 02:48:28PM +0100, Michael Niedermayer wrote: > This should improve coverage > > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 3 +++ > 1 file changed, 3 insertions(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF13361

Re: [FFmpeg-devel] [PATCH 1/7] tools/target_dec_fuzzer: Fuzz skip_frame

2021-07-17 Thread Michael Niedermayer
On Fri, Feb 07, 2020 at 02:48:25PM +0100, Michael Niedermayer wrote: > Should allow coverage of related code > > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 2 ++ > 1 file changed, 2 insertions(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730B

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/exr: Check uncompressed_size against max_pixels

2021-07-17 Thread Michael Niedermayer
On Sun, Jul 11, 2021 at 03:26:32PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 35286/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-6557139802914816 > Fixes: > 31253/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-4901782326214656 > > Found-by: contin