[FFmpeg-devel] [PATCH v2 01/10] configure: ensure --enable-libmfx uses libmfx 1.x

2021-08-16 Thread Haihao Xiang
Intel's oneVPL is a successor to MediaSDK, but removed some obsolete features of MediaSDK[1]. Some early versions of oneVPL still uses libmfx as library name[2], however some of obsolete features, including OPAQUE memory, multi-frame encode, user plugins and LA_EXT rate control mode etc, have been

[FFmpeg-devel] [PATCH v2 00/10] make QSV works with Intel's oneVPL

2021-08-16 Thread Haihao Xiang
The oneAPI Video Processing Library (oneVPL) is a single interface for encode, decode and video processing[1]. oneVPL is a successor to Intel's Media SDK (MediaSDK), but removed obsolete features. MediaSDK lifetime comes to an end now[2]. This patchset fixes compiler errors when building FFmpeg ag

[FFmpeg-devel] [PATCH v2 05/10] qsv: build audio related code when MFX_VERSION < 2.0

2021-08-16 Thread Haihao Xiang
Audio isn't supported for MFX_VERSION >= 2.0[1][2]. This is in preparation for oneVPL support [1]: https://spec.oneapi.io/versions/latest/elements/oneVPL/source/appendix/VPL_intel_media_sdk.html#msdk-full-name-feature-removals [2]: https://github.com/oneapi-src/oneVPL --- libavcodec/qsv.c |

[FFmpeg-devel] [PATCH v2 02/10] configure: fix the check for MFX_CODEC_VP9

2021-08-16 Thread Haihao Xiang
The data structures for VP9 in mfxvp9.h is wrapped by MFX_VERSION_NEXT, which means those data structures have never been used in a public release. Actually MFX_CODEC_VP9 and other VP9 stuffs is added in mfxstructures.h. In addition, mfxdefs.h is included in mfxvp9.h, so we may use the check in thi

[FFmpeg-devel] [PATCH v2 06/10] qsvenc: support multi-frame encode when MFX_VERSION < 2.0

2021-08-16 Thread Haihao Xiang
Multi-frame encode isn't supported for MFX_VERSION >= 2.0[1][2]. This is in preparation for oneVPL support [1]: https://spec.oneapi.io/versions/latest/elements/oneVPL/source/appendix/VPL_intel_media_sdk.html#msdk-full-name-feature-removals [2]: https://github.com/oneapi-src/oneVPL --- libavcodec

[FFmpeg-devel] [PATCH v2 03/10] qsv: remove mfx/ prefix from mfx headers

2021-08-16 Thread Haihao Xiang
The following Cflags has been added to libmfx.pc, so mfx/ prefix is no longer needed when including mfx headers in FFmpeg. Cflags: -I${includedir} -I${includedir}/mfx Some old versions of libmfx have the following Cflags in libmfx.pc Cflags: -I${includedir} We may add -I${includedir}/mfx to

[FFmpeg-devel] [PATCH v2 07/10] qsvenc: support MFX_RATECONTROL_LA_EXT when MFX_VERSION < 2.0

2021-08-16 Thread Haihao Xiang
MFX_RATECONTROL_LA_EXT isn't supported for MFX_VERSION >= 2.0[1][2]. This is in preparation for oneVPL support [1]: https://spec.oneapi.io/versions/latest/elements/oneVPL/source/appendix/VPL_intel_media_sdk.html#msdk-full-name-feature-removals [2]: https://github.com/oneapi-src/oneVPL --- libavc

[FFmpeg-devel] [PATCH v2 08/10] qsv: support OPAQUE memory when MFX_VERSION < 2.0

2021-08-16 Thread Haihao Xiang
OPAQUE memory isn't supported for MFX_VERSION >= 2.0[1][2]. This is in preparation for oneVPL support [1]: https://spec.oneapi.io/versions/latest/elements/oneVPL/source/appendix/VPL_intel_media_sdk.html#msdk-full-name-feature-removals [2]: https://github.com/oneapi-src/oneVPL --- libavcodec/qsv.

[FFmpeg-devel] [PATCH v2 09/10] qsv: use a new method to create mfx session when using the oneVPL SDK

2021-08-16 Thread Haihao Xiang
In oneVPL, MFXLoad() and MFXCreateSession() are required to create a workable mfx session[1] Add AccelerationMode config filter for D3D9 session (galinart) This is in preparation for oneVPL support [1] https://spec.oneapi.io/versions/latest/elements/oneVPL/source/programming_guide/VPL_prg_sessi

[FFmpeg-devel] [PATCH v2 10/10] configure: add --enable-libvpl option

2021-08-16 Thread Haihao Xiang
This allows user to build FFmpeg against Intel's oneVPL SDK. oneVPL 2.2 is the required minimum version when building Intel oneVPL SDK code. It will fail to run configure script if both libmfx and libvpl are enabled. --- configure | 26 -- 1 file changed, 20 insertions(+),

[FFmpeg-devel] [PATCH v2 04/10] qsv: load user plugin for MFX_VERSION < 2.0

2021-08-16 Thread Haihao Xiang
User plugin isn't supported for MFX_VERSION >= 2.0[1][2]. This is in preparation for oneVPL Support [1]: https://spec.oneapi.io/versions/latest/elements/oneVPL/source/appendix/VPL_intel_media_sdk.html#msdk-full-name-feature-removals [2]: https://github.com/oneapi-src/oneVPL --- libavcodec/qsv.c

Re: [FFmpeg-devel] [PATCH v1 2/2] avfilter/vf_subtitles: Added shift option for subtitles/ass filters.

2021-08-16 Thread Manolis Stamatogiannakis
Bumping this once more. On Thu, 22 Jul 2021 at 16:19, Gyan Doshi wrote: > > > On 2021-07-22 00:08, Manolis Stamatogiannakis wrote: > > Would it be possible to have a quick review for this patch? It is pretty > > straightforward. > > Will test within a few days. > > Regards, > Gyan > > > > > Plus

Re: [FFmpeg-devel] [PATCH] Handle AV_PIX_FMT_PAL8

2021-08-16 Thread myp...@gmail.com
The patch was broken On Sun, Aug 15, 2021 at 5:22 PM 一滴水 <229135...@qq.com> wrote: > > Signed-off-by: Ray <229135...@qq.com> > --- >  libavformat/riffenc.c | 9 - >  1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/libavformat/riffenc.c b/libavformat/riffenc.c > index 971c4a7

[FFmpeg-devel] [PATCH] support raw avi for raw PAL8 or Gray8 pixel data

2021-08-16 Thread rui.jiang
add palette data in avi header when the input data is raw PAL8 or Gray8 pixel data and the output data is 8bit raw avi video; Here is a sample: the codec params like: st->codecpar->bits_per_raw_sample=8; st->codecpar->bits_per_coded_sample=8; st->codecpar->format = AV_PIX_

[FFmpeg-devel] [PATCH 1/2] avformat/mxf: rename sub_descriptors as file_descriptors

2021-08-16 Thread Marc-Antoine Arnaud
--- libavformat/mxfdec.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 34cbd2cd77..c28549f6a9 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -203,8 +203,8 @@ typedef struct MXFDescri

[FFmpeg-devel] [PATCH 2/2] avformat/mxf: support MCA audio information

2021-08-16 Thread Marc-Antoine Arnaud
--- libavformat/mxf.h| 1 + libavformat/mxfdec.c | 363 ++- 2 files changed, 358 insertions(+), 6 deletions(-) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index fe9c52732c..cddbcb13c9 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@ -5

Re: [FFmpeg-devel] [PATCH] avfilter: add (a)segment filters

2021-08-16 Thread Nicolas George
Paul B Mahol (12021-08-10): > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 34 > libavfilter/Makefile | 2 + > libavfilter/allfilters.c | 2 + > libavfilter/f_segment.c | 335 +++ > 4 files changed, 373 insertions(+) > create m

Re: [FFmpeg-devel] [PATCH v2 1/5] libavfilter/x86/vf_gblur: add ff_postscale_slice_avx512()

2021-08-16 Thread Kieran Kunhya
On Mon, 16 Aug 2021, 02:26 Wu, Jianhua, wrote: > Paul B Mahol Wrote: > > will apply if nobody complains. > > Hi Paul, > > It seemed that there is no more objection to the patches. Is it able to > get to the next step? > Feel free to let me know if there is any other problem. > > Best regards. > J

Re: [FFmpeg-devel] [PATCH v2 1/5] libavfilter/x86/vf_gblur: add ff_postscale_slice_avx512()

2021-08-16 Thread Wu, Jianhua
Kieran Wrote: > Hi Jianhua, > > Can you make the avx512 code only be run for ice lake processors? > Hi Kieran, As I see the macro, EXTERNAL_AVX512, located in libavutil/cpu.h, only an EXTERNAL_AVX512 is used to check the state of AVX512, which did not district the Icelake-AVX512 or Skylake-AVX

Re: [FFmpeg-devel] [PATCH v2 1/5] libavfilter/x86/vf_gblur: add ff_postscale_slice_avx512()

2021-08-16 Thread Kieran Kunhya
> > Feel free to let me know if you have different perspectives or if I > neglected something. > Yes, but we don't want to use AVX512 on hardware that downclocks heavily. Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/ma

Re: [FFmpeg-devel] [PATCH v2 1/5] libavfilter/x86/vf_gblur: add ff_postscale_slice_avx512()

2021-08-16 Thread Wu, Jianhua
> > Yes, but we don't want to use AVX512 on hardware that downclocks heavily. > It's okay. Should I updated the configure file to let the IceLake-AVX512 to be the minimum baseline or add a new macro name AVX512ICL? Jianhua ___ ffmpeg-devel mailing l

[FFmpeg-devel] [PATCH 1/2] lavc/aarch64: move transpose_4x8H to neon.S

2021-08-16 Thread Mikhail Nitenko
transpose_4x8H was declared in vp9lpf_16bpp_neon, however this macro is not unique to vp9 and could be used elsewhere. Signed-off-by: Mikhail Nitenko --- libavcodec/aarch64/neon.S | 13 + libavcodec/aarch64/vp9lpf_16bpp_neon.S | 12 2 files changed, 13 inser

[FFmpeg-devel] [PATCH v2 2/2] lavc/aarch64: h264, add chroma loop filters for 10bit

2021-08-16 Thread Mikhail Nitenko
Benchmarks: A53 A72 h264_h_loop_filter_chroma422_10bpp_c: 277.5 114.2 h264_h_loop_filter_chroma422_10bpp_neon: 109.781.7 h264_h_loop_filter_chroma_10bpp_c: 165.075.5 h264_h_loop_filter_chrom

[FFmpeg-devel] [PATCH v2] lavc/aarch64: add pred functions for 10-bit

2021-08-16 Thread Mikhail Nitenko
Benchmarks:A53 A72 pred8x8_dc_10_c: 64.255.7 pred8x8_dc_10_neon:61.753.7 pred8x8_dc_128_10_c: 26.020.7 pred8x8_dc_128_10_neon:30.724.5 pred8x8_horizontal_10_c: 60.035.2 pred8x8_hori

Re: [FFmpeg-devel] [PATCH v2 1/5] libavfilter/x86/vf_gblur: add ff_postscale_slice_avx512()

2021-08-16 Thread James Almer
On 8/16/2021 6:27 AM, Wu, Jianhua wrote: Yes, but we don't want to use AVX512 on hardware that downclocks heavily. It's okay. Should I updated the configure file to let the IceLake-AVX512 to be the minimum baseline or add a new macro name AVX512ICL? Update the test in configure to look for

Re: [FFmpeg-devel] [PATCH] avfilter: add dewobble_opencl filter

2021-08-16 Thread Daniel Playfair Cal
Thanks for the feedback. On Sun Aug 15 14:11:27 EEST 2021 Lynne wrote: > > 15 Aug 2021, 11:13 by daniel.playfair.cal at gmail.com: > > > On Sun, Aug 15, 2021 at 6:18 PM Paul B Mahol wrote: > > > >> Non native filters can not be named like this. > > All library wrappers must be prefixed with 'lib

[FFmpeg-devel] [PATCH v4 0/2] TTML in MP4, part 1

2021-08-16 Thread Jan Ekström
To keep it simpler this first part includes only non-fragmented use cases if the built-in sample squashing is utilized. Contains the basic mapping code as well as the function that writes out the squashed documents. Works with both subtitle-only output as well as with other streams. In a separate

[FFmpeg-devel] [PATCH v4 1/2] avformat/ttml: split TTML paragraph based or not check into header

2021-08-16 Thread Jan Ekström
From: Jan Ekström This way it can be re-utilized in movenc. Signed-off-by: Jan Ekström --- libavformat/ttmlenc.c | 9 ++--- libavformat/ttmlenc.h | 39 +++ 2 files changed, 41 insertions(+), 7 deletions(-) create mode 100644 libavformat/ttmlenc.h diff

[FFmpeg-devel] [PATCH v4 2/2] avformat/movenc: add support for TTML muxing

2021-08-16 Thread Jan Ekström
From: Jan Ekström Includes basic support for both the ISMV ('dfxp') and MP4 ('stpp') methods. This initial version also foregoes fragmentation support in case the built-in sample squashing is to be utilized, as this eases the initial review. Additionally, add basic tests for both muxing modes in

Re: [FFmpeg-devel] [PATCH 02/23] avfilter/internal: Uninline ff_insert_(in|out)pad()

2021-08-16 Thread Nicolas George
Andreas Rheinhardt (12021-08-12): > These functions are not hot at all and future commits will make them > bigger. > > Signed-off-by: Andreas Rheinhardt > --- > I haven't found a caller that adds a pad somewhere else than the end > of the list, so the index parameter could be removed. Shall I do

Re: [FFmpeg-devel] [PATCH 03/23] avfilter/avfilter: Allow to free pads generically

2021-08-16 Thread Nicolas George
Andreas Rheinhardt (12021-08-12): > This can be enabled/disabled on a per-filter basis by setting > the new internal flags FF_FILTER_FLAG_FREE_(IN|OUT)PADS. > > Signed-off-by: Andreas Rheinhardt > --- > It would be possible to only free the names of non-static pads; > it could then be used with t

Re: [FFmpeg-devel] [PATCH 05/23] avfilter/af_amerge: Free inpads' names generically

2021-08-16 Thread Nicolas George
Andreas Rheinhardt (12021-08-12): > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/af_amerge.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) LGTM. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ff

Re: [FFmpeg-devel] [PATCH 10/23] avfilter/avf_concat: Free pads' names generically

2021-08-16 Thread Nicolas George
Andreas Rheinhardt (12021-08-12): > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/avf_concat.c | 14 +++--- > 1 file changed, 3 insertions(+), 11 deletions(-) LGTM. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 23/23] avfilter: Remove init_opaque callback

2021-08-16 Thread Nicolas George
Andreas Rheinhardt (12021-08-12): > The last init_opaque callback has been removed in commit > 07ffdedf784e86b88074d8d3e08e55752869562a; the opaque argument has been > always NULL since 0acf7e268b2f873379cd854b4d5aaba6f9c1f0b5. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/avfilter.c

[FFmpeg-devel] [PATCH v2] doc/git-howto: be more strict about commit message formatting.

2021-08-16 Thread Nicolas George
Explain the format of the first line: "context: summary". Add examples and explain bad practices. Make it a section, so that we can link to it. Signed-off-by: Nicolas George --- doc/git-howto.texi | 46 ++ 1 file changed, 38 insertions(+), 8 deletions(

[FFmpeg-devel] [PATCH] libavformat/riffenc: support raw avi for raw PAL8 or Gray8 pixel data

2021-08-16 Thread rui.jiang
add palette data in avi header when the input data is raw PAL8 or Gray8 pixel data and the output data is 8bit raw avi video; Signed-off-by: rui.jiang <229135...@qq.com> --- libavformat/riffenc.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavformat/riffenc.c

[FFmpeg-devel] [PATCH] dox/examples/encode_video: add explanations in comments.

2021-08-16 Thread Nicolas George
Signed-off-by: Nicolas George --- doc/examples/encode_video.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/doc/examples/encode_video.c b/doc/examples/encode_video.c index 908eb203d5..939ed68324 100644 --- a/doc/examples/encode_video.c +++ b/doc/exa

Re: [FFmpeg-devel] [PATCH v2] doc/git-howto: be more strict about commit message formatting.

2021-08-16 Thread Gyan Doshi
On 2021-08-16 06:28 pm, Nicolas George wrote: Explain the format of the first line: "context: summary". Add examples and explain bad practices. Make it a section, so that we can link to it. Signed-off-by: Nicolas George --- doc/git-howto.texi | 46 ++

Re: [FFmpeg-devel] [PATCH v2] doc/git-howto: be more strict about commit message formatting.

2021-08-16 Thread Nicolas George
Gyan Doshi (12021-08-16): > "Details can be added, when necessary, separated by an empty line. These > lines should not exceed 72 characters, except when containing code." Thanks, it is better. I have slightly amended it to: The first line must contain the context, a colon and a very short summar

Re: [FFmpeg-devel] [PATCH 02/23] avfilter/internal: Uninline ff_insert_(in|out)pad()

2021-08-16 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12021-08-12): >> These functions are not hot at all and future commits will make them >> bigger. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> I haven't found a caller that adds a pad somewhere else than the end >> of the list, so the index parameter could

Re: [FFmpeg-devel] [PATCH 02/23] avfilter/internal: Uninline ff_insert_(in|out)pad()

2021-08-16 Thread Nicolas George
Andreas Rheinhardt (12021-08-16): > insert_pad() has been made static in this patch; it is not declared in > any header any more. Therefore I moved the documentation together with > the function. Yes, but the documentation is not really for insert_pad(), it is just an internal function for the two

Re: [FFmpeg-devel] [PATCH v2] doc/git-howto: be more strict about commit message formatting.

2021-08-16 Thread Gyan Doshi
On 2021-08-16 06:50 pm, Nicolas George wrote: Gyan Doshi (12021-08-16): "Details can be added, when necessary, separated by an empty line. These lines should not exceed 72 characters, except when containing code." Thanks, it is better. I have slightly amended it to: The first line must cont

Re: [FFmpeg-devel] [PATCH] libavformat/riffenc: support raw avi for raw PAL8 or Gray8 pixel data

2021-08-16 Thread Ray
This is a my latest committed patch. Please ignore those similar mails I sent before. > 2021年8月16日 下午5:01,rui.jiang <229135...@qq.com> 写道: > > add palette data in avi header when the input data is raw PAL8 or Gray8 pixel > data and the output data is 8bit raw avi video; > > Signed-off-by: rui.

Re: [FFmpeg-devel] [PATCH 03/23] avfilter/avfilter: Allow to free pads generically

2021-08-16 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12021-08-12): >> This can be enabled/disabled on a per-filter basis by setting >> the new internal flags FF_FILTER_FLAG_FREE_(IN|OUT)PADS. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> It would be possible to only free the names of non-static pads; >> it c

Re: [FFmpeg-devel] [PATCH 02/23] avfilter/internal: Uninline ff_insert_(in|out)pad()

2021-08-16 Thread Andreas Rheinhardt
Nicolas George: > Andreas Rheinhardt (12021-08-16): >> insert_pad() has been made static in this patch; it is not declared in >> any header any more. Therefore I moved the documentation together with >> the function. > > Yes, but the documentation is not really for insert_pad(), it is just an > in

[FFmpeg-devel] [PATCH 1/4] avcodec/pthread_frame: also keep AVCodecContext.properties in sync between threads

2021-08-16 Thread James Almer
Some frame threaded decoders set it, but this information never reached the caller in frame threading scenarios. Signed-off-by: James Almer --- libavcodec/pthread_frame.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index 2ff71ca39e.

[FFmpeg-devel] [PATCH 2/4] avcodec: add a Film Grain codec property flag

2021-08-16 Thread James Almer
Signed-off-by: James Almer --- doc/APIchanges | 3 +++ fftools/ffprobe.c| 1 + libavcodec/avcodec.c | 2 ++ libavcodec/avcodec.h | 1 + libavcodec/version.h | 4 ++-- 5 files changed, 9 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 28cc0344ad..45272ac

[FFmpeg-devel] [PATCH 3/4] avcodec/libdav1d: signal the presence of Film Grain in the decoder context

2021-08-16 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libdav1d.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index 8a816da34d..2ee75310d7 100644 --- a/libavcodec/libdav1d.c +++ b/libavcodec/libdav1d.c @@ -157,6 +157,9 @@ static void libdav1d_init_param

[FFmpeg-devel] [PATCH 4/4] avcodec/av1: signal the presence of Film Grain in the decoder context

2021-08-16 Thread James Almer
Signed-off-by: James Almer --- libavcodec/av1dec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 1dda0f9160..139374f0a0 100644 --- a/libavcodec/av1dec.c +++ b/libavcodec/av1dec.c @@ -575,6 +575,9 @@ static int set_context_with_sequence(AVCo

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/libdav1d: signal the presence of Film Grain in the decoder context

2021-08-16 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavcodec/libdav1d.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c > index 8a816da34d..2ee75310d7 100644 > --- a/libavcodec/libdav1d.c > +++ b/libavcodec/libdav1d.c > @@ -157,6 +157,9 @

[FFmpeg-devel] [PATCH 3/4 v2] avcodec/libdav1d: signal the presence of Film Grain in the decoder context

2021-08-16 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libdav1d.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index 8a816da34d..51e0980f6e 100644 --- a/libavcodec/libdav1d.c +++ b/libavcodec/libdav1d.c @@ -157,6 +157,11 @@ static void libdav1d_init_pa

[FFmpeg-devel] [PATCH 4/4 v2] avcodec/av1: signal the presence of Film Grain in the decoder context

2021-08-16 Thread James Almer
Signed-off-by: James Almer --- libavcodec/av1dec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 1dda0f9160..a69808f7b6 100644 --- a/libavcodec/av1dec.c +++ b/libavcodec/av1dec.c @@ -575,6 +575,11 @@ static int set_context_with_sequence(A

Re: [FFmpeg-devel] [PATCH 4/4 v2] avcodec/av1: signal the presence of Film Grain in the decoder context

2021-08-16 Thread Lynne
16 Aug 2021, 18:24 by jamr...@gmail.com: > Signed-off-by: James Almer > --- > libavcodec/av1dec.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c > index 1dda0f9160..a69808f7b6 100644 > --- a/libavcodec/av1dec.c > +++ b/libavcodec/av1dec.c

Re: [FFmpeg-devel] [PATCH 4/4 v2] avcodec/av1: signal the presence of Film Grain in the decoder context

2021-08-16 Thread James Almer
On 8/16/2021 1:35 PM, Lynne wrote: 16 Aug 2021, 18:24 by jamr...@gmail.com: Signed-off-by: James Almer --- libavcodec/av1dec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 1dda0f9160..a69808f7b6 100644 --- a/libavcodec/av1dec.c +++

Re: [FFmpeg-devel] [PATCH 4/4 v2] avcodec/av1: signal the presence of Film Grain in the decoder context

2021-08-16 Thread James Almer
On 8/16/2021 1:45 PM, James Almer wrote: On 8/16/2021 1:35 PM, Lynne wrote: 16 Aug 2021, 18:24 by jamr...@gmail.com: Signed-off-by: James Almer ---   libavcodec/av1dec.c | 5 +   1 file changed, 5 insertions(+) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 1dda0f9160..a6980

Re: [FFmpeg-devel] [EXT] Re: [PATCH v3 1/3] avcodec/v4l2_context: don't reinit output queue when dynamic resolution change

2021-08-16 Thread Andriy Gelman
On Mon, 02. Aug 02:32, Ming Qian wrote: > > -Original Message- > > From: Andriy Gelman [mailto:andriy.gel...@gmail.com] > > Sent: Monday, August 2, 2021 7:36 AM > > To: FFmpeg development discussions and patches > > Cc: Ming Qian > > Subject: [EXT] Re: [FFmpeg-devel] [PATCH v3 1/3] avcode

[FFmpeg-devel] [PATCH 2/4 v2] avcodec: add a Film Grain codec property flag

2021-08-16 Thread James Almer
Signed-off-by: James Almer --- Added the missing ref updates doc/APIchanges | 3 +++ doc/ffprobe.xsd | 1 + fftools/ffprobe.c | 1 + libavcodec/avcodec.c| 2

Re: [FFmpeg-devel] [PATCH v3 3/3] avcodec/v4l2_m2m_dec: start capture after source change event is received

2021-08-16 Thread Andriy Gelman
On Thu, 29. Jul 14:00, Ming Qian wrote: > if client start the capture queue without waiting the source change > event, > there may be some timing issues. > For example, in client, the sequence is: > capture streamon -> source change -> capture streamoff -> capture > streamon. > but in driver side,

Re: [FFmpeg-devel] [EXT] Re: [PATCH v3 1/3] avcodec/v4l2_context: don't reinit output queue when dynamic resolution change

2021-08-16 Thread Andreas Rheinhardt
Andriy Gelman: > I tried to upload the sample to https://streams.videolan.org/upload/, but it > doesn't say what's the url of the file after uploading. It doesn't exist in > ffmpeg directory.. > Anyone used this before? > Uploads for ffmpeg for ticket x would be added to a subfolder called x here

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-16 Thread Michael Niedermayer
On Sun, Aug 15, 2021 at 01:53:23PM -0400, Andriy Gelman wrote: > On Sun, 15. Aug 17:15, Michael Niedermayer wrote: > > On Sun, Aug 15, 2021 at 08:18:17AM -0400, Andriy Gelman wrote: > > > On Sun, 15. Aug 11:17, Nicolas George wrote: > > > > Is it possible to add hooks in Patchwork to warn people au

Re: [FFmpeg-devel] [PATCH] libavformat/riffenc: support raw avi for raw PAL8 or Gray8 pixel data

2021-08-16 Thread Michael Niedermayer
On Mon, Aug 16, 2021 at 05:01:14PM +0800, rui.jiang wrote: > add palette data in avi header when the input data is raw PAL8 or Gray8 pixel > data and the output data is 8bit raw avi video; > > Signed-off-by: rui.jiang <229135...@qq.com> > --- > libavformat/riffenc.c | 10 +- > 1 file cha

[FFmpeg-devel] [PATCH] doc/general_contents: Fix dead links

2021-08-16 Thread Mapul Bhola
The x265 configuration and installation guide has moved to Bitbucket so the updated link reflects that one. As the openCV site currently only has docs for opencv3 and the filter in libavfilter is an opencv2 one an archived link to the old cv2 documentation is included. --- doc/filters.texi

Re: [FFmpeg-devel] [PATCH v3] avcodec/frame_thread_encoder: Free AVCodecContext structure on error during init

2021-08-16 Thread Michael Niedermayer
On Sun, Aug 15, 2021 at 07:35:35PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: MemLeak > > Fixes: 8281 > > Fixes: PoC_option158.jpg > > Fixes: CVE-2020-22037 > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/frame_thread_encoder.c | 11 +++ > > liba

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h264_parser: fix nalsize parser

2021-08-16 Thread Michael Niedermayer
On Sat, Aug 14, 2021 at 05:08:00PM +0200, Michael Niedermayer wrote: > Fixes: left shift of 16711968 by 8 places cannot be represented in type 'int' > Fixes: > 36601/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-6581933285965824 > > Found-by: continuous fuzzing process > https://

Re: [FFmpeg-devel] [PATCH v3] avcodec/frame_thread_encoder: Free AVCodecContext structure on error during init

2021-08-16 Thread Andreas Rheinhardt
Michael Niedermayer: > On Sun, Aug 15, 2021 at 07:35:35PM +0200, Andreas Rheinhardt wrote: >> >> PS: I still don't know whether my patch for av_opt_copy needs to bump >> minor or micro. > > you mean the documentation changing patch ? > IMHO It depends on the viewpoint i guess. is there a bug in th

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h264_parser: fix nalsize parser

2021-08-16 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: left shift of 16711968 by 8 places cannot be represented in type 'int' > Fixes: > 36601/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-6581933285965824 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/

[FFmpeg-devel] [PATCH] doc/filters.texi: Correct asegment example

2021-08-16 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- doc/filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index f8d99b7171..b8e413a40d 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -25715,7 +25715,7 @@ Split input audio stream into th

Re: [FFmpeg-devel] [EXT] Re: [PATCH v3 1/3] avcodec/v4l2_context: don't reinit output queue when dynamic resolution change

2021-08-16 Thread Ming Qian
> -Original Message- > From: Andriy Gelman [mailto:andriy.gel...@gmail.com] > Sent: Tuesday, August 17, 2021 1:34 AM > To: Ming Qian > Cc: FFmpeg development discussions and patches > Subject: Re: [EXT] Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/v4l2_context: > don't reinit output queue wh

[FFmpeg-devel] [PATCH 1/6] avfilter/internal: Replace AVFilterPad.needs_writable by flags

2021-08-16 Thread Andreas Rheinhardt
It will be useful in the future when more flags are added. Signed-off-by: Andreas Rheinhardt --- libavfilter/af_anequalizer.c | 2 +- libavfilter/af_channelmap.c | 2 +- libavfilter/af_firequalizer.c | 2 +- libavfilter/avfilter.c| 2 +- libavfilter/f_reverse.c

[FFmpeg-devel] [PATCH 2/6] avfilter/avfilter: Remove unused feature to add pads in the middle

2021-08-16 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/af_acrossover.c | 2 +- libavfilter/af_afir.c | 8 libavfilter/af_aiir.c | 4 ++-- libavfilter/af_amerge.c | 2 +- libavfilter/af_amix.c | 2 +- libavfilter/af_anequalizer.c| 4 ++-- lib

[FFmpeg-devel] [PATCH 3/6] avfilter/internal: Uninline ff_insert_(in|out)pad()

2021-08-16 Thread Andreas Rheinhardt
These functions are not hot at all and future commits will make them bigger. Signed-off-by: Andreas Rheinhardt --- libavfilter/avfilter.c | 24 +--- libavfilter/internal.h | 29 +++-- 2 files changed, 24 insertions(+), 29 deletions(-) diff --git a/lib

[FFmpeg-devel] [PATCH 4/6] avfilter/avfilter: Allow to free non-static pads generically

2021-08-16 Thread Andreas Rheinhardt
This can be enabled/disabled on a per-filter basis by setting the new internal flags FF_FILTER_FLAG_FREE_(IN|OUT)PADS and on a per-pad basis by setting the AVFILTERPAD_FLAG_FREE_NAME flag. Signed-off-by: Andreas Rheinhardt --- I decided to combine both approaches: It has the advantage that the ma

[FFmpeg-devel] [PATCH 6/6] avfilter/af_afir: Free inpads' names generically

2021-08-16 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- This is how one of the two filters that make use of setting AVFITLERPAD_FLAG_FREE_NAME directly are handled now. headphone is the other one. Furthermore, the newly added segment filters can also be simplified by this method. I think I can avoid (re)sending the

[FFmpeg-devel] [PATCH 5/6] avfilter/af_acrossover: Free outpads' names generically

2021-08-16 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/af_acrossover.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/libavfilter/af_acrossover.c b/libavfilter/af_acrossover.c index 1ad7ebad01..0ee9b47be5 100644 --- a/libavfilter/af_acrossover.c +++ b/libavfilter/af_acros

Re: [FFmpeg-devel] [WIP] Event loop

2021-08-16 Thread Xiang Xiao
On Sat, Jul 17, 2021 at 8:09 PM Nicolas George wrote: > Hi. > > Some time ago, I started working on the project to update libavformat's > protocols to run with a proper event loop, instead of the several > half-assed > event loops we have here and there in the code. > > I started by writing the d

[FFmpeg-devel] [PATCH 1/3] avfilter/avfilter: Remove redundant assignment

2021-08-16 Thread Andreas Rheinhardt
av_frame_copy_props() already copies pts. Signed-off-by: Andreas Rheinhardt --- libavfilter/avfilter.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 843b5947e5..cc24a6ed21 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c

[FFmpeg-devel] [PATCH 2/3] avfilter/internal: Combine get_(audio|video)_buffer into union

2021-08-16 Thread Andreas Rheinhardt
These fields are mutually exclusive, so putting them in a union is possible and makes AVFilterPad smaller. Signed-off-by: Andreas Rheinhardt --- libavfilter/audio.c | 4 ++-- libavfilter/avf_concat.c | 6 -- libavfilter/f_interleave.c| 4 ++-- libavfilter/in

[FFmpeg-devel] [PATCH 3/3] avfilter/audio: Don't call av_get_channel_layout_nb_channels twice

2021-08-16 Thread Andreas Rheinhardt
Also makes the assert-string shorter. Signed-off-by: Andreas Rheinhardt --- libavfilter/audio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/audio.c b/libavfilter/audio.c index 5289b94067..cebc9709dd 100644 --- a/libavfilter/audio.c +++ b/libavfilter/audio.c

[FFmpeg-devel] 回复: [PATCH 2/2] avfilter/dnn_processing: Add TensorRT backend

2021-08-16 Thread Xiaowei Wang
>No, dlopen() is not allowed for this kind of thing. Linking must be added at >build time. >You for that matter apparently add support for build time linking in patch 1, >then attempt to remove it in this one, leaving cruft in the configure script. >Why? Sorry for the late reply, outlook aut

[FFmpeg-devel] [PATCH] configure: set IceLake-AVX512 as the minimum baseline

2021-08-16 Thread Wu Jianhua
Based on IceLake-AVX512 and newer architecture, a broad range of the subsets of AVX512 could be supported. Signed-off-by: Wu Jianhua --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 94b30afe74..04caa25736 100755 --- a/configure +++

Re: [FFmpeg-devel] [PATCH] configure: set IceLake-AVX512 as the minimum baseline

2021-08-16 Thread Hendrik Leppkes
On Tue, Aug 17, 2021 at 8:30 AM Wu Jianhua wrote: > > Based on IceLake-AVX512 and newer architecture, a broad > range of the subsets of AVX512 could be supported. > > Signed-off-by: Wu Jianhua > --- > configure | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/configure

Re: [FFmpeg-devel] [PATCH] libavformat/riffenc: support raw avi for raw PAL8 or Gray8 pixel data

2021-08-16 Thread Ray
is that I should only deal with gray8 format in particular?and it has passed the fate test > 2021年8月17日 上午3:00,Michael Niedermayer 写道: > > On Mon, Aug 16, 2021 at 05:01:14PM +0800, rui.jiang wrote: >> add palette data in avi header when the input data is raw PAL8 or Gray8 >> pixel data and the