Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_dec: dequeue frame if input isn't ready

2021-12-24 Thread Andriy Gelman
On Tue, 14. Dec 02:12, Cameron Gutman wrote: > The V4L2M2M API operates asynchronously, so multiple packets can > be enqueued before getting a batch of frames back. Since it was > only possible to receive a frame by submitting another packet, > there wasn't a way to drain those excess output

[FFmpeg-devel] [PATCH v2 35/35] configure: Remove mpegvideo dependency on me_cmp

2021-12-24 Thread Andreas Rheinhardt
Forgotten in cf1e0786ed64e69614760bfb4ecd7adbde8e6094. (Both mpegvideodec as well as mpegvideoenc use me_cmp, so this doesn't affect them.) Signed-off-by: Andreas Rheinhardt --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index

[FFmpeg-devel] [PATCH v2 34/35] configure: Add new mpegvideodec CONFIG_EXTRA

2021-12-24 Thread Andreas Rheinhardt
This allows to remove the spurious dependencies of mpegvideo encoders on error_resilience; some other components that do not use mpegvideo to its fullest turned out to not need it either. Adding a new CONFIG_EXTRA needs a reconfigure to take effect. In order to force this a few unnecessary

[FFmpeg-devel] [PATCH 39/39] avcodec/mpeg12enc: Inline constants

2021-12-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- For a long time, ff_mpeg1_init_uni_ac_vlc() has only been used to create MPEG-1/2 tables and therefore some values (namely the number of elements) have been inlined; yet nowadays this function is also used for speedhq whose number of elements differs. So it

[FFmpeg-devel] [PATCH 38/39] avcodec/mpeg12enc: Partially inline whether codec is MPEG-1

2021-12-24 Thread Andreas Rheinhardt
MPEG-1 only supports 4:2:0, so one can optimize away the checks for whether one encodes MPEG-1 in codepaths that encode 4:2:2. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpeg12enc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpeg12enc.c

[FFmpeg-devel] [PATCH 37/39] avcodec/mpeg12enc: Also inline chroma subsampling

2021-12-24 Thread Andreas Rheinhardt
ff_mpeg1_encode_mb() contains two inlined calls to mpeg1_encode_mb_internal(); these calls are supposed to inline the properties depending upon the color space used. Yet inlining vertical chroma subsampling (which allows to remove complete branches and blocks depending upon them) has been

Re: [FFmpeg-devel] [PATCH 3/3] libavcodec/vaapi_encode: Add async_depth to vaapi_encoder to increase performance

2021-12-24 Thread Dennis Mungai
On Sat, 25 Dec 2021, 02:23 Ed Martin, wrote: > On 10/31/21 22:14, Chen, Wenbin wrote: > >> Add async_depth to increase encoder's performance. Reuse encode_fifo as > >> async buffer. Encoder puts all reordered frame to HW and then check > >> fifo size. If fifo < async_depth and the top frame is

[FFmpeg-devel] [PATCH 2/2] avcodec/qsvenc_h264: use AV_OPT_TYPE_BOOL for aud, a53cc, cavlc, look_ahead, pic_timing_sei options

2021-12-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/qsvenc_h264.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/qsvenc_h264.c b/libavcodec/qsvenc_h264.c index 80fe3cc..9f12760 100644 --- a/libavcodec/qsvenc_h264.c +++

[FFmpeg-devel] [PATCH 1/2] avcodec/qsvenc_hevc: use AV_OPT_TYPE_BOOL for aud option

2021-12-24 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- I haven't tested it for no build environment for qsv. libavcodec/qsvenc_hevc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c index 5847ea2..08aba30 100644 ---

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: skip moof and sidx before found moov

2021-12-24 Thread zhilizhao(赵志立)
> On Dec 25, 2021, at 3:09 AM, Derek Buitenhuis > wrote: > > On 12/24/2021 9:58 AM, Zhao Zhili wrote: >> --- >> libavformat/mov.c | 16 >> 1 file changed, 16 insertions(+) > > When do such files exist? They're not valid. File from Steven, and another one from ticket 8883.

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: add udu_sei option to import user data unregistered SEIs

2021-12-24 Thread lance . lmwang
On Fri, Dec 24, 2021 at 04:52:35PM +0100, Timo Rothenpieler wrote: > On 24.12.2021 15:47, lance.lmw...@gmail.com wrote: > > > > You can tested with libx264 output file, the size of unregistered SEIs(for > > encoding > > setting) will > 503 always, if you don't make the size <= 503, you'll see >

Re: [FFmpeg-devel] [PATCH v14 1/2] avformat/imf: Demuxer

2021-12-24 Thread Zane van Iperen
Looks mostly alright, just some style nits. Once they're fixed, lgtm. On Wednesday, 22 December 2021 4:42:08 AM AEST p...@sandflow.com wrote: > + > +int ff_imf_xml_read_uuid(xmlNodePtr element, uint8_t uuid[16]) > +{ > +xmlChar *element_text = NULL; > +int scanf_ret; > +int ret = 0;

Re: [FFmpeg-devel] [PATCH 3/3] libavcodec/vaapi_encode: Add async_depth to vaapi_encoder to increase performance

2021-12-24 Thread Ed Martin
On 10/31/21 22:14, Chen, Wenbin wrote: Add async_depth to increase encoder's performance. Reuse encode_fifo as async buffer. Encoder puts all reordered frame to HW and then check fifo size. If fifo < async_depth and the top frame is not ready, it will return AVERROR(EAGAIN) to require more

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2021-12-24 Thread Timo Rothenpieler
On 24.12.2021 21:51, Kyle Swanson wrote: Hi, Never followed through on this vf_libvmaf patch from last June, and I've had several people asking about its status lately. Rebased patch attached. It's been a while, so I guess let's start the review again. Would be nice if we could get this in

Re: [FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: update filter for libvmaf v2.0.0

2021-12-24 Thread Kyle Swanson
Hi, Never followed through on this vf_libvmaf patch from last June, and I've had several people asking about its status lately. Rebased patch attached. It's been a while, so I guess let's start the review again. Would be nice if we could get this in before 5.0. Thanks, Kyle On Wed, Jun 30, 2021

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mvdec: Check bytes_per_sample

2021-12-24 Thread John-Paul Stewart
On 2021-12-24 11:58, Michael Niedermayer wrote: > On Thu, Dec 23, 2021 at 10:32:12PM -0500, John-Paul Stewart wrote: >> On 2021-12-23 16:15, Michael Niedermayer wrote: >>> Fixes: division by zero >>> Fixes: >>> 42814/clusterfuzz-testcase-minimized-ffmpeg_dem_MV_fuzzer-4787014237552640 >>> >>>

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: skip moof and sidx before found moov

2021-12-24 Thread Derek Buitenhuis
On 12/24/2021 9:58 AM, Zhao Zhili wrote: > --- > libavformat/mov.c | 16 > 1 file changed, 16 insertions(+) When do such files exist? They're not valid. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: skip hoov box if strict >= normal

2021-12-24 Thread Derek Buitenhuis
On 12/24/2021 10:46 AM, Steven Liu wrote: > I think about ignore hoov should not default, because it use hoov > default before. I agree - we (Vimeo) get a ton of hoov files with no moov or broken moov - much more than files with hoov and valid moov (I've never seen any). This would be quite a

Re: [FFmpeg-devel] [PATCH 36/36] avcodec/mpegvideo_enc: Remove dead code at compile time

2021-12-24 Thread Michael Niedermayer
On Fri, Dec 24, 2021 at 07:30:11PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Fri, Dec 24, 2021 at 04:23:32AM +0100, Andreas Rheinhardt wrote: > >> There are no encoders for interlaced dct that support 4:4:4. > > > > i dont remember why its not supported but > > why not add

Re: [FFmpeg-devel] [PATCH 36/36] avcodec/mpegvideo_enc: Remove dead code at compile time

2021-12-24 Thread Andreas Rheinhardt
Michael Niedermayer: > On Fri, Dec 24, 2021 at 04:23:32AM +0100, Andreas Rheinhardt wrote: >> There are no encoders for interlaced dct that support 4:4:4. > > i dont remember why its not supported but > why not add 4:4:4 interlaced dct support ? > > just thinking as you already work on the code,

Re: [FFmpeg-devel] Pixel format support fixes in swscale and drawutils

2021-12-24 Thread Michael Niedermayer
On Thu, Dec 23, 2021 at 09:08:48PM -0600, rcombs wrote: > This patchset is also available as a GitHub pull request for review > simplicity: > https://github.com/FFmpeg/FFmpeg/pull/380 > > - Reduce hardcoding of pixfmt lists, preferring deriving properties from > pixdesc > - Fix big-endian

Re: [FFmpeg-devel] [PATCH 36/36] avcodec/mpegvideo_enc: Remove dead code at compile time

2021-12-24 Thread Michael Niedermayer
On Fri, Dec 24, 2021 at 04:23:32AM +0100, Andreas Rheinhardt wrote: > There are no encoders for interlaced dct that support 4:4:4. i dont remember why its not supported but why not add 4:4:4 interlaced dct support ? just thinking as you already work on the code, that would seem to me the "more

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mvdec: Check bytes_per_sample

2021-12-24 Thread Michael Niedermayer
On Thu, Dec 23, 2021 at 10:32:12PM -0500, John-Paul Stewart wrote: > On 2021-12-23 16:15, Michael Niedermayer wrote: > > Fixes: division by zero > > Fixes: > > 42814/clusterfuzz-testcase-minimized-ffmpeg_dem_MV_fuzzer-4787014237552640 > > > > Found-by: continuous fuzzing process > >

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: add udu_sei option to import user data unregistered SEIs

2021-12-24 Thread Timo Rothenpieler
On 24.12.2021 15:47, lance.lmw...@gmail.com wrote: You can tested with libx264 output file, the size of unregistered SEIs(for encoding setting) will > 503 always, if you don't make the size <= 503, you'll see below error by trace_eaders filter. Invalid SEI message: payload_size too large (xxx

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: add udu_sei option to import user data unregistered SEIs

2021-12-24 Thread lance . lmwang
On Fri, Dec 24, 2021 at 03:00:10PM +0100, Timo Rothenpieler wrote: > On 24.12.2021 05:32, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Note: > > nvenc sdk will truncated user data unregistered SEI if the size > 503. > > for example, hardcode its size to 504, trace_headers will

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: add udu_sei option to import user data unregistered SEIs

2021-12-24 Thread Timo Rothenpieler
On 24.12.2021 05:32, lance.lmw...@gmail.com wrote: From: Limin Wang Note: nvenc sdk will truncated user data unregistered SEI if the size > 503. for example, hardcode its size to 504, trace_headers will report below error: Invalid SEI message: payload_size too large (504 504 bytes). I'm

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_hevc: add -pic_timing_sei option

2021-12-24 Thread Xiang, Haihao
On Fri, 2021-12-24 at 17:55 +0800, lance.lmw...@gmail.com wrote: > On Fri, Dec 24, 2021 at 08:47:38AM +, Xiang, Haihao wrote: > > On Fri, 2021-12-24 at 16:17 +0800, lance.lmw...@gmail.com wrote: > > > On Fri, Dec 24, 2021 at 07:35:25AM +, Xiang, Haihao wrote: > > > > On Fri, 2021-08-06 at

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: remove always false condtion

2021-12-24 Thread Gyan Doshi
On 2021-12-24 03:52 pm, Steven Liu wrote: 2021年12月24日 下午5:58,Zhao Zhili 写道: 203b0e35 made duration unsigned. --- libavformat/mov.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 63483740a0..636cfce400 100644 ---

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: skip hoov box if strict >= normal

2021-12-24 Thread Steven Liu
"zhilizhao(赵志立)" 于2021年12月24日周五 18:38写道: > > > > > On Dec 24, 2021, at 6:19 PM, Steven Liu wrote: > > > >> 2021年12月24日 下午5:58,Zhao Zhili 写道: > >> > >> The samples I have got have hoov and moov both. Unknown boxes > >> should be skipped according to the spec. So don't treat hoov as > >> moov in

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: skip hoov box if strict >= normal

2021-12-24 Thread zhilizhao(赵志立)
> On Dec 24, 2021, at 6:19 PM, Steven Liu wrote: > >> 2021年12月24日 下午5:58,Zhao Zhili 写道: >> >> The samples I have got have hoov and moov both. Unknown boxes >> should be skipped according to the spec. So don't treat hoov as >> moov in normal mode. >> >> For backward compatible, a log message

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: remove always false condtion

2021-12-24 Thread Steven Liu
> 2021年12月24日 下午5:58,Zhao Zhili 写道: > > 203b0e35 made duration unsigned. > --- > libavformat/mov.c | 11 --- > 1 file changed, 11 deletions(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 63483740a0..636cfce400 100644 > --- a/libavformat/mov.c > +++

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: skip hoov box if strict >= normal

2021-12-24 Thread Steven Liu
> 2021年12月24日 下午5:58,Zhao Zhili 写道: > > The samples I have got have hoov and moov both. Unknown boxes > should be skipped according to the spec. So don't treat hoov as > moov in normal mode. > > For backward compatible, a log message has been added to notice > the user to relax the striction

[FFmpeg-devel] [PATCH 2/3] avformat/mov: skip hoov box if strict >= normal

2021-12-24 Thread Zhao Zhili
The samples I have got have hoov and moov both. Unknown boxes should be skipped according to the spec. So don't treat hoov as moov in normal mode. For backward compatible, a log message has been added to notice the user to relax the striction if moov doesn't exist. Fix #8883. ---

[FFmpeg-devel] [PATCH 3/3] avformat/mov: remove always false condtion

2021-12-24 Thread Zhao Zhili
203b0e35 made duration unsigned. --- libavformat/mov.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 63483740a0..636cfce400 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -3972,17 +3972,6 @@ static void

[FFmpeg-devel] [PATCH 1/3] avformat/mov: skip moof and sidx before found moov

2021-12-24 Thread Zhao Zhili
--- libavformat/mov.c | 16 1 file changed, 16 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 2aed6e80ef..ea2f010aa0 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -7366,6 +7366,21 @@ static int mov_read_default(MOVContext *c, AVIOContext *pb,

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_hevc: add -pic_timing_sei option

2021-12-24 Thread lance . lmwang
On Fri, Dec 24, 2021 at 08:47:38AM +, Xiang, Haihao wrote: > On Fri, 2021-12-24 at 16:17 +0800, lance.lmw...@gmail.com wrote: > > On Fri, Dec 24, 2021 at 07:35:25AM +, Xiang, Haihao wrote: > > > On Fri, 2021-08-06 at 10:10 +0800, Haihao Xiang wrote: > > > > The SDK may insert picture

[FFmpeg-devel] [PATCH 3/3] avcodec: [loongarch] Optimize prefetch with loongarch.

2021-12-24 Thread Hao Chen
From: gxw ./ffmpeg -i ../1_h264_1080p_30fps_3Mbps.mp4 -f rawvideo -y /dev/null -an before:296 after :308 Change-Id: I748490c1551d0ecfb8b8001625cf7e4e30f28eb4 --- libavcodec/loongarch/Makefile| 1 + libavcodec/loongarch/videodsp_init.c | 45

[FFmpeg-devel] [PATCH 1/3] avcodec: [loongarch] Optimize hpeldsp with LASX.

2021-12-24 Thread Hao Chen
From: Shiyou Yin ./ffmpeg -i 8_mpeg4_1080p_24fps_12Mbps.avi -f rawvideo -y /dev/null -an before:376fps after :433fps Change-Id: Ic8018562093154887323b508b81d0f489c0d265d Signed-off-by: Hao Chen --- libavcodec/hpeldsp.c |2 + libavcodec/hpeldsp.h

[FFmpeg-devel] [PATCH 2/3] avcodec: [loongarch] Optimize idctdstp with LASX.

2021-12-24 Thread Hao Chen
./ffmpeg -i 8_mpeg4_1080p_24fps_12Mbps.avi -f rawvideo -y /dev/null -an before:433fps after :552fps Change-Id: Ic233aeeb3a3b7414db294a7cb699ddbf4ca2e790 --- libavcodec/idctdsp.c | 2 + libavcodec/idctdsp.h | 2 + libavcodec/loongarch/Makefile

[FFmpeg-devel] Optimize Mpeg4 decoding for loongarch.

2021-12-24 Thread Hao Chen
./ffmpeg -i 8_mpeg4_1080p_24fps_12Mbps.avi -f rawvideo -y /dev/null -an before:376fps after :552fps avcodec: [loongarch] Optimize hpeldsp with LASX. avcodec: [loongarch] Optimize idctdstp with LASX. avcodec: [loongarch] Optimize prefetch with loongarch.

Re: [FFmpeg-devel] Pixel format support fixes in swscale and drawutils

2021-12-24 Thread Diederick C. Niehorster
On Fri, Dec 24, 2021 at 4:09 AM rcombs wrote: > > This patchset is also available as a GitHub pull request for review > simplicity: > https://github.com/FFmpeg/FFmpeg/pull/380 > > - Reduce hardcoding of pixfmt lists, preferring deriving properties from > pixdesc > - Fix big-endian support for

Re: [FFmpeg-devel] [PATCH] avfilter: add anlmf filter

2021-12-24 Thread Paul B Mahol
will apply soon ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v7 01/12] avdevice/dshow: prevent NULL access

2021-12-24 Thread Gyan Doshi
On 2021-12-23 10:54 am, Gyan Doshi wrote: On 2021-12-23 10:39 am, Roger Pack wrote: These LGTM, could someone apply them for me? Thanks! Tomorrow, if no else does, or objects. Pushed as 7b21841ce45ef4ab486c3c94a714345b878a70fd...a1c4929f65cc75b7175622a007b1e4bd37043d41 Had to correct

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_hevc: add -pic_timing_sei option

2021-12-24 Thread Xiang, Haihao
On Fri, 2021-12-24 at 16:17 +0800, lance.lmw...@gmail.com wrote: > On Fri, Dec 24, 2021 at 07:35:25AM +, Xiang, Haihao wrote: > > On Fri, 2021-08-06 at 10:10 +0800, Haihao Xiang wrote: > > > The SDK may insert picture timing SEI for hevc and the code to set mfx > > > parameter has been added

Re: [FFmpeg-devel] [PATCH] avcodec/vaapi_encode_vp9: fix > 4k encode fail issue

2021-12-24 Thread Xiang, Haihao
On Fri, 2021-12-24 at 16:19 +0800, lance.lmw...@gmail.com wrote: > On Fri, Dec 24, 2021 at 07:32:28AM +, Xiang, Haihao wrote: > > On Mon, 2021-04-12 at 09:47 +0800, Zhang yuankun wrote: > > > This patch will fix following command: > > > ffmpeg -hwaccel vaapi -hwaccel_output_format vaapi -i

Re: [FFmpeg-devel] [PATCH] avcodec/vaapi_encode_vp9: fix > 4k encode fail issue

2021-12-24 Thread lance . lmwang
On Fri, Dec 24, 2021 at 07:32:28AM +, Xiang, Haihao wrote: > On Mon, 2021-04-12 at 09:47 +0800, Zhang yuankun wrote: > > This patch will fix following command: > > ffmpeg -hwaccel vaapi -hwaccel_output_format vaapi -i input.264 \ > > -vf 'scale_vaapi=w=7680:h=4096' -c:v vp9_vaapi output.ivf >

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_hevc: add -pic_timing_sei option

2021-12-24 Thread lance . lmwang
On Fri, Dec 24, 2021 at 07:35:25AM +, Xiang, Haihao wrote: > On Fri, 2021-08-06 at 10:10 +0800, Haihao Xiang wrote: > > The SDK may insert picture timing SEI for hevc and the code to set mfx > > parameter has been added in qsvenc, however the corresponding option is > > missing in the hevc