Re: [FFmpeg-devel] [PATCH v2] avcodec/startcode: Avoid unaligned accesses

2022-10-13 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2022-10-12 00:20:23) > Up until now, ff_startcode_find_candidate_c() simply casts > an uint8_t* to uint64_t*/uint32_t* to read 64/32 bits at a time > in case HAVE_FAST_UNALIGNED is true. Yet this ignores the > alignment requirement of these types as well as effective typ

[FFmpeg-devel] [PATCH 2/2] avcodec/vp3data: rectify comment

2022-10-13 Thread Peter Ross
--- they're actually one byte different. libavcodec/vp3data.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vp3data.h b/libavcodec/vp3data.h index 317797a697..a347f492ad 100644 --- a/libavcodec/vp3data.h +++ b/libavcodec/vp3data.h @@ -25,7 +25,7 @@ #include

[FFmpeg-devel] [PATCH 1/2] avcodec/jpegtables: remove duplicate luma and chroma quantization tables

2022-10-13 Thread Peter Ross
Duplicates of the standard JPEG quantization tables were found in the AGM, MSS34(dsp), NUV and VP31 codecs. This patch elimates those duplicates, placing a single copy in jpegtables. --- configure | 6 -- libavcodec/agm.c| 27 +-- libavcodec/jpegt

Re: [FFmpeg-devel] [PATCH] ffmpeg: fix implementation of updated input start time

2022-10-13 Thread Gyan Doshi
On 2022-10-12 09:50 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-09-27 06:40:56) The current adjustment of input start times just adjusts the tsoffset. And it does so, by resetting the tsoffset to nullify the new start time. This leads to breakage of -copyts, ignoring of user_ts_offset,

Re: [FFmpeg-devel] [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 decoding

2022-10-13 Thread Lynne
Oct 13, 2022, 17:48 by toq...@outlook.com: >> Lynne wrote: >> >> Oct 12, 2022, 13:09 by toq...@outlook.com: >> >>> [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 >>> decoding >>> >>> Patch attached. >>> >> The Sync locking functions and the queue

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/mpeg4videodec: Remove always-true checks

2022-10-13 Thread Michael Niedermayer
On Thu, Oct 13, 2022 at 11:23:33PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Hi > > > > On Wed, Oct 12, 2022 at 08:06:22PM +0200, Andreas Rheinhardt wrote: > >> codec_id is always AV_CODEC_ID_MPEG4 in this file. > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > >> libavcod

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/mpeg4videodec: Remove always-true checks

2022-10-13 Thread Andreas Rheinhardt
Michael Niedermayer: > Hi > > On Wed, Oct 12, 2022 at 08:06:22PM +0200, Andreas Rheinhardt wrote: >> codec_id is always AV_CODEC_ID_MPEG4 in this file. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/mpeg4videodec.c | 6 ++ >> 1 file changed, 2 insertions(+), 4 deletions(-) > [.

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/mpeg4videodec: Remove always-true checks

2022-10-13 Thread Michael Niedermayer
Hi On Wed, Oct 12, 2022 at 08:06:22PM +0200, Andreas Rheinhardt wrote: > codec_id is always AV_CODEC_ID_MPEG4 in this file. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpeg4videodec.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) [...] > @@ -3084,7 +3083,6 @@ int ff

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/svq1enc: Inline constants

2022-10-13 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/svq1.h| 7 +++ > libavcodec/svq1enc.c | 13 + > 2 files changed, 12 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/svq1.h b/libavcodec/svq1.h > index 0ebc73a933..af8a7dfa04 100644 > --- a/l

Re: [FFmpeg-devel] [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 decoding

2022-10-13 Thread Wu Jianhua
James Almer wrote: > On 10/13/2022 12:48 PM, Wu Jianhua wrote: >>> Lynne wrote: >> >>> Oct 12, 2022, 13:09 by toq...@outlook.com: >> [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 decoding Patch attache

Re: [FFmpeg-devel] [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 decoding

2022-10-13 Thread James Almer
On 10/13/2022 12:48 PM, Wu Jianhua wrote: Lynne wrote: Oct 12, 2022, 13:09 by toq...@outlook.com: [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 decoding Patch attached. The Sync locking functions and the queue locking functions should

Re: [FFmpeg-devel] [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 decoding

2022-10-13 Thread Wu Jianhua
> Lynne wrote: > Oct 12, 2022, 13:09 by toq...@outlook.com: >> [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 >> decoding >> >> Patch attached. >> > The Sync locking functions and the queue locking functions should > be a function pointer in the

Re: [FFmpeg-devel] [PATCH 1/1] libswscale: force a minimum size of the slide for bayer sources

2022-10-13 Thread Anton Khirnov
Will push. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] lavf/async: Fix ring_write return value

2022-10-13 Thread Anton Khirnov
Quoting Guangyu Sun (2022-09-29 20:11:34) > his fixes a regression from commit 36117968ad. > > wrapped_url_read() used to be able to return positive number from > ffurl_read(). It relies on the result to check if EOF is reached in > async_buffer_task(). > > But FIFO callbacks must return 0 on suc

Re: [FFmpeg-devel] [PATCH 1/3] fftools/cmdutils: Use av_err2str

2022-10-13 Thread Anton Khirnov
Patchset looks good, will push. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe

[FFmpeg-devel] [PATCH 13/13] fftools/ffmpeg: move init_output_bsfs() to ffmpeg_mux

2022-10-13 Thread Anton Khirnov
Bitstream filtering is done as a part of muxing, so this is the more proper place for this. --- fftools/ffmpeg.c | 36 fftools/ffmpeg_mux.c | 38 ++ 2 files changed, 38 insertions(+), 36 deletions(-) diff --git a/fftools

[FFmpeg-devel] [PATCH 11/13] fftools/ffmpeg_mux: inline mux_free() into of_close()

2022-10-13 Thread Anton Khirnov
mux_free() is no longer called from anywhere else. --- fftools/ffmpeg_mux.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index 2f71e03144..f830e5854b 100644 --- a/fftools/ffmpeg_mux.c +++ b/fftools

[FFmpeg-devel] [PATCH 12/13] fftools/ffmpeg_mux: move sq_mux from OutputFile to Muxer

2022-10-13 Thread Anton Khirnov
It is internal to ffmpeg_mux* and does not need to be visible to other code. --- fftools/ffmpeg.h | 1 - fftools/ffmpeg_mux.c | 8 fftools/ffmpeg_mux.h | 1 + fftools/ffmpeg_mux_init.c | 8 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/fftools/

[FFmpeg-devel] [PATCH 09/13] fftools/ffmpeg_mux: allocate sq_pkt in setup_sync_queues()

2022-10-13 Thread Anton Khirnov
This is now possible since setup_sync_queues() can interact with Muxer. --- fftools/ffmpeg_mux.c | 8 fftools/ffmpeg_mux_init.c | 13 ++--- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index 4cb5a71659..4c56f4ba

[FFmpeg-devel] [PATCH 07/13] fftools/ffmpeg_mux: move Muxer and MuxStream to a new header

2022-10-13 Thread Anton Khirnov
This will allow ffmpeg_mux_init.c to see work with these structs. --- fftools/ffmpeg_mux.c | 36 +- fftools/ffmpeg_mux.h | 72 2 files changed, 73 insertions(+), 35 deletions(-) create mode 100644 fftools/ffmpeg_mux.h diff --git a/

[FFmpeg-devel] [PATCH 03/13] fftools/ffmpeg_mux: rename submit_packet() to thread_submit_packet()

2022-10-13 Thread Anton Khirnov
This is more descriptive, and the submit_packet() name will be reused in following commits. --- fftools/ffmpeg_mux.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index 6e9cbb4bab..7762038b1d 100644 --- a/fftools/ffmpeg_mux.c

[FFmpeg-devel] [PATCH 05/13] fftools/ffmpeg: move some stream initialization code to ffmpeg_mux

2022-10-13 Thread Anton Khirnov
The code in question is muxing-specific and so belongs there. This will allow make some objects private to the muxer in future commits. --- fftools/ffmpeg.c | 8 +--- fftools/ffmpeg.h | 10 -- fftools/ffmpeg_mux.c | 15 --- 3 files changed, 21 insertions(+), 12 del

[FFmpeg-devel] [PATCH 10/13] fftools/ffmpeg_mux: inline of_muxer_init() into of_open()

2022-10-13 Thread Anton Khirnov
A separate muxer init is no longer necessary, now that of_open() has access to Muxer. --- fftools/ffmpeg.h | 4 --- fftools/ffmpeg_mux.c | 56 --- fftools/ffmpeg_mux.h | 5 fftools/ffmpeg_mux_init.c | 39 --- 4 f

[FFmpeg-devel] [PATCH 04/13] fftools/ffmpeg_mux: drop the of_ prefix from of_submit_packet()

2022-10-13 Thread Anton Khirnov
This function is now static. --- fftools/ffmpeg_mux.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index 7762038b1d..63f63c0852 100644 --- a/fftools/ffmpeg_mux.c +++ b/fftools/ffmpeg_mux.c @@ -319,7 +319,7 @@ static int queue

[FFmpeg-devel] [PATCH 08/13] fftools/ffmpeg_mux: embed OutputFile in a Muxer

2022-10-13 Thread Anton Khirnov
This is now possible since the code allocating OutputFile can see sizeof(Muxer). Avoids the overhead and extra complexity of allocating two objects instead of one. Similar to what is done e.g. for AVStream/FFStream in lavf. --- fftools/ffmpeg.h | 3 - fftools/ffmpeg_mux.c | 128 ++

[FFmpeg-devel] [PATCH 02/13] fftools/ffmpeg: move output_packet() to ffmpeg_mux

2022-10-13 Thread Anton Khirnov
This function is common to both transcoding and streamcopy, so it properly belongs into the muxing code. --- fftools/ffmpeg.c | 78 fftools/ffmpeg.h | 13 +++- fftools/ffmpeg_mux.c | 54 +- 3 files changed, 72 ins

[FFmpeg-devel] [PATCH 01/13] fftools/ffmpeg_mux: do not unref a NULL packet

2022-10-13 Thread Anton Khirnov
The packet submitted to of_submit_packet() may be NULL to signal EOF. --- fftools/ffmpeg_mux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux.c b/fftools/ffmpeg_mux.c index 395f7cc89f..a6877ae5ec 100644 --- a/fftools/ffmpeg_mux.c +++ b/fftools/ffmpeg_mux.c

Re: [FFmpeg-devel] [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 decoding

2022-10-13 Thread Lynne
Oct 12, 2022, 13:09 by toq...@outlook.com: > [PATCH] avcodec: add D3D12VA hardware accelerated H264, HEVC, VP9, and AV1 > decoding > > Patch attached. > The Sync locking functions and the queue locking functions should be a function pointer in the device/frame context. Vulkan has the same issue,

[FFmpeg-devel] [PATCH 2/2] doc/encoders: Add doc for av1_qsv

2022-10-13 Thread wenbin . chen-at-intel . com
From: Wenbin Chen Add doc for av1_qsv. Signed-off-by: Wenbin Chen --- doc/encoders.texi | 32 1 file changed, 32 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 1a5216f8eb..53dd02fd28 100644 --- a/doc/encoders.texi +++ b/doc/encoders.tex

[FFmpeg-devel] [PATCH 1/2] libavcodec/qsvenc_av1: add av1_qsv encoder

2022-10-13 Thread wenbin . chen-at-intel . com
From: Wenbin Chen It is available only when libvpl is enabled. MSDK doesn't support av1 encoding. sample command: ffmpeg -f rawvideo -pix_fmt nv12 -s 1920x1080 -i input.yuv \ -c:v av1_qsv output.ivf Signed-off-by: Wenbin Chen Signed-off-by: Haihao Xiang --- configure | 2 + l