Re: [FFmpeg-devel] [PATCH 5/8] lavu: add a JSON writer API (WIP)

On 4/29/23 14:33, Nicolas George wrote: Anton Khirnov (12023-04-29): libavfilter is a C library with a C API. Any structured output from filters should be in the form of a C object, typically a struct. I do not see why are you so in love with strings, they make for terrible APIs. Yes, string

Re: [FFmpeg-devel] [PATCH 5/8] lavu: add a JSON writer API (WIP)

On Sat, Apr 29, 2023 at 8:29 PM Kieran Kunhya wrote: > On Sat, 29 Apr 2023 at 05:07, Derek Buitenhuis > > wrote: > > > On 4/29/2023 10:41 AM, Anton Khirnov wrote: > > > ffprobe: > > > * is not one of the libraries, but rather their caller > > > * we are not in business of providing random non-mu

Re: [FFmpeg-devel] [PATCH v4] avformat: add MMTP parser and MMT/TLV demuxer

Thanks for the feedback. I thought across libraries meant across different muxers/demuxers. In which case, is there any naming scheme for functions that are only used within lavf? Can i just remove the avpriv_ prefix? For inline, my habit is to add it when there’s only one place that uses it. I ca

[FFmpeg-devel] [PATCH] [RFC] web/donations: Remove ffis

There are some problems with the ffis webpage "Unable to connect to SQL server" I tried to report this but it seems my email was not achieving that. It may be safer to remove the link to ffis until we understand what exactly is going on on the ffis side. Suggested-by: Kieran Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH v4 6/6] decklink_enc: add support for playout of 608 captions in MOV files

On Fri, Apr 28, 2023 at 11:43 PM Devin Heitmueller < devin.heitmuel...@ltnglobal.com> wrote: > Unlike other cases where the closed captions are embedded in the > video stream as MPEG-2 userdata or H.264 SEI data, with MOV files > the captions are often found on a separate "e608" subtitle track. >

Re: [FFmpeg-devel] [PATCH v4 5/6] vf_ccrepack: Add new filter to repack CEA-708 side data

On Fri, Apr 28, 2023 at 11:43 PM Devin Heitmueller < devin.heitmuel...@ltnglobal.com> wrote: > THis filter can correct certain issues seen from upstream sources > where the cc_count is not properly set or the CEA-608 tuples are > not at the start of the payload as expected. > > Make use of the ccf

Re: [FFmpeg-devel] [PATCH 1/3] tools/target_dec_fuzzer: Adjust threshold for rka

On Thu, Apr 27, 2023 at 08:38:38PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 57993/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RKA_fuzzer-5825782785376256 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/hevc_ps: Check depth to be within 8 to 16

On Mon, Apr 17, 2023 at 12:25:18AM +0200, Michael Niedermayer wrote: > Fixes: assertion failure in bitreader > Fixes: > 45982/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-627318668066816 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects

Re: [FFmpeg-devel] [PATCH 5/8] lavu: add a JSON writer API (WIP)

> There are many projects which use libavcodec, format, filter > Human users use these projects > > If the standarization is at a C struct level only then the human interface > for each application can be different. > Thats fine if the 2 cases use fundamentally different interfaces like a > GUI dra

Re: [FFmpeg-devel] [PATCH 11/11] avcodec/wavarc: Check order before using it to write the list

On Sun, Apr 16, 2023 at 06:48:30PM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 45982/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-6247711015043072 > Fixes: > 45982/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-6487578428964864 > F

Re: [FFmpeg-devel] [PATCH 1/6] tools/target_dec_fuzzer: Adjust threshold for FMVC

On Mon, Apr 24, 2023 at 12:32:31AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 56753/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FMVC_fuzzer-5115163557888000 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/hevc_ps: Avoid signed overflow before check on QP

On Thu, Apr 27, 2023 at 03:49:54PM -0300, James Almer wrote: > On 4/27/2023 3:38 PM, Michael Niedermayer wrote: > > Fixes: signed integer overflow: -2147483648 - 5 cannot be represented in > > type 'int' > > Fixes: > > 58066/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5312995835

[FFmpeg-devel] [PATCH 03/10] avfilter/dnn: add log context to ff_get_dnn_module

From: Zhao Zhili Print backend type when failed. Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_interface.c | 6 -- libavfilter/dnn_filter_common.c | 2 +- libavfilter/dnn_interface.h | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/libavfilter/dnn/dnn_interfac

[FFmpeg-devel] [PATCH 04/10] avfilter/vf_dnn_classify: replace magic number by enum value

From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/vf_dnn_classify.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_dnn_classify.c b/libavfilter/vf_dnn_classify.c index d242aebcfb..c3f2762cf9 100644 --- a/libavfilter/vf_dnn_classify.c +++ b/libavf

[FFmpeg-devel] [PATCH 09/10] avfilter/dnn_backend_tf: fix use of uninitialized value

From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 552a9f2fa1..c15f1a7d3b 100644 --- a/libavfilter/dnn/dnn_backend_tf.c +++

[FFmpeg-devel] [PATCH 08/10] avfilter/dnn_backend_tf: check TF_OperationOutputType return value

From: Zhao Zhili This also fixed a warning: implicit conversion from enumeration type 'TF_DataType' (aka 'enum TF_DataType') to different enumeration type 'DNNDataType'. Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 14 +- 1 file changed, 13 insertions(+), 1 dele

[FFmpeg-devel] [PATCH 10/10] avfilter/dnn_backend_tf: silence implicit cast warning

From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index c15f1a7d3b..b521de7fbe 100644 --- a/libavfilter/dnn/dnn_backend_tf.c +++

[FFmpeg-devel] [PATCH 06/10] avfilter/vf_dnn_processing: replace magic number by enum value

From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/vf_dnn_processing.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_dnn_processing.c b/libavfilter/vf_dnn_processing.c index 18ecf111fe..95c3e0b99b 100644 --- a/libavfilter/vf_dnn_processing.c ++

[FFmpeg-devel] [PATCH 07/10] avfilter/dnn_backend_tf: remove unused define

From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index e6ebd17595..74fe06d6fb 100644 --- a/libavfilter/dnn/dnn_backend_tf.c +++ b/libavfilter/d

[FFmpeg-devel] [PATCH 05/10] avfilter/vf_dnn_detect: replace magic number by enum value

From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/vf_dnn_detect.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_dnn_detect.c b/libavfilter/vf_dnn_detect.c index 7e133f6af5..06efce02a6 100644 --- a/libavfilter/vf_dnn_detect.c +++ b/libavfilter/

[FFmpeg-devel] [PATCH 02/10] avfilter/dnn: refactor ff_get_dnn_module to remove allocation

From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_interface.c | 28 +--- libavfilter/dnn_filter_common.c | 1 - libavfilter/dnn_filter_common.h | 2 +- libavfilter/dnn_interface.h | 2 +- 4 files changed, 7 insertions(+), 26 deletions(-) diff --g

[FFmpeg-devel] [PATCH 01/10] avfilter/dnn: define each backend as a DNNModule

From: Zhao Zhili To avoid export multiple functions for each backend implementation. Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 98 +--- libavfilter/dnn/dnn_backend_openvino.h | 40 -- libavfilter/dnn/dnn_backend_tf.c | 101 ++

Re: [FFmpeg-devel] [PATCH v4] avformat: add MMTP parser and MMT/TLV demuxer

Quoting SuperFashi (2023-04-30 05:32:46) > Thanks. Is there anything else that does not fit codebase tradition? Please > point everything out so I could send a new patch. Some quick notes: * why are there avpriv_ functions when everything you do is libavformat? avpriv is for sharing functions ac

Re: [FFmpeg-devel] [PATCH 5/8] lavu: add a JSON writer API (WIP)

On Sat, Apr 29, 2023 at 08:27:32PM +0200, Anton Khirnov wrote: > Quoting Nicolas George (2023-04-29 19:11:52) > > Anton Khirnov (2023-04-29): > > > As far as I can see, there are exactly two places in the codebase that > > > produce JSON: af_loudnorm and ffprobe. > > > > I think I remember finding

[FFmpeg-devel] [PATCH] lavc/aarch64: new optimization for 8-bit hevc_pel_uni_w_pixels, qpel_uni_w_h, qpel_uni_w_v, qpel_uni_w_hv and qpel_h

Hi, This is a patch for the aarch64, which completes the neon versions of the hevc_pel_uni_w_pixels, qpel_uni_w_h, qpel_uni_w_v, qpel_uni_w_hv interfaces. put_hevc_pel_uni_w_pixels4_8_c: 54.3 put_hevc_pel_uni_w_pixels4_8_neon: 24.1 put_hevc_pel_uni_w_pixels6_8_c: 105.3 put_hevc_pel_uni_w_pixel

Re: [FFmpeg-devel] [PATCH] codec/aarch64/hevc: add transform_luma_neon

Thank you, Martin. It's my mistake that delete an empty line in the end of file. Should I submit a patch with a newline in the end of file or do something else? Thanks for your review and point out the details of error.  -- Original -- From: