Re: [FFmpeg-devel] [PATCH] avcodec/dovi_rpudec - correctly read el_bit_depth_minus8 when ext_mapping_idc is non-zero

2024-05-20 Thread Andreas Rheinhardt
Cosmin Stejerean via ffmpeg-devel: > From: Cosmin Stejerean > > It looks like the el_bitdepth_minus8 value in the header can also encode > ext_mapping_idc in the upper 8 bits. > > Samples having a non-zero ext_mapping_idc fail validation currently because > the > value returned is out of

[FFmpeg-devel] [PATCH 2/2] lavc/qsvenc_av1: accept HDR metadata if have

2024-05-20 Thread Xiang, Haihao
From: Haihao Xiang The sdk av1 encoder can accept HDR metadata via mfxEncodeCtrl::ExtParam. Signed-off-by: Haihao Xiang --- libavcodec/qsvenc_av1.c | 75 + 1 file changed, 75 insertions(+) diff --git a/libavcodec/qsvenc_av1.c b/libavcodec/qsvenc_av1.c

[FFmpeg-devel] [PATCH 1/2] lavc/qsvdec: update HDR side data on output AVFrame for AV1 decoding

2024-05-20 Thread Xiang, Haihao
From: Haihao Xiang The SDK may provides HDR metadata for HDR streams via mfxExtBuffer attached on output mfxFrameSurface1 Signed-off-by: Haihao Xiang --- libavcodec/qsvdec.c | 49 - 1 file changed, 48 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH v4 2/2][GSoC 2024] tests/checkasm: Add check_vvc_sad to vvc_mc.c

2024-05-20 Thread Rémi Denis-Courmont
Hi, Le 20 mai 2024 03:42:03 GMT+03:00, Stone Chen a écrit : >Adds checkasm for DMVR SAD AVX2 implementation. > >Benchmarks ( AMD 7940HS ) >vvc_sad_8x8_c: 70.0 >vvc_sad_8x8_avx2: 10.0 >vvc_sad_16x16_c: 280.0 >vvc_sad_16x16_avx2: 20.0 >vvc_sad_32x32_c: 1020.0 >vvc_sad_32x32_avx2: 70.0

[FFmpeg-devel] [PATCH] avcodec/dovi - disable metadata compression by default

2024-05-20 Thread Cosmin Stejerean via ffmpeg-devel
From: Cosmin Stejerean not all clients support metadata compression, make this an option and off by default until we can verify output. vdr_dm_metadata_changed = 0 case fails the DV verifier so force this to true for now until we can determine the correct output format for this case. ---

Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: send the EOS signal without a one frame delay to allow for the library to operate in a low-delay mode

2024-05-20 Thread Cosmin Stejerean via ffmpeg-devel
> On May 20, 2024, at 6:17 PM, Cosmin Stejerean via ffmpeg-devel > wrote: > > From: Cosmin Stejerean > > Co-authored-by: Amir Naghdinezhad > Signed-off-by: Cosmin Stejerean > --- > libavcodec/libsvtav1.c | 10 ++ > 1 file changed, 10 insertions(+) > Disregard this one, it was

[FFmpeg-devel] [PATCH 7/7] tools/enc_recon_frame_test: Assert that av_image_get_linesize() succeeds

2024-05-20 Thread Michael Niedermayer
Helps: CID1524598 Improper use of negative value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- tools/enc_recon_frame_test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/enc_recon_frame_test.c b/tools/enc_recon_frame_test.c index

[FFmpeg-devel] [PATCH 6/7] tools/decode_simple: Check avcodec_send_packet() for errors on flushing

2024-05-20 Thread Michael Niedermayer
This will not error but the API allows errors so we should check it Fixes: CID148 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- tools/decode_simple.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH 5/7] swscale/yuv2rgb: Use 64bit for brightness computation

2024-05-20 Thread Michael Niedermayer
This will not overflow for normal values Fixes: CID1500280 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libswscale/yuv2rgb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c

[FFmpeg-devel] [PATCH 4/7] swscale/x86/swscale: use a clearer name for INPUT_PLANER_RGB_A_FUNC_CASE

2024-05-20 Thread Michael Niedermayer
related: CID1497114 Missing break in switch Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libswscale/x86/swscale.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c index

[FFmpeg-devel] [PATCH 3/7] avutil/tests/opt: Check av_set_options_string() for failure

2024-05-20 Thread Michael Niedermayer
This is test code after all so it should test things Fixes: CID1518990 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavutil/tests/opt.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavutil/tests/opt.c

[FFmpeg-devel] [PATCH 2/7] avutil/tests/dict: Check av_dict_set() before get for failure

2024-05-20 Thread Michael Niedermayer
Failure is possible due to strdup() Fixes: CID1516764 Dereference null return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavutil/tests/dict.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavutil/tests/dict.c

[FFmpeg-devel] [PATCH 1/7] avutil/random_seed: Avoid dead returns

2024-05-20 Thread Michael Niedermayer
Fixes: CID1538296 Structurally dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavutil/random_seed.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/random_seed.c b/libavutil/random_seed.c index 6d399cee49c..8a4e4f1fc0b

[FFmpeg-devel] [PATCH] fate: add tests for xHE-AAC

2024-05-20 Thread Lynne via ffmpeg-devel
Starting off small with a few features. Samples and reference decoded files copied from the official ISO reference suite. --- Samples and references: https://files.lynne.ee/xhe_refs/ tests/fate/aac.mak | 8 1 file changed, 8 insertions(+) diff --git a/tests/fate/aac.mak

Re: [FFmpeg-devel] [PATCH v2] avutil/hwcontext_videotoolbox: Set proper CVBuffer colorspace

2024-05-20 Thread Gnattu OC via ffmpeg-devel
> On May 20, 2024, at 09:12, Marvin Scholz wrote: > > Fix #10884 > --- > libavutil/hwcontext_videotoolbox.c | 54 +- > 1 file changed, 38 insertions(+), 16 deletions(-) > > diff --git a/libavutil/hwcontext_videotoolbox.c > b/libavutil/hwcontext_videotoolbox.c >

[FFmpeg-devel] [PATCH] avcodec/libsvtav1: send the EOS signal without a one frame delay to allow for the library to operate in a low-delay mode

2024-05-20 Thread Cosmin Stejerean via ffmpeg-devel
From: Cosmin Stejerean Co-authored-by: Amir Naghdinezhad Signed-off-by: Cosmin Stejerean --- libavcodec/libsvtav1.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c index 3b41f5a39e..1eda63200c 100644 --- a/libavcodec/libsvtav1.c

[FFmpeg-devel] [PATCH] avcodec/dovi_rpudec - correctly read el_bit_depth_minus8 when ext_mapping_idc is non-zero

2024-05-20 Thread Cosmin Stejerean via ffmpeg-devel
From: Cosmin Stejerean It looks like the el_bitdepth_minus8 value in the header can also encode ext_mapping_idc in the upper 8 bits. Samples having a non-zero ext_mapping_idc fail validation currently because the value returned is out of range. This bypasses this by currently ignoring the

Re: [FFmpeg-devel] [PATCH] lavf/dash: Forward strict flag to component demuxers

2024-05-20 Thread Andreas Rheinhardt
Frank Plowman: > Before the patch, opening a DASH file containing streams which require > experimental decoders was problematic. No matter where the -strict -2 > was put on the command line, the option was not passed to the demuxer > for that component. This resulted in an error, prompting the

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec: add external dec libvvdec for H266/VVC

2024-05-20 Thread Cosmin Stejerean via ffmpeg-devel
> On May 20, 2024, at 1:05 PM, Rémi Denis-Courmont wrote: > > Le maanantaina 20. toukokuuta 2024, 22.33.45 EEST Cosmin Stejerean via ffmpeg- > devel a écrit : >>> And again, you can't expect users to select decoders manually. If vvdec is >>> the >>> default, hwaccel won't work. If vvdec is

[FFmpeg-devel] [PATCH v3 3/3] avfilter/af_volumedetect.c: reindent after last commit

2024-05-20 Thread Yigithan Yigit
--- libavfilter/af_volumedetect.c | 68 +-- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/libavfilter/af_volumedetect.c b/libavfilter/af_volumedetect.c index dbbcd037a5..b78b073c09 100644 --- a/libavfilter/af_volumedetect.c +++

[FFmpeg-devel] [PATCH v3 2/3] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-05-20 Thread Yigithan Yigit
--- libavfilter/af_volumedetect.c | 159 -- 1 file changed, 133 insertions(+), 26 deletions(-) diff --git a/libavfilter/af_volumedetect.c b/libavfilter/af_volumedetect.c index 327801a7f9..dbbcd037a5 100644 --- a/libavfilter/af_volumedetect.c +++

[FFmpeg-devel] [PATCH v3 1/3] avfilter/af_volumedetect.c: Move logdb function

2024-05-20 Thread Yigithan Yigit
--- libavfilter/af_volumedetect.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavfilter/af_volumedetect.c b/libavfilter/af_volumedetect.c index 8b001d1cf2..327801a7f9 100644 --- a/libavfilter/af_volumedetect.c +++ b/libavfilter/af_volumedetect.c @@

[FFmpeg-devel] [PATCH v3 0/3] avfilter/af_volumedetect.c: Move logdb function

2024-05-20 Thread Yigithan Yigit
v2 was mangled by my client. Yigithan Yigit (3): avfilter/af_volumedetect.c: Move logdb function avfilter/af_volumedetect.c: Add 32bit float audio support avfilter/af_volumedetect.c: reindent after last commit libavfilter/af_volumedetect.c | 221 +- 1 file

[FFmpeg-devel] [PATCH] lavf/dash: Forward strict flag to component demuxers

2024-05-20 Thread Frank Plowman
Before the patch, opening a DASH file containing streams which require experimental decoders was problematic. No matter where the -strict -2 was put on the command line, the option was not passed to the demuxer for that component. This resulted in an error, prompting the user to add the -strict

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec: add external dec libvvdec for H266/VVC

2024-05-20 Thread Rémi Denis-Courmont
Le maanantaina 20. toukokuuta 2024, 22.33.45 EEST Cosmin Stejerean via ffmpeg- devel a écrit : > > And again, you can't expect users to select decoders manually. If vvdec is > > the > > default, hwaccel won't work. If vvdec is not the default, then it's > > dead code. > > Not sure why you keep

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec: add external dec libvvdec for H266/VVC

2024-05-20 Thread Cosmin Stejerean via ffmpeg-devel
> On May 20, 2024, at 12:01 PM, Rémi Denis-Courmont wrote: > > Le maanantaina 20. toukokuuta 2024, 21.39.18 EEST Cosmin Stejerean via ffmpeg- > devel a écrit : >> The same way using FDK-AAC as a decoder works, if you want to use it as the >> *AAC decoder you have to specify the decoder with

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec: add external dec libvvdec for H266/VVC

2024-05-20 Thread Rémi Denis-Courmont
Le maanantaina 20. toukokuuta 2024, 21.39.18 EEST Cosmin Stejerean via ffmpeg- devel a écrit : > The same way using FDK-AAC as a decoder works, if you want to use it as the > *AAC decoder you have to specify the decoder with -c:a libfdk_aac before > the input.- AFAIK, we don't have hwaccel for

Re: [FFmpeg-devel] [RFC] STF 2025

2024-05-20 Thread Rémi Denis-Courmont
Le sunnuntaina 19. toukokuuta 2024, 14.29.43 EEST Thilo Borgmann via ffmpeg- devel a écrit : > [...] > > >> * Fund administrative / maintainance work (one example is the mailman > >> upgrade that is needed>> > >> with the next OS upgrade on one of our servers (this is not as trivial > >> as

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec: add external dec libvvdec for H266/VVC

2024-05-20 Thread Cosmin Stejerean via ffmpeg-devel
> On May 20, 2024, at 11:03 AM, Rémi Denis-Courmont wrote: > > Le maanantaina 20. toukokuuta 2024, 19.33.43 EEST Cosmin Stejerean via ffmpeg- > devel a écrit : > >> hwaccel decoding seems somewhat orthogonal > > How exactly will that work then? Either vvdec is the default, and hwaccel >

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec: add external dec libvvdec for H266/VVC

2024-05-20 Thread Rémi Denis-Courmont
Le maanantaina 20. toukokuuta 2024, 19.33.43 EEST Cosmin Stejerean via ffmpeg- devel a écrit : > > Adding a disabled-by-default decoder is adding bloat, if there is not a > > specific known reason why that is needed. > > This is especially true for video decoders, where the external decoders > >

Re: [FFmpeg-devel] [PATCH, v2] libavcodec/amfenc: Update AMF encoder options

2024-05-20 Thread Araz
Please review the attached patch and provide your feedback. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec: add external dec libvvdec for H266/VVC

2024-05-20 Thread Cosmin Stejerean via ffmpeg-devel
Trying again with better formatting, hopefully > On May 18, 2024, at 10:48 PM, Rémi Denis-Courmont wrote: > > Hi, > > Le 18 mai 2024 21:55:04 GMT+03:00, Cosmin Stejerean via ffmpeg-devel > a écrit : >> >> >>> On May 18, 2024, at 7:04 AM, Nuo Mi wrote: >>> >>> This happened many years

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec: add external dec libvvdec for H266/VVC

2024-05-20 Thread Cosmin Stejerean via ffmpeg-devel
On May 18, 2024, at 10:48 PM, Rémi Denis-Courmont wrote: Le 18 mai 2024 21:55:04 GMT+03:00, Cosmin Stejerean via ffmpeg-devel mailto:ffmpeg-devel@ffmpeg.org> > a écrit : On May 18, 2024, at 7:04 AM, Nuo Mi mailto:nuomi2...@gmail.com> > wrote: This happened many years ago. See the discussion

Re: [FFmpeg-devel] [PATCH v4 1/2][GSoC 2024] libavcodec/x86/vvc: Add AVX2 DMVR SAD functions for VVC

2024-05-20 Thread Ronald S. Bultje
Hi, one more, I forgot. On Sun, May 19, 2024 at 8:46 PM Stone Chen wrote: > +pw_1: dw 1 > [..] > +vpbroadcastw m4, [pw_1] > We typically suggest to use vpbroadcastd, not w (and then pw_1: times 2 dw 1). agner shows that on e.g. Haswell, the former (d) is 1 uops with 5 cycles

[FFmpeg-devel] [PATCH v2] avutil/hwcontext_videotoolbox: Set proper CVBuffer colorspace

2024-05-20 Thread Marvin Scholz
Fix #10884 --- libavutil/hwcontext_videotoolbox.c | 54 +- 1 file changed, 38 insertions(+), 16 deletions(-) diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c index 9f82b104c3..4a35bfc7ff 100644 ---

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext: Set proper CVBuffer colorspace

2024-05-20 Thread Zhao Zhili
> On May 20, 2024, at 09:12, Marvin Scholz wrote: > > Fix #10884 LGTM except the commit subject should mention videotoolbox or vt in short. > --- > libavutil/hwcontext_videotoolbox.c | 54 +- > 1 file changed, 38 insertions(+), 16 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH v8 12/15] avcodec/vaapi_encode: extract a free funtion to base layer

2024-05-20 Thread Wu, Tong1
>Subject: Re: [FFmpeg-devel] [PATCH v8 12/15] avcodec/vaapi_encode: extract a >free funtion to base layer > >On 18/04/2024 09:59, tong1.wu-at-intel@ffmpeg.org wrote: >> From: Tong Wu >> >> Signed-off-by: Tong Wu >> --- >> libavcodec/hw_base_encode.c | 11 +++ >>

[FFmpeg-devel] [PATCH v9 13/13] Changelog: add D3D12VA HEVC encoder changelog

2024-05-20 Thread tong1 . wu-at-intel . com
From: Tong Wu Signed-off-by: Tong Wu --- Changelog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Changelog b/Changelog index dd25715d6b..c3f802617f 100644 --- a/Changelog +++ b/Changelog @@ -10,7 +10,7 @@ version : - vf_scale supports secondary ref input and framesync

[FFmpeg-devel] [PATCH v9 07/13] avcodec/vaapi_encode: extract gop configuration and two options to base layer

2024-05-20 Thread tong1 . wu-at-intel . com
From: Tong Wu idr_interval and desired_b_depth are moved to HW_BASE_ENCODE_COMMON_OPTIONS. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 54 + libavcodec/hw_base_encode.h | 19 + libavcodec/vaapi_encode.c | 52

[FFmpeg-devel] [PATCH v9 12/13] avcodec: add D3D12VA hardware HEVC encoder

2024-05-20 Thread tong1 . wu-at-intel . com
From: Tong Wu This implementation is based on D3D12 Video Encoding Spec: https://microsoft.github.io/DirectX-Specs/d3d/D3D12VideoEncoding.html Sample command line for transcoding: ffmpeg.exe -hwaccel d3d12va -hwaccel_output_format d3d12 -i input.mp4 -c:v hevc_d3d12va output.mp4 Signed-off-by:

[FFmpeg-devel] [PATCH v9 11/13] avutil/hwcontext_d3d12va: add Flags for resource creation

2024-05-20 Thread tong1 . wu-at-intel . com
From: Tong Wu Flags field is added to support diffferent resource creation. Signed-off-by: Tong Wu --- doc/APIchanges| 3 +++ libavutil/hwcontext_d3d12va.c | 2 +- libavutil/hwcontext_d3d12va.h | 8 libavutil/version.h | 2 +- 4 files changed, 13

[FFmpeg-devel] [PATCH v9 10/13] avcodec/vaapi_encode: extract a free funtion to base layer

2024-05-20 Thread tong1 . wu-at-intel . com
From: Tong Wu Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 11 +++ libavcodec/hw_base_encode.h | 2 ++ libavcodec/vaapi_encode.c | 6 +- 3 files changed, 14 insertions(+), 5 deletions(-) diff --git a/libavcodec/hw_base_encode.c b/libavcodec/hw_base_encode.c index

[FFmpeg-devel] [PATCH v9 09/13] avcodec/vaapi_encode: extract a get_recon_format function to base layer

2024-05-20 Thread tong1 . wu-at-intel . com
From: Tong Wu Surface size and block size parameters are also moved to base layer. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 58 +++ libavcodec/hw_base_encode.h | 12 + libavcodec/vaapi_encode.c | 81 -

[FFmpeg-devel] [PATCH v9 08/13] avcodec/vaapi_encode: extract set_output_property to base layer

2024-05-20 Thread tong1 . wu-at-intel . com
From: Tong Wu Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 40 + libavcodec/hw_base_encode.h | 3 +++ libavcodec/vaapi_encode.c | 44 ++--- 3 files changed, 45 insertions(+), 42 deletions(-) diff --git

[FFmpeg-devel] [PATCH v9 06/13] avcodec/vaapi_encode: extract the init and close function to base layer

2024-05-20 Thread tong1 . wu-at-intel . com
From: Tong Wu Related parameters such as device context, frame context are also moved to base layer. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.c | 49 ++ libavcodec/hw_base_encode.h | 17 +++ libavcodec/vaapi_encode.c | 90

[FFmpeg-devel] [PATCH v9 05/13] avcodec/vaapi_encode: move the dpb logic from VAAPI to base layer

2024-05-20 Thread tong1 . wu-at-intel . com
From: Tong Wu Move receive_packet function to base. This requires adding *alloc, *issue, *output, *free as hardware callbacks. HWBaseEncodePicture is introduced as the base layer structure. The related parameters in VAAPIEncodeContext are also extracted to HWBaseEncodeContext. Then DPB

[FFmpeg-devel] [PATCH v9 04/13] avcodec/vaapi_encode: move pic->input_surface initialization to encode_alloc

2024-05-20 Thread tong1 . wu-at-intel . com
From: Tong Wu When allocating the VAAPIEncodePicture, pic->input_surface can be initialized right in the place. This movement simplifies the send_frame logic and is the preparation for moving vaapi_encode_send_frame to the base layer. Signed-off-by: Tong Wu --- libavcodec/vaapi_encode.c | 8

[FFmpeg-devel] [PATCH v9 03/13] avcodec/vaapi_encode: add picture type name to base

2024-05-20 Thread tong1 . wu-at-intel . com
From: Tong Wu Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.h | 5 + libavcodec/vaapi_encode.c | 4 +--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/hw_base_encode.h b/libavcodec/hw_base_encode.h index 5272f2836d..a578db8c06 100644 ---

[FFmpeg-devel] [PATCH v9 02/13] avcodec/vaapi_encode: add async_depth to common options

2024-05-20 Thread tong1 . wu-at-intel . com
From: Tong Wu Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.h | 10 +- libavcodec/vaapi_encode.c | 13 - libavcodec/vaapi_encode.h | 7 --- libavcodec/vaapi_encode_av1.c | 1 + libavcodec/vaapi_encode_h264.c | 1 +

[FFmpeg-devel] [PATCH v9 01/13] avcodec/vaapi_encode: introduce a base layer for vaapi encode

2024-05-20 Thread tong1 . wu-at-intel . com
From: Tong Wu Since VAAPI and future D3D12VA implementation may share some common parameters, a base layer encode context is introduced as vaapi context's base. Signed-off-by: Tong Wu --- libavcodec/hw_base_encode.h | 56 + libavcodec/vaapi_encode.h | 39

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_drm: Check ioctl in drm_map_frame() for failure

2024-05-20 Thread Rémi Denis-Courmont
Le 20 mai 2024 12:33:41 GMT+03:00, Andreas Rheinhardt a écrit : >Michael Niedermayer: >> Fixes: CID1583742 Unchecked return value >> >> Sponsored-by: Sovereign Tech Fund >> Signed-off-by: Michael Niedermayer >> --- >> libavutil/hwcontext_drm.c | 5 - >> 1 file changed, 4 insertions(+),

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_drm: Check ioctl in drm_map_frame() for failure

2024-05-20 Thread Michael Niedermayer
On Mon, May 20, 2024 at 11:33:41AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1583742 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavutil/hwcontext_drm.c | 5 - > > 1 file changed, 4

Re: [FFmpeg-devel] [PATCH 12/18] avcodec/vvcdec: inter, wait reference with a diffrent resolution

2024-05-20 Thread Nuo Mi
On Sun, May 19, 2024 at 11:21 PM Jean-Baptiste Kempf wrote: > Careful about the typo on "different" on the title of the patch. > Changed locally. Thank you, jb > > On Sun, 19 May 2024, at 13:27, Nuo Mi wrote: > > For RPR, the current frame may reference a frame with a different > resolution. >

Re: [FFmpeg-devel] [PATCH v4 1/2][GSoC 2024] libavcodec/x86/vvc: Add AVX2 DMVR SAD functions for VVC

2024-05-20 Thread Ronald S. Bultje
Hi, This is mostly good, the following is tiny nitpicks. On Sun, May 19, 2024 at 8:46 PM Stone Chen wrote: > +%macro INIT_OFFSET 6 ; src1, src2, dxq, dyq, off1, off2 > The macro is only used once, so you could inline it in the calling function. > > +imul%5, 128 > +imul

Re: [FFmpeg-devel] Samples with invalid permissions

2024-05-20 Thread Thilo Borgmann via ffmpeg-devel
Hi, There are a couple of files in samples.ffmpeg.org with invalid permissions, rsync is not able to read those: /V-codecs/UCOD/noextradata/CLV1_tony.mov /V-codecs/UCOD/noextradata/freddie2.mov /V-codecs/UCOD/noextradata/pittc.mov /V-codecs/UCOD/noextradata/smilla_cv.mov

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/vf_signalstats: Use av_dict_set_int() where appropriate

2024-05-20 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/vf_signalstats.c | 80 ++-- > 1 file changed, 40 insertions(+), 40 deletions(-) > > diff --git a/libavfilter/vf_signalstats.c b/libavfilter/vf_signalstats.c > index c2358c66cb..960899596f

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_drm: Check ioctl in drm_map_frame() for failure

2024-05-20 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: CID1583742 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavutil/hwcontext_drm.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavutil/hwcontext_drm.c