,
>
> On Wed, Jan 24, 2024 at 7:54 PM Dai, Jianhui J < jianhui.j.dai-at-
> intel@ffmpeg.org> wrote:
>
> > This commit adds value range checks to cbs_vp8_read_unsigned_le,
> > migrates fixed() to use it, and enforces little-endian consistency for
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Andreas Rheinhardt
> Sent: Monday, March 18, 2024 7:35 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Improve the
> bitstream position check
>
> Dai, Jianhu
The VP8 compressed header may not be byte-aligned due to boolean
coding. Round up byte count for accurate data positioning.
Signed-off-by: Jianhui Dai
---
libavcodec/cbs_vp8.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavcodec/cbs_vp8.c b/libavcodec/cbs_vp8.c
> -Original Message-
> From: ffmpeg-devel On Behalf Of Dai,
> Jianhui J
> Sent: Friday, February 23, 2024 8:43 AM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Improve the
> bit
> -Original Message-
> From: ffmpeg-devel On Behalf Of Dai,
> Jianhui J
> Sent: Thursday, January 25, 2024 8:54 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Use little endian in
> fixed()
>
> This com
> -Original Message-
> From: ffmpeg-devel On Behalf Of Dai,
> Jianhui J
> Sent: Thursday, January 25, 2024 8:54 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Improve the bitstream
> position check
>
> The VP8 compre
The VP8 compressed header may not be byte-aligned due to boolean
coding. Use bitwise comparison to prevent the potential overread.
Signed-off-by: Jianhui Dai
---
libavcodec/cbs_vp8.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavcodec/cbs_vp8.c
This commit adds value range checks to cbs_vp8_read_unsigned_le,
migrates fixed() to use it, and enforces little-endian consistency for
all read methods.
Signed-off-by: Jianhui Dai
---
libavcodec/cbs_vp8.c | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
diff
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Anton Khirnov
> Sent: Wednesday, January 24, 2024 7:41 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Use little endian in
> fixed() and improve the pos check
>
> -Original Message-
> From: ffmpeg-devel On Behalf Of Dai,
> Jianhui J
> Sent: Tuesday, January 23, 2024 10:58 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Use little endian in
> fixed() and improve the pos check
>
This commit adds value range checks to cbs_vp8_read_unsigned_le,
migrates fixed() to use it, and enforces little-endian consistency for
all read methods.
The VP8 compressed header may not be byte-aligned due to boolean coding.
Use bitwise comparison to prevent the potential overread.
TETS:
This commit adds value range checks to cbs_vp8_read_unsigned_le,
migrates fixed() to use it, and enforces little-endian consistency for
all read methods.
The VP8 compressed header may not be byte-aligned due to boolean coding.
Use bitwise comparison to prevent the potential overread.
TETS:
> -Original Message-
> From: ffmpeg-devel On Behalf Of Dai,
> Jianhui J
> Sent: Friday, January 5, 2024 8:35 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH v3] avcodec/cbs_vp8: Use little endian in
> fixed()
> and improve the pos check
>
This commit adds value range checks to cbs_vp8_read_unsigned_le,
migrates fixed() to use it, and enforces little-endian consistency for
all read methods.
The VP8 compressed header may not be byte-aligned due to boolean coding.
Use bitwise comparison to prevent the potential overread.
TETS:
This commit applies clang-format to the source and fixes typos.
TETS: ffmpeg -i fate-suite/vp8-test-vectors-r1/* -vcodec copy -bsf:v
trace_headers -f null -
Signed-off-by: Jianhui Dai
---
libavcodec/cbs_vp8.c | 52 ++--
1 file changed, 36 insertions(+),
> -Original Message-
> From: ffmpeg-devel On Behalf Of Michael
> Niedermayer
> Sent: Saturday, December 16, 2023 8:16 PM
> To: FFmpeg development discussions and patches
> Subject: [FFmpeg-devel] [PATCH 2/4] avcodec/cbs_vp8: Do not use assert to
> check for end
>
> Fixes: abort()
>
> -Original Message-
> From: ffmpeg-devel On Behalf Of Michael
> Niedermayer
> Sent: Sunday, December 17, 2023 9:19 PM
> To: FFmpeg development discussions and patches
> Subject: [FFmpeg-devel] [PATCH] avcodec/cbs_vp8: fix GetBitContext setup
>
> Fixes: abort()
> Fixes:
> -Original Message-
> From: ffmpeg-devel On Behalf Of Dai,
> Jianhui J
> Sent: Monday, December 18, 2023 3:59 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH v1] avcodec/cbs_vp8: Apply clang-format and
> fix typos.
>
> This commit applies
This commit applies clang-format to the source and fixes typos.
TETS: ffmpeg -i fate-suite/vp8-test-vectors-r1/* -vcodec copy -bsf:v
trace_headers -f null -
Signed-off-by: Jianhui Dai
---
libavcodec/cbs_vp8.c | 54 ++--
1 file changed, 37 insertions(+),
3 3:47 PM, Ronald S. Bultje wrote:
> > Hi,
> >
> > On Sun, Nov 12, 2023 at 8:53 PM Dai, Jianhui J <
> > jianhui.j.dai-at-intel@ffmpeg.org> wrote:
> >
> >> TESTS: ffmpeg -i fate-suite/vp8/frame_size_change.webm -vcodec copy
> >> -bsf:v trace
> VP8 codec bitstream
>
> Hi,
>
> On Sun, Nov 12, 2023 at 8:53 PM Dai, Jianhui J < jianhui.j.dai-at-
> intel@ffmpeg.org> wrote:
>
> > TESTS: ffmpeg -i fate-suite/vp8/frame_size_change.webm -vcodec copy
> > -bsf:v trace_headers -f null -
> >
>
> (I
> -Original Message-
> From: ffmpeg-devel On Behalf Of Leo
> Izen
> Sent: Monday, November 13, 2023 2:53 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v3] avcodec/vp8: Export
> `vp8_token_update_probs` variable
>
> On 11/12/23
This commit adds support for VP8 bitstream read methods to the cbs
codec. This enables the trace_headers bitstream filter to support VP8,
in addition to AV1, H.264, H.265, and VP9. This can be useful for
debugging VP8 stream issues.
The CBS VP8 implements a simple VP8 boolean decoder using
> -Original Message-
> From: Dai, Jianhui J
> Sent: Monday, November 13, 2023 9:44 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [PATCH v3] avcodec/vp8: Export `vp8_token_update_probs` variable
>
> This commit exports the `vp8_token_update_probs` variable to int
This commit exports the `vp8_token_update_probs` variable to internal
library scope to facilitate its reuse within the library.
Signed-off-by: Jianhui Dai
---
libavcodec/vp8.c | 2 +-
libavcodec/vp8data.c | 170 ++
libavcodec/vp8data.h | 171
>
> Hi,
>
> On Wed, Nov 8, 2023 at 10:55 AM Ronald S. Bultje wrote:
>
> > Hi Jianhui,
> >
> > On Tue, Nov 7, 2023 at 8:52 PM Dai, Jianhui J <
> > jianhui.j.dai-at-intel@ffmpeg.org> wrote:
> >
> >> The smaller delta patch
>
> Hi,
>
> On Tue, Nov 7, 2023 at 12:01 AM Dai, Jianhui J < jianhui.j.dai-at-
> intel@ffmpeg.org> wrote:
>
> >
> >
> > > -Original Message-
> > > From: ffmpeg-devel On Behalf Of
> > > Ronald S. Bultje
> > > Sent:
This commit exports the `vp8_token_default_probs` variable to internal
library scope to facilitate its reuse within the library.
Signed-off-by: Jianhui Dai
---
libavcodec/vp8.c | 2 +-
libavcodec/vp8data.c | 170 ++
libavcodec/vp8data.h | 171
codec bitstream
>
> Hi,
>
> On Mon, Nov 6, 2023 at 7:07 AM Ronald S. Bultje
> wrote:
>
> > On Sun, Nov 5, 2023 at 11:13 PM Dai, Jianhui J <
> > jianhui.j.dai-at-intel@ffmpeg.org> wrote:
> >
> >> > > +static const uint8_t vp8_token_up
This commit reorganizes the vp8data.[c|h] files, moving all of the
static data to vp8.c and keeping only the extern data in vp8data.[c|h].
It also exports the ff_vp8_token_default_probs variable.
Signed-off-by: Jianhui Dai
---
libavcodec/vp8.c | 602 -
codec bitstream
>
> Hi,
>
> On Sun, Nov 5, 2023 at 7:56 PM Dai, Jianhui J < jianhui.j.dai-at-
> intel@ffmpeg.org> wrote:
>
> > This commit adds support for VP8 bitstream read methods to the cbs
> > codec. This enables the trace_headers bitstream filter t
This commit adds support for VP8 bitstream read methods to the cbs
codec. This enables the trace_headers bitstream filter to support VP8,
in addition to AV1, H.264, H.265, and VP9. This can be useful for
debugging VP8 stream issues.
The CBS VP8 implements a simple VP8 boolean decoder using
> -Original Message-
> From: ffmpeg-devel On Behalf Of Mark
> Thompson
> Sent: Tuesday, October 17, 2023 5:14 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/cbs: Keep
> ff_cbs_trace_syntax_element
>
> On 10/10/2023
> -Original Message-
> From: Dai, Jianhui J
> Sent: Tuesday, October 10, 2023 10:57 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [PATCH v1] avcodec/cbs: Keep ff_cbs_trace_syntax_element
>
> Split ff_cbs_trace_syntax_element from ff_cbs_trace_read_log to decoup
Split ff_cbs_trace_syntax_element from ff_cbs_trace_read_log to decouple
the tracing from GetBitContext. This allows CBS implementations that do
not have a GetBitContext to directly use ff_cbs_trace_syntax_element to
trace syntax elements.
Signed-off-by: Jianhui Dai
---
libavcodec/cbs.c
> -Original Message-
> From: ffmpeg-devel On Behalf Of Dai,
> Jianhui J
> Sent: Friday, August 25, 2023 10:40 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH v4] avcodec/cbs_vp8: Add support for VP8
> codec bitstream
>
> This commit add
This commit adds support for VP8 bitstream read methods to the cbs
codec. This enables the trace_headers bitstream filter to support VP8,
in addition to AV1, H.264, H.265, and VP9. This can be useful for
debugging VP8 stream issues.
The CBS VP8 implements a simple VP8 boolean decoder with bounds
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Andreas Rheinhardt
> Sent: Saturday, August 12, 2023 5:41 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v3] avcodec/cbs_vp8: Add support for
> VP8 codec bitstream READ method
> -Original Message-
> From: ffmpeg-devel On Behalf Of Dai,
> Jianhui J
> Sent: Tuesday, June 20, 2023 9:42 AM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v3] avcodec/cbs_vp8: Add support for VP8
> codec b
> -Original Message-
> From: ffmpeg-devel On Behalf Of Dai,
> Jianhui J
> Sent: Monday, July 3, 2023 12:26 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH v5] avformat/ivfenc: Set the "number of
> frames" in IVF header
>
> Should
> -Original Message-
> From: ffmpeg-devel On Behalf Of Dai,
> Jianhui J
> Sent: Monday, July 3, 2023 12:26 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH v5] avformat/ivfenc: Set the "number of
> frames" in IVF header
>
> Should
Should set "number of frames" to bytes 24-27 of IVF header, not
duration.
It is described by [1], and confirmed by parsing all IVF files in [2].
This commit also updates the md5sum of refs to pass fate-cbs.
[1] Duck IVF - MultimediaWiki
https://wiki.multimedia.cx/index.php/Duck_IVF
[2]
Should set "number of frames" to bytes 24-27 of IVF header, not
duration.
It is described by [1], and confirmed by parsing all IVF files in [2].
This commit also updates the md5sum of refs to pass fate-cbs.
[1] Duck IVF - MultimediaWiki
https://wiki.multimedia.cx/index.php/Duck_IVF
[2]
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Anton Khirnov
> Sent: Sunday, July 2, 2023 8:59 PM
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/ivfenc: Set the "number of
> frames" in IVF header
>
>
of
> frames" in IVF header
>
> Hi,
>
> On Thu, Jun 29, 2023 at 8:54 AM Dai, Jianhui J < jianhui.j.dai-at-
> intel@ffmpeg.org> wrote:
>
> > Should set "number of frames" to bytes 24-27 of IVF header, not
> > duration.
> > It is described b
Should set "number of frames" to bytes 24-27 of IVF header, not
duration.
It is described by [1], and confirmed by parsing all IVF files in [2].
This commit also updates the md5sum of refs to pass fate-cbs.
[1] Duck IVF - MultimediaWiki
https://wiki.multimedia.cx/index.php/Duck_IVF
[2]
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Anton Khirnov
> Sent: Wednesday, June 28, 2023 11:25 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/ivfenc: Set the "number of
> frames" in IVF header
>
>
> -Original Message-
> From: Dai, Jianhui J
> Sent: Monday, June 5, 2023 8:54 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [PATCH v2] avformat/ivfenc: Set the "number of frames" in IVF header
>
> Should set "number of frames" t
> -Original Message-
> From: Dai, Jianhui J
> Sent: Thursday, June 8, 2023 11:18 AM
> To: FFmpeg development discussions and patches
> Subject: RE: [PATCH v3] avcodec/cbs_vp8: Add support for VP8 codec bitstream
> READ methods
>
>
>
> > -Origi
> -Original Message-
> From: ffmpeg-devel On Behalf Of Dai,
> Jianhui J
> Sent: Tuesday, May 30, 2023 4:00 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH v3] avcodec/cbs_vp8: Add support for VP8
> codec bitstream READ methods
>
> Th
Should set "number of frames" to bytes 24-27 of IVF header, not duration.
It is described by [1], and confirmed by parsing all IVF files in [2].
This commit also updates the md5sum of refs to pass fate-cbs.
[1] Duck IVF - MultimediaWiki
https://wiki.multimedia.cx/index.php/Duck_IVF
[2]
Should set "number of frames" to bytes 24-27 of IVF header, not duration.
It is described by [1]. Also confirm it by parsing IVF files in [2].
[1] Duck IVF - MultimediaWiki
https://wiki.multimedia.cx/index.php/Duck_IVF
[2] webm/vp8-test-vectors - Git at Google
> -Original Message-
> From: ffmpeg-devel On Behalf Of James
> Almer
> Sent: Monday, May 29, 2023 2:05 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/cbs_vp8: Add support for VP8
> codec bitstream READ methods
>
> On 5/23/2
This commit adds VP8 into cbs supported codec list, and enables the
`trace_headers` bitstream filters to support VP8, besides existing AV1,
H.264, H.265 and VP9. It can be useful to debug VP8 stream issues.
Only the READ methods `read_unit` and `split_fragment` are implemented,
the WRITE methods
This commit adds VP8 into cbs supported codec list, and enables the
`trace_headers` bitstream filters to support VP8, besides existing AV1,
H.264, H.265 and VP9. It can be useful to debug VP8 stream issues.
Only the READ methods `read_unit` and `split_fragment` are implemented,
the WRITE methods
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Andreas Rheinhardt
> Sent: Monday, May 15, 2023 4:10 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH V1] avcodec/cbs_vp8: Add support for VP8
> codec bitstream READ method
This commit adds VP8 into cbs supported codec list, and enables the
`trace_headers` bitstream filters to support VP8, besides existing AV1,
H.264, H.265 and VP9. It can be useful to debug VP8 stream issues.
Only the READ methods `read_unit` and `split_fragment` are implemented,
the WRITE methods
Avoid compiling error if included by multiple sources.
Signed-off-by: Jianhui Dai
---
libavcodec/Makefile | 4 ++--
libavcodec/vp8data.c | 42 ++
libavcodec/vp8data.h | 20 +---
3 files changed, 45 insertions(+), 21 deletions(-)
create
Of James Almer
Sent: Tuesday, May 9, 2023 10:04 AM
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] vcodec/vp8data: Make ff_vp8_dct_cat_prob
static
On 5/8/2023 10:49 PM, Dai, Jianhui J wrote:
> Avoid compiling error if included by multiple sources.
>
> Signed-off-by: Ji
Avoid compiling error if included by multiple sources.
Signed-off-by: Jianhui Dai
---
libavcodec/vp8data.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/vp8data.h b/libavcodec/vp8data.h
index 1fcce134eb..ac4af5f733 100644
--- a/libavcodec/vp8data.h
+++
Apologize for segfaults.
I do pass FATE and some basic tests myself before submit for review.
Fixed locally and wait for other review comments.
Thanks,
Jianhui Dai
-Original Message-
From: ffmpeg-devel On Behalf Of Michael
Niedermayer
Sent: Wednesday, March 11, 2020 5:56 PM
To: FFmpeg
Thanks for clarify the packets-to-frames delay. I will respect that decoder
design principle.
Add a few backgrounds for this issue.
I work on 4K@30fps streaming playback on 16-cores host.
Initially I use FF_THREAD_SLICE, but "avcodec_send_packet" takes ~100ms, only
10fps playback (I want
frame to
reduce latency
On Wed, 11 Mar 2020 at 02:59, Dai, Jianhui J
wrote:
> It does not break FFmpeg output frames management logic (e.g.
> h264_select_output_frame), just enter that phase earlier.
>
> Perhaps my understanding is not correct.
> In my opinions, render sh
As reply in another thread, the sequence of output frames still follows
standard, like display order POC in H264.
Big enough frame cache can guarantee deterministic delay in some extent, but
not always (decoding time > caching time).
E.g. in FF_THREAD_FRAME 4320x2160 30fps video streaming, 4
10:41 AM
To: FFmpeg development discussions and patches
Subject: Re: [FFmpeg-devel] [PATCH] pthread_frame: attempt to get frame to
reduce latency
On Wed, 11 Mar 2020 at 02:29, Dai, Jianhui J
wrote:
> Thanks, I will update the commit message.
>
> I test it with FFmpeg native sw H26
Thanks, I will update the commit message.
I test it with FFmpeg native sw H264 decoder.
In previous FF_THREAD_FRAME, the latency is constant as N ( = thread_count -
1) frames.
It won't sync thread state until no idle threads available, therefore N frames
are cached internal, even some frames
66 matches
Mail list logo
