Re: [FFmpeg-devel] [PATCH v4] lavc/libvpxenc: add screen-content-mode option

2024-02-13 Thread Dariusz Marcinkiewicz via ffmpeg-devel
Hello. On Tue, Feb 13, 2024 at 12:12 AM James Zern wrote: > [...] > > +@item screen-content-mode > > +Screen content mode, one of: off (0), screen (1), screen with more > > aggressive rate control (2). > > + > > Move this above 'VP9-specific options' and add a section for VP8. Also > reword

[FFmpeg-devel] [PATCH v5] lavc/libvpxenc: add screen-content-mode option

2024-02-12 Thread Dariusz Marcinkiewicz via ffmpeg-devel
This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. Co-authored-by: Erik Språng Signed-off-by: Dariusz Marcinkiewicz --- doc/encoders.texi | 6 ++ libavcodec/libvpxenc.c | 13 + libavcodec/version.h | 2 +- 3 files changed, 20 insertions(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH v3] lavc/libvpxenc: add screen-content-mode option

2024-02-10 Thread Dariusz Marcinkiewicz via ffmpeg-devel
Hello. On Fri, Feb 9, 2024 at 7:28 PM James Zern wrote: > Just sent v4, which addresses the below comments. Thank you. > On Thu, Feb 8, 2024 at 1:58 PM Dariusz Marcinkiewicz via ffmpeg-devel > wrote: ... > > --- a/libavcodec/libvpxenc.c > > +++ b/libavcodec/libvpxenc.c

[FFmpeg-devel] [PATCH v4] lavc/libvpxenc: add screen-content-mode option

2024-02-10 Thread Dariusz Marcinkiewicz via ffmpeg-devel
This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. Co-authored-by: Erik Språng Signed-off-by: Dariusz Marcinkiewicz --- doc/encoders.texi | 3 +++ libavcodec/libvpxenc.c | 11 +++ libavcodec/version.h | 2 +- 3 files changed, 15 insertions(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH v2] libavcodec: add tune_content option also for VP8.

2024-02-08 Thread Dariusz Marcinkiewicz via ffmpeg-devel
Hi. On Thu, Feb 8, 2024 at 7:13 AM James Zern wrote: > > Hi, > > On Wed, Feb 7, 2024 at 8:04 AM Dariusz Marcinkiewicz via ffmpeg-devel > wrote: > > > > This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. > > > > For the subject u

[FFmpeg-devel] [PATCH v3] lavc/libvpxenc: add screen-content-mode option

2024-02-08 Thread Dariusz Marcinkiewicz via ffmpeg-devel
This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx and makes us retry encode if screen_content_mode == 2 and no output was produced by encoder. Co-authored-by: Erik Språng Signed-off-by: Dariusz Marcinkiewicz --- doc/encoders.texi | 3 +++ libavcodec/libvpxenc.c | 57

[FFmpeg-devel] [PATCH v2] libavcodec: add tune_content option also for VP8.

2024-02-07 Thread Dariusz Marcinkiewicz via ffmpeg-devel
This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. Changes since v1: - Put the new param initialzation in the right place, - Account for cases when the encoder's output is queued up. Co-authored-by: Erik Språng Signed-off-by: Dariusz Marcinkiewicz --- doc/encoders.texi | 7

[FFmpeg-devel] [PATCH v2] libavcodec: add tune_content option also for VP8.

2024-01-31 Thread Dariusz Marcinkiewicz via ffmpeg-devel
This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. Changes since v1: - Put the new param initialzation in the right place, - Account for cases when the encoder's output is queued up. Co-authored-by: Erik Språng Signed-off-by: Dariusz Marcinkiewicz --- doc/encoders.texi | 7

Re: [FFmpeg-devel] [PATCH] libavcodec: add tune_content option also for VP8.

2024-01-29 Thread Dariusz Marcinkiewicz via ffmpeg-devel
Please ignore this version of the patch. I'll send out v2 soon. Apologies for the noise. On Thu, Jan 25, 2024 at 6:13 PM Dariusz Marcinkiewicz wrote: > This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. > > Change authored by Erik Språng > > Signed-off-by: Dariusz Marcinkiewicz >

[FFmpeg-devel] [PATCH] libavcodec: add tune_content option also for VP8.

2024-01-25 Thread Dariusz Marcinkiewicz via ffmpeg-devel
This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. Change authored by Erik Språng Signed-off-by: Dariusz Marcinkiewicz --- doc/encoders.texi | 7 +-- libavcodec/libvpxenc.c | 35 ++- 2 files changed, 39 insertions(+), 3 deletions(-) diff