Re: [FFmpeg-devel] what AVCodecID to use for copying full vanc data between .mxf and .mcc

2025-07-09 Thread Devin Heitmueller
right ff_stream_add_bitstream_filter calls in the > muxers' init functions? Yes. You can see an example of it here: https://github.com/LTNGlobal-opensource/FFmpeg-ltn/blob/lted2b/libavdevice/decklink_enc.cpp#L860 Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communicati

Re: [FFmpeg-devel] what AVCodecID to use for copying full vanc data between .mxf and .mcc

2025-07-08 Thread Devin Heitmueller
go back and forth between 608 packets and SEI data embedded within the video stream (in either direction: SEI to 608 packet streams, or 608 packet streams into SEI). Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: d

Re: [FFmpeg-devel] [PATCH] Playout to DeckLink will wait for all buffered frames before stopping.

2025-07-08 Thread Devin Heitmueller
approach. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman

Re: [FFmpeg-devel] [PATCH] Playout to DeckLink will wait for all buffered frames before stopping.

2025-07-08 Thread Devin Heitmueller
immediately). But I think my use case is far less common than people who simply want to play out their file based content to the Blackmagic device. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-100

Re: [FFmpeg-devel] [PATCH] Playout to DeckLink will wait for all buffered frames before stopping.

2025-07-08 Thread Devin Heitmueller
\n", buffered); > +if (buffered < 5) { > +usleep(1); > +} else { > +usleep(300); > +} The sleep calls should use av_usleep(), which is portable and you don't need unistd.h. Also, there should be some li

Re: [FFmpeg-devel] [PATCH] avcodec/itut35: always check the provider code and country code together

2025-06-12 Thread Devin Heitmueller
nding organization. > Add a constant for AOM. > Write all constants with 4 hex digits to make it clear that they are 2-byte > ids. While it's a bit more annoying, I think the checks should actually be inverted. It should be looking at the country codes first, and then within those co

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Passthrough SCTE 35 Current behavior breaks SCTE 35 by wrapping it in a PES packet, this adds the logic for the SCTE 35 messages to be passed through cleanl

2025-06-11 Thread Devin Heitmueller
rs ago, which also accommodates modifying the pts_adjust field (which is mandatory if the output stream's clocks are rebased). https://ffmpeg.org/pipermail/ffmpeg-devel/2023-July/312417.html Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 36

Re: [FFmpeg-devel] [RFC] Subtitle Filtering Ramp-Up

2025-06-06 Thread Devin Heitmueller
aragraphs lamenting how bad softworks patches are, when you could have proven your point with a single command line (which would have demonstrated your concerns definitively). Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglob

Re: [FFmpeg-devel] [RFC] Subtitle Filtering Ramp-Up

2025-06-03 Thread Devin Heitmueller
and I'm not confident anyone has proposed anything that actually accommodates the use case he has raised. I've seen lots of, "You MUST use the native time fields", but nobody saying, "Oh given what you're trying to accomplish here's a better approach..."

Re: [FFmpeg-devel] STF RaptorQ

2025-05-23 Thread Devin Heitmueller
Hello Michael, On Fri, May 23, 2025 at 5:45 AM Michael Niedermayer wrote: > On Thu, May 22, 2025 at 07:55:40PM -0400, Devin Heitmueller wrote: > > On Thu, May 22, 2025 at 7:42 PM Kieran Kunhya via ffmpeg-devel > > wrote: > > > I wanted to put on the record that adding

Re: [FFmpeg-devel] STF RaptorQ

2025-05-23 Thread Devin Heitmueller
east for me personally, I am not confident I could argue that the RaptorQ work proposed falls within that definition. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com _

Re: [FFmpeg-devel] STF RaptorQ

2025-05-23 Thread Devin Heitmueller
source projects).Like I mentioned, > > I believe the STF is not maintenance-only, or so I gather. Yeah, I suspect much of this comes down to a discussion on what STF expects/requires funds to be used for. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301)

Re: [FFmpeg-devel] STF RaptorQ

2025-05-22 Thread Devin Heitmueller
proving the RIST or SRT integration, which is where most of the industry is putting their energy. I agree with Kieran that this seems to largely be outside the STF objectives (i.e. sustainability for open source projects). Devin (1) https://trac.ffmpeg.org/wiki/SponsoringPrograms/STF/2025 --

Re: [FFmpeg-devel] [PATCH] lavc: Replace 181 magic number with ITU_T_T35_COUNTRY_CODE_US

2025-03-31 Thread Devin Heitmueller
, and they are well aware of the problem (in fact the ticket includes some discussion I had with one of the developers). https://github.com/obsproject/obs-studio/issues/4006 Devin -- Devin Heitmueller, LTN Global Communications o:m: w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.

Re: [FFmpeg-devel] [PATCH] lavc: Replace 181 magic number with ITU_T_T35_COUNTRY_CODE_US

2025-03-10 Thread Devin Heitmueller
ng that many decoders don't support the full character set, where it works fine with the characters found typically in English and Spanish, but overlooks characters from Western Europe. Same goes for transcoders; even some expensive commercial transcoders I can think of don't work wit

Re: [FFmpeg-devel] Advice on patch: Decklink flushes most buffered frames at end of video instead of displaying them

2025-03-05 Thread Devin Heitmueller
e case). The correct fix is simply to change the StopScheduledPlayback to not exit immediately (for which there is a specific argument, IIRC). You shouldn't need to do any sort of counters/timers to achieve the desired behavior. If you still can't get it to work, let me know and I'll take a lo

Re: [FFmpeg-devel] [PATCH] lavc: Replace 181 magic number with ITU_T_T35_COUNTRY_CODE_US

2025-03-04 Thread Devin Heitmueller
ercial hardware encoders, and couldn't find a single one that specified the 608 language in XDS (if I found cases where it was, I was prepared to submit patches to VLC to show the language in the subtitle dropdown menu). Devin -- Devin Heitmueller, Senior Software Engi

Re: [FFmpeg-devel] [PATCH] lavc: Replace 181 magic number with ITU_T_T35_COUNTRY_CODE_US

2025-03-03 Thread Devin Heitmueller
ions are intended to serve other countries, the country code will stay the same (defining the country code for individual languages goes in the PMT). Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel

Re: [FFmpeg-devel] [PATCH] doc/developer: Better {} style rule

2025-02-28 Thread Devin Heitmueller
tool exists. Cheers, Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/ma

Re: [FFmpeg-devel] [PATCH] doc/developer: Better {} style rule

2025-02-27 Thread Devin Heitmueller
omated means to run the check his/herself prior to submission. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [BASIC QUESTION] Profiling tool for ffmpeg

2025-02-24 Thread Devin Heitmueller
ing the results, but the GUI makes that *much* easier than any command line perf based solution. But yeah, as Kieran pointed out, for any of these solutions you should be using the version of the ffmpeg binary that contains debug info. Devin -- Devin Heitmueller, Senior Software Eng

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix get_eia608_packet c608 caption reformatting

2025-02-13 Thread Devin Heitmueller
rge Sebastian's patch as it's simpler. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix get_eia608_packet c608 caption reformatting

2025-02-13 Thread Devin Heitmueller
accordingly. I tried it two years ago (which is how I found a bug in it), but it would be good to have someone else test it before it gets merged. Thanks, Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e

Re: [FFmpeg-devel] [PATCH] avformat/mov: Fix get_eia608_packet c608 caption reformatting

2025-02-13 Thread Devin Heitmueller
to make sure it covers the cases you care about: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2023-June/310456.html Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel.

Re: [FFmpeg-devel] Captions SCC

2025-02-09 Thread Devin Heitmueller
ost of my work in captioning within ffmpeg was funded by my employer, and most of the work I did improving 608 captions in VLC was financed by contract work I did for commercial customers who were embedding VLC into solutions and needed decent caption support. Devin -- Devin Heitmueller, Senior S

Re: [FFmpeg-devel] Captions SCC

2025-02-08 Thread Devin Heitmueller
what you're trying to accomplish I may be able to offer some code up to help. If nothing else, I've got *alot* of experience in this area and might be able to offer some feedback. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 3

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devin Heitmueller
ll the different combinations of muxer/demuxer/encoder/decoders that support captions. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devin Heitmueller
suming Zack confirms it's fixed for him there is no further need for discussion. Also, Zack, please don't top post. If you don't know what that means, look it up in Google. Thanks, Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 36

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devin Heitmueller
On Fri, Feb 7, 2025 at 2:55 PM Devin Heitmueller wrote: > And encoder itself should be required. Correction: I meant to say "An encoder itself should *not* be required". Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devin Heitmueller
Packets, and it's likely the video framerate would have to be explicitly specified (unless we're able to determine it in the MP4 muxer and automatically instantiate the BSF with the correct parameters). Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Comm

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devin Heitmueller
I would recommend if you decide to open a ticket to either rename the files or change the commands so whoever tries to reproduce the issue knows they are working with the exact same files. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https:/

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devin Heitmueller
t manner (e.g. deals with cases where an incorrect amount of padding is in the source stream, the 608 tuples violate the interleaving rules, etc). Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Devin Heitmueller
quot;cc_repack" filter and framerate conversion in the first part of the command before sending the CC data to before handing off the data to the subcc output. That said, I've never tried it and would probably have to play around with it to get the syntax right. Devin -- Devin Heitmuel

Re: [FFmpeg-devel] Up to Date DeckLink Support broken in FFMPEG

2025-02-06 Thread Devin Heitmueller
APIs and increase the minimum supported version to 13.3, I would encourage you to be careful to not force everybody to update to the latest version and consider a path that doesn't cause breakage (we typically do this with #defines). Devin -- Devin Heitmueller, Senior Software Engineer

Re: [FFmpeg-devel] FOSDEM meeting

2025-02-01 Thread Devin Heitmueller
On Sat, Jan 25, 2025, 11:09 PM Marth64 wrote: > > Hello, > > Looking forward to it. Has a time/location been set for this? Thanks, Devin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubsc

Re: [FFmpeg-devel] [PATCH v2 00/11] fix broken CC detection and ffprobe fields (cover letter)

2025-01-27 Thread Devin Heitmueller
7;t contain captions and the encoder/transcoder isn't smart enough to generate empty caption packets and include them in the output. That said, I think it's very defensible to say, "We don't set the flag saying captions are present if not detected within the probing window". Devi

Re: [FFmpeg-devel] [PATCH v0] Implement promeg decoder.

2025-01-17 Thread Devin Heitmueller
> [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Freedom in capitalist society always remains about the same as it was in > ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin > ___ &

Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec/cuvid: introduce a ringbuffer to reattach additional data

2024-12-03 Thread Devin Heitmueller
nding on codec/resolution/framerate). Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [RFC] AVFilter

2024-10-15 Thread Devin Heitmueller
since I'm not the one who is doing that work it wouldn't be appropriate for me to say, "it's worth it". But as a user of the libraries I will say it would indeed be very nice if I could have out-of-tree filters. Devin -- Devin Heitmueller, Senior Software Engineer LTN Glo

Re: [FFmpeg-devel] [PATCH 2/2] checkasm/h264dsp: support checking more idct depths

2024-05-02 Thread Devin Heitmueller
+for (i = 0; i < 5; i++) { > +bit_depth = depths[i]; Perhaps this should use FF_ARRAY_ELEMS(depths) rather than a hard-coded "5"? Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmu

[FFmpeg-devel] Inconsistent usage of AVFieldOrder values

2024-04-22 Thread Devin Heitmueller
gnize this may cause some breakage in existing applications. Thoughts? Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com ___ ffmpeg-devel

[FFmpeg-devel] FFmpeg table at NAB

2024-04-16 Thread Devin Heitmueller
nsidered to be a competitor to ffmpeg. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https:/

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

2024-02-19 Thread Devin Heitmueller
on't have the expertise necessary to modify the actual libavcodec HEVC decoder to do the interleaving. If somebody were to fix the decoder itself then I could throw away all those hacks. Regards, Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-07 Thread Devin Heitmueller
e impact and conclude whether it's worth it, but it doesn't effect any of my use cases and (in my opinion) there are likely to be far fewer users impacted by such a change. This feels like just the sort of thing the TC is meant to discuss/resolve. And the fact that your positio

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread Devin Heitmueller
On Mon, Feb 5, 2024 at 3:31 PM Anton Khirnov wrote: > > Quoting Devin Heitmueller (2024-02-05 21:13:22) > > On Mon, Feb 5, 2024 at 2:59 PM Anton Khirnov wrote: > > > > > > It should be available in all relevant modern compilers and will allow > > > u

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-05 Thread Devin Heitmueller
on what major platforms/versions we expect to be able to build on. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-01-23 Thread Devin Heitmueller
ious one. I knew the Dolby-E packet had to be cotimed with the video frame, but was unaware that the S302M packets also had that requirement. But yeah, now that I look at the spec I see that to be the case (S302M-2007 Sec 6.10). Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Comm

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-01-23 Thread Devin Heitmueller
ad, and use that to determine the actual PTS of the embedded non-PCM packet? Unless I"m misreading the code, it seems like it's simply setting the PTS of the non-pcm packet to be the PTS of the original S302 packet, which will result in incorrect A/V sync. Devin -- Devin Heitmueller, Se

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

2023-11-28 Thread Devin Heitmueller
On Tue, Nov 28, 2023 at 4:22 AM Michael Riedl wrote: > > Ping My apologies, I saw your remarks that this didn't change backward compatibility but failed to reply. I have no further issues with this patch. Thanks, Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Com

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: TC/CC elections

2023-11-28 Thread Devin Heitmueller
t out a few hours ago, to tell everyone the first vote is being thrown away (without revealing the voting results), and give everyone the opportunity to vote again now that it's been made clear how the weighting works. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communicati

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

2023-11-02 Thread Devin Heitmueller
gt;signal_loss_action = SIGNAL_LOSS_NONE" Even though the option is deprecated, it should still continue to work until it is completely removed. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin

Re: [FFmpeg-devel] [PATCH v4 2/4] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-08-10 Thread Devin Heitmueller
to solve some orthogonal problem that I'm not really worried about isn't grounds for rejecting it. I would be happy to see other developers weigh in, or if Kieran's is the final word then I would like to see this reviewed by the TC. I'm making a genuine effort to improve the s

Re: [FFmpeg-devel] [PATCH v4 2/4] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-08-10 Thread Devin Heitmueller
On Thu, Aug 10, 2023 at 8:48 AM Kieran Kunhya wrote: > > > > On Thu, 10 Aug 2023 at 08:41, Kieran Kunhya wrote: >> >> On Thu, 10 Aug 2023 at 08:20, Devin Heitmueller >> wrote: >>> >>> On Thu, Aug 10, 2023 at 8:13 AM Kieran Kunhya wrote: >&

Re: [FFmpeg-devel] [PATCH v4 2/4] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-08-10 Thread Devin Heitmueller
Thanks, Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman

Re: [FFmpeg-devel] [PATCH v4 2/4] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-08-09 Thread Devin Heitmueller
pt to tackle the problem of the SCTE-35 timestamp not being as accurate as it could be. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com ___

Re: [FFmpeg-devel] [PATCH v4 0/4] Add passthrough support for SCTE-35

2023-08-08 Thread Devin Heitmueller
On Fri, Aug 4, 2023 at 7:16 AM Devin Heitmueller wrote: > > On Mon, Jul 31, 2023 at 9:38 AM Devin Heitmueller > wrote: > > > > Properly set up the MPEG-TS mux and recalculate the pts_adjust field > > in SCTE_35 packets, such that a user can transparently pass throu

Re: [FFmpeg-devel] [PATCH v4 0/4] Add passthrough support for SCTE-35

2023-08-04 Thread Devin Heitmueller
On Mon, Jul 31, 2023 at 9:38 AM Devin Heitmueller wrote: > > Properly set up the MPEG-TS mux and recalculate the pts_adjust field > in SCTE_35 packets, such that a user can transparently pass through > SCTE-35 streams when both the input and output are MPEG-TS. > > This patch

[FFmpeg-devel] [PATCH v4 4/4] bsf: Add new bitstream filter to set SCTE-35 pts_adjustment when reclocking

2023-07-31 Thread Devin Heitmueller
roving the patch. Signed-off-by: Devin Heitmueller --- doc/bitstream_filters.texi | 9 libavcodec/Makefile | 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/scte35ptsadjust_bsf.c | 100 +++ libavformat/mpegtsenc.c

[FFmpeg-devel] [PATCH v4 3/4] mpegtsenc: Add support for output of SCTE-35 streams over TS

2023-07-31 Thread Devin Heitmueller
recompute the PTS values. Signed-off-by: Devin Heitmueller --- libavformat/mpegts.h| 1 + libavformat/mpegtsenc.c | 74 ++--- libavformat/mux.c | 6 ++-- 3 files changed, 75 insertions(+), 6 deletions(-) diff --git a/libavformat/mpegts.h b

[FFmpeg-devel] [PATCH v4 2/4] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-07-31 Thread Devin Heitmueller
We need the original PTS value in order to do subsequent processing, so set it as packet side data. Signed-off-by: Devin Heitmueller --- libavformat/mpegts.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 0b3edda

[FFmpeg-devel] [PATCH v4 1/4] avcodec: Add new side data type to contain original PTS value

2023-07-31 Thread Devin Heitmueller
. Signed-off-by: Devin Heitmueller --- libavcodec/defs.h | 12 libavcodec/packet.h | 11 +++ 2 files changed, 23 insertions(+) diff --git a/libavcodec/defs.h b/libavcodec/defs.h index fbe3254..ff50d25 100644 --- a/libavcodec/defs.h +++ b/libavcodec/defs.h @@ -28,6 +28,7

[FFmpeg-devel] [PATCH v4 0/4] Add passthrough support for SCTE-35

2023-07-31 Thread Devin Heitmueller
Properly set up the MPEG-TS mux and recalculate the pts_adjust field in SCTE_35 packets, such that a user can transparently pass through SCTE-35 streams when both the input and output are MPEG-TS. This patch series updated to reflect feedback from James Almer. Devin Heitmueller (4): avcodec

Re: [FFmpeg-devel] [PATCH v3 0/4] Add passthrough support for SCTE-35

2023-07-27 Thread Devin Heitmueller
On Fri, Jul 21, 2023 at 4:38 PM Devin Heitmueller wrote: > > Properly set up the MPEG-TS mux and recalculate the pts_adjust field > in SCTE_35 packets, such that a user can transparently pass through > SCTE-35 streams when both the input and output are MPEG-TS. > > This pa

[FFmpeg-devel] [RFC][PATCH 3/3] decklink: Add support for output of HDR metadata

2023-07-21 Thread Devin Heitmueller
in-house content as well as samples from 4kmedia.org. Testing was done with the Decklink 8K Pro and the Duo2 with 12.5.1 firmware, as well as with the Duo2 with 10.11.2 (before it supported HDR) to ensure there are no regressions. Signed-off-by: Devin Heitmueller --- libavdevice

[FFmpeg-devel] [RFC][PATCH 2/3] v210enc: Add HDR metadata passthrough

2023-07-21 Thread Devin Heitmueller
In order to implement HDR output for decklink we need to expose the side data containing the mastering and light level info. Add the two additional types of side table to those which are passed through. Signed-off-by: Devin Heitmueller --- libavcodec/v210enc.c | 2 ++ 1 file changed, 2

[FFmpeg-devel] [RFC][PATCH 1/3] v210enc: Refactor side data passthrough

2023-07-21 Thread Devin Heitmueller
As the number of side-data items we pass through increases, refactor the values into a table in the same manner as done in decode.c. In the future it might make sense to make this a shared function which can be reused by other encoders. But for now keep it local. Signed-off-by: Devin

[FFmpeg-devel] [RFC][PATCH 0/3] Add support for decklink HDR metadata output

2023-07-21 Thread Devin Heitmueller
This patch series includes support for output of HDR metadata, as well as a change to the v210 encoder to ensure it is passed through to the decklink libavdevice. Comments/feedback are welcome. Devin Heitmueller (3): v210enc: Refactor side data passthrough v210enc: Add HDR metadata

[FFmpeg-devel] [PATCH v3 4/4] bsf: Add new bitstream filter to set SCTE-35 pts_adjustment when reclocking

2023-07-21 Thread Devin Heitmueller
h. Signed-off-by: Devin Heitmueller --- doc/bitstream_filters.texi | 9 libavcodec/Makefile | 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/scte35ptsadjust_bsf.c | 103 +++ libavformat/mpegtsenc.c | 2 + 5 fil

[FFmpeg-devel] [PATCH v3 3/4] mpegtsenc: Add support for output of SCTE-35 streams over TS

2023-07-21 Thread Devin Heitmueller
recompute the PTS values. Signed-off-by: Devin Heitmueller --- libavformat/mpegts.h| 1 + libavformat/mpegtsenc.c | 74 ++--- libavformat/mux.c | 6 ++-- 3 files changed, 75 insertions(+), 6 deletions(-) diff --git a/libavformat/mpegts.h b

[FFmpeg-devel] [PATCH v3 1/4] avcodec: Add new side data type to contain original PTS value

2023-07-21 Thread Devin Heitmueller
. Signed-off-by: Devin Heitmueller --- libavcodec/defs.h | 12 libavcodec/packet.h | 11 +++ 2 files changed, 23 insertions(+) diff --git a/libavcodec/defs.h b/libavcodec/defs.h index fbe3254..ff50d25 100644 --- a/libavcodec/defs.h +++ b/libavcodec/defs.h @@ -28,6 +28,7

[FFmpeg-devel] [PATCH v3 2/4] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-07-21 Thread Devin Heitmueller
We need the original PTS value in order to do subsequent processing, so set it as packet side data. Signed-off-by: Devin Heitmueller --- libavformat/mpegts.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 0b3edda

[FFmpeg-devel] [PATCH v3 0/4] Add passthrough support for SCTE-35

2023-07-21 Thread Devin Heitmueller
been dropped as the behavior is no longer reproducible in master. Devin Heitmueller (4): avcodec: Add new side data type to contain original PTS value mpegts: Stash original PTS for SCTE-35 sections for processing later mpegtsenc: Add support for output of SCTE-35 streams over TS bsf: Add

Re: [FFmpeg-devel] [PATCH 1/7] lavu: add ecinfo sidedata

2023-07-21 Thread Devin Heitmueller
ERSION_MINOR 14 > +#define LIBAVUTIL_VERSION_MINOR 15 > #define LIBAVUTIL_VERSION_MICRO 100 > > #define LIBAVUTIL_VERSION_INT AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \ > -- > 2.41.0 > > ___ > ffmpeg-devel mailing list > f

Re: [FFmpeg-devel] [PATCH v2 4/5] mpegtsenc: Don't periodically announce PCR on SCTE-35 streams

2023-07-05 Thread Devin Heitmueller
tter document the behavior I am seeing and update the patch description so it's more clear why it is needed. Regards, Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com __

[FFmpeg-devel] [PATCH v2 5/5] bsf: Add new bitstream filter to set pts_adjustment when reclocking

2023-07-03 Thread Devin Heitmueller
h. Signed-off-by: Devin Heitmueller --- doc/bitstream_filters.texi | 9 libavcodec/Makefile | 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/scte35ptsadjust_bsf.c | 103 +++ libavformat/mpegtsenc.c | 2 + 5 fil

[FFmpeg-devel] [PATCH v2 4/5] mpegtsenc: Don't periodically announce PCR on SCTE-35 streams

2023-07-03 Thread Devin Heitmueller
right" fix should be for this, but for now just disable all periodic sending of PCR-only packets on SCTE-35 streams. Signed-off-by: Devin Heitmueller --- libavformat/mpegtsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtse

[FFmpeg-devel] [PATCH v2 3/5] mpegtsenc: Add support for output of SCTE-35 streams over TS

2023-07-03 Thread Devin Heitmueller
recompute the PTS values. Signed-off-by: Devin Heitmueller --- libavformat/mpegts.h| 1 + libavformat/mpegtsenc.c | 74 ++--- libavformat/mux.c | 6 ++-- 3 files changed, 75 insertions(+), 6 deletions(-) diff --git a/libavformat/mpegts.h b

[FFmpeg-devel] [PATCH v2 1/5] avcodec: Add new side data type to contain original PTS value

2023-07-03 Thread Devin Heitmueller
. Signed-off-by: Devin Heitmueller --- libavcodec/defs.h | 12 libavcodec/packet.h | 11 +++ 2 files changed, 23 insertions(+) diff --git a/libavcodec/defs.h b/libavcodec/defs.h index deadfe7..173020f 100644 --- a/libavcodec/defs.h +++ b/libavcodec/defs.h @@ -28,6 +28,7

[FFmpeg-devel] [PATCH v2 0/5] Add passthrough support for SCTE-35

2023-07-03 Thread Devin Heitmueller
improvements suggested by Andreas Rheinhardt to the BSF filter. Devin Heitmueller (5): avcodec: Add new side data type to contain original PTS value mpegts: Stash original PTS for SCTE-35 sections for processing later mpegtsenc: Add support for output of SCTE-35 streams over TS mpegtsenc

[FFmpeg-devel] [PATCH v2 2/5] mpegts: Stash original PTS for SCTE-35 sections for processing later

2023-07-03 Thread Devin Heitmueller
We need the original PTS value in order to do subsequent processing, so set it as packet side data. Signed-off-by: Devin Heitmueller --- libavformat/mpegts.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 0b3edda

Re: [FFmpeg-devel] [PATCH v2 0/7] Misc AFD improvements and support for Bar Data

2023-07-03 Thread Devin Heitmueller
EVC stuff is submitted it makes sense to generate a short sample for FATE usage. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e: devin.heitmuel...@ltnglobal.com ___ ffmpeg-

Re: [FFmpeg-devel] [PATCH v2 3/7] avcodec/avframe: add new side data types for Bar Data

2023-07-03 Thread Devin Heitmueller
ould make it a generic > bound0, bound1 or a union instead. It was only an extra eight bytes per video frame, so I wasn't particularly worried about the size. That said, perhaps a union would make it more clear that you can't set both simultaneously. Devin -- Devin Heitm

Re: [FFmpeg-devel] [PATCH v2 6/7] v210enc: Pass through bar data

2023-06-30 Thread Devin Heitmueller
Hi Kieran, On Fri, Jun 30, 2023 at 6:41 PM Kieran Kunhya wrote: > > On Fri, 30 Jun 2023 at 21:42, Devin Heitmueller > wrote: >> >> When encoding to V210, make sure the bar side data makes it through >> in the resulting AVPacket. This is needed so the decklink outpu

[FFmpeg-devel] [PATCH v2 7/7] avdevice/decklink_enc: Add support for output of bar data as VANC

2023-06-30 Thread Devin Heitmueller
SMPTE ST2016-3 supports both AFD and bar data within the VANC message. Extend the existing support to pass through both. Example usage: ffmpeg -i input.ts -vf setafd=afd=1:code=0x00:bardata=1:top=100:bottom=120 -f decklink -vcodec v210 'DeckLink Duo (4)' Signed-off-by: Devin H

[FFmpeg-devel] [PATCH v2 6/7] v210enc: Pass through bar data

2023-06-30 Thread Devin Heitmueller
When encoding to V210, make sure the bar side data makes it through in the resulting AVPacket. This is needed so the decklink output module can put out bar data as VANC when in 10-bit mode. Signed-off-by: Devin Heitmueller --- libavcodec/v210enc.c | 8 1 file changed, 8 insertions

[FFmpeg-devel] [PATCH v2 5/7] libavutil: Provide a side data description for newly introduced bar data

2023-06-30 Thread Devin Heitmueller
Add a new description for bar data, so that the presence of bar data can be seen through ffprobe. Signed-off-by: Devin Heitmueller --- libavutil/frame.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index b6cee2d..03d1b31 100644 --- a/libavutil

[FFmpeg-devel] [PATCH v2 4/7] libavfilter: Add filter to insert AFD/bar data

2023-06-30 Thread Devin Heitmueller
Introduce a new filter which allows the user to manually set the AFD or bar data side data on AVFrames. Signed-off-by: Devin Heitmueller --- doc/filters.texi | 52 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_afd.c | 133

[FFmpeg-devel] [PATCH v2 3/7] avcodec/avframe: add new side data types for Bar Data

2023-06-30 Thread Devin Heitmueller
Add new side data types for both AVPacket and AVFrame to support "bar data" as defined in SMPTE 2016-1, ATSC A/53, and SCTE 128-1. Signed-off-by: Devin Heitmueller --- libavcodec/decode.c | 1 + libavcodec/defs.h | 12 libavcodec/packet.h | 6 ++ libavutil/fram

[FFmpeg-devel] [PATCH v2 2/7] vf_drawtext: Add ability to show AFD value

2023-06-30 Thread Devin Heitmueller
ot;:fontsize=32:x=10:y=50:fontcolor=blue burnin.ts Signed-off-by: Devin Heitmueller Conflicts: libavfilter/vf_drawtext.c --- doc/filters.texi | 5 + libavfilter/vf_drawtext.c | 20 +++- 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/do

[FFmpeg-devel] [PATCH v2 1/7] libavcodec: Preserve AFD side data when going from AVPacket to AVFrame

2023-06-30 Thread Devin Heitmueller
This is needed to ensure that AFD data continues to work when capturing V210 video with the Decklink libavdevice input. Signed-off-by: Devin Heitmueller --- libavcodec/decode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index a7c1302..6ee2c85

[FFmpeg-devel] [PATCH v2 0/7] Misc AFD improvements and support for Bar Data

2023-06-30 Thread Devin Heitmueller
This patch series is essentially exactly the same as the one sent on June 7, but the vf_drawtext patch has been rebased against master to resolve a conflict, per Paul Mahol's request. Devin Heitmueller (7): libavcodec: Preserve AFD side data when going from AVPacket to AVFrame vf_dra

[FFmpeg-devel] [PATCH v3 2/2] decklink_enc: add support for SMPTE 2038 VANC packet output

2023-06-30 Thread Devin Heitmueller
abstraction for data streams in general as opposed to just SMPTE 2038 packets. This is because subsequent patches will introduce support for other data codecs. Thanks to Marton Balint for review/feedback. Signed-off-by: Devin Heitmueller --- doc/outdevs.texi| 5 +++ libavdevice

[FFmpeg-devel] [PATCH v3 1/2] decklink: move queue_size to an argument for ff_decklink_packet_queue_init

2023-06-30 Thread Devin Heitmueller
r. This patch makes no functional change to the behavior. It is being made to accommodate Marton Balin's request to split out the queue size for the new VANC queue being introduced in a later patch. Signed-off-by: Devin Heitmueller --- libavdevice/decklink_common.cpp | 4 ++--

Re: [FFmpeg-devel] [PATCH v2 4/4] decklink_enc: add support for SMPTE 2038 VANC packet output

2023-06-22 Thread Devin Heitmueller
On Tue, Jun 6, 2023 at 2:56 PM Devin Heitmueller wrote: > You indicated in patch 0/4 that you had some additional > feedback/comments on this patch series. Could you please provide > them? I've got other data formats I'm working on support for (i.e. > SCTE-104) whic

Re: [FFmpeg-devel] [PATCH 0/7] Misc AFD improvements and support for Bar Data

2023-06-22 Thread Devin Heitmueller
Does anyone else have any comments on this series that would prevent it from being merged upstream? If not, I can rebase the drawtext patch so there are no conflicts. Devin -- Devin Heitmueller, Senior Software Engineer LTN Global Communications o: +1 (301) 363-1001 w: https://ltnglobal.com e

Re: [FFmpeg-devel] [PATCH 1/3] closed caption decoder: accept and decode a new codec type of 'raw 608 byte pairs'

2023-06-20 Thread Devin Heitmueller
de-note, it's probably worth noting that using a three-byte payload predates CEA-708. The prefix byte was present in earlier standards such as use in DVD GOPs, although the actual structure of the prefix byte differs in various standards. While the format for the ffmpeg codec does match what&#x

Re: [FFmpeg-devel] [PATCH 1/5] avcodec: Add new side data type to contain original PTS value

2023-06-19 Thread Devin Heitmueller
inal input timestamp on arrival, and not something that has been transformed, and I worry that "transport" might be a bit vague as it isn't clear whether this was on input, output, or somewhere else in the workflow. That said, pick a name that will be considered acceptable to be merged

Re: [FFmpeg-devel] [PATCH 4/5] bsf: Add new bitstream filter to set pts_adjustment when reclocking

2023-06-19 Thread Devin Heitmueller
On Fri, Jun 16, 2023 at 5:58 PM Andreas Rheinhardt wrote: > > Devin Heitmueller: > > Because SCTE-35 messages are represented in TS streams as sections > > rather than PES packets, we cannot rely on ffmpeg's standard > > mechanisms to adjust PTS values if reclockin

Re: [FFmpeg-devel] [PATCH 1/5] avcodec: Add new side data type to contain original PTS value

2023-06-19 Thread Devin Heitmueller
adata field rather than a new side data type (as that won't necessarily lock us into a new side data type that we would have to support), and the functionality is really specific to one use case. However I figured side data might be better since it avoids the conversion of the PTS to a

[FFmpeg-devel] [PATCH 5/5] mpegtsenc: Don't periodically announce PCR on SCTE-35 streams

2023-06-16 Thread Devin Heitmueller
right" fix should be for this, but for now just disable all periodic sending of PCR-only packets on SCTE-35 streams. Signed-off-by: Devin Heitmueller --- libavformat/mpegtsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtse

  1   2   3   4   >