Signed-off-by: Jai Luthra
---
libavcodec/mlpenc.c | 72 +++--
1 file changed, 37 insertions(+), 35 deletions(-)
diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c
index deb171645c..09a8336b47 100644
--- a/libavcodec/mlpenc.c
+++ b/libavcodec/mlpenc.c
we need two bits instead of one bit to represent -1 in bitstream
Signed-off-by: Jai Luthra
---
libavcodec/mlpenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c
index deb171645c..f4948451f1 100644
--- a/libavcodec/mlpenc.c
+++ b
huff offset wasn't always within the bounds before, which lead to
corrupt encoding that didn't always trigger lossless check failures
Signed-off-by: Jai Luthra
---
libavcodec/mlpenc.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/libavcodec/mlpenc.c b/
* fix a possible memory leak (apply_filter returned before freeing)
* use apply_filters in process_major_frame
* revert back to checking bounds with 24 bitdepth, as huff offset takes
care of it
Signed-off-by: Jai Luthra
---
libavcodec/mlpenc.c | 20 +++-
1 file changed, 11
Signed-off-by: Jai Luthra
---
libavcodec/mlpenc.c | 34 --
1 file changed, 16 insertions(+), 18 deletions(-)
diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c
index 9805e7ff23..4124df6d8f 100644
--- a/libavcodec/mlpenc.c
+++ b/libavcodec/mlpenc.c
@@ -94,8
Fixes Coverity CID 1396239.
Signed-off-by: Jai Luthra
---
libavcodec/mlpenc.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c
index 1cee38c82f..41030f6f07 100644
--- a/libavcodec/mlpenc.c
+++ b/libavcodec/mlpenc.c
@@ -1,6
On Tue, Jul 09, 2019 at 08:26:19PM +0200, Carl Eugen Hoyos wrote:
Please split the patch into self-contained changes with appropriate commit
messages.
Thank you, Carl Eugen
Cool, I've done more fixes will send a new patch set as a separate thread
thx
On Wed, Jul 10, 2019 at 12:14:56AM +0200, Lynne wrote:
Jul 9, 2019, 9:18 PM by m...@jailuthra.in:
we need two bits instead of one bit to represent -1 in bitstream
Signed-off-by: Jai Luthra
---
libavcodec/mlpenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec
* fix a possible memory leak (apply_filter returned before freeing)
* use apply_filters in process_major_frame
* revert back to checking bounds with 24 bitdepth, as huff offset takes
care of it
Signed-off-by: Jai Luthra
---
v2: remove unused variables in process_major_frame
---
libavcodec
week.
Should I squash the commits and send a single patch instead?
Cheers,
Jai Luthra
PS: I noticed Disha Singh is also working on this for outreachy. Is it
fine if two applicants work on the same project through different
programs over the summer?
From 4ed2b13f7b263aaca0aa0caea7153aa64785948a Mon
tion task for this project though
I'll complete it and submit for final evaluation within a week.
Sorry for being late, I was busy with college studies but I'll be completely
free during the coding period.
Cheers,
Jai Luthra
From 6190f169d87523af12c9a5187dc3a8019d066c3f Mon Sep 17 00:00
980] No samples to output.
[mlp @ 0x7fd2b4001980] Max channel must be equal max matrix channel.
I'll find a fix for this asap, and might need some help from the mentor if I
get stuck.
Cheers,
Jai Luthra
From e2748f6a65ffedf7b79a76c20bbbf17665f66ae2 Mon Sep 17 00:00:00 2001
From: Jai Luthra
moved for now, will add it later
While testing, some samples gave lossless check failures when enforcing
s32. Probably this will also get solved with the LFE issues.
Signed-off-by: Jai Luthra
---
> a fate test could also be added
sure. i will add it in a separate patch later.
li
On Sat, Sep 17, 2016 at 05:07:28PM +0100, Andy Furniss wrote:
> Nice work, this is just a sort of related question really from a user
> who hasn't taken any notice of TrueHD for a few years.
>
> Last I looked I couldn't find much in the way of specs for TrueHD and
> noticed that the Decoder didn't
Signed-off-by: Jai Luthra
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index f7e8298..f1f991d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -196,7 +196,7 @@ Codecs:
mdec.cMichael Niedermayer
* Add FATE tests?
* Send the patch for review and merge
Also while testing how to implement multi-channel support, I noticed that the
LFE channel encoding was not lossless for most samples. Any suggestions on how
to fix this would be helpful.
Cheers,
Jai Lu
; this might also explain similar errors in LFE
channel with MLP), or that the dolby encoder didn't do lossless
encoding (unlikely, but still a possibility).
I'll look into it for sure.
Cheers,
Jai Luthra (darkapex)
___
ffmpeg-devel mailing list
f
odes on hardware and the
proprietary suite.
Cheers,
Jai Luthra
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
The min_shift parameter is needed by the MLP encoder
Signed-off-by: Jai Luthra
---
libavcodec/alacenc.c | 4 +++-
libavcodec/flacenc.c | 3 ++-
libavcodec/lpc.c | 13 -
libavcodec/lpc.h | 2 +-
libavcodec/ra144enc.c | 2 +-
5 files changed, 15 insertions(+), 9
moved for now, will add it later
While testing, some samples gave lossless check failures when enforcing
s32. Probably this will also get solved with other lossless issues.
Signed-off-by: Jai Luthra
---
libavcodec/Makefile|2 +
libavcodec/allcodecs.c |4 +-
libavcodec/
we need two bits instead of one bit to represent -1 in bitstream
Signed-off-by: Jai Luthra
---
libavcodec/mlpenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c
index deb171645c..f4948451f1 100644
--- a/libavcodec/mlpenc.c
+++ b
Fixes Coverity CID 1396239.
Signed-off-by: Jai Luthra
---
libavcodec/mlpenc.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c
index 1cee38c82f..41030f6f07 100644
--- a/libavcodec/mlpenc.c
+++ b/libavcodec/mlpenc.c
@@ -1,6
* fix a possible memory leak (apply_filter returned before freeing)
* use apply_filters in process_major_frame
* revert back to checking bounds with 24 bitdepth, as huff offset takes
care of it
Signed-off-by: Jai Luthra
---
libavcodec/mlpenc.c | 25 -
1 file changed, 12
ct.
I will continue on the WIP patch Paul posted earlier and try to fix this.
32-bit encoding still has many lossless failures, so keeping it disabled for
now. Will work on it later.
Jai Luthra (5):
mlpenc: fix lossless check error in number_sbits
mlpenc: fix huff offset calculation
m
huff offset wasn't always within the bounds before, which lead to
corrupt encoding that didn't always trigger lossless check failures
Signed-off-by: Jai Luthra
---
libavcodec/mlpenc.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/libavcodec/mlpenc.c b/
Signed-off-by: Jai Luthra
---
libavcodec/mlpenc.c | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c
index 0e7a9b7640..40872c42fa 100644
--- a/libavcodec/mlpenc.c
+++ b/libavcodec/mlpenc.c
@@ -94,8 +94,8
Signed-off-by: Jai Luthra
---
On Fri, Jan 24, 2020 at 02:25:20PM +0100, Paul B Mahol wrote:
> This is not cleanup, this adds new line of code without proper explanation.
My bad, I was testing something and forgot to remove that line. Fixed now.
libavcodec/mlpenc.c |
On Sun, Feb 02, 2020 at 01:16:38AM +0100, Michael Niedermayer wrote:
Fixes: left shift of negative value -2
Fixes:
20305/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEHD_fuzzer-5677196618498048
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects
When no codebook is used, huff_lsbs can be more than 24 and still decode to
original values once filters are applied.
Signed-off-by: Jai Luthra
---
libavcodec/mlpdec.c | 2 +-
libavcodec/mlpenc.c | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
Fixes lossless check failures caused
Signed-off-by: Jai Luthra
---
libavcodec/mlpenc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Thanks to Paul for the original pastebin patch
diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c
index 347a43248c..af04648097 100644
--- a/libavcodec/mlpenc.c
+++ b
Signed-off-by: Jai Luthra
---
libavcodec/mlpenc.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
v2: fixes more integer issues
diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c
index 347a43248c..173cf71956 100644
--- a/libavcodec/mlpenc.c
+++ b/libavcodec
On Tue, Feb 04, 2020 at 10:24:50PM +0100, Michael Niedermayer wrote:
On Mon, Feb 03, 2020 at 12:33:00AM +0530, Jai Luthra wrote:
When no codebook is used, huff_lsbs can be more than 24 and still decode to
original values once filters are applied.
huff_lsbs can but get_bits() is limited to 25
lsb bits may go beyond 25 bits, so to be safe use get_bits_long
Signed-off-by: Jai Luthra
---
libavcodec/mlpdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/mlpdec.c b/libavcodec/mlpdec.c
index 22a6efd63d..1a2c0f29ac 100644
--- a/libavcodec/mlpdec.c
+++ b
On Sun, Feb 23, 2020 at 02:54:42PM +0530, Kartik Khullar wrote:
I am 2nd year Computer Engineering Student at TIET, Patiala. I am
interested in FLIF Encoder and Decoder Project. I am informing so as to
prevent clash between other potential applicants. I will be working on its
Qualification Task.
Co-authored-by: Oscar
---
The uninitialized score & dist values are used a few lines below this, leading
to inconsistent mpeg7 matches.
Original PR here: https://github.com/livepeer/FFmpeg/pull/4
libavfilter/signature_lookup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
Recent encode API restructure (827d6fe73d) removed some state - which broke
the API for flushing without closing the encoder.
This functionality was originally added in 3ea7057677 and is useful for
segmented video, where we don't want to do expensive re-init of HW sessions
for every segment.
-
Recent encode API restructure (827d6fe73d) removed some state - which broke
the API for flushing without closing the encoder.
This functionality was originally added in 3ea7057677 and is useful for
segmented video, where we don't want to do expensive re-init of HW sessions
for every segment.
---
v
On Fri, Jul 16, 2021, at 10:06 PM, Timo Rothenpieler wrote:
-- snip --
> Can you explain the logic this follows some more? I'm quite confused
> what exactly changed, and how it broke this.
> How do you trigger a flush, if calling flush does nothing?
Since https://github.com/ffmpeg/ffmpeg/commit
Planning to push it in 24h - if there are no objections.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsu
On Mon, May 24, 2021 at 04:00:24AM +0300, Valerii Zapodovnikov wrote:
Otherwise since "==" has higher precedence, mode is never checked.
---
libavfilter/signature_lookup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/signature_lookup.c b/libavfilter/signature_loo
Co-authored-by: Oscar
Signed-off-by: Jai Luthra
---
libavfilter/signature_lookup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavfilter/signature_lookup.c b/libavfilter/signature_lookup.c
index 977f898049..86dd0c6675 100644
--- a/libavfilter/signature_lookup.c
On Fri, Aug 20, 2021, at 4:24 PM, Jai Luthra wrote:
> Co-authored-by: Oscar
> Signed-off-by: Jai Luthra
> ---
> libavfilter/signature_lookup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavfilter/signature_lookup.c
> b/libavfilter/si
Hi Anamitra,
On Wed, Feb 26, 2020 at 12:26:37PM +0530, Anamitra Ghorui wrote:
This is a buildable "skeleton" of my component (the FLIF16 parser)
i.e. everything is present aside from the logic itself.
***
Hello, I am trying to implement a parser for the FLIF16 file format as
a GSoC 2020 qualif
Hi Anamitra,
On Sat, Feb 29, 2020 at 04:50:23AM +, Anamitra Ghorui wrote:
Hello,
I have been reading through the parsing API and other things and here's what
I've managed to gather (I will be ignoring overruns in these functions for now).
Please tell me if I am right or wrong:
1. As long as
Hi Anamitra,
Good progres on the parser, I tested it on the samples you provided, lgtm.
Comments inline.
On Fri, Mar 06, 2020 at 06:10:04PM +, Anamitra Ghorui wrote:
The parser has been tested and is able to correctly identify the start
of the compressed bitstream. The patch has a set of
Hi Varun,
Set [RFC]/[WIP]/[GSOC] and other subject labels for patches that are not
intended for merge review. From your first email it seems like your mailer
mangled it. You can edit the .patch file before sending it via git send-email.
On Mon, Mar 16, 2020 at 12:11:54AM +0530, Varun Gupta wr
Please mark the patch as [WIP] or [RFC] if you are not sending it for a merge
review.
On Wed, Mar 18, 2020 at 11:01:22AM +0530, Kartik wrote:
From: Kartik K. Khullar
---
FFmpeg/libavutil/colorspace.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/FFmpeg/libavutil/colorspace.h
Hi Kartik,
Please mark the patch as [WIP] or [RFC] if you are not sending it for a merge
review. You may also mark it as [GSoC].
You've done a good job of reading the spec and turning the pseudocode there to
a method, but I'm afraid it is not enough.
I would suggest you run the reference co
Enables writing buffered frames to the outsink using send command api.
This is useful when a lavf user wants to fetch buffered frames without
closing/reopening the filtergraph again and again.
Signed-off-by: Jai Luthra
---
libavfilter/vf_fps.c | 36 +++-
1 file
Hi Kartik,
On Mon, Mar 30, 2020, at 4:50 AM, Kartik K. Khullar wrote:
> This is my WIP patch for GSoC and I worked on transformations involved
> in encoding/decoding FLIF images. I have created a module under
> libavcodec and as guided by my mentors I have tried to use pixel data
> from AVFrame
LGTM
On Tue, Nov 24, 2020, at 1:29 AM, Andreas Rheinhardt wrote:
> Andreas Rheinhardt:
> > Signed-off-by: Andreas Rheinhardt
> > ---
> > libavcodec/mlp.c | 17 ++---
> > 1 file changed, 10 insertions(+), 7 deletions(-)
> >
> > diff --git a/libavcodec/mlp.c b/libavcodec/mlp.c
> > ind
51 matches
Mail list logo
