Re: [FFmpeg-devel] MpegTS contribution question

2019-08-08 Thread Phil Burr
Hello Anthony, I'm not really the best to answer your questions, as I'm also a fairly new contributor (my patches seem to be languishing due to a lack of feedback and a lack of time on my part pushing the issue). I've been working on getting support into mpegts for ATSC compliant descriptors of

Re: [FFmpeg-devel] [PATCH v4] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-06-25 Thread Phil Burr
It's been a month, no replies. Is this commit going to be committed, or is there something further I need to do to move this along? Should I post a rebased version? Thanks, Phil On Tue, May 21, 2019 at 8:40 AM Phillip Burr wrote: > Minimal support for ATSC PSIP tables. Does not support STT

Re: [FFmpeg-devel] [PATCH v4] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-21 Thread Phil Burr
This patch has a bit more restructuring to consolidate the ATSC specific fields. I fixed some bugs where a few fields were set incorrectly. Specifically, the MGT transmits the length of each table it describes and so each table it describes is pre-populated. Testing last night involved taking an

Re: [FFmpeg-devel] [PATCH v3] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-20 Thread Phil Burr
I've found some fields that aren't being set correctly. I've corrected those and I'll push a new patch after I've done proper testing. Phil On Mon, May 20, 2019 at 11:03 AM Thomas Volkert wrote: > > On 20.05.2019 18:56, Phil Burr wrote: > > Besides passing `make fate` locally, I h

Re: [FFmpeg-devel] [PATCH v3] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-20 Thread Phil Burr
Besides passing `make fate` locally, I have manually inspected data streams to look at my packets and I've used SDR software to transmit to various TV sets I own and have verified correct virtual channel and channel name on those receivers. On Mon, May 20, 2019 at 10:44 AM Thomas Volkert wrote:

Re: [FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-20 Thread Phil Burr
Thank you for your suggestions. I will push an update to the patch with documentation and will hold off on STT and EIT[0-3] tables for a later patch. On Mon, May 20, 2019 at 7:24 AM Devin Heitmueller < dheitmuel...@kernellabs.com> wrote: > On Mon, May 20, 2019 at 8:36 AM Phil Bu

Re: [FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-20 Thread Phil Burr
Thank you for the feedback. I will look into adding documentation for the atsc metadata. ATSC requires in addition to the tables I've added, the STT and EIT0-EIT3 tables. I'm thinking of adding support for STT and at least producing empty EIT tables so that the stream would be minimally