Re: [FFmpeg-devel] [PATCH] [RFC] GSoC: FLIF16 Image format parser

2020-02-27 Thread Anamitra Ghorui
February 27, 2020 6:15 PM, "Moritz Barsnick" wrote: >> OBJS-$(CONFIG_FLAC_PARSER) += flac_parser.o flacdata.o flac.o \ >> vorbis_data.o >> +OBJS-$(CONFIG_FLAC_PARSER) += flif16_parser.o > > > > This looks wrong. You are adding this object to a compile of the FLAC > parser, not your new

Re: [FFmpeg-devel] [PATCH] [RFC] GSoC: FLIF16 Image format parser

2020-02-27 Thread Moritz Barsnick
Welcome to ffmpeg! Since review has now started, I want to point out what was missed: On Wed, Feb 26, 2020 at 12:26:37 +0530, Anamitra Ghorui wrote: > a. Please tell me if I am right or wrong here: > 1. Each audio/video/image file format has a parser for converting the >file data into a

Re: [FFmpeg-devel] [PATCH] [RFC] GSoC: FLIF16 Image format parser

2020-02-27 Thread Jai Luthra
Hi Anamitra, On Wed, Feb 26, 2020 at 12:26:37PM +0530, Anamitra Ghorui wrote: This is a buildable "skeleton" of my component (the FLIF16 parser) i.e. everything is present aside from the logic itself. *** Hello, I am trying to implement a parser for the FLIF16 file format as a GSoC 2020

Re: [FFmpeg-devel] [PATCH] [RFC] GSoC: FLIF16 Image format parser

2020-02-27 Thread Thilo Borgmann
Am 27.02.20 um 11:56 schrieb Lynne: > Feb 27, 2020, 09:09 by agho...@teknik.io: > >> February 26, 2020 12:27 PM, "Anamitra Ghorui" wrote: >> >>> c. I have been looking at the decoder/encoder/parser of the BMP format >>> (which is one of the simplest image formats), the actual decoding work >>>

Re: [FFmpeg-devel] [PATCH] [RFC] GSoC: FLIF16 Image format parser

2020-02-27 Thread Lynne
Feb 27, 2020, 09:09 by agho...@teknik.io: > February 26, 2020 12:27 PM, "Anamitra Ghorui" wrote: > >> c. I have been looking at the decoder/encoder/parser of the BMP format >> (which is one of the simplest image formats), the actual decoding work >> (according to me), i.e. Finding the magic

Re: [FFmpeg-devel] [PATCH] [RFC] GSoC: FLIF16 Image format parser

2020-02-27 Thread aghorui
February 26, 2020 12:27 PM, "Anamitra Ghorui" wrote: > c. I have been looking at the decoder/encoder/parser of the BMP format > (which is one of the simplest image formats), the actual decoding work > (according to me), i.e. Finding the magic numbers, seeing the various > segments is being done

[FFmpeg-devel] [PATCH] [RFC] GSoC: FLIF16 Image format parser

2020-02-25 Thread Anamitra Ghorui
This is a buildable "skeleton" of my component (the FLIF16 parser) i.e. everything is present aside from the logic itself. *** Hello, I am trying to implement a parser for the FLIF16 file format as a GSoC 2020 qualification project. So far I think I have managed to register the parser (alongwith