Re: [FFmpeg-devel] [PATCH] Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

2020-01-01 Thread Michael Niedermayer
On Wed, Sep 25, 2019 at 11:57:08AM -0700, William Martin wrote: > From: Will Martin > > Motivation: When running multiple rtmp ingest on the same machine on the same > port, users may want to explicitly forbid mismatched rtmp streams from > successfully completing handshakes. This patch allows

Re: [FFmpeg-devel] [PATCH] Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

2019-12-31 Thread William Martin
I doesn't look like there are any blockers on this patch request - could someone go ahead and merge it? On Sat, Sep 28, 2019 at 2:55 AM Reino Wijnsma wrote: > On 2019-09-27T19:37:40+0200, William Martin > wrote: > > On Wed, Sep 25, 2019 at 2:36 PM Reino Wijnsma > wrote: > >> On

Re: [FFmpeg-devel] [PATCH] Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

2019-09-28 Thread Reino Wijnsma
On 2019-09-27T19:37:40+0200, William Martin wrote: > On Wed, Sep 25, 2019 at 2:36 PM Reino Wijnsma wrote: >> On 2019-09-25T20:57:08+0200, William Martin >> wrote: >>> +av_log(s, AV_LOG_ERROR, "App field don't match up: %s <-> %s. " >> Although I'm not a native English speaker,

Re: [FFmpeg-devel] [PATCH] Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

2019-09-27 Thread William Martin
Hi Reino - good point. Though, that was an existing log message that I did not modify. Should the old typo be addressed in a separate patch, or should I update it here? On Wed, Sep 25, 2019 at 2:36 PM Reino Wijnsma wrote: > On 2019-09-25T20:57:08+0200, William Martin > wrote: > > +

Re: [FFmpeg-devel] [PATCH] Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

2019-09-26 Thread William Martin
I don't think so. The existing 'strict' option is more general and touches lots of things in encoding/decoding. The new option is very narrow in scope. The existing 'strict' and the new 'rtmp_strict_paths` don't have anything to do with each other - in fact it would be quite possible that a user

Re: [FFmpeg-devel] [PATCH] Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

2019-09-25 Thread Carl Eugen Hoyos
Am Mi., 25. Sept. 2019 um 21:04 Uhr schrieb William Martin : > > From: Will Martin > > Motivation: When running multiple rtmp ingest on the same machine on the same > port, users may want to explicitly forbid mismatched rtmp streams from > successfully completing handshakes. This patch allows

Re: [FFmpeg-devel] [PATCH] Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

2019-09-25 Thread Reino Wijnsma
On 2019-09-25T20:57:08+0200, William Martin wrote: > +av_log(s, AV_LOG_ERROR, "App field don't match up: %s <-> %s. " Although I'm not a native English speaker, since "field" isn't plural, I'm pretty confident "don't" should be "doesn't". -- Reino

[FFmpeg-devel] [PATCH] Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

2019-09-25 Thread William Martin
From: Will Martin Motivation: When running multiple rtmp ingest on the same machine on the same port, users may want to explicitly forbid mismatched rtmp streams from successfully completing handshakes. This patch allows for such enforcement Signed-off-by: Will Martin ---